[GitHub] [spark] SparkQA commented on pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
SparkQA commented on pull request #34611: URL: https://github.com/apache/spark/pull/34611#issuecomment-973839046 **[Test build #145445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145445/testReport)** for PR 34611 at commit

[GitHub] [spark] sarutak commented on a change in pull request #34664: [SPARK-35672][FOLLOWUP][TESTS] Add more exclusion rules to MimaExcludes.scala for Scala 2.13

2021-11-18 Thread GitBox
sarutak commented on a change in pull request #34664: URL: https://github.com/apache/spark/pull/34664#discussion_r752926070 ## File path: project/MimaExcludes.scala ## @@ -37,8 +37,10 @@ object MimaExcludes { // Exclude rules for 3.3.x from 3.2.0 lazy val v33excludes =

[GitHub] [spark] AngersZhuuuu commented on pull request #34616: [SPARK-37344][SQL][DOC] spark-sql cli will keep `\` when match `\;` after spark3

2021-11-18 Thread GitBox
AngersZh commented on pull request #34616: URL: https://github.com/apache/spark/pull/34616#issuecomment-973839962 @wangyum Any more suggestion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] sarutak commented on a change in pull request #34664: [SPARK-35672][FOLLOWUP][TESTS] Add more exclusion rules to MimaExcludes.scala for Scala 2.13

2021-11-18 Thread GitBox
sarutak commented on a change in pull request #34664: URL: https://github.com/apache/spark/pull/34664#discussion_r752926070 ## File path: project/MimaExcludes.scala ## @@ -37,8 +37,10 @@ object MimaExcludes { // Exclude rules for 3.3.x from 3.2.0 lazy val v33excludes =

[GitHub] [spark] SparkQA commented on pull request #34651: [SPARK-37373] Collecting LocalSparkContext worker logs in case of test failure

2021-11-18 Thread GitBox
SparkQA commented on pull request #34651: URL: https://github.com/apache/spark/pull/34651#issuecomment-973835804 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49911/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34642: [SPARK-37369][SQL] Avoid redundant ColumnarToRow transistion on InMemoryTableScan

2021-11-18 Thread GitBox
SparkQA commented on pull request #34642: URL: https://github.com/apache/spark/pull/34642#issuecomment-973831608 **[Test build #145444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145444/testReport)** for PR 34642 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34658: [SPARK-37379][SQL] Add tree pattern pruning to CTESubstitution rule

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34658: URL: https://github.com/apache/spark/pull/34658#issuecomment-973830076 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145422/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973830080 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145432/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34662: [SPARK-37386][SQL] Simplify OptimizeSkewedJoin to not run the cost evaluator

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34662: URL: https://github.com/apache/spark/pull/34662#issuecomment-973830069 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49909/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34659: [SPARK-34863][SQL] Support complex types for Parquet vectorized reader

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34659: URL: https://github.com/apache/spark/pull/34659#issuecomment-973830072 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145429/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34661: URL: https://github.com/apache/spark/pull/34661#issuecomment-973830075 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145433/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34663: [SPARK-37385][SQL][TESTS] Add tests for TimestampNTZ and TimestampLTZ for Parquet data source

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34663: URL: https://github.com/apache/spark/pull/34663#issuecomment-973830078 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49908/

[GitHub] [spark] SparkQA commented on pull request #34664: [SPARK-35672][FOLLOWUP][TESTS] Add more exclusion rules to MimaExcludes.scala for Scala 2.13

2021-11-18 Thread GitBox
SparkQA commented on pull request #34664: URL: https://github.com/apache/spark/pull/34664#issuecomment-973831492 **[Test build #145443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145443/testReport)** for PR 34664 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34647: [SPARK-36180][SQL] Support TimestampNTZ type in Hive

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34647: URL: https://github.com/apache/spark/pull/34647#issuecomment-973830073 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145427/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34638: [SPARK-37360][SQL] Support TimestampNTZ in JSON data source

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34638: URL: https://github.com/apache/spark/pull/34638#issuecomment-973830074 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145435/

[GitHub] [spark] AmplabJenkins commented on pull request #34665: [SPARK-37383][SQL]Print the parsing time for each phase of a SQL

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34665: URL: https://github.com/apache/spark/pull/34665#issuecomment-973831130 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins commented on pull request #34647: [SPARK-36180][SQL] Support TimestampNTZ type in Hive

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34647: URL: https://github.com/apache/spark/pull/34647#issuecomment-973830073 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145427/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34661: URL: https://github.com/apache/spark/pull/34661#issuecomment-973830075 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145433/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973830080 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145432/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34658: [SPARK-37379][SQL] Add tree pattern pruning to CTESubstitution rule

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34658: URL: https://github.com/apache/spark/pull/34658#issuecomment-973830076 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145422/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34659: [SPARK-34863][SQL] Support complex types for Parquet vectorized reader

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34659: URL: https://github.com/apache/spark/pull/34659#issuecomment-973830072 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145429/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34638: [SPARK-37360][SQL] Support TimestampNTZ in JSON data source

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34638: URL: https://github.com/apache/spark/pull/34638#issuecomment-973830074 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145435/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34663: [SPARK-37385][SQL][TESTS] Add tests for TimestampNTZ and TimestampLTZ for Parquet data source

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34663: URL: https://github.com/apache/spark/pull/34663#issuecomment-973830078 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49908/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34662: [SPARK-37386][SQL] Simplify OptimizeSkewedJoin to not run the cost evaluator

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34662: URL: https://github.com/apache/spark/pull/34662#issuecomment-973830069 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49909/ --

[GitHub] [spark] SparkQA commented on pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
SparkQA commented on pull request #34611: URL: https://github.com/apache/spark/pull/34611#issuecomment-973825951 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49913/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34663: [SPARK-37385][SQL][TESTS] Add tests for TimestampNTZ and TimestampLTZ for Parquet data source

2021-11-18 Thread GitBox
SparkQA commented on pull request #34663: URL: https://github.com/apache/spark/pull/34663#issuecomment-973825703 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49908/ -- This is an automated message from the

[GitHub] [spark] zhengruifeng commented on pull request #34504: [SPARK-37226][SQL] Filter push down through window if partitionSpec isEmpty

2021-11-18 Thread GitBox
zhengruifeng commented on pull request #34504: URL: https://github.com/apache/spark/pull/34504#issuecomment-973825582 This should be faster than SPARK-37099, since quick-selection is used internally instead of sorting. -- This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #33893: [SPARK-36638][SQL] Generalize OptimizeSkewedJoin

2021-11-18 Thread GitBox
SparkQA commented on pull request #33893: URL: https://github.com/apache/spark/pull/33893#issuecomment-973822571 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49914/ -- This is an automated message from the Apache

[GitHub] [spark] cloud-fan closed pull request #34662: [SPARK-37386][SQL] Simplify OptimizeSkewedJoin to not run the cost evaluator

2021-11-18 Thread GitBox
cloud-fan closed pull request #34662: URL: https://github.com/apache/spark/pull/34662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] cloud-fan commented on pull request #34662: [SPARK-37386][SQL] Simplify OptimizeSkewedJoin to not run the cost evaluator

2021-11-18 Thread GitBox
cloud-fan commented on pull request #34662: URL: https://github.com/apache/spark/pull/34662#issuecomment-973821032 thanks for the review, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] SparkQA commented on pull request #34662: [SPARK-37386][SQL] Simplify OptimizeSkewedJoin to not run the cost evaluator

2021-11-18 Thread GitBox
SparkQA commented on pull request #34662: URL: https://github.com/apache/spark/pull/34662#issuecomment-973820663 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49909/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #34642: [SPARK-37369][SQL] Avoid redundant ColumnarToRow transistion on InMemoryTableScan

2021-11-18 Thread GitBox
SparkQA commented on pull request #34642: URL: https://github.com/apache/spark/pull/34642#issuecomment-973820637 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49912/ -- This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on a change in pull request #34663: [SPARK-37385][SQL][TESTS] Add tests for TimestampNTZ and TimestampLTZ for Parquet data source

2021-11-18 Thread GitBox
cloud-fan commented on a change in pull request #34663: URL: https://github.com/apache/spark/pull/34663#discussion_r752915534 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala ## @@ -122,7 +122,63 @@ class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34664: [SPARK-35672][FOLLOWUP][TESTS] Add more exclusion rules to MimaExcludes.scala for Scala 2.13

2021-11-18 Thread GitBox
dongjoon-hyun commented on a change in pull request #34664: URL: https://github.com/apache/spark/pull/34664#discussion_r752915062 ## File path: project/MimaExcludes.scala ## @@ -37,8 +37,10 @@ object MimaExcludes { // Exclude rules for 3.3.x from 3.2.0 lazy val

[GitHub] [spark] SparkQA removed a comment on pull request #34647: [SPARK-36180][SQL] Support TimestampNTZ type in Hive

2021-11-18 Thread GitBox
SparkQA removed a comment on pull request #34647: URL: https://github.com/apache/spark/pull/34647#issuecomment-973653633 **[Test build #145427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145427/testReport)** for PR 34647 at commit

[GitHub] [spark] SparkQA commented on pull request #34647: [SPARK-36180][SQL] Support TimestampNTZ type in Hive

2021-11-18 Thread GitBox
SparkQA commented on pull request #34647: URL: https://github.com/apache/spark/pull/34647#issuecomment-973818242 **[Test build #145427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145427/testReport)** for PR 34647 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r752914361 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ## @@ -188,7 +193,13 @@ class

[GitHub] [spark] SparkQA removed a comment on pull request #34638: [SPARK-37360][SQL] Support TimestampNTZ in JSON data source

2021-11-18 Thread GitBox
SparkQA removed a comment on pull request #34638: URL: https://github.com/apache/spark/pull/34638#issuecomment-973732334 **[Test build #145435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145435/testReport)** for PR 34638 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34659: [SPARK-34863][SQL] Support complex types for Parquet vectorized reader

2021-11-18 Thread GitBox
SparkQA removed a comment on pull request #34659: URL: https://github.com/apache/spark/pull/34659#issuecomment-973675452 **[Test build #145429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145429/testReport)** for PR 34659 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #34644: [SPARK-36357][SQL] Support pushdown Timestamp without time zone for orc

2021-11-18 Thread GitBox
cloud-fan commented on a change in pull request #34644: URL: https://github.com/apache/spark/pull/34644#discussion_r752910817 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala ## @@ -168,6 +168,8 @@ private[sql] object

[GitHub] [spark] cloud-fan commented on a change in pull request #34644: [SPARK-36357][SQL] Support pushdown Timestamp without time zone for orc

2021-11-18 Thread GitBox
cloud-fan commented on a change in pull request #34644: URL: https://github.com/apache/spark/pull/34644#discussion_r752910518 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala ## @@ -168,6 +168,8 @@ private[sql] object

[GitHub] [spark] SparkQA commented on pull request #34638: [SPARK-37360][SQL] Support TimestampNTZ in JSON data source

2021-11-18 Thread GitBox
SparkQA commented on pull request #34638: URL: https://github.com/apache/spark/pull/34638#issuecomment-973809002 **[Test build #145435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145435/testReport)** for PR 34638 at commit

[GitHub] [spark] SparkQA commented on pull request #34659: [SPARK-34863][SQL] Support complex types for Parquet vectorized reader

2021-11-18 Thread GitBox
SparkQA commented on pull request #34659: URL: https://github.com/apache/spark/pull/34659#issuecomment-973807807 **[Test build #145429 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145429/testReport)** for PR 34659 at commit

[GitHub] [spark] caican00 opened a new pull request #34665: [SPARK-37383][SQL]Print the parsing time for each phase of a SQL

2021-11-18 Thread GitBox
caican00 opened a new pull request #34665: URL: https://github.com/apache/spark/pull/34665 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this

[GitHub] [spark] LuciferYang edited a comment on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target

2021-11-18 Thread GitBox
LuciferYang edited a comment on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-973800658 @srowen @dongjoon-hyun @sunchao It seems that this issue has been fixed by some PR, let me investigate it -- This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
SparkQA removed a comment on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973729506 **[Test build #145432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145432/testReport)** for PR 34596 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite

2021-11-18 Thread GitBox
SparkQA removed a comment on pull request #34661: URL: https://github.com/apache/spark/pull/34661#issuecomment-973730846 **[Test build #145433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145433/testReport)** for PR 34661 at commit

[GitHub] [spark] SparkQA commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
SparkQA commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973805577 **[Test build #145432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145432/testReport)** for PR 34596 at commit

[GitHub] [spark] SparkQA commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite

2021-11-18 Thread GitBox
SparkQA commented on pull request #34661: URL: https://github.com/apache/spark/pull/34661#issuecomment-973805495 **[Test build #145433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145433/testReport)** for PR 34661 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34658: [SPARK-37379][SQL] Add tree pattern pruning to CTESubstitution rule

2021-11-18 Thread GitBox
SparkQA removed a comment on pull request #34658: URL: https://github.com/apache/spark/pull/34658#issuecomment-973648709 **[Test build #145422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145422/testReport)** for PR 34658 at commit

[GitHub] [spark] SparkQA commented on pull request #34648: [SPARK-37282][TESTS][FOLLOWUP] Extract `Utils.isMacOnAppleSilicon` for reuse in UTs

2021-11-18 Thread GitBox
SparkQA commented on pull request #34648: URL: https://github.com/apache/spark/pull/34648#issuecomment-973804176 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49910/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34658: [SPARK-37379][SQL] Add tree pattern pruning to CTESubstitution rule

2021-11-18 Thread GitBox
SparkQA commented on pull request #34658: URL: https://github.com/apache/spark/pull/34658#issuecomment-973804069 **[Test build #145422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145422/testReport)** for PR 34658 at commit

[GitHub] [spark] sarutak commented on pull request #34664: [SPARK-35672][FOLLOWUP][TESTS] Add more exclusion rules to MimaExcludes.scala for Scala 2.13

2021-11-18 Thread GitBox
sarutak commented on pull request #34664: URL: https://github.com/apache/spark/pull/34664#issuecomment-973804090 @dongjoon-hyun Thank you for letting me know this issue! After I cleaned my repository and ran `dev/mima`, I observed this issue too. -- This is an automated message from the

[GitHub] [spark] sarutak opened a new pull request #34664: [SPARK-35672][FOLLOWUP][TESTS] Add more exclusion rules to MimaExcludes.scala for Scala 2.13

2021-11-18 Thread GitBox
sarutak opened a new pull request #34664: URL: https://github.com/apache/spark/pull/34664 ### What changes were proposed in this pull request? This PR adds more MiMa exclusion rules for Scala 2.13. #34649 partially resolved the compatibility issue but additional 3 compatibility

[GitHub] [spark] LuciferYang commented on pull request #34620: [SPARK-37209][YARN][TESTS] Fix `YarnShuffleIntegrationSuite` releated UTs when using `hadoop-3.2` profile without `assembly/target/scala-

2021-11-18 Thread GitBox
LuciferYang commented on pull request #34620: URL: https://github.com/apache/spark/pull/34620#issuecomment-973800658 @srowen @dongjoon-hyun @sunchao It seems that this issue has been fixed by some PR company, let me investigate it -- This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
SparkQA removed a comment on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973730980 **[Test build #145434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145434/testReport)** for PR 34596 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973800284 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145434/

[GitHub] [spark] AmplabJenkins commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973800284 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145434/ -- This

[GitHub] [spark] SparkQA commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
SparkQA commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973800105 **[Test build #145434 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145434/testReport)** for PR 34596 at commit

[GitHub] [spark] SparkQA commented on pull request #34663: [SPARK-37385][SQL][TESTS] Add tests for TimestampNTZ and TimestampLTZ for Parquet data source

2021-11-18 Thread GitBox
SparkQA commented on pull request #34663: URL: https://github.com/apache/spark/pull/34663#issuecomment-973797550 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49908/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34611: URL: https://github.com/apache/spark/pull/34611#issuecomment-973796766 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145441/

[GitHub] [spark] SparkQA removed a comment on pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
SparkQA removed a comment on pull request #34611: URL: https://github.com/apache/spark/pull/34611#issuecomment-973795538 **[Test build #145441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145441/testReport)** for PR 34611 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34611: URL: https://github.com/apache/spark/pull/34611#issuecomment-973796766 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145441/ -- This

[GitHub] [spark] SparkQA commented on pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
SparkQA commented on pull request #34611: URL: https://github.com/apache/spark/pull/34611#issuecomment-973796754 **[Test build #145441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145441/testReport)** for PR 34611 at commit

[GitHub] [spark] SparkQA commented on pull request #33893: [SPARK-36638][SQL] Generalize OptimizeSkewedJoin

2021-11-18 Thread GitBox
SparkQA commented on pull request #33893: URL: https://github.com/apache/spark/pull/33893#issuecomment-973796432 **[Test build #145442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145442/testReport)** for PR 33893 at commit

[GitHub] [spark] sadikovi edited a comment on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
sadikovi edited a comment on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973796214 IMHO, we should revert to the original proposal with `isTimeZoneSet` method: it preserves the original API at the expense of having an additional method to check

[GitHub] [spark] sadikovi commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
sadikovi commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973796214 IMHO, we should revert to the original proposal with `isTimeZoneSet` method: it preserves the original API at the expense of having an additional method to check timezone.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34660: [SPARK-37038][SQL][TESTS][FOLLOWUP] Fix flaky test by loosening the number of results for TABLESAMPLE

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34660: URL: https://github.com/apache/spark/pull/34660#issuecomment-973795951 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49904/

[GitHub] [spark] SparkQA commented on pull request #34660: [SPARK-37038][SQL][TESTS][FOLLOWUP] Fix flaky test by loosening the number of results for TABLESAMPLE

2021-11-18 Thread GitBox
SparkQA commented on pull request #34660: URL: https://github.com/apache/spark/pull/34660#issuecomment-973795929 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49904/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #34660: [SPARK-37038][SQL][TESTS][FOLLOWUP] Fix flaky test by loosening the number of results for TABLESAMPLE

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34660: URL: https://github.com/apache/spark/pull/34660#issuecomment-973795951 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49904/ --

[GitHub] [spark] sadikovi commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
sadikovi commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r752897272 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ## @@ -1451,7 +1451,29 @@ class

[GitHub] [spark] SparkQA commented on pull request #34642: [SPARK-37369][SQL] Avoid redundant ColumnarToRow transistion on InMemoryTableScan

2021-11-18 Thread GitBox
SparkQA commented on pull request #34642: URL: https://github.com/apache/spark/pull/34642#issuecomment-973795437 **[Test build #145440 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145440/testReport)** for PR 34642 at commit

[GitHub] [spark] SparkQA commented on pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
SparkQA commented on pull request #34611: URL: https://github.com/apache/spark/pull/34611#issuecomment-973795538 **[Test build #145441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145441/testReport)** for PR 34611 at commit

[GitHub] [spark] SparkQA commented on pull request #34651: [SPARK-37373] Collecting LocalSparkContext worker logs in case of test failure

2021-11-18 Thread GitBox
SparkQA commented on pull request #34651: URL: https://github.com/apache/spark/pull/34651#issuecomment-973795464 **[Test build #145439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145439/testReport)** for PR 34651 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r752896736 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ## @@ -1451,7 +1451,29 @@ class

[GitHub] [spark] SparkQA commented on pull request #34662: [SPARK-37386][SQL] Simplify OptimizeSkewedJoin to not run the cost evaluator

2021-11-18 Thread GitBox
SparkQA commented on pull request #34662: URL: https://github.com/apache/spark/pull/34662#issuecomment-973794832 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49909/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34661: URL: https://github.com/apache/spark/pull/34661#issuecomment-973794157 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49906/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973794160 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49905/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34638: [SPARK-37360][SQL] Support TimestampNTZ in JSON data source

2021-11-18 Thread GitBox
AmplabJenkins removed a comment on pull request #34638: URL: https://github.com/apache/spark/pull/34638#issuecomment-973794159 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49907/

[GitHub] [spark] kazuyukitanimura commented on pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
kazuyukitanimura commented on pull request #34611: URL: https://github.com/apache/spark/pull/34611#issuecomment-973794312 Added more tests. @sadikovi @sunchao Thank you for reviewing this PR again. Please check one more time. -- This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #34638: [SPARK-37360][SQL] Support TimestampNTZ in JSON data source

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34638: URL: https://github.com/apache/spark/pull/34638#issuecomment-973794159 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49907/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34661: URL: https://github.com/apache/spark/pull/34661#issuecomment-973794157 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49906/ --

[GitHub] [spark] AmplabJenkins commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
AmplabJenkins commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973794160 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49905/ --

[GitHub] [spark] viirya commented on a change in pull request #34642: [SPARK-37369][SQL] Avoid redundant ColumnarToRow transistion on InMemoryTableScan

2021-11-18 Thread GitBox
viirya commented on a change in pull request #34642: URL: https://github.com/apache/spark/pull/34642#discussion_r752895193 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala ## @@ -62,7 +63,7 @@ case class

[GitHub] [spark] viirya commented on a change in pull request #34642: [SPARK-37369][SQL] Avoid redundant ColumnarToRow transistion on InMemoryTableScan

2021-11-18 Thread GitBox
viirya commented on a change in pull request #34642: URL: https://github.com/apache/spark/pull/34642#discussion_r752895104 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala ## @@ -538,7 +539,13 @@ case class

[GitHub] [spark] sadikovi commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
sadikovi commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r752893985 ## File path: sql/core/src/test/resources/sql-tests/results/timestampNTZ/timestamp.sql.out ## @@ -373,17 +374,19 @@ struct

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r752893650 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala ## @@ -1440,7 +1440,7 @@ class

[GitHub] [spark] advancedxy commented on a change in pull request #34640: [SPARK-31585][SQL] Introduce Z-order expression

2021-11-18 Thread GitBox
advancedxy commented on a change in pull request #34640: URL: https://github.com/apache/spark/pull/34640#discussion_r752840061 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ZOrder.scala ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache

[GitHub] [spark] Yikun commented on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

2021-11-18 Thread GitBox
Yikun commented on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-973790941 @dongjoon-hyun Would you mind giving some suggestion on this? Sorry to ping wrong person in https://github.com/apache/spark/pull/34599#issuecomment-968704348 . : ) -- This is

[GitHub] [spark] Yikun edited a comment on pull request #34599: [SPARK-37331][K8S] Add the ability to create resources before driverPod creating

2021-11-18 Thread GitBox
Yikun edited a comment on pull request #34599: URL: https://github.com/apache/spark/pull/34599#issuecomment-968704348 cc @dongjoon-hyun @holdenk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] Yikun edited a comment on pull request #34646: [SPARK-37372][K8S] Removing redundant label addition and refactoring related test case

2021-11-18 Thread GitBox
Yikun edited a comment on pull request #34646: URL: https://github.com/apache/spark/pull/34646#issuecomment-973786521 @dongjoon-hyun Thanks for you patient review, and I rename the title to `Removing redundant label addition and refactoring related test case`, and update the PR

[GitHub] [spark] cloud-fan commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
cloud-fan commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r752890382 ## File path: sql/core/src/test/resources/sql-tests/results/timestampNTZ/timestamp.sql.out ## @@ -373,17 +374,19 @@ struct

[GitHub] [spark] SparkQA commented on pull request #34661: [SPARK-37384][CORE][TESTS] Increase timeout for job termination in SchedulerIntegrationSuite

2021-11-18 Thread GitBox
SparkQA commented on pull request #34661: URL: https://github.com/apache/spark/pull/34661#issuecomment-973788477 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49906/ -- This is an automated message from the

[GitHub] [spark] huaxingao commented on pull request #34660: [SPARK-37038][SQL][TESTS][FOLLOWUP] Fix flaky test by loosening the number of results for TABLESAMPLE

2021-11-18 Thread GitBox
huaxingao commented on pull request #34660: URL: https://github.com/apache/spark/pull/34660#issuecomment-973788410 Thanks @HyukjinKwon @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] SparkQA commented on pull request #34638: [SPARK-37360][SQL] Support TimestampNTZ in JSON data source

2021-11-18 Thread GitBox
SparkQA commented on pull request #34638: URL: https://github.com/apache/spark/pull/34638#issuecomment-973787285 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49907/ -- This is an automated message from the

[GitHub] [spark] kazuyukitanimura commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
kazuyukitanimura commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r75291 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java ## @@ -53,19 +53,46 @@

[GitHub] [spark] SparkQA commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
SparkQA commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973786838 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49905/ -- This is an automated message from the

[GitHub] [spark] Yikun commented on pull request #34646: [SPARK-37372][K8S] Removing redundant label addition and refactoring related test case

2021-11-18 Thread GitBox
Yikun commented on pull request #34646: URL: https://github.com/apache/spark/pull/34646#issuecomment-973786521 @dongjoon-hyun Thanks for you patient review, and I rename the title to `Removing redundant label addition and refactoring related test case`. -- This is an automated message

[GitHub] [spark] kazuyukitanimura commented on a change in pull request #34611: [SPARK-35867][SQL] Enable vectorized read for VectorizedPlainValuesReader.readBooleans

2021-11-18 Thread GitBox
kazuyukitanimura commented on a change in pull request #34611: URL: https://github.com/apache/spark/pull/34611#discussion_r751886931 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java ## @@ -53,20 +53,45 @@

[GitHub] [spark] sadikovi commented on a change in pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
sadikovi commented on a change in pull request #34596: URL: https://github.com/apache/spark/pull/34596#discussion_r752883351 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala ## @@ -121,6 +122,10 @@ class

  1   2   3   4   5   6   7   8   >