[GitHub] [spark] SparkQA commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
SparkQA commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977622901 **[Test build #145569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145569/testReport)** for PR 34060 at commit [`6a3bc84`](https://github.com

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755782469 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ p

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755784540 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -156,9 +156,16 @@ class DataSource

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755786855 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -189,17 +190,35 @@ trait V2CreateTablePlan

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755788709 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ p

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755788709 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ p

[GitHub] [spark] cloud-fan commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
cloud-fan commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r755790090 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -44,7 +45,8 @@ import org.apache.s

[GitHub] [spark] cloud-fan commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
cloud-fan commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r755791057 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -1294,13 +1294,25 @@ class DataSourceV2SQLSuite

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755792043 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ p

[GitHub] [spark] cloud-fan closed pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-24 Thread GitBox
cloud-fan closed pull request #34668: URL: https://github.com/apache/spark/pull/34668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsu

[GitHub] [spark] cloud-fan commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-24 Thread GitBox
cloud-fan commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977635547 thanks, merging to master/3.2! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755792043 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ p

[GitHub] [spark] cloud-fan commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-24 Thread GitBox
cloud-fan commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977636986 @beliefer can you open backport PRs for 3.1/3.0? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [spark] cloud-fan commented on pull request #34694: [MINOR][DOCS] Fix scaladoc for skewed partitions optimization

2021-11-24 Thread GitBox
cloud-fan commented on pull request #34694: URL: https://github.com/apache/spark/pull/34694#issuecomment-977637885 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] cloud-fan closed pull request #34694: [MINOR][DOCS] Fix scaladoc for skewed partitions optimization

2021-11-24 Thread GitBox
cloud-fan closed pull request #34694: URL: https://github.com/apache/spark/pull/34694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsu

[GitHub] [spark] SparkQA commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
SparkQA commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977642156 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50040/ -- This is an automated message from the A

[GitHub] [spark] beliefer commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-24 Thread GitBox
beliefer commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977646762 @cloud-fan Thanks a lot for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] beliefer commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-24 Thread GitBox
beliefer commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977647936 > @beliefer can you open backport PRs for 3.1/3.0? thanks! OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [spark] zhengruifeng commented on pull request #34504: [SPARK-37226][SQL] Filter push down through window if partitionSpec isEmpty

2021-11-24 Thread GitBox
zhengruifeng commented on pull request #34504: URL: https://github.com/apache/spark/pull/34504#issuecomment-977648570 > @zhengruifeng can you highlight the differences between your PR and this one? IMHO, there are two main differences: 1, a new node `RankLimit` is introduced,

[GitHub] [spark] SparkQA commented on pull request #34695: [WIP][SPARK-32446][CORE] Add percentile distribution REST API & UI of peak memory metrics for all executors

2021-11-24 Thread GitBox
SparkQA commented on pull request #34695: URL: https://github.com/apache/spark/pull/34695#issuecomment-977653859 **[Test build #145563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145563/testReport)** for PR 34695 at commit [`fa685bf`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #34695: [WIP][SPARK-32446][CORE] Add percentile distribution REST API & UI of peak memory metrics for all executors

2021-11-24 Thread GitBox
SparkQA removed a comment on pull request #34695: URL: https://github.com/apache/spark/pull/34695#issuecomment-977559042 **[Test build #145563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145563/testReport)** for PR 34695 at commit [`fa685bf`](https://gi

[GitHub] [spark] cloud-fan commented on a change in pull request #34684: [SPARK-37442][SQL] InMemoryRelation statistics bug causing broadcast join failures with AQE enabled

2021-11-24 Thread GitBox
cloud-fan commented on a change in pull request #34684: URL: https://github.com/apache/spark/pull/34684#discussion_r755811926 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala ## @@ -259,6 +259,12 @@ case class CachedRDDBuilde

[GitHub] [spark] SparkQA commented on pull request #34689: [SPARK-37445][BUILD] Upgrade hadoop profile to hadoop-3.3 since we support hadoop-3.3 as default now

2021-11-24 Thread GitBox
SparkQA commented on pull request #34689: URL: https://github.com/apache/spark/pull/34689#issuecomment-977656998 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50039/ -- This is an automated message from the A

[GitHub] [spark] imback82 commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
imback82 commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r755814962 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -1294,13 +1294,25 @@ class DataSourceV2SQLSuite

[GitHub] [spark] SparkQA commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
SparkQA commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977661304 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50041/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34367: [SPARK-37099][SQL] Impl a rank-based filter to optimize top-k computation

2021-11-24 Thread GitBox
SparkQA commented on pull request #34367: URL: https://github.com/apache/spark/pull/34367#issuecomment-977664510 **[Test build #145562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145562/testReport)** for PR 34367 at commit [`728d485`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #34367: [SPARK-37099][SQL] Impl a rank-based filter to optimize top-k computation

2021-11-24 Thread GitBox
SparkQA removed a comment on pull request #34367: URL: https://github.com/apache/spark/pull/34367#issuecomment-977497924 **[Test build #145562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145562/testReport)** for PR 34367 at commit [`728d485`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #34367: [SPARK-37099][SQL] Impl a rank-based filter to optimize top-k computation

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34367: URL: https://github.com/apache/spark/pull/34367#issuecomment-977667783 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145562/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977667786 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50040/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #34695: [WIP][SPARK-32446][CORE] Add percentile distribution REST API & UI of peak memory metrics for all executors

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34695: URL: https://github.com/apache/spark/pull/34695#issuecomment-97766 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145563/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34689: [SPARK-37445][BUILD] Upgrade hadoop profile to hadoop-3.3 since we support hadoop-3.3 as default now

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34689: URL: https://github.com/apache/spark/pull/34689#issuecomment-977667780 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50039/ -- T

[GitHub] [spark] SparkQA commented on pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
SparkQA commented on pull request #34686: URL: https://github.com/apache/spark/pull/34686#issuecomment-977668700 **[Test build #145570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145570/testReport)** for PR 34686 at commit [`068473f`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34367: [SPARK-37099][SQL] Impl a rank-based filter to optimize top-k computation

2021-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #34367: URL: https://github.com/apache/spark/pull/34367#issuecomment-977667783 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145562/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34695: [WIP][SPARK-32446][CORE] Add percentile distribution REST API & UI of peak memory metrics for all executors

2021-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #34695: URL: https://github.com/apache/spark/pull/34695#issuecomment-97766 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145563/ -

[GitHub] [spark] peter-toth commented on pull request #34693: [SPARK-37259][SQL] Support CTE queries with MSSQL JDBC

2021-11-24 Thread GitBox
peter-toth commented on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977671500 > > This change also seem to work with MSSQL's temp table syntax: > > ``` > > val withClause = "(SELECT * INTO #TempTable FROM (SELECT * FROM tbl WHERE x > 10) t)" >

[GitHub] [spark] SparkQA commented on pull request #34689: [SPARK-37445][BUILD] Upgrade hadoop profile to hadoop-3.3 since we support hadoop-3.3 as default now

2021-11-24 Thread GitBox
SparkQA commented on pull request #34689: URL: https://github.com/apache/spark/pull/34689#issuecomment-977671754 **[Test build #145567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145567/testReport)** for PR 34689 at commit [`7d8e8b4`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
SparkQA commented on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977672214 **[Test build #145571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145571/testReport)** for PR 34693 at commit [`dea730a`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
SparkQA commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977672925 **[Test build #145568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145568/testReport)** for PR 34060 at commit [`29ba020`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977673271 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145568/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #34689: [SPARK-37445][BUILD] Upgrade hadoop profile to hadoop-3.3 since we support hadoop-3.3 as default now

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34689: URL: https://github.com/apache/spark/pull/34689#issuecomment-977673273 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145567/ -- This

[GitHub] [spark] peter-toth edited a comment on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
peter-toth edited a comment on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977671500 > > This change also seem to work with MSSQL's temp table syntax: > > ``` > > val withClause = "(SELECT * INTO #TempTable FROM (SELECT * FROM tbl WHERE x > 10) t)

[GitHub] [spark] peter-toth edited a comment on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
peter-toth edited a comment on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977671500 > > This change also seem to work with MSSQL's temp table syntax: > > ``` > > val withClause = "(SELECT * INTO #TempTable FROM (SELECT * FROM tbl WHERE x > 10) t)

[GitHub] [spark] peter-toth commented on a change in pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
peter-toth commented on a change in pull request #34693: URL: https://github.com/apache/spark/pull/34693#discussion_r755830269 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala ## @@ -356,4 +357,42 @@ cla

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34689: [SPARK-37445][BUILD] Upgrade hadoop profile to hadoop-3.3 since we support hadoop-3.3 as default now

2021-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #34689: URL: https://github.com/apache/spark/pull/34689#issuecomment-977667780 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50039/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977667786 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50040/

[GitHub] [spark] peter-toth edited a comment on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
peter-toth edited a comment on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977671500 > > This change also seem to work with MSSQL's temp table syntax: > > ``` > > val withClause = "(SELECT * INTO #TempTable FROM (SELECT * FROM tbl WHERE x > 10) t)

[GitHub] [spark] SparkQA commented on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
SparkQA commented on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977679549 **[Test build #145572 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145572/testReport)** for PR 34693 at commit [`b53ef47`](https://github.com

[GitHub] [spark] peter-toth commented on a change in pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
peter-toth commented on a change in pull request #34693: URL: https://github.com/apache/spark/pull/34693#discussion_r755836451 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala ## @@ -325,6 +325,6 @@ private[sql] case clas

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755839634 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ pac

[GitHub] [spark] beliefer opened a new pull request #34696: [SPARK-37389][SQL][3.1] Check unclosed bracketed comments

2021-11-24 Thread GitBox
beliefer opened a new pull request #34696: URL: https://github.com/apache/spark/pull/34696 ### What changes were proposed in this pull request? This PR used to backport https://github.com/apache/spark/pull/34668 to branch 3.1 ### Why are the changes needed? The execute plan

[GitHub] [spark] SparkQA removed a comment on pull request #34689: [SPARK-37445][BUILD] Upgrade hadoop profile to hadoop-3.3 since we support hadoop-3.3 as default now

2021-11-24 Thread GitBox
SparkQA removed a comment on pull request #34689: URL: https://github.com/apache/spark/pull/34689#issuecomment-977587000 **[Test build #145567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145567/testReport)** for PR 34689 at commit [`7d8e8b4`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
SparkQA removed a comment on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977587562 **[Test build #145568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145568/testReport)** for PR 34060 at commit [`29ba020`](https://gi

[GitHub] [spark] SparkQA commented on pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
SparkQA commented on pull request #34686: URL: https://github.com/apache/spark/pull/34686#issuecomment-977706870 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50042/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
SparkQA commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977710744 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50041/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
SparkQA commented on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977713681 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50044/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
SparkQA commented on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977715174 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50045/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34354: [WIP][SPARK-37085][PYTHON][SQL] Add list/tuple overloads to array, struct, create_map, map_concat

2021-11-24 Thread GitBox
SparkQA commented on pull request #34354: URL: https://github.com/apache/spark/pull/34354#issuecomment-977716284 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50043/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977717376 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50041/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977673271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] SparkQA commented on pull request #34696: [SPARK-37389][SQL][3.1] Check unclosed bracketed comments

2021-11-24 Thread GitBox
SparkQA commented on pull request #34696: URL: https://github.com/apache/spark/pull/34696#issuecomment-977720618 **[Test build #145573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145573/testReport)** for PR 34696 at commit [`2bd8736`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #34367: [SPARK-37099][SQL] Impl a rank-based filter to optimize top-k computation

2021-11-24 Thread GitBox
SparkQA commented on pull request #34367: URL: https://github.com/apache/spark/pull/34367#issuecomment-977721203 **[Test build #145574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145574/testReport)** for PR 34367 at commit [`562fbb1`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
SparkQA commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977721207 **[Test build #145569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145569/testReport)** for PR 34060 at commit [`6a3bc84`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977721539 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145569/ -- This

[GitHub] [spark] zhengruifeng commented on a change in pull request #34504: [SPARK-37226][SQL] Filter push down through window if partitionSpec isEmpty

2021-11-24 Thread GitBox
zhengruifeng commented on a change in pull request #34504: URL: https://github.com/apache/spark/pull/34504#discussion_r755892984 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1548,6 +1548,31 @@ object PushPredicateThro

[GitHub] [spark] zhengruifeng commented on a change in pull request #34504: [SPARK-37226][SQL] Filter push down through window if partitionSpec isEmpty

2021-11-24 Thread GitBox
zhengruifeng commented on a change in pull request #34504: URL: https://github.com/apache/spark/pull/34504#discussion_r755895427 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1548,6 +1548,31 @@ object PushPredicateThro

[GitHub] [spark] yaooqinn opened a new pull request #34697: [SPARK-37452][SQL] Char and Varchar breaks backward compatibility between v3.1 and v2

2021-11-24 Thread GitBox
yaooqinn opened a new pull request #34697: URL: https://github.com/apache/spark/pull/34697 ### What changes were proposed in this pull request? We will store table schema in table properties for the read-side to restore. In Spark 3.1, we add char/varchar support nativ

[GitHub] [spark] SparkQA removed a comment on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

2021-11-24 Thread GitBox
SparkQA removed a comment on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977622901 **[Test build #145569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145569/testReport)** for PR 34060 at commit [`6a3bc84`](https://gi

[GitHub] [spark] SparkQA commented on pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
SparkQA commented on pull request #34686: URL: https://github.com/apache/spark/pull/34686#issuecomment-977749419 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50042/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
SparkQA commented on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977750115 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50045/ -- This is an automated message from the A

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755839634 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ pac

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755910761 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ pac

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755910761 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ pac

[GitHub] [spark] SparkQA commented on pull request #34696: [SPARK-37389][SQL][3.1] Check unclosed bracketed comments

2021-11-24 Thread GitBox
SparkQA commented on pull request #34696: URL: https://github.com/apache/spark/pull/34696#issuecomment-977753806 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50046/ -- This is an automated message from the Apache

[GitHub] [spark] HyukjinKwon opened a new pull request #34698: [SPARK-37453][INFRA][SQL][TESTS] Split TPC-DS build in GitHub Actions

2021-11-24 Thread GitBox
HyukjinKwon opened a new pull request #34698: URL: https://github.com/apache/spark/pull/34698 ### What changes were proposed in this pull request? This is kind of a followup for https://github.com/apache/spark/pull/33510 and https://github.com/apache/spark/pull/34641. This PR propose

[GitHub] [spark] zero323 closed pull request #34671: [SPARK-37399][SPARK-37403][PySpark][ML] Merge {ml, mllib}/common.pyi into common.py

2021-11-24 Thread GitBox
zero323 closed pull request #34671: URL: https://github.com/apache/spark/pull/34671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubs

[GitHub] [spark] SparkQA commented on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
SparkQA commented on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977760966 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50044/ -- This is an automated message from the A

[GitHub] [spark] zero323 commented on pull request #34671: [SPARK-37399][SPARK-37403][PySpark][ML] Merge {ml, mllib}/common.pyi into common.py

2021-11-24 Thread GitBox
zero323 commented on pull request #34671: URL: https://github.com/apache/spark/pull/34671#issuecomment-977761457 Merged to master. Thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] SparkQA commented on pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
SparkQA commented on pull request #34686: URL: https://github.com/apache/spark/pull/34686#issuecomment-977762075 **[Test build #145565 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145565/testReport)** for PR 34686 at commit [`8c0a8c9`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
SparkQA removed a comment on pull request #34686: URL: https://github.com/apache/spark/pull/34686#issuecomment-977559123 **[Test build #145565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145565/testReport)** for PR 34686 at commit [`8c0a8c9`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-24 Thread GitBox
SparkQA removed a comment on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977559157 **[Test build #145566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145566/testReport)** for PR 34668 at commit [`c2cec26`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977764284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] AmplabJenkins commented on pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34686: URL: https://github.com/apache/spark/pull/34686#issuecomment-977764283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34693: [SPARK-37259][SQL] Support CTE and TempTable queries with MSSQL JDBC

2021-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #34693: URL: https://github.com/apache/spark/pull/34693#issuecomment-977764281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

2021-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #34686: URL: https://github.com/apache/spark/pull/34686#issuecomment-977764280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] SparkQA commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-24 Thread GitBox
SparkQA commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977763550 **[Test build #145566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145566/testReport)** for PR 34668 at commit [`c2cec26`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #34367: [SPARK-37099][SQL] Impl a rank-based filter to optimize top-k computation

2021-11-24 Thread GitBox
SparkQA commented on pull request #34367: URL: https://github.com/apache/spark/pull/34367#issuecomment-977763552 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50047/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on pull request #34354: [WIP][SPARK-37085][PYTHON][SQL] Add list/tuple overloads to array, struct, create_map, map_concat

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34354: URL: https://github.com/apache/spark/pull/34354#issuecomment-977765686 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50043/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34354: [WIP][SPARK-37085][PYTHON][SQL] Add list/tuple overloads to array, struct, create_map, map_concat

2021-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #34354: URL: https://github.com/apache/spark/pull/34354#issuecomment-977765686 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50043/

[GitHub] [spark] SparkQA commented on pull request #34354: [WIP][SPARK-37085][PYTHON][SQL] Add list/tuple overloads to array, struct, create_map, map_concat

2021-11-24 Thread GitBox
SparkQA commented on pull request #34354: URL: https://github.com/apache/spark/pull/34354#issuecomment-977765650 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50043/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-24 Thread GitBox
AmplabJenkins removed a comment on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977765137 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145566/ -

[GitHub] [spark] SparkQA commented on pull request #34697: [SPARK-37452][SQL] Char and Varchar breaks backward compatibility between v3.1 and v2

2021-11-24 Thread GitBox
SparkQA commented on pull request #34697: URL: https://github.com/apache/spark/pull/34697#issuecomment-977766815 **[Test build #145576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145576/testReport)** for PR 34697 at commit [`1934285`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #34698: [WIP][SPARK-37453][INFRA][SQL][TESTS] Split TPC-DS build in GitHub Actions

2021-11-24 Thread GitBox
SparkQA commented on pull request #34698: URL: https://github.com/apache/spark/pull/34698#issuecomment-977766737 **[Test build #145575 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145575/testReport)** for PR 34698 at commit [`2157008`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #34354: [WIP][SPARK-37085][PYTHON][SQL] Add list/tuple overloads to array, struct, create_map, map_concat

2021-11-24 Thread GitBox
SparkQA commented on pull request #34354: URL: https://github.com/apache/spark/pull/34354#issuecomment-977767329 **[Test build #145577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145577/testReport)** for PR 34354 at commit [`2693310`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

2021-11-24 Thread GitBox
AmplabJenkins commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977765137 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145566/ -- This

[GitHub] [spark] SparkQA commented on pull request #34696: [SPARK-37389][SQL][3.1] Check unclosed bracketed comments

2021-11-24 Thread GitBox
SparkQA commented on pull request #34696: URL: https://github.com/apache/spark/pull/34696#issuecomment-977781156 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50046/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #34354: [WIP][SPARK-37085][PYTHON][SQL] Add list/tuple overloads to array, struct, create_map, map_concat

2021-11-24 Thread GitBox
SparkQA commented on pull request #34354: URL: https://github.com/apache/spark/pull/34354#issuecomment-977790001 **[Test build #145577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145577/testReport)** for PR 34354 at commit [`2693310`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #34354: [WIP][SPARK-37085][PYTHON][SQL] Add list/tuple overloads to array, struct, create_map, map_concat

2021-11-24 Thread GitBox
SparkQA removed a comment on pull request #34354: URL: https://github.com/apache/spark/pull/34354#issuecomment-977767329 **[Test build #145577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145577/testReport)** for PR 34354 at commit [`2693310`](https://gi

[GitHub] [spark] SparkQA commented on pull request #34696: [SPARK-37389][SQL][3.1] Check unclosed bracketed comments

2021-11-24 Thread GitBox
SparkQA commented on pull request #34696: URL: https://github.com/apache/spark/pull/34696#issuecomment-977796177 **[Test build #145573 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145573/testReport)** for PR 34696 at commit [`2bd8736`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #34696: [SPARK-37389][SQL][3.1] Check unclosed bracketed comments

2021-11-24 Thread GitBox
SparkQA removed a comment on pull request #34696: URL: https://github.com/apache/spark/pull/34696#issuecomment-977720618 **[Test build #145573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145573/testReport)** for PR 34696 at commit [`2bd8736`](https://gi

[GitHub] [spark] SparkQA commented on pull request #34697: [SPARK-37452][SQL] Char and Varchar breaks backward compatibility between v3.1 and v2

2021-11-24 Thread GitBox
SparkQA commented on pull request #34697: URL: https://github.com/apache/spark/pull/34697#issuecomment-977800553 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50049/ -- This is an automated message from the Apache

  1   2   3   4   5   6   7   >