Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223864050
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -806,6 +806,22 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22504
Oh, you should also remove yarn from the PR title. This isn't really
related to yarn in any way (anymore).
---
-
To unsubscribe
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223846450
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223850112
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223842100
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -806,6 +806,22 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223843974
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -48,6 +48,19 @@ package object config {
.bytesConf(ByteUnit.MiB
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223842662
--- Diff: core/src/main/scala/org/apache/spark/internal/Logging.scala ---
@@ -143,13 +147,27 @@ trait Logging {
// overriding the root logger's
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223842417
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -806,6 +806,22 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223849313
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223849163
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223851626
--- Diff:
core/src/test/scala/org/apache/spark/util/logging/DriverLoggerSuite.scala ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223851248
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223844575
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223848348
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223840375
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -806,6 +806,22 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223849768
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223850451
--- Diff:
core/src/test/scala/org/apache/spark/util/logging/DriverLoggerSuite.scala ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223853075
--- Diff:
core/src/test/scala/org/apache/spark/util/logging/DriverLoggerSuite.scala ---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223848006
--- Diff:
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala ---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223842304
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -806,6 +806,22 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223840922
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -806,6 +806,22 @@ private[history] class FsHistoryProvider(conf
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r223842956
--- Diff: core/src/main/scala/org/apache/spark/internal/Logging.scala ---
@@ -166,6 +184,7 @@ private[spark] object Logging {
@volatile private var
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22623#discussion_r223838784
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -74,20 +74,25 @@ trait TestPrematureExit {
@volatile var
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r223815272
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosHadoopDelegationTokenManager.scala
---
@@ -34,15 +34,9
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22624
I merged start() with createAndUpdateTokens() in the last commit; the API
is still awkward because of YARN's usage, but it simplifies the Mesos code a
little bit. It can be easily reverted in any
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r223767588
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/AbstractCredentialRenewer.scala
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r223767408
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -60,8 +60,13
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r223767268
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/AbstractCredentialRenewer.scala
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r223767033
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/AbstractCredentialRenewer.scala
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r223766731
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/AbstractCredentialRenewer.scala
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r223766345
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosHadoopDelegationTokenManager.scala
---
@@ -14,147 +14,39
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r223766218
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/AbstractCredentialRenewer.scala
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223525785
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopKerberosLogin.scala
---
@@ -0,0 +1,75
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223524734
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopKerberosLogin.scala
---
@@ -0,0 +1,75
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22615
Hmmm... just want to raise a possible issue that maybe, just maybe, we
should be hosting those jenkins configs in a repository that is owned by the
ASF and writable by all Spark committers
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223524047
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -0,0 +1,156
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223517953
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtil.scala
---
@@ -0,0 +1,238
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223513908
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -81,4 +83,35 @@ private[spark] object
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223519417
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala
---
@@ -51,7 +67,25
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223513489
--- Diff: examples/src/main/scala/org/apache/spark/examples/HdfsTest.scala
---
@@ -41,6 +41,8 @@ object HdfsTest {
val end
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223515094
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -0,0 +1,156
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223516515
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtil.scala
---
@@ -0,0 +1,238
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223518860
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopKerberosLogin.scala
---
@@ -0,0 +1,75
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223515755
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -0,0 +1,156
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223516199
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfExecutorFeatureStep.scala
---
@@ -0,0 +1,58
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223514310
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStep.scala
---
@@ -0,0 +1,52
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223511748
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -646,8 +646,9 @@ private[spark] class SparkSubmit extends Logging
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223515261
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -0,0 +1,156
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223512267
--- Diff: docs/running-on-kubernetes.md ---
@@ -820,4 +820,37 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223519651
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilderSuite.scala
---
@@ -19,14 +19,18
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223517312
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtil.scala
---
@@ -0,0 +1,238
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223517875
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtil.scala
---
@@ -0,0 +1,238
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223518149
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtil.scala
---
@@ -0,0 +1,238
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223515400
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -0,0 +1,156
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223517824
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopBootstrapUtil.scala
---
@@ -0,0 +1,238
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223514752
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala
---
@@ -0,0 +1,156
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223512056
--- Diff: docs/running-on-kubernetes.md ---
@@ -820,4 +820,37 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223518787
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadooputils/HadoopKerberosLogin.scala
---
@@ -0,0 +1,75
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223512232
--- Diff: docs/running-on-kubernetes.md ---
@@ -820,4 +820,37 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r223520296
--- Diff: docs/security.md ---
@@ -722,7 +722,85 @@ with encryption, at least.
The Kerberos login will be periodically renewed using the provided
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22615
> an unset var is just an empty string anyway.
The issue is that if you call that function multiple times the variables
might be set by a previous c
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22615#discussion_r223509836
--- Diff: dev/create-release/release-build.sh ---
@@ -191,9 +191,17 @@ if [[ "$1" == "package" ]]; then
make_binary_release(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22623#discussion_r223507984
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -70,23 +70,25 @@ trait TestPrematureExit {
mainObject
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22623#discussion_r223497773
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -74,20 +74,28 @@ trait TestPrematureExit {
@volatile var
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22614
> a better and safer solution by introducing exponential backoff with
retries
I'm confused about that suggestion. What is being retried? The user query?
The HMS call? What is chang
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22624#discussion_r223493773
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/AbstractCredentialRenewer.scala
---
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r223462348
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
---
@@ -79,12 +82,30 @@ class HiveClientSuite(version: String
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r223461273
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -746,34 +746,45 @@ private[client] class Shim_v0_13 extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22614#discussion_r223459567
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -544,6 +544,15 @@ object SQLConf {
.booleanConf
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22624
Given the lack of reviews let me ping some people: @skonto @jerryshao
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22623#discussion_r223454115
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -74,20 +74,26 @@ trait TestPrematureExit {
@volatile var
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22623#discussion_r223453846
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -74,20 +74,26 @@ trait TestPrematureExit {
@volatile var
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22624
> ...calls fetchDelegationTokens() twice since the tokenRenewalInterval...
That is true - the second fetch is only needed for YARN because reasons.
But that's also completely unrela
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22557
Ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22623#discussion_r223447961
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -74,20 +74,26 @@ trait TestPrematureExit {
@volatile var
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223436285
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala
---
@@ -0,0 +1,255
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223440836
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
---
@@ -134,6 +163,29 @@ class YarnAllocatorSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223439004
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestTestHelper.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223433455
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceRequestHelper.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223439326
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala
---
@@ -0,0 +1,255
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223441224
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala
---
@@ -0,0 +1,255
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223437860
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala
---
@@ -0,0 +1,255
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223437109
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala
---
@@ -0,0 +1,255
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223438072
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala
---
@@ -0,0 +1,255
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223438810
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala
---
@@ -0,0 +1,255
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223434738
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -288,9 +296,14 @@ private[yarn] class YarnAllocator
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223436523
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala
---
@@ -0,0 +1,255
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223435325
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
@@ -199,6 +200,37 @@ class ClientSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223442688
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
---
@@ -87,6 +88,20 @@ class YarnAllocatorSuite
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223433617
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceRequestHelper.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223436337
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala
---
@@ -0,0 +1,255
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223440106
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestTestHelper.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223436057
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
@@ -433,4 +465,36 @@ class ClientSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223433078
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceRequestHelper.scala
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r223435056
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
---
@@ -35,7 +36,7 @@ import
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22642#discussion_r223150948
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -33,11 +33,13 @@ import
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22532
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22615
> had classpath-like references to hadoop-...-2.6.5
It also has references to a bunch of other old stuff; I don't think there's
a need to cha
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22637
While we're at it, it would be great to fix the typo in the PR title.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22615
What is the change in `app-20180109111548-` about? It's hard to see in
the diff and I'm a little surprised you needed to touch
501 - 600 of 11074 matches
Mail list logo
