[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302704915 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSu

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302704994 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSu

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302704450 ## File path: sql/core/src/test/scala/org/apache/spark/sql/RuntimeConfigSuite.scala ###

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302704340 ## File path: sql/core/src/test/scala/org/apache/spark/sql/RuntimeConfigSuite.scala ###

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-11 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302702361 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala ###

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302329225 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala #

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302329089 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala #

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302329029 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala #

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302307714 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala ###

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302307831 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala ###

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302307645 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHive.scala ###

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302307132 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.sca

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302306529 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersi

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302306447 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersi

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302306288 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersi

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302306328 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersi

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302306401 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersi

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302305891 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersi

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302305340 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserve

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302305265 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserve

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302304884 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/Continuo

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302304550 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/Continuo

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302304287 ## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryListe

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302304058 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSui

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302303628 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSu

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302303676 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSu

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302303246 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusList

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302303385 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusList

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302303246 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusList

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302303246 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusList

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302303010 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/Sta

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302302967 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/Sta

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302302208 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302302186 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302302093 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302302154 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302301828 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.sc

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302300020 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggre

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302299080 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala #

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302299013 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala #

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302299080 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala #

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

2019-07-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302299013 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala #