Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11573
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-195597743
OK. Let's merge this first (to avoid it has conflicts caused by other
commits ). We can address the comments in a follow-up PR.
---
If your project is set up for it,
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55902999
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,10 +83,86 @@ private[sql] class SparkQl(conf: ParserConf =
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-195592073
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-195592071
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-195591633
**[Test build #52937 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52937/consoleFull)**
for PR 11573 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-195570543
I have left a few comments. It is a good starting point. Thank you for
working on this!
---
If your project is set up for it, you can reply to this email and have your
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55893285
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -29,7 +29,26 @@ private[sql] class SparkQl(conf: ParserConf =
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55892958
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,428 @@
+/*
+ * Licensed to the
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55892525
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -29,7 +29,26 @@ private[sql] class SparkQl(conf: ParserConf =
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55889875
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,10 +83,86 @@ private[sql] class SparkQl(conf: ParserConf =
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55888485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,10 +83,86 @@ private[sql] class SparkQl(conf: ParserConf =
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-195520611
**[Test build #52937 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52937/consoleFull)**
for PR 11573 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55867164
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala
---
@@ -24,12 +27,15 @@ package
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194613303
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194613298
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194612768
**[Test build #52770 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52770/consoleFull)**
for PR 11573 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194600792
Also cc @rxin @yhuai.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194590031
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194590032
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194589783
**[Test build #52773 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52773/consoleFull)**
for PR 11573 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194555700
**[Test build #52773 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52773/consoleFull)**
for PR 11573 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194550969
**[Test build #52770 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52770/consoleFull)**
for PR 11573 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194549041
@hvanhovell I believe as of the latest commit I've addressed all of your
comments. This is ready from my side so I've removed the WIP tag. PTAL.
---
If your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194189126
@hvanhovell I've addressed most of your comments except a couple ones where
I said I would fix later. Separately I've also significantly cleaned up the
logic and
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55487582
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf =
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55487513
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55487572
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala
---
@@ -29,7 +32,8 @@ package
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194188020
**[Test build #52739 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52739/consoleFull)**
for PR 11573 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55487318
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55487276
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-194186989
**[Test build #52737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52737/consoleFull)**
for PR 11573 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55486952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf =
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55486925
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55352952
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf =
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55337949
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55337179
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala
---
@@ -29,7 +32,8 @@ package
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55336977
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55336439
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55336099
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55335658
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf =
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55335240
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55335131
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55335079
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55334443
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55333881
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55333529
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableCommandParser.scala
---
@@ -0,0 +1,410 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r5511
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf =
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55332214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -64,6 +85,53 @@ private[sql] class SparkQl(conf: ParserConf =
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55324768
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55324206
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-193637484
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-193637485
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-193637270
**[Test build #52630 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52630/consoleFull)**
for PR 11573 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-193610715
Note: The only changes I made on top of #11048 is addressing the
outstanding comments in that patch and some minor clean ups. It's entirely
possible that there
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11573#issuecomment-193609366
**[Test build #52630 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52630/consoleFull)**
for PR 11573 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55316476
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11573#discussion_r55316403
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/11573
[SPARK-13139][SQL] Parse Hive DDL commands ourselves
## What changes were proposed in this pull request?
This patch is ported over from @viirya's changes in #11048. Currently for
most
59 matches
Mail list logo
