Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215944276
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12660
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215938663
I'm merging this one in. I will send a follow-up PR to rename the params
and update `ALS.train`. Thanks!
---
If your project is set up for it, you can reply to this ema
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215861118
Good point. I will update the param names
On Fri, 29 Apr 2016 at 21:46, Xiangrui Meng
wrote:
> Just realized that it doesn't make sense to say RDD in the
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215859307
Just realized that it doesn't make sense to say `RDD` in the parameter
name. This is implementation detail and we actually return the factors as
DataFrames. So, shall we
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215856943
I'm making another pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61631797
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215707756
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215707757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215707673
**[Test build #57332 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57332/consoleFull)**
for PR 12660 at commit
[`f767592`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215699840
**[Test build #57332 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57332/consoleFull)**
for PR 12660 at commit
[`f767592`](https://gi
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215699140
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215698999
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215699002
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215698753
I moved the storage param tests into a separate test suite, since the
persistent RDDs were conflicting between the other test cases in `ALSSuite`. I
could also clear the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215684404
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215684407
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215684384
**[Test build #57328 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57328/consoleFull)**
for PR 12660 at commit
[`cd2d32b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215680199
**[Test build #57328 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57328/consoleFull)**
for PR 12660 at commit
[`cd2d32b`](https://gi
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215679740
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215668201
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215668166
**[Test build #57327 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57327/consoleFull)**
for PR 12660 at commit
[`cd2d32b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215668206
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215663718
**[Test build #57327 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57327/consoleFull)**
for PR 12660 at commit
[`cd2d32b`](https://gi
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215663631
Thanks for the comments. Have updated tests accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61393700
--- Diff: python/pyspark/ml/tests.py ---
@@ -929,6 +932,50 @@ def test_apply_binary_term_freqs(self):
": expected " + s
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61392731
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61392206
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61391861
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61391277
--- Diff: python/pyspark/ml/tests.py ---
@@ -929,6 +932,50 @@ def test_apply_binary_term_freqs(self):
": expected " + s
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61391177
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61391003
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61391033
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61390984
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215350491
If it's just porting old API params to the new API, seems sensible. The
implementation looks sensible to me.
---
If your project is set up for it, you can reply to this
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-215323273
ping @srowen @yanboliang @jkbradley any comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61148265
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61145104
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.use
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61144699
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61102417
--- Diff: python/pyspark/ml/tests.py ---
@@ -929,6 +932,50 @@ def test_apply_binary_term_freqs(self):
": expected " + s
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61102146
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -512,6 +514,55 @@ class ALSSuite
assert(getFactors(model.user
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61042431
--- Diff: python/pyspark/ml/tests.py ---
@@ -929,6 +932,50 @@ def test_apply_binary_term_freqs(self):
": expected " + s
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61001243
--- Diff: python/pyspark/ml/tests.py ---
@@ -929,6 +932,50 @@ def test_apply_binary_term_freqs(self):
": expected " + s
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r61000897
--- Diff: python/pyspark/ml/tests.py ---
@@ -929,6 +932,50 @@ def test_apply_binary_term_freqs(self):
": expected " + s
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r60943435
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -153,12 +153,42 @@ private[recommendation] trait ALSParams extends
ALS
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r60925487
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -153,12 +153,42 @@ private[recommendation] trait ALSParams extends
ALSMode
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r60925223
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -153,12 +153,42 @@ private[recommendation] trait ALSParams extends
ALSMode
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r60920681
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -153,12 +153,42 @@ private[recommendation] trait ALSParams extends
ALS
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r60920007
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -153,12 +153,42 @@ private[recommendation] trait ALSParams extends
ALS
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r60911592
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -374,8 +404,21 @@ class ALS(@Since("1.4.0") override val uid: String)
exte
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-214318819
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-214318808
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-214318343
**[Test build #56896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56896/consoleFull)**
for PR 12660 at commit
[`dcf0a3e`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-214298405
**[Test build #56896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56896/consoleFull)**
for PR 12660 at commit
[`dcf0a3e`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-214292927
**[Test build #56893 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56893/consoleFull)**
for PR 12660 at commit
[`d25fee6`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-214292971
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-214292972
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user rishabhbhardwaj commented on a diff in the pull request:
https://github.com/apache/spark/pull/12660#discussion_r60901825
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -374,8 +404,21 @@ class ALS(@Since("1.4.0") override val uid: Stri
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12660#issuecomment-214280613
**[Test build #56893 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56893/consoleFull)**
for PR 12660 at commit
[`d25fee6`](https://gi
GitHub user MLnick opened a pull request:
https://github.com/apache/spark/pull/12660
[SPARK-14412][ML][PYSPARK] Add StorageLevel params to ALS
`mllib` `ALS` supports `setIntermediateRDDStorageLevel` and
`setFinalRDDStorageLevel`. This PR adds these as Params in `ml` `ALS`. They are
60 matches
Mail list logo
