Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2734#issuecomment-58507800
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user shijinkui opened a pull request:
https://github.com/apache/spark/pull/2734
[SPARK-3781] code Style format and little improvement
1. use scala recommended usage
2. method body's left bracket
3. parameter list format
4. explicit mutable collection, such as "new
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2644#issuecomment-58390539
Hey @shijinkui I think we're fairly confused as to which one is the latest
PR. Is there a reason why you keep opening and closing PRs? If you make a
change to the code
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18596253
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -40,10 +40,9 @@ case class Aggregator[K, V, C] (
def combineValuesByKey(iter:
Github user shijinkui closed the pull request at:
https://github.com/apache/spark/pull/2714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2714#issuecomment-58374755
@shijinkui Why do you keep closing this? Right after you requested Jenkins
to test it. You can verify the style checks run locally first if you need to.
The test failures
Github user shijinkui commented on the pull request:
https://github.com/apache/spark/pull/2714#issuecomment-58370144
@AmplabJenkins @andrewor14 review and run test again please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2714#issuecomment-58370041
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user shijinkui commented on the pull request:
https://github.com/apache/spark/pull/2704#issuecomment-58369964
@AmplabJenkins @andrewor14 review and run test again please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2704#issuecomment-58369791
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2704#issuecomment-58369787
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21465/consoleFull)
for PR 2704 at commit
[`42a9d81`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2704#issuecomment-58369606
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21465/consoleFull)
for PR 2704 at commit
[`42a9d81`](https://github.com/ap
GitHub user shijinkui opened a pull request:
https://github.com/apache/spark/pull/2714
[SPARK-3781] code Style format
code Style format, modify the third time :(
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/spark mast
Github user shijinkui closed the pull request at:
https://github.com/apache/spark/pull/2704
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18565055
--- Diff: core/src/main/scala/org/apache/spark/ui/UIWorkloadGenerator.scala
---
@@ -17,11 +17,11 @@
package org.apache.spark.ui
-import sc
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18565013
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala ---
@@ -59,7 +59,7 @@ private[spark] class BroadcastManager(
private val
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2704#issuecomment-58308674
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21443/consoleFull)
for PR 2704 at commit
[`4a685cc`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2704#issuecomment-58308676
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2704#issuecomment-58308604
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21443/consoleFull)
for PR 2704 at commit
[`4a685cc`](https://github.com/ap
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2704#issuecomment-58308187
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2704#issuecomment-58303122
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user shijinkui closed the pull request at:
https://github.com/apache/spark/pull/2644
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user shijinkui commented on the pull request:
https://github.com/apache/spark/pull/2644#issuecomment-58302944
repush at #2704
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
GitHub user shijinkui opened a pull request:
https://github.com/apache/spark/pull/2704
[SPARK-3781] code Style format
1. code formater
2. scala normal usage about method and param
You can merge this pull request into a Git repository by running:
$ git pull https://github.co
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18562140
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -265,15 +265,15 @@ private[spark] object Utils extends Logging {
/** Copy
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18562132
--- Diff: core/src/main/scala/org/apache/spark/ui/UIWorkloadGenerator.scala
---
@@ -17,11 +17,11 @@
package org.apache.spark.ui
-import
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18562022
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala ---
@@ -38,5 +42,4 @@ private[spark] trait SchedulerBackend {
* @ret
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18561868
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala ---
@@ -59,7 +59,7 @@ private[spark] class BroadcastManager(
private
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18560510
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -40,10 +40,9 @@ case class Aggregator[K, V, C] (
def combineValuesByKey(iter: I
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2644#issuecomment-58251994
Hey @shijinkui I agree with most of the changes here. It seems that there
are a few lines that exceed the 100 character limit however.
---
If your project is set up f
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544914
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -265,15 +265,15 @@ private[spark] object Utils extends Logging {
/** Cop
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544949
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -845,7 +845,7 @@ private[spark] object Utils extends Logging {
stdoutThread.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544573
--- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala ---
@@ -40,10 +40,9 @@ case class Aggregator[K, V, C] (
def combineValuesByKey(iter:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544867
--- Diff: core/src/main/scala/org/apache/spark/ui/UIWorkloadGenerator.scala
---
@@ -17,11 +17,11 @@
package org.apache.spark.ui
-impor
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544810
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulerBackend.scala ---
@@ -38,5 +42,4 @@ private[spark] trait SchedulerBackend {
* @re
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544762
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1019,7 +1020,7 @@ class DAGScheduler(
changeEpoc
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2644#discussion_r18544674
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala ---
@@ -59,7 +59,7 @@ private[spark] class BroadcastManager(
private
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2644#issuecomment-57810182
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user shijinkui opened a pull request:
https://github.com/apache/spark/pull/2644
[SPARK-3781] code Style format
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/spark styleFormat
Alternatively you can review and a
39 matches
Mail list logo
