[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34261344 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-120036882 [Test build #36938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36938/consoleFull) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-120036165 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-120036134 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-120084714 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-120084579 [Test build #36938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36938/console) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-120089930 LGTM, merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34284480 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34284738 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6762 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-09 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-120179612 Thanks, I will update the code in another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119494142 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119547061 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119546905 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119496567 [Test build #36773 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36773/consoleFull) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119494206 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119536945 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119536817 [Test build #36773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36773/console) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119572615 [Test build #36788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36788/consoleFull) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119571717 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119632019 cc @rxin @davies can you review the code for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119628099 [Test build #36788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36788/console) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119628347 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34171330 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1627,6 +1627,178 @@ object functions { def ascii(columnName: String):

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34169428 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34170273 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34171969 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34172081 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34173357 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -159,6 +162,77 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34173817 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34170014 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34170078 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34170486 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34172948 --- Diff: unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -121,11 +121,86 @@ public void endsWith() { @Test

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119671887 @chenghao-intel Thanks for working on this, it's in good shape, left some minor comments. This is a question about how we define the functions for DataFrame, i'd

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34220506 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34214857 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34214783 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1627,6 +1627,178 @@ object functions { def ascii(columnName: String):

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34216050 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34219910 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34220659 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34220637 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34223717 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34219801 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34213184 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34214228 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1627,6 +1627,178 @@ object functions { def ascii(columnName:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119775338 @davies, thanks for the reviewing, and I will update the code once we make the alignment for the comments. I do have the same concerns on the DataFrame

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34216355 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34216312 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34216247 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34214016 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34214037 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34214578 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34214489 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34215063 --- Diff: unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -121,11 +121,86 @@ public void endsWith() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34215354 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34216079 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34213545 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34214670 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -159,6 +162,77 @@ public UTF8String toLowerCase() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34215153 --- Diff: unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -121,11 +121,86 @@ public void endsWith() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34215896 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -206,6 +207,198 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34213337 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -188,6 +189,302 @@ case class

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34215417 --- Diff: unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -121,11 +121,86 @@ public void endsWith() { @Test

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-07 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34066113 --- Diff: unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -88,4 +88,57 @@ public void substring() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-07 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r34106289 --- Diff: unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java --- @@ -88,4 +88,57 @@ public void substring() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118850907 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118850856 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118851731 [Test build #36578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36578/consoleFull) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118852017 [Test build #36578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36578/console) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118852021 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118889291 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118897252 [Test build #36585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36585/consoleFull) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118935740 [Test build #36585 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36585/console) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118935874 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33997696 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1627,6 +1627,178 @@ object functions { def ascii(columnName:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-119033062 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-11629 [Test build #36583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36583/consoleFull) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118894565 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118894682 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-11291 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-11315 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-118889284 [Test build #36583 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36583/console) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-117941631 [Test build #36342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36342/console) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-117941709 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33703131 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -220,6 +222,404 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33685192 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -159,6 +162,77 @@ public UTF8String toLowerCase() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33698505 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringFunctionsSuite.scala --- @@ -226,5 +226,128 @@ class

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33700254 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -220,6 +222,404 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33698802 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -159,6 +162,77 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33700547 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -220,6 +222,404 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread tarekauel
Github user tarekauel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33699927 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -220,6 +222,404 @@ case class EndsWith(left:

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33654601 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -159,6 +162,77 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33655757 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -159,6 +162,77 @@ public UTF8String toLowerCase() { return

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6762#discussion_r33655087 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -159,6 +162,77 @@ public UTF8String toLowerCase() {

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-117909074 [Test build #36342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36342/consoleFull) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread zhichao-li
Github user zhichao-li commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-117905644 retest this please. weird failure on unrelated `repeat` function --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-117908868 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-117908853 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-117904884 [Test build #36328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36328/console) for PR 6762 at commit

[GitHub] spark pull request: [SPARK-8247][SPARK-8249][SPARK-8252][SPARK-825...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6762#issuecomment-117904903 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   >