Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73764141
@sryza looks like I narrowly missed your last commit. I have copied the
changes there to this HOTFIX commit: b640c841fca92bb0bca77267db2965ff8f79586f
---
If your proj
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73763274
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73763270
[Test build #27220 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27220/consoleFull)
for PR 4168 at commit
[`3cca880`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73762745
[Test build #27220 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27220/consoleFull)
for PR 4168 at commit
[`3cca880`](https://githu
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24440514
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1105,6 +1105,25 @@ class SparkContext(config: SparkConf) extends
Logging with Exe
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24440168
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,59 +240,90 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73761510
Hey @sryza thanks a lot for fixing this. I will merge this into master and
1.3 after fixing the last batch of comments that I pointed out when I merge
this.
---
If y
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24438965
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,59 +240,90 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24435726
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,59 +240,90 @@ private[spark] class ExecutorAllocationManager(
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24406500
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,59 +240,90 @@ private[spark] class ExecutorAllocationManager(
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73656534
(I only looked at the public API's, but those look fine to me now - there
are none!)
---
If your project is set up for it, you can reply to this email and have your
rep
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24391913
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,59 +240,90 @@ private[spark] class ExecutorAllocationManager(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73645547
[Test build #27168 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27168/consoleFull)
for PR 4168 at commit
[`f80b7ec`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73645552
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73645180
Hey @sryza thanks for reiterating quickly on the reviews. I left 1 question
but other than that this looks pretty close.
---
If your project is set up for it, you can
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24389414
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,59 +240,90 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24388610
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1105,6 +1105,25 @@ class SparkContext(config: SparkConf) extends
Logging with Exe
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24388465
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -23,10 +23,16 @@ package org.apache.spark
private[spark] trait Ex
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73641698
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73641693
[Test build #27170 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27170/consoleFull)
for PR 4168 at commit
[`37ce77d`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73641562
[Test build #27170 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27170/consoleFull)
for PR 4168 at commit
[`37ce77d`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73640262
[Test build #27168 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27168/consoleFull)
for PR 4168 at commit
[`f80b7ec`](https://githu
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24383247
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -311,18 +303,27 @@ class CoarseGrainedSchedulerBack
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24381198
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -311,18 +303,27 @@ class CoarseGrainedSchedule
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73628826
@andrewor14 when I mentioned rederiving `numPendingExecutors` I was
actually talking about the way we calculate the version of it that lives in
`ExecutorAllocationManager`.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73625504
@sryza I may be missing something but I don't understand why
`numPendingExecutors` should be rederived from the user calling
`requestTotalExecutors` every time. What e
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24382301
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -23,12 +23,19 @@ package org.apache.spark
private[spark] trait Executo
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24381293
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
@@ -311,18 +303,27 @@ class CoarseGrainedSchedule
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24381075
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -23,12 +23,19 @@ package org.apache.spark
private[spark] trait Ex
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24381071
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -23,12 +23,19 @@ package org.apache.spark
private[spark] trait Ex
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73623282
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73623276
[Test build #27138 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27138/consoleFull)
for PR 4168 at commit
[`a19e6d2`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73614961
[Test build #27138 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27138/consoleFull)
for PR 4168 at commit
[`a19e6d2`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73613671
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73613658
[Test build #27129 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27129/consoleFull)
for PR 4168 at commit
[`985ffe7`](https://gith
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24375632
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1105,16 +1105,35 @@ class SparkContext(config: SparkConf) extends
Logging with Executo
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24375535
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1105,16 +1105,35 @@ class SparkContext(config: SparkConf) extends
Logging with Ex
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24373580
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1105,16 +1105,35 @@ class SparkContext(config: SparkConf) extends
Logging with Exec
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24373541
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1105,16 +1105,35 @@ class SparkContext(config: SparkConf) extends
Logging with Exec
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73602915
@andrewor14 updated patch adds back `requestExecutors` and incorporates
your other comments.
I also made some small changes to the way we update `numExecutorsPendin
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73601805
[Test build #27129 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27129/consoleFull)
for PR 4168 at commit
[`985ffe7`](https://githu
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24368946
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,54 +241,75 @@ private[spark] class ExecutorAllocationManager(
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24367502
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,54 +241,75 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24366945
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -201,18 +201,35 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24366884
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,54 +241,75 @@ private[spark] class ExecutorAllocationManager(
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24363707
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -201,18 +201,35 @@ private[spark] class ExecutorAllocationManager(
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24358135
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,54 +241,75 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24358128
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -201,18 +201,35 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24357953
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,54 +241,75 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24357759
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -201,18 +201,35 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24357547
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,54 +241,75 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24357469
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -224,54 +241,75 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24356890
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -26,7 +26,7 @@ private[spark] trait ExecutorAllocationClient {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73571161
[Test build #27111 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27111/consoleFull)
for PR 4168 at commit
[`b78806e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73571179
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73563743
Hey @sryza we definitely need to keep the API because applications building
on top of Spark may want to implement their own heuristics (e.g. Spark
streaming may want t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73558148
[Test build #27111 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27111/consoleFull)
for PR 4168 at commit
[`b78806e`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73557433
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73557431
[Test build #27110 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27110/consoleFull)
for PR 4168 at commit
[`aa01555`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73557303
[Test build #27110 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27110/consoleFull)
for PR 4168 at commit
[`aa01555`](https://githu
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24313087
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -413,6 +418,7 @@ private[spark] class ExecutorAllocationManager(
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24311057
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -438,6 +444,7 @@ private[spark] class ExecutorAllocationManager(
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24310281
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -438,6 +444,7 @@ private[spark] class ExecutorAllocationManager(
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73459200
Thanks for the review @andrewor14. Updated patch coming soon.
Regarding the public API, what I'm contending is that we don't really have
any idea whether or how pe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73457967
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73457963
[Test build #27077 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27077/consoleFull)
for PR 4168 at commit
[`16db9f4`](https://gith
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73456491
@sryza Is the API change in `ExecutorAllocationManager` necessary for this
change? The new API essentially pushes the responsibility of maintaining the
number of execu
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308654
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -226,50 +249,32 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308697
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1029,12 +1029,12 @@ class SparkContext(config: SparkConf) extends
Logging with Ex
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308687
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -413,6 +418,7 @@ private[spark] class ExecutorAllocationManager(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73456090
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73456084
[Test build #27073 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27073/consoleFull)
for PR 4168 at commit
[`9ba0e01`](https://gith
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308610
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -226,50 +249,32 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308577
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -226,50 +249,32 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308537
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -198,15 +198,38 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308517
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -198,15 +198,38 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308501
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -198,15 +198,38 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308485
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -198,15 +198,38 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308449
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -226,50 +249,32 @@ private[spark] class ExecutorAllocationManager(
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308401
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -198,15 +198,38 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r24308360
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -198,15 +198,38 @@ private[spark] class ExecutorAllocationManager(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73455047
[Test build #27077 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27077/consoleFull)
for PR 4168 at commit
[`16db9f4`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73451518
[Test build #27073 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27073/consoleFull)
for PR 4168 at commit
[`9ba0e01`](https://githu
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73451192
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73155456
@andrewor14 it's no longer a WIP, and I am aiming for it for 1.3. I just
updated the title - sorry for the confusion.
---
If your project is set up for it, you can reply
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-73154727
@sryza is this still WIP? Are we aiming for this to go into 1.3?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r23683544
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -226,50 +249,32 @@ private[spark] class ExecutorAllocationManager(
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r23682980
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -226,50 +249,32 @@ private[spark] class ExecutorAllocationManager(
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r23682774
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -470,6 +477,7 @@ private[spark] class ExecutorAllocationManager(
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r23682749
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -438,6 +444,7 @@ private[spark] class ExecutorAllocationManager(
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-71757464
@sryza looks like the test failures are legit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-71697091
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-71697071
[Test build #26168 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26168/consoleFull)
for PR 4168 at commit
[`9ba0e01`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4168#issuecomment-71687375
[Test build #26168 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26168/consoleFull)
for PR 4168 at commit
[`9ba0e01`](https://githu
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r23566205
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -199,14 +199,31 @@ private[spark] class ExecutorAllocationManager(
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r23502091
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -226,8 +243,11 @@ private[spark] class ExecutorAllocationManager(
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r23502082
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -237,39 +257,18 @@ private[spark] class ExecutorAllocationManager(
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r23502033
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -237,39 +257,18 @@ private[spark] class ExecutorAllocationManager(
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4168#discussion_r23502021
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -199,14 +199,31 @@ private[spark] class ExecutorAllocationManager(
1 - 100 of 104 matches
Mail list logo
