Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/14788
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r83336142
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -916,21 +931,26 @@ case class ToDate(ch
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r83280122
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -916,21 +931,26 @@ case class ToDate(chi
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82737073
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2374,14 +2374,14 @@ object functions {
* @group datetime_funcs
* @
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82735390
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2374,14 +2374,14 @@ object functions {
* @group datetime_funcs
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82701507
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2548,16 +2548,20 @@ object functions {
def to_date(e: Column): Colum
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82650345
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2548,16 +2548,20 @@ object functions {
def to_date(e: Column): Column
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82604966
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2374,14 +2374,14 @@ object functions {
* @group datetime_funcs
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82604495
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2548,16 +2548,20 @@ object functions {
def to_date(e: Column): Colum
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82544981
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2548,16 +2548,20 @@ object functions {
def to_date(e: Column): Column = wit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r82544965
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2374,14 +2374,14 @@ object functions {
* @group datetime_funcs
* @
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r78003977
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -322,9 +322,9 @@ object FunctionRegistry {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77960352
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,58 +72,64 @@ case class CurrentTime
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77799138
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -834,8 +874,29 @@ object DateTimeUtils {
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77799005
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -834,8 +874,29 @@ object DateTimeUtils {
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77798210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -90,6 +98,14 @@ object DateTimeUtils {
}
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77798052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -42,12 +42,20 @@ object DateTimeUtils {
// see
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77797979
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -42,12 +42,20 @@ object DateTimeUtils {
// see
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77796464
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2551,7 +2551,11 @@ object functions {
* Returns date truncated to th
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77796274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -916,21 +944,25 @@ case class ToDate(chi
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77796182
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class CurrentTimes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77796067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class CurrentTimes
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77794368
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class CurrentTime
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77794238
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -916,21 +944,25 @@ case class ToDate(chi
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77793869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class CurrentTimes
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77646040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class CurrentTime
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77619649
--- Diff: python/pyspark/sql/functions.py ---
@@ -974,13 +974,14 @@ def trunc(date, format):
"""
Returns date truncated to the unit specif
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77619318
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class CurrentTimest
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76511830
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -916,21 +953,26 @@ case class ToDate(ch
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76511635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -916,21 +953,26 @@ case class ToDate(chil
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76511621
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -583,20 +602,25 @@ case class FromUnixTim
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76511591
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -748,6 +764,14 @@ object DateTimeUtils {
}
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76511384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -845,6 +922,10 @@ object DateTimeUtils {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76054268
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -783,27 +783,34 @@ case class TimeSub(st
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76049982
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -783,27 +783,34 @@ case class TimeSub(sta
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76041905
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -783,27 +783,34 @@ case class TimeSub(s
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r76041561
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -783,27 +783,34 @@ case class TimeSub(st
37 matches
Mail list logo
