Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r98751522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,47 @@ object CombineLimits extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r98751322
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,47 @@ object CombineLimits extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r98750834
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,47 @@ object CombineLimits extends
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14866
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77383666
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2265,7 +2265,7 @@ setMethod("join",
signature(x = "SparkDataFrame", y = "SparkDataFrame"),
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77380304
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2265,7 +2265,7 @@ setMethod("join",
signature(x = "SparkDataFrame", y = "SparkDataFrame"),
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77290718
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2265,7 +2265,7 @@ setMethod("join",
signature(x = "SparkDataFrame", y = "SparkDataFrame"),
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77219760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,47 @@ object CombineLimits extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77155243
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,47 @@ object CombineLimits extends
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77099268
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -39,39 +38,46 @@ object ReorderJoin extends
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77098768
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/joinTypes.scala
---
@@ -28,6 +28,7 @@ object JoinType {
case
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77098708
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,47 @@ object CombineLimits extends
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77097569
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,47 @@ object CombineLimits extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77089271
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -39,39 +38,46 @@ object ReorderJoin extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77086020
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/joinTypes.scala
---
@@ -28,6 +28,7 @@ object JoinType {
case
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77085681
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,47 @@ object CombineLimits extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77084851
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,47 @@ object CombineLimits extends
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77069424
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,45 @@ object CombineLimits extends
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77067766
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -698,6 +698,8 @@ private[sql] class SQLConf extends Serializable
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77067849
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
---
@@ -353,7 +353,7 @@ case class
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77049987
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -39,39 +38,44 @@ object ReorderJoin extends
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77049867
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -303,7 +303,7 @@ package object dsl {
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r77049426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,45 @@ object CombineLimits extends
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76885747
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -39,39 +38,44 @@ object ReorderJoin extends
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76885372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -303,7 +303,7 @@ package object dsl {
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76884744
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,45 @@ object CombineLimits extends
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76884680
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -933,6 +936,45 @@ object CombineLimits extends
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76878769
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
---
@@ -353,7 +353,7 @@ case class
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76874085
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -698,6 +698,8 @@ private[sql] class SQLConf extends Serializable
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76873765
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -698,6 +698,8 @@ private[sql] class SQLConf extends Serializable
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76857357
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -642,7 +642,7 @@ class LogicalPlanToSQLSuite
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76720134
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -642,7 +642,7 @@ class LogicalPlanToSQLSuite extends
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76716719
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -159,23 +159,30 @@ object ExtractEquiJoinKeys
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76716740
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1534,6 +1542,34 @@ object
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76716676
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1534,6 +1542,34 @@ object
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76716689
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1534,6 +1542,34 @@ object
Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76683461
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1534,6 +1542,34 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76670132
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1534,6 +1542,34 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76665743
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -159,23 +159,30 @@ object ExtractEquiJoinKeys extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76665431
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1534,6 +1542,34 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76665332
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1534,6 +1542,34 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14866#discussion_r76665008
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1534,6 +1542,34 @@ object
GitHub user srinathshankar opened a pull request:
https://github.com/apache/spark/pull/14866
[SPARK-17298][SQL] Require explicit CROSS join for cartesian products
## What changes were proposed in this pull request?
Require the use of CROSS join syntax in SQL (and a new
43 matches
Mail list logo
