Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19657
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user felixcheung reopened a pull request:
https://github.com/apache/spark/pull/19657
[SPARK-22344][SPARKR] clean up install dir if running test as source package
## What changes were proposed in this pull request?
remove spark if spark downloaded & installed
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/19657
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.or
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/19657
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.or
GitHub user felixcheung reopened a pull request:
https://github.com/apache/spark/pull/19657
[SPARK-22344][SPARKR] clean up install dir if running test as source package
## What changes were proposed in this pull request?
remove spark if spark downloaded & installed
GitHub user felixcheung reopened a pull request:
https://github.com/apache/spark/pull/19657
[SPARK-22344][SPARKR] clean up install dir if running test as source package
## What changes were proposed in this pull request?
remove spark if spark downloaded & installed
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/19657
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.or
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r149448556
--- Diff: R/pkg/tests/fulltests/test_utils.R ---
@@ -236,4 +236,23 @@ test_that("basenameSansExtFromUrl", {
expect_equal(basenameSansExtFromUrl(z)
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r149436164
--- Diff: R/pkg/tests/fulltests/test_utils.R ---
@@ -236,4 +236,23 @@ test_that("basenameSansExtFromUrl", {
expect_equal(basenameSansExtFromUrl(z), "
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r149331874
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -1183,3 +1183,24 @@ env | map
```{r, echo=FALSE}
sparkR.session.stop()
```
+
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r149174223
--- Diff: R/pkg/R/install.R ---
@@ -152,6 +152,9 @@ install.spark <- function(hadoopVersion = "2.7",
mirrorUrl = NULL,
})
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r149140297
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -1183,3 +1183,24 @@ env | map
```{r, echo=FALSE}
sparkR.session.stop()
```
+
+`
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r149017035
--- Diff: R/pkg/R/install.R ---
@@ -152,6 +152,9 @@ install.spark <- function(hadoopVersion = "2.7",
mirrorUrl = NULL,
})
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r149015420
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -1183,3 +1183,24 @@ env | map
```{r, echo=FALSE}
sparkR.session.stop()
```
+
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r149014391
--- Diff: R/pkg/tests/run-all.R ---
@@ -60,3 +60,22 @@ if (identical(Sys.getenv("NOT_CRAN"), "true")) {
NULL,
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r148979368
--- Diff: R/pkg/R/install.R ---
@@ -152,6 +152,9 @@ install.spark <- function(hadoopVersion = "2.7",
mirrorUrl = NULL,
})
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r148979827
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -1183,3 +1183,24 @@ env | map
```{r, echo=FALSE}
sparkR.session.stop()
```
+
+`
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r148979924
--- Diff: R/pkg/tests/run-all.R ---
@@ -60,3 +60,22 @@ if (identical(Sys.getenv("NOT_CRAN"), "true")) {
NULL,
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/19657
[SPARK-22344][SPARKR] clean up install dir if running test as source package
## What changes were proposed in this pull request?
remove spark if spark downloaded & installed
##
19 matches
Mail list logo
