GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/19937
[SPARK-22746][SQL] Avoid the generation of useless mutable states by
SortMergeJoin
## What changes were proposed in this pull request?
This PR reduce the number of global mutable variables i
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155925941
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155926316
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155926812
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155926973
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155927018
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155927167
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155934663
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155942157
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155944205
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155944247
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155949301
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155984096
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155984232
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155984429
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155984439
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r15631
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r156000717
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r156004320
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r156005086
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r156005276
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r156007853
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r156010028
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -513,26 +513,28 @@ case class SortMergeJoinExec(
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19937
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
24 matches
Mail list logo