Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r161834649
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20223
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r161651289
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r161564385
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -48,14 +48,16 @@ public synchronized void disconnect() {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r161022921
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -137,7 +139,9 @@ public void testInProcessLauncher() throws Exception {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r161022671
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java ---
@@ -95,15 +95,15 @@ protected synchronized void send(Message msg) thro
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r161022567
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -91,10 +92,15 @@ LauncherConnection getConnection() {
retur
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r161006918
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -137,7 +139,9 @@ public void testInProcessLauncher() throws Exce
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r160989105
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -91,10 +92,15 @@ LauncherConnection getConnection() {
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r160991236
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -71,15 +71,16 @@ public void stop() {
@Override
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r160989352
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -91,10 +92,15 @@ LauncherConnection getConnection() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r160957301
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -137,7 +139,9 @@ public void testInProcessLauncher() throws Exceptio
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r160956968
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java ---
@@ -95,15 +95,15 @@ protected synchronized void send(Message msg) t
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r160952457
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -91,10 +92,15 @@ LauncherConnection getConnection() {
re
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/20223
[SPARK-23020][core] Fix races in launcher code, test.
The race in the code is because the handle might update
its state to the wrong state if the connection handling
thread is still processin
15 matches
Mail list logo