Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518860
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -140,6 +141,17 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518531
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -113,34 +115,37 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518479
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -113,34 +115,37 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518507
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -113,34 +115,37 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518538
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -150,14 +155,14 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518823
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -357,4 +357,17 @@ private[ml] trait HasWeightCol extends Params
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40519224
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -199,8 +238,8 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40519125
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -169,6 +181,33 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40519092
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -169,6 +181,33 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518407
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -92,13 +93,14 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518673
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -302,29 +314,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518653
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -206,30 +213,32 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518663
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -255,29 +264,32 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518641
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -206,30 +213,32 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518652
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -206,30 +213,32 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518708
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -396,29 +413,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518699
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -350,28 +364,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518703
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -350,28 +364,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518680
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -334,13 +348,13 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518599
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -190,13 +198,12 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937155
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -493,26 +515,28 @@ private class LeastSquaresAggregator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937140
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -520,28 +544,28 @@ private class LeastSquaresAggregator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937145
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -520,28 +544,28 @@ private class LeastSquaresAggregator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937180
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -31,21 +31,30 @@ import org.apache.spark.ml.util.Identifiable
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937365
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -510,4 +513,90 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937357
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -510,4 +513,90 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937361
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -510,4 +513,90 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937291
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -598,17 +629,14 @@ private class LeastSquaresCostFun
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937401
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -510,4 +513,90 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39937392
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -510,4 +513,90 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8631#issuecomment-141851806
Can you merge the master to resolve the conflicts? Also, add warning in
training summary that it ignores the training weights currently (except for the
objective trace
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39947613
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -520,29 +544,32 @@ private class LeastSquaresAggregator
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-143085746
Vote for adding a new param called "solver". In the unit test, we have to
test two code paths as well; otherwise, the previous LBFGS behavior will not be
te
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39995497
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -520,30 +544,33 @@ private class LeastSquaresAggregator
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8631#issuecomment-142080769
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/8853
[SPARK-10738][ML] Refactoring `Instance` out from LOR and LIR, and also
cleaning up some code
Refactoring `Instance` case class out from LOR and LIR, and also cleaning
up some code.
You can merge
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8510#issuecomment-135871835
Also disable standerizarion feature :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8510#issuecomment-135875437
You can create the jira yourself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8510#issuecomment-135870428
LGTM. By the way, we add intercept option in LiR recently, can you add it
to the example code? Thanks.
---
If your project is set up for it, you can reply to this email
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8510#issuecomment-135876384
Thanks. Merged into branch 1.5, and master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9037#discussion_r47317124
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -434,6 +435,22 @@ class LogisticRegressionModel private[ml
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9037#issuecomment-163821070
LGTM except the minor style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9207#discussion_r47320088
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/pmml/PMMLExportable.scala ---
@@ -0,0 +1,90 @@
+/*
--- End diff --
Seems this is a copy
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9037#issuecomment-163865696
Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r48805006
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -86,6 +86,22 @@ private[ml] class WeightedLeastSquares
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r48806696
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -86,6 +86,22 @@ private[ml] class WeightedLeastSquares
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r48807534
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -94,8 +110,7 @@ private[ml] class WeightedLeastSquares
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/10274#issuecomment-168864994
jenkins, add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r48805155
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -86,6 +86,22 @@ private[ml] class WeightedLeastSquares
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168523352
LGTM except minor issues pointed out by @srowen Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48239336
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48239041
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48239605
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48239945
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/RegressionMetricsSuite.scala
---
@@ -22,91 +22,115 @@ import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48390400
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -53,6 +58,7 @@ class RegressionMetrics @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48390399
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -61,7 +67,6 @@ class RegressionMetrics @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48390247
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-167017269
LGTM except minor issues. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45806031
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Split.scala ---
@@ -85,7 +85,7 @@ final class CategoricalSplit private[ml
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9397#issuecomment-159416401
Can you rebase the master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r46011586
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -211,14 +213,16 @@ private object IDFModel {
val n = v.size
v
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r46010330
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -218,7 +218,7 @@ private object IDFModel {
newValues(k) = values
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r46017051
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -211,14 +213,17 @@ private object IDFModel {
val n = v.size
v
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9843#issuecomment-160255311
With `minDocFreq`, the idf vector will result lots of zeros, which means
looping through each of elements in idf vector is not efficient. Also, with
lots of zeros in idf
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9457#issuecomment-159374620
@moustaki yes, we need to hold off now until 1.7 window.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9843#issuecomment-160551599
Your PR will impact the performance when idf vector is dense, but the input
vector is sparse which is my concern. Of course, we would like to have patch as
simple
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r45953181
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -218,7 +218,7 @@ private object IDFModel {
newValues(k) = values
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r46022674
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -211,14 +213,17 @@ private object IDFModel {
val n = v.size
v
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45668718
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/codeGenerator.scala
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9397#issuecomment-159077964
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45669138
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/codeGenerator.scala
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45669679
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Split.scala ---
@@ -85,7 +85,7 @@ final class CategoricalSplit private[ml
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45668289
--- Diff: mllib/pom.xml ---
@@ -125,6 +125,10 @@
org.apache.spark
spark-test-tags_${scala.binary.version
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45669204
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/codeGenerator.scala
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9457#issuecomment-159195862
@moustaki This PR looks good to me. I'll start to work on refactoring the
mllib vector out after 1.6 release, so graphx can use those data structure.
Then we can change
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6386#issuecomment-159076845
@mengxr what do you think? Should we fix the intercept issue in old mllib
version of LoR or just deprecate it and educate users to use to new ml version?
---
If your
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r49394419
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -94,8 +110,7 @@ private[ml] class WeightedLeastSquares
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10702#discussion_r49399116
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -219,33 +219,41 @@ class LinearRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r49400106
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala
---
@@ -74,6 +89,35 @@ class WeightedLeastSquaresSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r49652270
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -883,6 +884,22 @@ class LogisticRegressionSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r49649843
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -339,9 +339,11 @@ class LogisticRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10743#discussion_r49650452
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -883,6 +884,22 @@ class LogisticRegressionSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r49667844
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -94,8 +110,7 @@ private[ml] class WeightedLeastSquares
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10274#discussion_r49654189
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -94,8 +110,7 @@ private[ml] class WeightedLeastSquares
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962408
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -374,4 +383,82 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962416
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -374,4 +383,82 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49963912
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -322,10 +329,11 @@ class LogisticRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962448
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -374,4 +383,82 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962512
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -374,4 +383,82 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962541
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -374,4 +383,82 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49961903
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -247,10 +247,31 @@ class LogisticRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49961912
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -247,10 +247,31 @@ class LogisticRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49963463
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -247,8 +247,15 @@ class LogisticRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49963455
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -247,8 +247,15 @@ class LogisticRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49961714
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -247,10 +247,30 @@ class LogisticRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962964
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -374,4 +383,82 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962944
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -322,10 +343,12 @@ class LogisticRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49963357
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -374,4 +383,82 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962157
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -322,10 +343,12 @@ class LogisticRegression @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962716
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -374,4 +383,82 @@ class LogisticRegressionWithLBFGS
701 - 800 of 1777 matches
Mail list logo
