Probably a role thing.
Crap. Ok, I'll do the merge, but I really need to figure out what the heck
is happening.
I do not have permissions to check in. No button to merge and my icon shows
"Cannot merge". I am logged in.
> Mon Jul 31 2023 06:25:58 PM EDT from IGnatius T Foobar Subject: Re: Merge
>Request Approval: IMAP memory issues with use of ConstStr
>
>Sorry about that, it just got away from
Sorry about that, it just got away from me. I approved it. Looks good.
This is still waiting for approval. Do you want me to bring the branch up
to the head or anything else?
I agree. The developer who introduced StrBuf and ConstBuf was helpful in
giving us an elastic string class, but I wish he hadn't gone back through
old code and converted stuff without a really deep inspection of how it was
used.
While looking at the use of ConstStr, it was interesting how it was being
used. "Const" is definably not the description to use. It really is just
a StrBuf where the pointer does not need to be freed. All sorts of code
change the pointer string and really did not check what it is doing.
>Not sure why the parameter was empty, but a lot of code accessed ConstStr
>pointers without checking for zero length and pointer was null and could
>coredump, so went through and added checks.
*sigh*
The IMAP server was written completely with straight C pointers and string
>I just realized that a Seen message set of *:2099348686 means all messages
>have been seen. Were all your messages unseen before the upgrade? I
do
A seen message set of *:2099348686 means all messages have been seen up to
and including 2099348686.
We are using what RFC 3501
Duh. Button next to Comment button. I closed.
>I was trying to figure out how to reject the request myself. Does not
look
Do you have the button "Close merge request" on the bottom of the screen?
I just realized that a Seen message set of *:2099348686 means all messages
have been seen. Were all your messages unseen before the upgrade? I do
ignore Visit records when upgrading that look bad. If they got skipped, the
message set would be blank and all messages would show as unseen after
I was trying to figure out how to reject the request myself. Does not look
like you can. I Googled and others were talking about how GitLab was
lacking that option. If you can figure out how to reject or delete it, I
will not be offended unless you don't tell me how :-) Otherwise I will just
Ok then, I think the proper workflow is to cancel the merge request and start
a new one? I could reject it but that seems rude :)
It isn't just "a seen message set" -- it was ALL of them, across all rooms,
at least for me. But if you want an example, my current seen-set for this
room
Thanks for the feedback. My testing only had a small database, so 10 min is
rather bad. I think switching to doing the conversion when accessed is the
best idea. It is simple since that is how I did it before I switched to the
upgrade. I only have to add some code to one function. I am going
Ok, I tried out the proposed merge. Here are the results.
1. I made a copy of the Uncensored database and ran it on the main line code
to verify that the copy is functioning identically to the production database.
2. I switched over to the merged branch and built everything from
No rush on the review. I had to put the code aside for a while (pesky day
job :-) and had to write some tests to try to hit most code paths.
I tried not to change too much existing code since the change is pretty big
to begin with. I only tried to rewrite things that affected performance or
I'm away on vacation right now and casually browsing the changes. I'll give
it a good thorough testing when I'm back at my desk after the weekend, but
so far I'm quite impressed. It looks like the changes really follow not just
the coding style, but the *design* style of the existing Citadel
>Not sure if regression, but if you try to sent a message with a blank body,
>webcit coredumps. Just checked for empty message text and skipped trying
to
>output.
I wasn't able to reproduce the problem but the patch looks like it will add
some safety so I pulled it in anyway.
I see the merge request and will check it out. Thanks!
meld is probably a good tool to use.
usually you start by git pull master and resolve the conflicts.
I wonder what these conflicts may be? I didn't do anything about the configs yet...
(I wanted to change them so they are transmitted inline in the migrate process instead of r'synced - because of that may fail badly...)
22 matches
Mail list logo
