Re: [sage-combinat-devel] Re: # 10744

2011-02-11 Thread Daniel Bump
Nicolas wrote: > > Where do people think the main code for plotting should go? In > > WeightRingElement, WeylCharacterRing, or in weyl_character.py but > > outside of any class (and have plot methods in both classes that call > > this function?) > > In RootLatticeRealization. I see the plotting

Re: [sage-combinat-devel] Re: tickets 10632 and 10485

2011-02-11 Thread Nicolas M. Thiery
On Fri, Feb 11, 2011 at 12:32:24PM -0800, Anne Schilling wrote: > Nicolas, is your patch ready for review? I saw on trac that there are > a couple of timeouts. Yup. Robert told me he would review it next week. The timeouts are unrelated; I get the same ones without the patch. Cheers,

Re: [sage-combinat-devel] Re: # 10744

2011-02-11 Thread Nicolas M. Thiery
On Fri, Feb 11, 2011 at 12:28:12PM -0800, Benjamin Jones wrote: > Where do people think the main code for plotting should go? In > WeightRingElement, WeylCharacterRing, or in weyl_character.py but > outside of any class (and have plot methods in both classes that call > this function?) In RootLatt

Re: [sage-combinat-devel] Re: tickets 10632 and 10485

2011-02-11 Thread Anne Schilling
Dear Dan, After the two patches (fresh downloads from trac, to be sure that I have the latest) #10723 and #10632, there are no problems in sage_object.pyx, which is where we would see pickle problems. There are also no failures in any of the crystal files. (I ran sage -t -long *.) I think that

[sage-combinat-devel] Re: # 10744

2011-02-11 Thread Benjamin Jones
On Feb 10, 1:34 pm, Daniel Bump wrote: > Here are some comments on #10744. > > Very nice! > > I do have some comments. Thanks, and I appreciate the feedback! > > sage: A2=WeylCharacterRing("A2",style="coroots") > sage: a2=WeightRing(A2) > sage: rp=a2(A2(2,1)) > sage: rp.plot() > > Frequently o

Re: [sage-combinat-devel] Re: tickets 10632 and 10485

2011-02-11 Thread Daniel Bump
> Dear Dan and Nicolas! > > As I said, I posted a revised patch on trac which includes Nicolas' review > patch. > > I reinstalled the old crystal pickles and ran > > lolita-3:pickle_jar anne$ sage -t -force_lib > "devel/sage/sage/structure/sage_object.pyx" > sage -t -force_lib "devel/sage/sa

Re: [sage-combinat-devel] Re: tickets 10632 and 10485

2011-02-11 Thread Anne Schilling
Dear Dan and Nicolas! As I said, I posted a revised patch on trac which includes Nicolas' review patch. I reinstalled the old crystal pickles and ran lolita-3:pickle_jar anne$ sage -t -force_lib "devel/sage/sage/structure/sage_object.pyx" sage -t -force_lib "devel/sage/sage/structure/sage_ob

Re: [sage-combinat-devel] Re: tickets 10632 and 10485

2011-02-11 Thread Anne Schilling
On 2/10/11 9:27 AM, Nicolas M. Thiery wrote: On Wed, Feb 09, 2011 at 02:59:56PM -0800, Anne Schilling wrote: That being said, this could advocate for keeping CrystalOfTableaux as a class (using the classcall trick as we had discussed) in order to maintain backward compatibility on pickles (besid

Re: [sage-combinat-devel] Re: Pickle jar

2011-02-11 Thread Nicolas M. Thiery
Hi! Thanks Sébastien for pointing out the other upcoming changes to the pickle jar. On Fri, Feb 11, 2011 at 01:06:06AM -0800, Anne Schilling wrote: > Ticket #10632 > http://trac.sagemath.org/sage_trac/ticket/10632 > also changes the pickle jar. I followed the very clear instructions that

Re: [sage-combinat-devel] # 10744

2011-02-11 Thread Nicolas M. Thiery
On Thu, Feb 10, 2011 at 11:34:34AM -0800, Daniel Bump wrote: > Here are some comments on #10744. > > Very nice! Indeed! Just one thing: there is already some plotting support in the root/weight lattice which is very similar in purpose. Please make sure to factor out as much as possible between t

Re: [sage-combinat-devel] Re: Pickle jar

2011-02-11 Thread Anne Schilling
Salut Sebastien, Ticket #10632 http://trac.sagemath.org/sage_trac/ticket/10632 also changes the pickle jar. I followed the very clear instructions that Dan Bump recently sent out. As far as I understand #7922 also changes the pickle jar. Since, as far as I understand, we currently replace the wh