Re: [sage-combinat-devel] #7922

2011-04-07 Thread Nicolas M. Thiery
On Wed, Apr 06, 2011 at 04:46:05PM -0700, Daniel Bump wrote: > I saw your reviewer patch for #7922 (thanks). > > There were a couple of further minor revisions > which are in the patch > > trac_7922_alpha3-changes.patch > > that I put in the combinat queue. The patch: > > trac_7922-rebased-4.7.

[sage-combinat-devel] #7922

2011-04-06 Thread Daniel Bump
Hi Nicolas, I saw your reviewer patch for #7922 (thanks). There were a couple of further minor revisions which are in the patch trac_7922_alpha3-changes.patch that I put in the combinat queue. The patch: trac_7922-rebased-4.7.alpha3.patch that is now on the trac server is the sum of the thre

Re: [sage-combinat-devel] #7922 reviewer's patch

2011-03-22 Thread Nicolas M. Thiery
On Mon, Mar 21, 2011 at 07:58:59PM -0700, Daniel Bump wrote: > > I just pushed my changes on the Sage-Combinat queue. The code uses > > standard coercion now. > > Thanks! At the moment, I can say that after your patch, > the code seems to be about the same speed as before, > which is good. In th

Re: [sage-combinat-devel] #7922 reviewer's patch

2011-03-21 Thread Daniel Bump
> I just pushed my changes on the Sage-Combinat queue. The code uses > standard coercion now. Thanks! At the moment, I can say that after your patch, the code seems to be about the same speed as before, which is good. > I won't touch the thing tomorrow, so feel free to fold all the 7922 > patche

Re: [sage-combinat-devel] #7922 reviewer's patch

2011-03-21 Thread Nicolas M. Thiery
On Tue, Mar 22, 2011 at 01:21:36AM +0100, Nicolas M. Thiery wrote: > I just pushed my changes on the Sage-Combinat queue. The code uses > standard coercion now. In the process, I have factored out a couple > functions to the ambient space (from_vector_notation, the coerce_E6 > and friends). It's no

Re: [sage-combinat-devel] #7922 reviewer's patch

2011-03-21 Thread Nicolas M. Thiery
On Mon, Mar 21, 2011 at 10:35:55PM +0100, Nicolas M. Thiery wrote: > On Sat, Mar 19, 2011 at 07:37:25AM -0700, Daniel Bump wrote: > > Well, what you are suggesting is a little tricky. Two > > rings will be created at the same time, and the > > multiplication will be implemented by coercing from > >

Re: [sage-combinat-devel] #7922 reviewer's patch

2011-03-21 Thread Nicolas M. Thiery
On Sat, Mar 19, 2011 at 07:37:25AM -0700, Daniel Bump wrote: > Well, what you are suggesting is a little tricky. Two > rings will be created at the same time, and the > multiplication will be implemented by coercing from > the WeylCharacterRing to the WeightRing, multiplying, > and coercing back.

Re: [sage-combinat-devel] #7922 reviewer's patch

2011-03-19 Thread Daniel Bump
> Can you elaborate? Is there a compelling technical reason? Well, what you are suggesting is a little tricky. Two rings will be created at the same time, and the multiplication will be implemented by coercing from the WeylCharacterRing to the WeightRing, multiplying, and coercing back. And I see

Re: [sage-combinat-devel] #7922 reviewer's patch

2011-03-19 Thread Nicolas M. Thiery
Hi Dan, Sorry for letting this slip down my mailbox ... Florent: please see the intersphinx question below. On Mon, Mar 07, 2011 at 06:48:56AM -0800, Daniel Bump wrote: > As I noted earlier, the timing issue is apparently fixed by > making _weight_multiplicities a cached method, and the

[sage-combinat-devel] #7922 reviewer's patch

2011-03-07 Thread Daniel Bump
Here is the status of #7922. As I noted earlier, the timing issue is apparently fixed by making _weight_multiplicities a cached method, and the caching can be removed from product_on_basis. Nicolas has a patch called trac_7922-review-nt.patch. Some of his comments can be implemented, others not

Re: [sage-combinat-devel] #7922 timing issues

2011-02-26 Thread Nicolas M. Thiery
On Fri, Feb 25, 2011 at 06:12:15PM +0100, Nicolas M. Thiery wrote: > - What would be an efficient implementation of hashing for free >module elements? The one you implemented in AmbientSpace can >be 10 times faster than the default one provided by SageObject and >using repr. So it wo

Re: [sage-combinat-devel] #7922 timing issues

2011-02-26 Thread Nicolas M. Thiery
Hi Dan, I have just been through your #7922 patches, and put a reviewers patch in the Sage-Combinat queue: trac_7922-review-nt.patch Altogether it looks good. I did a few changes, and also added a series of comments and suggestions. Please check them out, and decide which ones yo

Re: [sage-combinat-devel] #7922 timing issues

2011-02-25 Thread Daniel Bump
> - Is it reasonnable that hash is called 4 000 000 times in your >example? Are there huge elements being manipulated? No, I don't think that is reasonable. So there must be something fishy going on. The character of A7 (SL(8)) in question has 792 weights with nonzero coefficient. This is n

Re: [sage-combinat-devel] #7922 timing issues

2011-02-25 Thread Nicolas M. Thiery
Hi Dan! On Thu, Feb 10, 2011 at 09:35:08AM -0800, Daniel Bump wrote: > I am returning to the question of timing issues with #7922. > > I recall that for a variety of branching rules, I ran tests > with and without the test, and obtained the following > results: > > Old Code

[sage-combinat-devel] #7922 timing issues

2011-02-10 Thread Daniel Bump
I am returning to the question of timing issues with #7922. I recall that for a variety of branching rules, I ran tests with and without the test, and obtained the following results: Old Code48 seconds New Code25 seconds Old Code, cache=true18 seconds This is