Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Matthias Koeppe
PR using this approach at https://github.com/sagemath/sage/pull/36731 On Thursday, November 16, 2023 at 8:35:53 PM UTC-8 Matthias Koeppe wrote: > Or we just let pillow use a system libjpeg if it finds one. > > On Thursday, November 16, 2023 at 2:38:07 PM UTC-8 Dima Pasechnik wrote: > >> >> >> On

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Matthias Koeppe
If we decide to make libjpeg a normal standard package, then I'd be +1 on using libjpeg-turbo. Debian also switched to it many years ago, and it only has to apply a small amount of patches (https://sources.debian.org/src/libjpeg-turbo/1%253A2.1.5-2/), which we could easily adopt. On Friday, No

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Michael Orlitzky
On Fri, 2023-11-17 at 10:49 -0800, Marc Culler wrote: > I expect to receive lots of flak for saying this, but I support making > libjpeg be a standard spkg using the source code from > https://libjpeg.sourceforge.net. I just built version jpeg-9e on Ubuntu > 18.04 and macOS 10.13. The standard

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Michael Orlitzky
On Fri, 2023-11-17 at 17:26 +, Dima Pasechnik wrote: > > Why can't Features be set up by ./configure ? You'll tell me that > (some) distributions don't run ./configure, but this is beside the > point. > They have ways to know what's installed and what's not installed. > I think the problem i

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Marc Culler
I should also have mentioned that macOS is an example of a system which does not come with libjpeg. On Fri, Nov 17, 2023 at 12:53 PM Marc Culler wrote: > No, I meant both "normal" and "standard". I am sure I will master this > terminology sooner or later. > > On Friday, November 17, 2023 at 12:

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Marc Culler
No, I meant both "normal" and "standard". I am sure I will master this terminology sooner or later. On Friday, November 17, 2023 at 12:51:48 PM UTC-6 Marc Culler wrote: > I meant "normal" when I said "standard". > > On Friday, November 17, 2023 at 12:49:18 PM UTC-6 Marc Culler wrote: > >> I exp

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Marc Culler
I meant "normal" when I said "standard". On Friday, November 17, 2023 at 12:49:18 PM UTC-6 Marc Culler wrote: > I expect to receive lots of flak for saying this, but I support making > libjpeg be a standard spkg using the source code from > https://libjpeg.sourceforge.net. I just built version

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Marc Culler
I expect to receive lots of flak for saying this, but I support making libjpeg be a standard spkg using the source code from https://libjpeg.sourceforge.net. I just built version jpeg-9e on Ubuntu 18.04 and macOS 10.13. The standard ./configure ; make install method works flawlessly - not eve

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Matthias Koeppe
On Friday, November 17, 2023 at 10:11:43 AM UTC-8 Dima Pasechnik wrote: We have at least one open issue/PR, adding spkg-configure.m4 for FriCAS, stuck due to the fact it's an insanely complicated job to provide Feature for it, and totally meaningless, if you ask me. I'll interpret this declar

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Dima Pasechnik
On Fri, Nov 17, 2023 at 5:57 PM Matthias Koeppe wrote: > > On Friday, November 17, 2023 at 9:27:03 AM UTC-8 Dima Pasechnik wrote: > > why do we even need runtime Feature tests? This is a leftover from the > times one could install Sage packages in a Sage session > > > No, it's not. It's a much new

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Matthias Koeppe
On Friday, November 17, 2023 at 9:27:03 AM UTC-8 Dima Pasechnik wrote: why do we even need runtime Feature tests? This is a leftover from the times one could install Sage packages in a Sage session No, it's not. It's a much newer facility. -- You received this message because you are subscrib

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Dima Pasechnik
On Fri, Nov 17, 2023 at 5:15 PM Matthias Koeppe wrote: > > On Friday, November 17, 2023 at 1:14:54 AM UTC-8 Dima Pasechnik wrote: > > > On 17 November 2023 04:35:53 GMT, Matthias Koeppe > wrote: > >Or we just let pillow use a system libjpeg if it finds one. > > With a dummy package we can have d

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Matthias Koeppe
On Friday, November 17, 2023 at 2:33:06 AM UTC-8 Eric Gourgoulhon wrote: What is exactly a "dummy package"? Is it something that requires a system package ? Is it complicated to set up and maintain? It's a package for which the Sage distribution does not provide a method of installing it, bu

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Matthias Koeppe
On Friday, November 17, 2023 at 1:14:54 AM UTC-8 Dima Pasechnik wrote: On 17 November 2023 04:35:53 GMT, Matthias Koeppe wrote: >Or we just let pillow use a system libjpeg if it finds one. With a dummy package we can have doctests, with #optional tag, checking that this all works. No, tha

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Michael Orlitzky
On Fri, 2023-11-17 at 02:33 -0800, Eric Gourgoulhon wrote: > On 17 November 2023 04:35:53 GMT, Matthias Koeppe > wrote: > > Or we just let pillow use a system libjpeg if it finds one. > > This would probably be the easiest solution: I cannot imagine a system > without libjpeg... I don't know

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Eric Gourgoulhon
Le vendredi 17 novembre 2023 à 10:14:54 UTC+1, Dima Pasechnik a écrit : On 17 November 2023 04:35:53 GMT, Matthias Koeppe wrote: >Or we just let pillow use a system libjpeg if it finds one. This would probably be the easiest solution: I cannot imagine a system without libjpeg... With

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-17 Thread Dima Pasechnik
On 17 November 2023 04:35:53 GMT, Matthias Koeppe wrote: >Or we just let pillow use a system libjpeg if it finds one. With a dummy package we can have doctests, with #optional tag, checking that this all works. > >On Thursday, November 16, 2023 at 2:38:07 PM UTC-8 Dima Pasechnik wrote: > >>

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-16 Thread Matthias Koeppe
Or we just let pillow use a system libjpeg if it finds one. On Thursday, November 16, 2023 at 2:38:07 PM UTC-8 Dima Pasechnik wrote: > > > On 16 November 2023 19:33:45 GMT, Michael Orlitzky > wrote: > >On Thu, 2023-11-16 at 06:48 -0800, Eric Gourgoulhon wrote: > >> > >> If we agree to restore

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-16 Thread Dima Pasechnik
On 16 November 2023 19:33:45 GMT, Michael Orlitzky wrote: >On Thu, 2023-11-16 at 06:48 -0800, Eric Gourgoulhon wrote: >> >> If we agree to restore jpeg support in Pillow, I have prepared a branch >> that does this for Sage 10.2 (simply suppressing the option "jpeg=disable"): >> https://github

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-16 Thread Michael Orlitzky
On Thu, 2023-11-16 at 06:48 -0800, Eric Gourgoulhon wrote: > > If we agree to restore jpeg support in Pillow, I have prepared a branch > that does this for Sage 10.2 (simply suppressing the option "jpeg=disable"): > https://github.com/egourgoulhon/sage/tree/pillow_jpeg > and I am happy to submit

Re: [sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-16 Thread David Roe
I'm not aware of why we were suppressing jpeg support before, but this sounds like a good idea to me. David On Thu, Nov 16, 2023 at 9:48 AM Eric Gourgoulhon wrote: > Hi All, > > Pillow provides the Python Imaging Library (PIL) > https://pillow.readthedocs.io/en/stable/ > and is a standard packag

[sage-devel] Pillow built without jpeg support in Sage 10.2.rc3

2023-11-16 Thread Eric Gourgoulhon
Hi All, Pillow provides the Python Imaging Library (PIL) https://pillow.readthedocs.io/en/stable/ and is a standard package in Sage. Now, in Sage 10.2.rc3, the following code g = plot(sin(x)) # to generate a png figure g.save("fig.png") # from PIL import Image img = Image.open("fig.png") i