[sage-devel] Re: sage-env - PLEASE review.

2010-01-07 Thread Jaap Spies
Dr. David Kirkby wrote: William Stein wrote: On Thu, Jan 7, 2010 at 12:15 AM, Minh Nguyen nguyenmi...@gmail.com wrote: Hi David, On Thu, Jan 7, 2010 at 2:09 PM, Dr. David Kirkby david.kir...@onetel.net wrote: SNIP It needs reviewing, and I'd appreciate if a few people could have a look at

Re: [sage-devel] Re: sage-env - PLEASE review.

2010-01-07 Thread Dr. David Kirkby
Jaap Spies wrote: Dr. David Kirkby wrote: Could #7818 get a positive review, be dropped into alpha2, and let Jaap Spies get on with the port to Open Solaris? I very much doubt most people will notice any difference whatsoever, but it will make the Solaris port a lot easier, and allow for some

[sage-devel] Re: sage-env - PLEASE review.

2010-01-07 Thread Jaap Spies
Dr. David Kirkby wrote: Jaap Spies wrote: Dr. David Kirkby wrote: Could #7818 get a positive review, be dropped into alpha2, and let Jaap Spies get on with the port to Open Solaris? I very much doubt most people will notice any difference whatsoever, but it will make the Solaris port a lot

Re: [sage-devel] Re: sage-env - PLEASE review.

2010-01-07 Thread Dr. David Kirkby
Jaap Spies wrote: Dr. David Kirkby wrote: Jaap Spies wrote: Dr. David Kirkby wrote: Could #7818 get a positive review, be dropped into alpha2, and let Jaap Spies get on with the port to Open Solaris? I very much doubt most people will notice any difference whatsoever, but it will make the

[sage-devel] Re: sage-env - PLEASE review.

2010-01-07 Thread John H Palmieri
On Jan 7, 8:37 am, Dr. David Kirkby david.kir...@onetel.net wrote: The changes introduced are deliberately very small - which is why I think the file is safe. Unfortunately, given the file sage-env has no echo statements, it's hard to know exactly what sage-env has done, compared to what

Re: [sage-devel] Re: sage-env - PLEASE review.

2010-01-07 Thread Dr. David Kirkby
John H Palmieri wrote: On Jan 7, 8:37 am, Dr. David Kirkby david.kir...@onetel.net wrote: The changes introduced are deliberately very small - which is why I think the file is safe. Unfortunately, given the file sage-env has no echo statements, it's hard to know exactly what sage-env has done,

[sage-devel] Re: sage-env - PLEASE review.

2010-01-07 Thread Nils Bruin
On Jan 7, 1:26 pm, Dr. David Kirkby david.kir...@onetel.net wrote: In the new version of sage-env, there are two if statements involving $SAGE_PRINT_ENVIRONMENT.  It makes a lot of sense not to print these by default (for example, when starting Sage), but maybe the second group of