Re: [sage-devel] Should fast test suites be run from spkg-install?

2010-08-24 Thread David Kirkby
On 24 August 2010 23:48, Robert Bradshaw wrote: >> You could make it more complex if you wanted, but then you would need >> to consider exceptions like ATLAS, for the reasons I stated. > > I wasn't proposing a rule, just a rule of thumb. And I did mean OR. If > a package took 5 seconds to build,

Re: [sage-devel] Should fast test suites be run from spkg-install?

2010-08-24 Thread Robert Bradshaw
On Tue, Aug 24, 2010 at 7:47 AM, David Kirkby wrote: > On 24 August 2010 15:39, David Kirkby wrote: > >> Robert, >> >> Are you suggesting (1) or (2) below? >> >> 1) Run if tests take < 30 seconds AND <25% of the build time. >> >> 2) If tests take <30 seconds OR < 25% of the build time. >> >> I ca

Re: [sage-devel] Should fast test suites be run from spkg-install?

2010-08-24 Thread David Kirkby
On 24 August 2010 15:39, David Kirkby wrote: > Robert, > > Are you suggesting (1) or (2) below? > > 1) Run if tests take < 30 seconds AND <25% of the build time. > > 2) If tests take <30 seconds OR < 25% of the build time. > > I can see a problem with the latter. I mean I can see a problem with

Re: [sage-devel] Should fast test suites be run from spkg-install?

2010-08-24 Thread David Kirkby
On 23 August 2010 17:26, Robert Bradshaw wrote: > +1 to running all short test suites on build if they're small enough > (e.g. less than 30 seconds, or, say, 25% of the build time). That is > assuming they're expected to pass, unlike some (scipy?). > > - Robert Robert, Are you suggesting (1) or

Re: [sage-devel] Should fast test suites be run from spkg-install?

2010-08-23 Thread Robert Bradshaw
On Sat, Aug 21, 2010 at 7:47 AM, Dr. David Kirkby wrote: > Setting SAGE_CHECK=yes forces the test suites of some packages to run. > Clearly that slows the build time - in some cases very significantly. I > think with Pari, it takes about 10x as long to run the test suite as it does > to just build

[sage-devel] Should fast test suites be run from spkg-install?

2010-08-21 Thread Dr. David Kirkby
Setting SAGE_CHECK=yes forces the test suites of some packages to run. Clearly that slows the build time - in some cases very significantly. I think with Pari, it takes about 10x as long to run the test suite as it does to just build the code. But for some programs, the time need to run the tes