On Mon, Apr 06, 2020 at 05:26:35PM -0700, Fangrui Song wrote:
> On 2020-04-06, Kevin O'Connor wrote:
> > On Wed, Apr 01, 2020 at 10:29:12AM -0700, Fangrui Song wrote:
> > > (1) In romlayout.S, .fixedaddr.\addr sections do have not the SHF_ALLOC
> > > flag.
On Wed, Apr 01, 2020 at 10:29:15AM -0700, Fangrui Song wrote:
> The previous commit changed romlayout32flag.lds to use `. += ` instead
> of `. =`.
> We no longer need the LD capability test checking
> https://sourceware.org/bugzilla/show_bug.cgi?id=12726
Thanks. It would be great to remove this t
On Wed, Apr 01, 2020 at 10:29:14AM -0700, Fangrui Song wrote:
> This improves the portability of the linker script and allows lld to link
> rom.o
>
> Dot assignment inside an output section has an inconsistent behavior
> which makes lld difficult to implement.
> See https://bugs.llvm.org/show_bug
On Wed, Apr 01, 2020 at 10:29:13AM -0700, Fangrui Song wrote:
> Accepting ET_EXEC as an input file is an extremely rare GNU ld feature
> that lld does not intend to support, because this is error-prone.
>
> See Linux kernel commit 90ceddcb495008ac8ba7a3dce297841efcd7d584 for
> another use of the d
On Wed, Apr 01, 2020 at 10:29:12AM -0700, Fangrui Song wrote:
> (1) In romlayout.S, .fixedaddr.\addr sections do have not the SHF_ALLOC flag.
> It does not make sense to reference a SHF_ALLOC section from a non-SHF_ALLOC
> section via R_386_PC16.
> GNU ld allows it but lld will warn. Add the SHF_A
On Wed, Apr 01, 2020 at 06:12:09PM -0700, Fangrui Song wrote:
> objdump -h relies heavily on BFD internals and the BFD flags are difficult to
> emulate in llvm-objdump.
> llvm-objdump -h has a different output (https://reviews.llvm.org/D57146)
>
> Switch to readelf, which is generally better than
On Fri, Apr 03, 2020 at 10:31:19AM +0200, Gerd Hoffmann wrote:
> Create a list of devices found in the DSDT table. Add helper functions
> to find devices, walk the list and figure device informations like mmio
> ranges and irqs.
>
> Signed-off-by: Gerd Hoffmann
> ---
> src/util.h | 10
On Fri, Apr 03, 2020 at 10:31:20AM +0200, Gerd Hoffmann wrote:
> Don't initialize the ps/2 keyboard in case the device is not
> listed in the ACPi DSDT table.
>
> Signed-off-by: Gerd Hoffmann
> ---
> src/hw/ps2port.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/hw/ps2port.c
On Fri, Apr 03, 2020 at 10:31:13AM +0200, Gerd Hoffmann wrote:
> Add a new virtio-mmio.c source file, providing a function
> to register virtio-mmio devices.
>
> Signed-off-by: Gerd Hoffmann
> ---
> Makefile | 2 +-
> src/hw/virtio-mmio.h | 6 ++
> src/hw/virtio-mmio.c | 30 +++
On Tue, Mar 31, 2020 at 04:53:02PM +0200, Gerd Hoffmann wrote:
> On Fri, Mar 27, 2020 at 09:15:19AM -0400, Kevin O'Connor wrote:
> > On Fri, Mar 27, 2020 at 09:12:06AM +0100, Gerd Hoffmann wrote:
> > > > Something like:
> > > >
> > > > s
On Sun, Mar 29, 2020 at 07:21:41PM -0400, Stefan Berger wrote:
> On 3/27/20 11:27 PM, Stefan Berger wrote:
> > Add support for SHA3 type of algorithms that a TPM2 may support
> > some time in the future.
> >
> > Signed-off-by: Stefan Berger
> > ---
> > src/std/tcg.h | 9 +
> > src/tcg
On Fri, Mar 27, 2020 at 09:12:06AM +0100, Gerd Hoffmann wrote:
> > Something like:
> >
> > struct hlist_head DSDTTree;
> >
> > struct dsdt_entry {
> > struct hlist_node node;
> > char *name; // eg, "_SB.PCI0.ISA.COM1._HID"
> > int type; // eg: Device, Name, Integer, String, ResourceT
On Wed, Mar 25, 2020 at 10:35:50AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > If you mean a DSDT parser then I suspect a full implementation in
> > SeaBIOS would be too burdensome. However, it might be possible to
> > introduce a minimal DSDT parser (eg, one that only supports extracting
> > const
On Mon, Mar 23, 2020 at 03:59:09PM +0100, Gerd Hoffmann wrote:
> Gerd Hoffmann (2):
> pci: factor out ioconfig_cmd()
> pci: add mmconfig support
Thanks. Looks good to me.
One question - how would this work with multiple independent PCI
buses? Or is the intent to only enable this on machines
On Fri, Mar 20, 2020 at 04:41:09PM +0100, Paul Menzel wrote:
> Am 06.03.20 um 18:01 schrieb Stefan Berger:
> > On 3/6/20 8:33 AM, Kevin O'Connor wrote:
> > > On Wed, Mar 04, 2020 at 02:51:27PM +0100, Paul Menzel wrote:
> > > > Date: Tue, 3 Mar 2020 16:24:46 +010
On Fri, Mar 20, 2020 at 07:13:02AM +0100, Gerd Hoffmann wrote:
> On Thu, Mar 19, 2020 at 07:48:19PM -0400, Kevin O'Connor wrote:
> > On Thu, Mar 19, 2020 at 08:39:33AM +0100, Gerd Hoffmann wrote:
> > > Use bootorder fw_cfg file to find bootable virtio-mmio devices.
>
On Fri, Mar 20, 2020 at 06:48:53AM +0100, Gerd Hoffmann wrote:
> > > +static void *pci_mmconfig_addr(u16 bdf, u32 addr)
> > > +{
> > > +if (!mmconfig)
> > > +return NULL;
> > > +return (void*)(mmconfig + ((u32)bdf << 12) + addr);
> > > +}
> > > +
> > > void pci_config_writel(u16 bd
On Thu, Mar 19, 2020 at 10:21:55AM +0100, Gerd Hoffmann wrote:
> Add support for pci config space access via mmconfig bar. Enable for
> qemu q35 chipset. Main advantage is that we need only one instead of
> two io operations per config space access, which translates to one
> instead of two vmexit
On Thu, Mar 19, 2020 at 08:39:33AM +0100, Gerd Hoffmann wrote:
> Use bootorder fw_cfg file to find bootable virtio-mmio devices.
> Also add a new virtio-mmio.c source file, providing a function
> to register virtio-mmio devices.
Can you expand on this? I'm not sure I understand what this patch
do
On Fri, Mar 13, 2020 at 10:17:09PM -0700, Fangrui Song wrote:
> This improves the portability of the linker script and allows lld to link
> rom.o
> We can thus delete an ld check detecting "cannot move location counter
> backwards".
>
> Dot assignment inside an output section has a inconsistent
On Tue, Mar 17, 2020 at 08:31:08PM +0100, Paul Menzel wrote:
> Signed-off-by: Paul Menzel
> ---
> docs/Execution_and_code_flow.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/Execution_and_code_flow.md b/docs/Execution_and_code_flow.md
> index 4a7ba8d..267464e 10
On Mon, Mar 16, 2020 at 05:48:55PM +0100, Paul Menzel wrote:
> From: Rob Barnes
> Date: Wed, 22 Jan 2020 14:09:21 -0700
>
> Some devices have the same vendor and device ID but need different
> Option ROM files. Change the look-up to include the revision, then
> fallback to looking up without the
On Mon, Mar 16, 2020 at 05:39:45PM +0100, Paul Menzel wrote:
> From: "Ronald G. Minnich"
> Date: Thu, 24 May 2012 11:27:26 -0700
>
> Serial port detection in SeaBIOS tests for bit 2 in the IER. That bit is
> never set, and SeaBIOS mistakenly reports 0 serial ports. As it happens,
> just testing f
On Mon, Mar 16, 2020 at 05:36:50PM +0100, Paul Menzel wrote:
> From: Stefan Reinauer
> Date: Fri, 31 Jan 2014 13:53:58 -0800
>
> Allow specifying a file instead of /dev/null for defconfig.
What's the high-level use case for this change? Couldn't the same
functionality be obtained by doing:
cp
On Mon, Mar 16, 2020 at 10:38:25AM +0100, Paul Menzel wrote:
> From: Matt DeVillier
> Date: Fri, 12 Aug 2016 14:21:58 -0500
>
> PS/2 keyboards on Chromebooks with upstream coreboot + SeaBIOS often
> fail to init properly / register keystrokes. Modify ps2port init
> to match that of TianoCore, wh
On Mon, Mar 16, 2020 at 10:32:41AM +0100, Paul Menzel wrote:
> From: Matt DeVillier
> Date: Fri, 13 Jun 2014 17:20:23 -0500
>
> Signed-off-by: Matt DeVillier
> Signed-off-by: Paul Menzel
> ---
> Upstream from https://github.com/MrChromebox/SeaBIOS/
I don't think this is a good change to make.
On Tue, Mar 10, 2020 at 11:22:45AM +0100, Gerd Hoffmann wrote:
> Add function to set tsc frequency directly, without calibration.
> Also tweak timer setup functions a bit: skip setup in case TimerPort
> has not the default value any more, i.e. another timer has been setup
> already.
>
> Signed-off
On Wed, Mar 04, 2020 at 03:02:59PM +0100, Paul Menzel wrote:
> From: Matt DeVillier
> Date: Fri, 13 Jun 2014 17:21:57 -0500
>
> Currently, booting from a USB device displays the same text as
> booting from a hard disk ('Booting from Hard Disk').
>
> Identify USB devices based on the description
On Fri, Mar 06, 2020 at 04:44:16PM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> src/fw/paravirt.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/fw/paravirt.c b/src/fw/paravirt.c
> index 4fcd8f570673..8b463af96c3e 100644
> --- a/src/fw/paravirt.c
> +++ b/
On Fri, Mar 06, 2020 at 04:44:14PM +0100, Gerd Hoffmann wrote:
> Factor out TimerKHz and ShiftTSC calculation to tsctimer_configure().
>
> Signed-off-by: Gerd Hoffmann
> ---
> src/hw/timer.c | 21 +
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/src/hw/t
ercon entry point on any vesa modeset
> -if (regs->al == 0x00)
> +if (regs->al == 0x02)
> SET_LOW(sercon_enable, 0);
> }
> }
Reviewed-by: Kevin O'Connor
-Kevin
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
On Wed, Mar 04, 2020 at 02:51:27PM +0100, Paul Menzel wrote:
> Date: Tue, 3 Mar 2020 16:24:46 +0100
>
> GCC 10 gives the warnings below:
>
> In file included from out/ccode32flat.o.tmp.c:54:
> ./src/tcgbios.c: In function 'tpm20_write_EfiSpecIdEventStruct':
> ./src/tcgbios.c:290:30: w
On Sun, Dec 15, 2019 at 09:26:17PM -0600, Matt DeVillier wrote:
> On Sun, Dec 15, 2019 at 6:26 PM Kevin O'Connor wrote:
> >
> > On Sat, Dec 14, 2019 at 11:26:17AM -0600, Matt DeVillier wrote:
> > > Some USB keyboards report 9 or 10-byte max packet sizes, instead
>
On Thu, Dec 12, 2019 at 09:51:19PM -0600, Matt DeVillier wrote:
> Since the USB stack doesn't handle stalled pipes,
> don't abort keyboard setup if the set_idle command fails,
> since it's a non-critical feature. Instead, log a warning.
>
> Test: build/boot Google Pixel Slate, observe keyboard fun
On Tue, Jan 14, 2020 at 06:10:43PM +0100, Laszlo Ersek wrote:
> On 01/14/20 10:25, Gerd Hoffmann wrote:
> > Call find_prio("HALT") only once, on first is_bootprio_strict() call.
> > Store the result in a variable and reuse it on subsequent calls.
> >
> > Signed-off-by: Gerd Hoffmann
> > ---
> >
On Sat, Dec 14, 2019 at 11:26:17AM -0600, Matt DeVillier wrote:
> Some USB keyboards report 9 or 10-byte max packet sizes, instead
> of the 8-byte max specified by the USB HID spec. Handle this by
> increasing the size of the keyevent struct to 10 bytes, and using the key
> array size of the usbkey
eometry: Apply LCHS values for boot devices"
Revert "config: Add toggle for bootdevice information"
Revert "geometry: Add boot_lchs_find_*() utility functions"
Revert "geometry: Read LCHS from fw_cfg"
Kevin O'Connor (11):
output: Avoid
On Wed, Nov 06, 2019 at 11:29:18AM -0500, Kevin O'Connor wrote:
> On Wed, Nov 06, 2019 at 12:12:55PM +0100, Gerd Hoffmann wrote:
> > On Wed, Oct 16, 2019 at 12:44:12PM +0200, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > Almost a year since 1.12.0 was tag
On Wed, Nov 06, 2019 at 04:35:58PM -0500, Stefan Berger wrote:
> This series of patches addresses issues that may arise if a TPM sends
> unexpected short packets.
>
>Stefan
Thanks. I committed this series.
-Kevin
___
SeaBIOS mailing list -- seabio
On Wed, Nov 06, 2019 at 12:12:55PM +0100, Gerd Hoffmann wrote:
> On Wed, Oct 16, 2019 at 12:44:12PM +0200, Gerd Hoffmann wrote:
> > Hi,
> >
> > Almost a year since 1.12.0 was tagged (Nov 17th to be exact),
> > time to plan the 1.13 release I think ...
> >
> > How about freeze in a week or two,
On Tue, Oct 29, 2019 at 06:42:21PM +0100, cyrev...@googlemail.com wrote:
> From: Daniel Maslowski
>
> Signed-off-by: Daniel Maslowski
> ---
> src/lodepng.c | 5983 +
> src/lodepng.h | 1909
> 2 files changed, 7892 insertions(+)
>
On Tue, Oct 29, 2019 at 08:43:02PM +, Eli Duttman wrote:
> Folks, please be very gentle with me. I'm a retired IBM mainframe system
> programmer and, other than a few lines of COBOL and assembler written YEARS
> ago, know essentially nada about 8x86 programming.
>
> I want to reactivate an "
On Mon, Oct 21, 2019 at 11:31:04AM -0400, Kevin O'Connor wrote:
> Update the documentation to be explicit about the signed-off-by
> convention.
>
> Signed-off-by: Kevin O'Connor
FYI, I committed a slightly modified version of this patch. Hopefully
links in both the wi
On Mon, Oct 21, 2019 at 07:00:34PM -0400, Kevin O'Connor wrote:
> Commit 004f5b3a moved part of vgasrc/bochsvga.c to vgasrc/svgamodes.c
> - copy over the copyright statements as well.
>
> Signed-off-by: Kevin O'Connor
FYI, I committ
On Wed, Oct 23, 2019 at 07:50:36AM +0200, Gerd Hoffmann wrote:
> Gerd Hoffmann (3):
> add copyright and license to bochsdisplay.c
> add copyright and license to ramfb.c
> add license to cp437.c
Thanks. I committed these patches.
-Kevin
___
SeaBIO
Hi Gerd and Michael,
After a quick review it seems a few .c files in the SeaBIOS repo are
missing the typical LGPLv3 license statement.
egrep LGPLv3 -R --include='*.c' -L vgasrc/ src/
If we ignore build files and files from external projects it finds:
vgasrc/ramfb.c
vgasrc/bochsdisplay.c
src/cp
On Tue, Oct 22, 2019 at 10:01:28AM +0200, Uwe Kleine-König wrote:
> On 10/22/19 12:35 AM, Kevin O'Connor wrote:
> > On Mon, Oct 21, 2019 at 10:33:19PM +0200, Uwe Kleine-König wrote:
> >> I like this change in general. Note however that I could not have
> >> sign
Commit 004f5b3a moved part of vgasrc/bochsvga.c to vgasrc/svgamodes.c
- copy over the copyright statements as well.
Signed-off-by: Kevin O'Connor
---
vgasrc/svgamodes.c | 8
1 file changed, 8 insertions(+)
diff --git a/vgasrc/svgamodes.c b/vgasrc/svgamodes.c
index f89ebef..6e
On Mon, Oct 21, 2019 at 08:31:11PM +0200, Laszlo Ersek wrote:
> On 10/21/19 17:31, Kevin O'Connor wrote:
> > Update the documentation to be explicit about the signed-off-by
> > convention.
> >
> I've grown to dislike URLs, pointing into git WebUIs, that lack a
On Mon, Oct 21, 2019 at 05:00:55PM +, Peter Stuge wrote:
> Kevin O'Connor wrote:
> > Update the documentation to be explicit about the signed-off-by
> > convention.
>
> FWIW I'm against that convention, and would rather see it abandoned,
> than the p
On Mon, Oct 21, 2019 at 10:33:19PM +0200, Uwe Kleine-König wrote:
> Hello Kevin,
>
> On 10/21/19 5:31 PM, Kevin O'Connor wrote:
> > Update the documentation to be explicit about the signed-off-by
> > convention.
>
[...]
>The best match for this patch would be (
Update the documentation to be explicit about the signed-off-by
convention.
Signed-off-by: Kevin O'Connor
---
docs/Contributing.md | 5
docs/developer-certificate-of-origin | 37
2 files changed, 42 insertions(+)
create mode 100644
On Mon, Oct 14, 2019 at 11:01:59PM -0700, Rafael Send wrote:
> Hi,
> I've built SeaBIOS 1.12.1 with coreboot for the Thinkpad X210 (51nb
> aftermarket board).
> Generally I can get into SeaBIOS itself just fine, but I haven't had
> any luck loading much of anything besides Linux Live. Tianocore &
>
On Wed, Oct 16, 2019 at 12:44:12PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> Almost a year since 1.12.0 was tagged (Nov 17th to be exact),
> time to plan the 1.13 release I think ...
>
> How about freeze in a week or two, release by mid-november?
Works for me.
-Kevin
_
On Thu, Oct 10, 2019 at 05:43:30PM +0200, Uwe Kleine-König wrote:
> On 7/31/19 5:51 PM, Uwe Kleine-König wrote:
> > Hello,
> >
> > this is my attempt to address the review comments I got for v2:
> >
> > - Gerd pointed out that cbvesa should only use the modes where memmodel
> >== MM_DIRECT.
On Tue, Sep 24, 2019 at 04:02:35PM -0500, Matt DeVillier wrote:
> From 015d42aefa7cdebee79f12f9eca113e234574c89 Mon Sep 17 00:00:00 2001
> From: Matt DeVillier
> Date: Tue, 24 Sep 2019 12:29:55 -0500
> Subject: [PATCH] Reduce video modeswitching when using a boot splash
> image
>
> In the normal
On Wed, Aug 21, 2019 at 03:55:16PM +0200, Philippe Mathieu-Daudé wrote:
> On 8/21/19 3:21 PM, Kevin O'Connor wrote:
> > Building with gcc v9 causes lots of warnings about pointers to packed
> > variables. However, SeaBIOS is limited to x86 where unaligned
> > reads/write
On Wed, Aug 21, 2019 at 08:42:08AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > Using the default QEMU config, we build SeaBIOS to use the TSC timer:
> >
> > builds/seabios-128k/.config:CONFIG_TSC_TIMER=y
> > builds/seabios-256k/.config:CONFIG_TSC_TIMER=y
>
> > Do we need a cpu with TSC support to
Building with gcc v9 causes lots of warnings about pointers to packed
variables. However, SeaBIOS is limited to x86 where unaligned
reads/writes are supported by the cpu. So, disable that warning.
Signed-off-by: Kevin O'Connor
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --
Hi,
On Tue, Jul 30, 2019 at 07:21:36PM +0200, Uwe Kleine-König wrote:
> @@ -91,8 +28,8 @@ struct vgamode_s *cbvga_find_mode(int mode)
> return &CBemulinfo;
>
> int i;
> -for (i = 0; i < ARRAY_SIZE(cbvesa_modes); i++) {
> -struct cbvga_mode_s *cbmode_g = &cbvesa_modes[i]
On Thu, Jul 25, 2019 at 07:57:33AM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On 7/5/19 7:08 PM, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König
>
> hmm, git send-email failed to set the encoding for this mail, so my name
> looks funny for some people here I assume. (Corrected for this mail.
On Tue, Jul 16, 2019 at 02:43:03PM +0100, Stefan Hajnoczi wrote:
> Down for everyone or just me? :-)
>
> $ git clone https://git.seabios.org/seabios.git
> fatal: unable to access 'https://git.seabios.org/seabios.git/':
> Maximum (20) redirects followed
It's working now for me. Not sure if it was
On Fri, Jun 28, 2019 at 02:57:47PM +0100, David Woodhouse wrote:
> Explicitly handle the BBS_DO_NOT_BOOT_FROM and BBS_IGNORE_ENTRY values.
>
> Also add one to the other priority values, as find_prio() does for
> entries from bootorder. SeaBIOS uses zero for an item explicitly
> selected in interac
On Mon, Jun 24, 2019 at 02:44:00PM +0200, Gerd Hoffmann wrote:
> Reduce loglevel for mode line removals from 1 to 3.
>
> Signed-off-by: Gerd Hoffmann
Thanks. I don't know enough about the ati code to provide much
feedback, but for what it's worth, the series looks fine to me.
-Kevin
__
On Sat, Jun 22, 2019 at 11:51:48AM +0300, Sam Eiderman wrote:
> But maybe someone wants bootorder but doesn’t want to override legacy disk
> translations…
>
> I’m thinking of maybe adding
>
> if (!CONFIG_BOOTORDER || !CONFIG_BIOS_GEOMETRY)
> return NULL;
That's fine - though it's (!CONFIG_B
On Fri, Jun 21, 2019 at 08:42:28PM +0300, Sam Eiderman wrote:
> Sounds reasonable, how do purpose to deal with:
>
> config BIOS_GEOMETRY
> config BOOTORDER
>
> precompiler optouts?
I think you can stick them both under BOOTORDER. That option is only
there in case someone wants to reduce the siz
On Wed, Jun 19, 2019 at 12:23:51PM +0300, Sam Eiderman wrote:
> Adding the following utility functions:
>
> * boot_lchs_find_pci_device
> * boot_lchs_find_scsi_device
> * boot_lchs_find_ata_device
FWIW, this leads to a bit of code duplication. I think it would be
preferable to refact
On Thu, Jun 20, 2019 at 03:12:33PM +0100, David Woodhouse wrote:
> On Thu, 2019-06-20 at 09:43 -0400, Kevin O'Connor wrote:
> > On Thu, Jun 20, 2019 at 01:07:45PM +0100, David Woodhouse wrote:
> > > For CSM, the highest priority for a boot entry is zero. SeaBIOS doesn&#x
On Thu, Jun 20, 2019 at 01:07:45PM +0100, David Woodhouse wrote:
> For CSM, the highest priority for a boot entry is zero. SeaBIOS doesn't
> use zero, and the highest priority is 1.
FYI, SeaBIOS does treat zero as the highest priority. And a negative
priority means "use default priority".
I'm fi
On Thu, Jun 13, 2019 at 07:01:06PM +0100, David Woodhouse wrote:
> On Thu, 2019-06-13 at 13:33 -0400, Kevin O'Connor wrote:
> > Can you give some background on how this is intended to be used?
> >
> > We used to allow the version string to be overridden, but we found
On Thu, Jun 13, 2019 at 04:25:13PM +0100, David Woodhouse wrote:
> The alignment constraint is defined in the CSM specifications as
> "Bit mapped. First non-zero bit from the right is the alignment."
>
> Use __fls() to sanitise the alignment given that definition, since
> passing a non-power-of-t
On Mon, Jun 17, 2019 at 10:36:54AM +0300, Sam Eiderman wrote:
> So overall, WDYT?
> Keep it extendible for a low price of ABI + “bootdevices” name.
> Or go strict and rename to “bios-geometries”?
If we add another qemu to firmware interface I think the interface
should be documented. I also think
On Thu, Jun 13, 2019 at 04:25:53PM +0100, David Woodhouse wrote:
> Signed-off-by: David Woodhouse
> ---
> scripts/buildversion.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/buildversion.py b/scripts/buildversion.py
> index 8875497..fc2decd 100755
> --- a/
On Wed, Jun 12, 2019 at 05:56:23PM +0100, David Woodhouse wrote:
> The alignment constraint is defined in the CSM specifications as
> "Bit mapped. First non-zero bit from the right is the alignment."
>
> Use __fls() to sanitise the alignment given that definition, since
> passing a non-power-of-t
-Kevin
> On 6/2/19 9:01 PM, Kevin O'Connor wrote:
> > On Sun, Jun 02, 2019 at 05:39:11PM +0300, Evgeny Zinoviev wrote:
> >> Hi folks.
> >>
> >> I've recently ported coreboot on MBA 5,2 (13'' mid 2012 model) and MBP
> >> 10,1 (15'
On Mon, Jun 10, 2019 at 10:48:31AM +0300, Sam Eiderman wrote:
> Hey,
>
> What is the status on these patches?
I just committed them.
Thanks,
-Kevin
> > On 23 May 2019, at 18:39, Kevin O'Connor wrote:
> >
> > Signed-off-by: Kevin O'Connor
On Sun, Jun 02, 2019 at 05:39:11PM +0300, Evgeny Zinoviev wrote:
> Hi folks.
>
> I've recently ported coreboot on MBA 5,2 (13'' mid 2012 model) and MBP
> 10,1 (15'' mid 2012 retina model). The integrated keyboard on these
> models is connected as a USB device, not PS/2. I have tested GRUB,
> SeaBI
On Wed, May 29, 2019 at 10:27:57PM +0300, Sam Eiderman wrote:
> The implementation for this is very hacky.
>
> For non-legacy smbios we need to deconstruct a packed smbios table that qemu
> supplies.
> Preferably around this code in smbios_romfile_setup(void):
>
> /* did we get a type 0 stru
On Thu, May 23, 2019 at 06:58:57PM +0300, Sam Eiderman wrote:
> > On 23 May 2019, at 18:54, Kevin O'Connor wrote:
> > I understand. If we ensured the smbios date is always in the
> > f-segment, would that also solve the problem? (That is, using the
> > 'ch
On Thu, May 23, 2019 at 04:11:21PM +0300, Sam Eiderman wrote:
> Many programs use SystemBiosDate registry key in order to verify the machine
> they are running on (mostly for activation/licensing purposes).
> This registry key is read only and is computed as explained before.
> When this date chan
Signed-off-by: Kevin O'Connor
---
src/hw/virtio-pci.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c
index 96f9c6b..d543521 100644
--- a/src/hw/virtio-pci.c
+++ b/src/hw/virtio-pci.c
@@ -417,9 +417,8 @@ void vp_init_s
The hardcoded device names can cause false-positives on Windows bios
version checks. Use the %pP format to avoid that.
Reported-by: Sam Eiderman
Signed-off-by: Kevin O'Connor
---
src/fw/pciinit.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/s
On Wed, May 22, 2019 at 04:49:35PM +0300, Sam Eiderman wrote:
> > On 20 May 2019, at 5:28, Kevin O'Connor wrote:
> > On Fri, May 17, 2019 at 11:57:23PM +0300, Sam Eiderman wrote:
> >> From: Liran Alon
> >>
> >> Windows kernel extracts various BIOS
On Tue, May 21, 2019 at 07:41:33AM +0200, Gerd Hoffmann wrote:
> Check whenever pnp roms attempt to redirect int19, and in case it does
> log a message and undo the redirect.
>
> A pnp rom should not need this, we have BEVs and BCVs for that.
> Nevertheless there are roms in the wild which are red
On Mon, May 20, 2019 at 04:43:08PM -0500, Matt DeVillier wrote:
> v2 of the patch works as intended, once 'current.offset != current.offset'
> is corrected to 'current.offset != seabios.offset'
FWIW, that code could simply be:
static int boot_irq_captured(void)
{
return GET_IVT(0x19).segoff !
On Fri, May 17, 2019 at 11:57:23PM +0300, Sam Eiderman wrote:
> From: Liran Alon
>
> Windows kernel extracts various BIOS information at boot-time.
> The method it uses to extract SystemBiosDate is very hueristic.
> It is done by nt!CmpGetBiosDate().
>
> nt!CmpGetBiosDate() works by scanning all
On Fri, May 17, 2019 at 11:57:21PM +0300, Sam Eiderman wrote:
> From: Liran Alon
>
> There are 2 places where SeaBIOS reports its release date:
>
> 1. SMBIOS Type 0 entry
> 2. Hard-coded address 0x5
>
> Previous to this commit, each of these places defined it's own unique
> date whi
On Fri, May 17, 2019 at 11:57:20PM +0300, Sam Eiderman wrote:
> Windows kernel extracts various BIOS information at boot-time.
> The method it uses to extract SystemBiosDate & SystemBiosVersion which
> are then stored in:
> * "HKLM\HARDWARE\DESCRIPTION\System" "SystemBiosDate"
> * "HKLM\HAR
On Sat, May 18, 2019 at 09:58:59PM +0300, Sam Eiderman wrote:
> I wanted it to look more consistent with a dprintf just a few lines above:
>
> dprintf(1, "Intel IGD OpRegion enabled at 0x%08x, size %dKB, dev "
> "%02x:%02x.%x\n", (u32)addr, opregion->size >> 10,
> pci_bdf_to_bus(bd
On Wed, May 15, 2019 at 10:07:38AM +0200, Gerd Hoffmann wrote:
> Switch get_raw_keystroke() to return ax instead of ah, so it returns
> both scan code and ascii code of the key pressed.
>
> Add get_keystroke_full() function which passes up ax to the caller.
>
> The get_keystroke() function contin
Hi David,
On Wed, May 01, 2019 at 11:16:03PM +0300, David Woodhouse wrote:
> On Tue, 2019-04-30 at 22:56 -0400, Kevin O'Connor wrote:
> > That call trace certainly looks odd. The SeaBIOS debugging info would
> > help - try compiling SeaBIOS with debug level 8 and grab the l
On Wed, Apr 24, 2019 at 05:04:09PM +0300, Sam Eiderman wrote:
> From the above it can be seen that any SMBIOS type which contains string
> references should end with an additional zero byte.
Thanks. I committed this change.
I noticed during the commit that this change was made to the legacy
smbi
On Wed, Apr 24, 2019 at 05:04:09PM +0300, Sam Eiderman wrote:
> According to SMBIOS Specification, section 6.1.3 Text Strings:
> "Text strings associated with a given SMBIOS structure are returned in
> the dmiStructBuffer, appended directly after the formatted portion of the
> structure. This metho
On Mon, Apr 29, 2019 at 12:05:33AM +0300, David Woodhouse wrote:
> When I kexec either Xen or Linux in real mode, from either Xen or
> Linux, it fails.
>
> The last thing I see looks like SeaBIOS trying to use SMM for call32:
>
>
> IN:
> 0x000f70ec: mov%eax,%esi
> 0
On Fri, Apr 12, 2019 at 11:38:52AM -0700, Rafael Send wrote:
> Hi,
> I'm working on stuffing a bootable Linux distro into coreboot. In QEMU I
> already succeded by using coreboot's built-in kernel loading mechanism, but
> that's without SeaBIOS.
>
> I'd love to have it as a SeaBIOS payload so I c
On Fri, Apr 12, 2019 at 08:30:09AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> src/util.h| 2 +-
> src/boot.c| 16 +---
> src/tcgbios.c | 8
> 3 files changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/src/util.h b/src/util.h
> index
On Thu, Apr 11, 2019 at 10:01:20PM +0200, Gerd Hoffmann wrote:
> 10th and following entries can be selected using letters.
[...]
> --- a/src/boot.c
> +++ b/src/boot.c
> @@ -465,6 +465,14 @@ get_keystroke(int msec)
>
> #define DEFAULT_BOOTMENU_WAIT 2500
>
> +static const char menuchars[] = {
>
On Thu, Apr 11, 2019 at 10:01:20PM +0200, Gerd Hoffmann wrote:
> 10th and following entries can be selected using letters.
Ah, using an array of charcters makes sense. Looks fine to me.
Thanks,
-Kevin
___
SeaBIOS mailing list -- seabios@seabios.org
To
On Thu, Apr 11, 2019 at 10:00:51PM +0200, Gerd Hoffmann wrote:
> On Thu, Apr 11, 2019 at 11:53:42AM -0400, Kevin O'Connor wrote:
> > On Thu, Apr 11, 2019 at 08:54:01AM +0200, Gerd Hoffmann wrote:
> > > In case more than 9 entries are found in the boot menu
> > >
On Thu, Apr 11, 2019 at 08:54:01AM +0200, Gerd Hoffmann wrote:
> In case more than 9 entries are found in the boot menu
> switch into two digit mode, so entries 10 and above can
> actually be selected.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1693031
FWIW, I'm surprised there's enou
201 - 300 of 3556 matches
Mail list logo
