Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-08-06 Thread Erik Joelsson
On 2014-08-06 11:14, Weijun Wang wrote: On 8/6/2014 17:04, Erik Joelsson wrote: Speaking of indentation, please also change the ifdef bodies to 2 spaces. Sure. Whenever I edit a Makefile, I dare not use spaces and always use TABs. Obviously an ifdef does not need it. The tab character unfo

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-08-06 Thread Weijun Wang
On 8/6/2014 17:04, Erik Joelsson wrote: Speaking of indentation, please also change the ifdef bodies to 2 spaces. Sure. Whenever I edit a Makefile, I dare not use spaces and always use TABs. Obviously an ifdef does not need it. Thanks Max

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-08-06 Thread Erik Joelsson
On 2014-08-05 23:24, Sean Mullan wrote: On 07/28/2014 09:53 AM, Wang Weijun wrote: Yes, you are right. Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.02. GendataJavaSecurity.gmk and MakeJavaSecurity.java updated. There's an unnecessary indent at line 1 of GendataJavaSe

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-08-05 Thread Sean Mullan
On 07/28/2014 09:53 AM, Wang Weijun wrote: Yes, you are right. Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.02. GendataJavaSecurity.gmk and MakeJavaSecurity.java updated. There's an unnecessary indent at line 1 of GendataJavaSecurity.gmk In CheckSecurityProvider.java,

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-28 Thread Erik Joelsson
Build change looks good to me now. /Erik On 2014-07-28 15:53, Wang Weijun wrote: Yes, you are right. Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.02. GendataJavaSecurity.gmk and MakeJavaSecurity.java updated. Thanks Max On Jul 28, 2014, at 19:43, Erik Joelsson wrote:

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-28 Thread Wang Weijun
Yes, you are right. Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.02. GendataJavaSecurity.gmk and MakeJavaSecurity.java updated. Thanks Max On Jul 28, 2014, at 19:43, Erik Joelsson wrote: > Hello Max, > > Shouldn't the rule for $(GENDATA_JAVA_SECURITY) depend on > $(RE

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-28 Thread Erik Joelsson
Hello Max, Shouldn't the rule for $(GENDATA_JAVA_SECURITY) depend on $(RESTRICTED_PKGS_SRC) so that updates to the pkgs file triggers a rebuild? For that to work, the variable $(RESTRICTED_PKGS_SRC) needs to be empty for the OPENJDK case rather than have a dummy name and MakeJavaSecurity.java

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-27 Thread Wang Weijun
Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.01/ New test CheckSecurityProvider.java, and updates to MakeJavaSecurity.addPackages(). Thanks Max On Jul 25, 2014, at 22:44, Wang Weijun wrote: > > On Jul 25, 2014, at 22:30, Sean Mullan wrote: > >>> http://cr.openjdk

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-25 Thread Wang Weijun
On Jul 25, 2014, at 22:30, Sean Mullan wrote: >> http://cr.openjdk.java.net/~weijun/6997010/webrev.00/ >> >> 4. *IMPORTANT*: In order to easily maintain platform-related entries, >> every line (including the last line) in package.access and >> package.definition MUST end with ',\' now. A blank

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-25 Thread Sean Mullan
On 07/22/2014 10:28 PM, Wang Weijun wrote: Please review the code change at http://cr.openjdk.java.net/~weijun/6997010/webrev.00/ The fix consolidates java.security- files into one with #ifdef directives. There are several major changes: 1. Creation of file is moved from CopyFiles to Generat

RFR 6997010: Consolidate java.security files into one file with modifications

2014-07-22 Thread Wang Weijun
Please review the code change at http://cr.openjdk.java.net/~weijun/6997010/webrev.00/ The fix consolidates java.security- files into one with #ifdef directives. There are several major changes: 1. Creation of file is moved from CopyFiles to GenerateData, since we are really generating so