hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-05-21 Thread david . holmes
Changeset: f54c85acc043 Author:mikael Date: 2013-05-21 09:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f54c85acc043 8013726: runtime/memory/ReserveMemory.java fails due to 'assert(bytes % os::vm_allocation_granularity() == 0) failed: reserve block size' Summa

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread David Holmes
Hi Kelly, On 22/05/2013 5:27 AM, Kelly O'Hair wrote: I am pretty sure you want to keep the symbol in the library and have it return an error code, rather than remove the symbol entirely. Most tools will not necessarily know what kind of jdk/jre is being used, and getting a runtime linker error m

Re: Need help with change

2013-05-21 Thread David Holmes
On 21/05/2013 11:56 PM, Coleen Phillimore wrote: On 05/21/2013 09:29 AM, Staffan Larsen wrote: When doing heap iteration with JVMTI, the spec requires callbacks from the VM to the agent identifying the signers and protection domain references. This is what tagMap does, see jvmtiTagMap.cpp:2464.

hg: hsx/hotspot-rt/hotspot: 8014059: JSR292: Failed to reject invalid class cplmhl00201m28n

2013-05-21 Thread bharadwaj . yadavalli
Changeset: ccdecfece956 Author:bharadwaj Date: 2013-05-21 16:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ccdecfece956 8014059: JSR292: Failed to reject invalid class cplmhl00201m28n Summary: Restrict reference of interface methods by invokestatic and invokes

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
On 5/21/2013 4:00 PM, Oleg Mazurov wrote: Though formally not part of the Solaris Studio team any more here is my opinion based on my recollection of how I implemented interaction with the JVM via AsyncGetCallTrace. It's looked up using dlsym. If the symbol is not there Java callstack collecti

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread Oleg Mazurov
Though formally not part of the Solaris Studio team any more here is my opinion based on my recollection of how I implemented interaction with the JVM via AsyncGetCallTrace. It's looked up using dlsym. If the symbol is not there Java callstack collection is shut down. I understand in your case e

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread Kelly O'Hair
On May 21, 2013, at 12:19 PM, JOSEPH PROVINO wrote: >> >> Let's ask the Solaris Studio guys directly. >> I'm adding Oleg to the mailing list. >> >> Oleg, >> >> Could you, please, share your view on this problem? > > In particular what will the Sun Studio Profiler collector do if it gets the

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
On 5/21/2013 3:16 PM, serguei.spit...@oracle.com wrote: On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: On 5/21/2013 2:23 PM, Staffan Larsen wrote: On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: On 5/21/2013 3:06 AM, David Holmes wrote: Hi Staffan, On 21/05/2013 4:49 PM, Staffan Larsen wrot

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread serguei.spit...@oracle.com
On 5/21/13 11:26 AM, JOSEPH PROVINO wrote: On 5/21/2013 2:23 PM, Staffan Larsen wrote: On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: On 5/21/2013 3:06 AM, David Holmes wrote: Hi Staffan, On 21/05/2013 4:49 PM, Staffan Larsen wrote: On 21 maj 2013, at 04:34, David Holmes wrote: Hi

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread serguei.spit...@oracle.com
On 5/21/13 11:23 AM, Staffan Larsen wrote: On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: On 5/21/2013 3:06 AM, David Holmes wrote: Hi Staffan, On 21/05/2013 4:49 PM, Staffan Larsen wrote: On 21 maj 2013, at 04:34, David Holmes wrote: Hi Joe, As I have previously stated you copied th

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
On 5/21/2013 2:23 PM, Staffan Larsen wrote: On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: On 5/21/2013 3:06 AM, David Holmes wrote: Hi Staffan, On 21/05/2013 4:49 PM, Staffan Larsen wrote: On 21 maj 2013, at 04:34, David Holmes wrote: Hi Joe, As I have previously stated you copied

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread Staffan Larsen
On 21 maj 2013, at 17:35, JOSEPH PROVINO wrote: > > On 5/21/2013 3:06 AM, David Holmes wrote: >> Hi Staffan, >> >> On 21/05/2013 4:49 PM, Staffan Larsen wrote: >>> >>> On 21 maj 2013, at 04:34, David Holmes wrote: >>> Hi Joe, As I have previously stated you copie

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread Staffan Larsen
On 21 maj 2013, at 18:33, Kelly O'Hair wrote: > http://jeremymanson.blogspot.com/2007/05/profiling-with-jvmtijvmpi-sigprof-and.html > http://stackoverflow.com/questions/3426537/how-to-properly-write-a-sigprof-handler-that-invokes-asyncgetcalltrace > http://hiroshiyamauchi.blogspot.com/2008/12/st

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread Kelly O'Hair
http://jeremymanson.blogspot.com/2007/05/profiling-with-jvmtijvmpi-sigprof-and.html http://stackoverflow.com/questions/3426537/how-to-properly-write-a-sigprof-handler-that-invokes-asyncgetcalltrace http://hiroshiyamauchi.blogspot.com/2008/12/stabilizing-asyncgetcalltrace.html The AsyncGetCallTrace

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
On 5/21/2013 2:49 AM, Staffan Larsen wrote: On 21 maj 2013, at 04:34, David Holmes wrote: Hi Joe, As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. Serviceability folk: we are particularly interested in whether the use of ticks_no_cl

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
On 5/21/2013 3:06 AM, David Holmes wrote: Hi Staffan, On 21/05/2013 4:49 PM, Staffan Larsen wrote: On 21 maj 2013, at 04:34, David Holmes wrote: Hi Joe, As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. Serviceability folk: we are

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread JOSEPH PROVINO
On 5/20/2013 10:34 PM, David Holmes wrote: Hi Joe, As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. I fixed this and will send out a new webrev. joe Serviceability folk: we are particularly interested in whether the use of ticks_n

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Coleen Phillimore
On 05/21/2013 09:18 AM, Staffan Larsen wrote: Net footprint change is zero except that these fields are in Java heap rather than metaspace. This helps a little with InstanceKlass size which is in fixed size space with UseCompressedKlassPointers. Included serviceability because there were SA cha

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Coleen Phillimore
Thanks Stefan, I have 2 small comments. On 05/21/2013 10:38 AM, Stefan Karlsson wrote: On 21 maj 2013, at 16:12, Coleen Phillimore wrote: On 05/21/2013 05:11 AM, Stefan Karlsson wrote: Hi Coleen, Good to see all these oops moving to the mirrors. I think the changes look good. I let some

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Stefan Karlsson
On 21 maj 2013, at 16:12, Coleen Phillimore wrote: > > On 05/21/2013 05:11 AM, Stefan Karlsson wrote: >> Hi Coleen, >> >> Good to see all these oops moving to the mirrors. I think the changes look >> good. I let someone else review the SA changes > > Yes, I'm hoping for someone to review th

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Coleen Phillimore
On 05/21/2013 05:11 AM, Stefan Karlsson wrote: Hi Coleen, Good to see all these oops moving to the mirrors. I think the changes look good. I let someone else review the SA changes Yes, I'm hoping for someone to review the SA changes. Some comments below: On 05/21/2013 12:39 AM, Coleen Phi

Re: Need help with change

2013-05-21 Thread Coleen Phillimore
On 05/21/2013 09:29 AM, Staffan Larsen wrote: When doing heap iteration with JVMTI, the spec requires callbacks from the VM to the agent identifying the signers and protection domain references. This is what tagMap does, see jvmtiTagMap.cpp:2464. As long as it it still possible for JVMTI to f

hg: jdk8/tl/langtools: 7164114: Two jtreg tests are not run due to no file extension on the test files

2013-05-21 Thread vicente . romero
Changeset: 08daea43a7f8 Author:vromero Date: 2013-05-21 14:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/08daea43a7f8 7164114: Two jtreg tests are not run due to no file extension on the test files Reviewed-by: mcimadamore - test/tools/javac/HiddenAbstractMethod/Te

Re: Need help with change

2013-05-21 Thread Staffan Larsen
When doing heap iteration with JVMTI, the spec requires callbacks from the VM to the agent identifying the signers and protection domain references. This is what tagMap does, see jvmtiTagMap.cpp:2464. As long as it it still possible for JVMTI to find these references (with ik->protection_domai

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Staffan Larsen
>>> Net footprint change is zero except that these fields are in Java heap >>> rather than metaspace. This helps a little with InstanceKlass size >>> which is in fixed size space with UseCompressedKlassPointers. Included >>> serviceability because there were SA changes to code that I don't know >

Need help with change

2013-05-21 Thread Coleen Phillimore
I found during code review comment editing for my change that removes signers and protection domain from the InstanceKlass, that JVMTI code seems to have some sort of call back and knowledge of these fields in instanceKlass. Reference from a class to its sig

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Coleen Phillimore
On 05/20/2013 11:39 PM, David Holmes wrote: Hi Coleen, On 21/05/2013 8:39 AM, Coleen Phillimore wrote: Summary: Inject protection_domain, signers, init_lock into java_lang_Class Basic VM changes look fine to me. Thanks! Net footprint change is zero except that these fields are in Java h

hg: jdk8/tl/langtools: 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir

2013-05-21 Thread vicente . romero
Changeset: 3d9750039fff Author:vromero Date: 2013-05-21 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d9750039fff 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir Reviewed-by: mcimadamore ! test/tools/javac/diags/Example.java

hg: jdk8/tl/langtools: 7177168: Redundant array copy in UnsharedNameTable

2013-05-21 Thread vicente . romero
Changeset: 824932ecdbc8 Author:vromero Date: 2013-05-21 11:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/824932ecdbc8 7177168: Redundant array copy in UnsharedNameTable Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/UnsharedNameTable.java

hg: jdk8/tl/langtools: 8013180: Qualified type reference with annotations in throws list crashes compiler

2013-05-21 Thread joel . franck
Changeset: 67cbd6d756f4 Author:jfranck Date: 2013-05-21 12:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67cbd6d756f4 8013180: Qualified type reference with annotations in throws list crashes compiler Reviewed-by: jjg + test/tools/javac/annotations/typeAnnotations

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Stefan Karlsson
Hi Coleen, Good to see all these oops moving to the mirrors. I think the changes look good. I let someone else review the SA changes Some comments below: On 05/21/2013 12:39 AM, Coleen Phillimore wrote: Summary: Inject protection_domain, signers, init_lock into java_lang_Class Net footprin

hg: jdk8/tl/nashorn: 3 new changesets

2013-05-21 Thread sundararajan . athijegannathan
Changeset: 92164a5742db Author:lagergren Date: 2013-05-20 16:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/92164a5742db 8006069: Range analysis first iteration, runtime specializations Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CompilationPhase.j

Re: review request for JDK-8013461 There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release

2013-05-21 Thread David Holmes
Hi Staffan, On 21/05/2013 4:49 PM, Staffan Larsen wrote: On 21 maj 2013, at 04:34, David Holmes wrote: Hi Joe, As I have previously stated you copied the struct definitions instead of moving them outside the ifdef. Serviceability folk: we are particularly interested in whether the use o