Re: RFR: 8057558 VirtualMachineImpl.execute on windows should close PipedInputStream before throwing exceptions

On 9/8/14 10:39 PM, Staffan Larsen wrote: On 8 sep 2014, at 22:03, serguei.spit...@oracle.com wrote: On 9/8/14 12:59 PM, Staffan Larsen wrote: On 8 sep 2014, at 21:26, serguei.spit...@oracle.com wrote: This looks g

Re: RFR: 8057558 VirtualMachineImpl.execute on windows should close PipedInputStream before throwing exceptions

On 8 sep 2014, at 22:23, Dmitry Samersoff wrote: > Staffan, > > Technically, the fix look OK for me. Thanks. > > But, > > executeJCmd("ManagementAgent.start_local").close(); > > looks a bit weird for me. > > It might be better to create something like > > executeJCmd_no_out(); I tend t

Re: RFR: 8057558 VirtualMachineImpl.execute on windows should close PipedInputStream before throwing exceptions

On 8 sep 2014, at 22:03, serguei.spit...@oracle.com wrote: > On 9/8/14 12:59 PM, Staffan Larsen wrote: >> >> On 8 sep 2014, at 21:26, serguei.spit...@oracle.com wrote: >> >>> This looks good to me. >> >> Thanks. >> >>> >>> A minor question: >>> >>> src/jdk.attach/windows/classes/sun/tools/a

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

Bind call is required to listen on particular address. So please, keep it. I think JdpBroadcaster need not to call bind(). bind() binds address to application, so another application on same host cannot use JDP. I've changed JdpBroadcaster as below: --- diff -r 68a6bb51cb26 src/java.ma

Re: RFR: 8057558 VirtualMachineImpl.execute on windows should close PipedInputStream before throwing exceptions

Staffan, Technically, the fix look OK for me. But, executeJCmd("ManagementAgent.start_local").close(); looks a bit weird for me. It might be better to create something like executeJCmd_no_out(); -Dmitry On 2014-09-08 16:25, Staffan Larsen wrote: > Two fixes: > - The PipedInputStream use

Re: RFR: 8057558 VirtualMachineImpl.execute on windows should close PipedInputStream before throwing exceptions

On 9/8/14 12:59 PM, Staffan Larsen wrote: On 8 sep 2014, at 21:26, serguei.spit...@oracle.com wrote: This looks good to me. Thanks. A minor question: src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java 110 is.clo

Re: RFR: 8057558 VirtualMachineImpl.execute on windows should close PipedInputStream before throwing exceptions

On 8 sep 2014, at 21:26, serguei.spit...@oracle.com wrote: > This looks good to me. Thanks. > > A minor question: > > src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java > 110 is.close(); > > An IOException can be thrown in the readErrorMessage(). > Would

Re: RFR: 8057558 VirtualMachineImpl.execute on windows should close PipedInputStream before throwing exceptions

This looks good to me. A minor question: src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java 110 is.close(); An IOException can be thrown in the readErrorMessage(). Would it make sense to use a finally statementto close the stream? Thanks, Serguei On 9/8

Re: RFR: 8057776 Misc cleanups of the attach code

Thanks for testing it out. /Staffan On 8 sep 2014, at 19:34, Volker Simonis wrote: > Hi Staffan, > > I've just successfully built on AIX with your proposed changes. > > Everything looks fine, so thumbs up from me and thanks for pushing the > additional changes! > > Regards, > Volker > > >

Re: RFR: 8057776 Misc cleanups of the attach code

Hi Staffan, I've just successfully built on AIX with your proposed changes. Everything looks fine, so thumbs up from me and thanks for pushing the additional changes! Regards, Volker On Mon, Sep 8, 2014 at 3:04 PM, Staffan Larsen wrote: > Hi Volker, > > Unfortunately I had already pushed th

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

Jaroslav, > L96-100 Do we still need these lines? Isn't > `channel.setOption(StandardSocketOptions.IP_MULTICAST_IF, interf);` > enough to listen on the interface? Bind call is required to listen on particular address. So please, keep it. -Dmitry On 2014-09-08 14:12, Jaroslav Bachorik wrote: >

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

Hi Jaroslav, I could not receive your email. So I reply from another email. L103 Please, move "else" to the previous line I will fix it. L96-100 Do we still need these lines? Isn't `channel.setOption(StandardSocketOptions.IP_MULTICAST_IF, interf);` enough to listen on the interface? I thi

Re: RFR [8057744] (process) Synchronize exiting of threads and process [win]

On 08.09.2014 17:31, Daniel D. Daugherty wrote: Ivan, I'll sponsor the change, but I want to push it after this week's RT_Baseline snapshot. We snapshot on Tuesday (2014.09.09 at 1900 PT) and if the nightly test results look reasonable Wednesday morning, then I'll push it on Wednesday. Does th

Re: RFR [8057744] (process) Synchronize exiting of threads and process [win]

Ivan, I'll sponsor the change, but I want to push it after this week's RT_Baseline snapshot. We snapshot on Tuesday (2014.09.09 at 1900 PT) and if the nightly test results look reasonable Wednesday morning, then I'll push it on Wednesday. Does this sound acceptable to you? Dan On 9/7/14 10:03

Re: RFR: 8057776 Misc cleanups of the attach code

Hi Volker, Unfortunately I had already pushed the change. I filed a new bug for the AIX work: JDK-8057778 and the changes are below. If you can review them, I will push it soon. Thanks and sorry I forgot aix, /Staffan diff --git a/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImp

Re: RFR: 8057558 VirtualMachineImpl.execute on windows should close PipedInputStream before throwing exceptions

On 08/09/2014 13:25, Staffan Larsen wrote: Two fixes: - The PipedInputStream used by the attach code on windows is not closed in case of errors - The InputStreams returned by VirtualMachine.execute are not closed by all callers webrev: http://cr.openjdk.java.net/~sla/8057558/webrev.00/ bug: ht

Re: RFR: 8057776 Misc cleanups of the attach code

hi Staffen, the change looks good, but could you please also change src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java Thanks, Volker On Mon, Sep 8, 2014 at 2:45 PM, Staffan Larsen wrote: > Thank you, all. > > On 8 sep 2014, at 14:39, Daniel Fuchs wrote: > > > Hi Staffan, >

Re: RFR: 8057776 Misc cleanups of the attach code

Thank you, all. On 8 sep 2014, at 14:39, Daniel Fuchs wrote: > Hi Staffan, > > Looks good! > > -- daniel > > On 9/8/14 2:23 PM, Staffan Larsen wrote: >> Please review this simple fix for some small issues in the attach code: >> - Removed unused imports >> - Removed unused fields >> - Update @

Re: RFR: 8057776 Misc cleanups of the attach code

Hi Staffan, Looks good! -- daniel On 9/8/14 2:23 PM, Staffan Larsen wrote: Please review this simple fix for some small issues in the attach code: - Removed unused imports - Removed unused fields - Update @since for startManagementAgent() and startLocalManagementAgent() since these were just

Re: RFR: 8057776 Misc cleanups of the attach code

Looks fine -JB- On 09/08/2014 02:23 PM, Staffan Larsen wrote: Please review this simple fix for some small issues in the attach code: - Removed unused imports - Removed unused fields - Update @since for startManagementAgent() and startLocalManagementAgent() since these were just backported to

Re: RFR: 8057776 Misc cleanups of the attach code

On 08/09/2014 13:23, Staffan Larsen wrote: Please review this simple fix for some small issues in the attach code: - Removed unused imports - Removed unused fields - Update @since for startManagementAgent() and startLocalManagementAgent() since these were just backported to 1.8 - Simplified a fo

RFR: 8057558 VirtualMachineImpl.execute on windows should close PipedInputStream before throwing exceptions

Two fixes: - The PipedInputStream used by the attach code on windows is not closed in case of errors - The InputStreams returned by VirtualMachine.execute are not closed by all callers webrev: http://cr.openjdk.java.net/~sla/8057558/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-805755

RFR: 8057776 Misc cleanups of the attach code

Please review this simple fix for some small issues in the attach code: - Removed unused imports - Removed unused fields - Update @since for startManagementAgent() and startLocalManagementAgent() since these were just backported to 1.8 - Simplified a for-loop in a test bug: https://bugs.openjdk.j

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

Hi Yasamusa, On 09/05/2014 12:28 PM, Yasumasa Suenaga wrote: Hi Peter, I fixed it and created new webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.1/ Could you review it again? Just a few nits ... L103 Please, move "else" to the previous line L96-100 Do we still need these li

Re: RFR: JDK-8057746: Cannot handle JdpException in JMX agent initialization.

Looks good! -JB- On 09/07/2014 03:04 PM, Yasumasa Suenaga wrote: > Hi all, > > This issue is related to JDK-8057556: JDP should better handle non-active > interfaces > http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-September/015548.html > > JMX agent will be terminated silently

Re: jmx-dev Review request: 8049303: Transient network problems cause JMX thread to fail silenty

Jaroslav, Your fix was to close a connection if the IOException was not related to a serialization problem, without testing whether the connection was back. This might modify the current RMIConnector behaviors, because the method RMIClientCommunicatorAdmin.gotIOException was called not only