Re: RFR(S): 8168305 GC.class_stats should not require -XX:+UnlockDiagnosticVMOptions

Hi Staffan, On 2016-10-27 10:36, Staffan Larsen wrote: All, Please review this small patch to remove the requirement -XX:+UnlockDiagnosticVMOptions when running the GC.class_stats diagnostic command. Diagnostic commands are used for diagnosing problems and should not require restarting the

Re: [PING] RFR: 8150894: Unused -Xlog tag sequences are silently ignored.

Thanks Staffan! Marcus On 08/25/2016 10:15 AM, Staffan Larsen wrote: Looks ok to me. /Staffan On 25 aug. 2016, at 09:51, Marcus Larsson <marcus.lars...@oracle.com> wrote: On 08/23/2016 01:17 PM, Marcus Larsson wrote: Hi, Still looking for a Reviewer for this. (Rebased webrev in

[PING] Re: RFR: 8150894: Unused -Xlog tag sequences are silently ignored.

On 08/23/2016 01:17 PM, Marcus Larsson wrote: Hi, Still looking for a Reviewer for this. (Rebased webrev in-place.) Thanks, Marcus On 04/12/2016 04:14 PM, Marcus Larsson wrote: Ping! On 04/06/2016 08:46 AM, Marcus Larsson wrote: Hi, Please review the following patch to add a warning

Re: RFR: 8150894: Unused -Xlog tag sequences are silently ignored.

Hi, Still looking for a Reviewer for this. (Rebased webrev in-place.) Thanks, Marcus On 04/12/2016 04:14 PM, Marcus Larsson wrote: Ping! On 04/06/2016 08:46 AM, Marcus Larsson wrote: Hi, Please review the following patch to add a warning for when tag selections in -Xlog or VM.log don't

Re: 8164523: Clean up metadata for event based tracing

Hi, On 08/20/2016 08:49 PM, Erik Gahlin wrote: Hi, Could I have review of this fix to the event tracing metadata. The patch touches many files, but it doesn't change the control flow, only class and field names. Webrev: http://cr.openjdk.java.net/~egahlin/8164523/ Looks good to me!

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.07/ Looks good, thanks for fixing this. Marcus Thanks, Yasumasa On 2016/06/30 18:38, Marcus Larsson wrote: Hi, On 2016-06-30 11:31, Yasumasa Suenaga wrote: Hi Marcus, Therefore I suggest that we introduce a describe() function

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

and this enhancement can be merged and be accepted, I will start to work for it. Thanks, Yasumasa On 2016/06/28 20:23, Marcus Larsson wrote: Hi, On 06/28/2016 11:29 AM, Yasumasa Suenaga wrote: PING: Could you review and sponsor it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.05/ I

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

dk.java.net/~ysuenaga/JDK-8153074/webrev.03/ Thanks, Yasumasa On 2016/05/10 8:06, Yasumasa Suenaga wrote: We need a second reviewer. Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.03/ Yasumasa On 2016/05/04 23:38, Marcus Larsson wrote: Hi, On

Re: RFR: 8072440: serviceability/dcmd/ tests timeout

Looks good to me! Thanks, Marcus On 2016-06-10 09:27, Robbin Ehn wrote: Hi all, I can not reproduce running the tests mutiple times on mutiple platforms. And I can not see anything particular in test code. So I'm removing the @ignore flag for these. Bug:

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

p://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.03/ Looks OK. Thanks, Marcus Could you review again? Yasumasa On 2016/05/04 22:35, Marcus Larsson wrote: Hi, On 05/04/2016 02:59 PM, Yasumasa Suenaga wrote: Hi Marcus, Thank you for your comment. http://cr.openjdk.java.net/~ysuenag

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

rev.07/ Looks good! Thanks for fixing this. Marcus Thanks, Yasumasa On 2016/05/04 21:38, Marcus Larsson wrote: Hi, On 05/04/2016 02:29 PM, Yasumasa Suenaga wrote: Hi David, Marcus, Thank you for your comment. I uploaded new webrev. Could you review it again? http://cr.openjdk.java.

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

_byte_size(_rotate_size)); Thanks, Marcus I fixed to use _rotate_size and _file_count directly to show VM.log list jcmd. I do not store option string, and I added new function to print option string. Could you review it again? Thanks. Yasumasa On 2016/05/04 18:33, Marcus Larsson wrote: Hi

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

rnings on 32-bit platforms. Thanks, Marcus Thanks, Yasumasa On 2016/05/04 15:49, Marcus Larsson wrote: Hi, On 05/04/2016 03:45 AM, David Holmes wrote: On 4/05/2016 10:19 AM, Yasumasa Suenaga wrote: Hi David, Marcus, I would not have done that but instead used a temporary julong for the

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

Hi, On 05/03/2016 01:43 PM, Yasumasa Suenaga wrote: PING: Could you review and sponsor it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.01/ I would prefer to generate the option string from the actual options rather than saving the string from when it was configured. This would

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

w, without a suffix, it is just bytes. Is it no problem? Thanks, Yasumasa On 2016/05/03 21:41, Marcus Larsson wrote: Hi, On 05/03/2016 02:25 PM, David Holmes wrote: Adding in the runtime team as they now own UL. I've reviewed the change from a coding perspective - the question for the

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

viously the filesize was interpreted as a value in KB, whereas now, without a suffix, it is just bytes. Is it no problem? No I don't think that's a problem. Thanks, Marcus Thanks, Yasumasa On 2016/05/03 21:41, Marcus Larsson wrote: Hi, On 05/03/2016 02:25 PM, David Holmes wrote:

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

>>>> Yasumasa >>>> >>>> >>>> On 2016/03/31 22:33, Yasumasa Suenaga wrote: >>>>> CC'ed to serviceability-dev. >>>>> >>>>> Could you review it? >>>

Re: RFR: JDK-8155089: UL: Remove trailing comma from log decoration list

Hi, On 04/26/2016 03:08 PM, Yasumasa Suenaga wrote: Hi all, This review request relates [1]. We can check log configuration through VM.log list jcmd: --- Log output configuration: #0: stdout vmoperation=debug,safepoint=info uptime,level,tags, #1: stderr all=warning uptime,level,tags, #2:

Re: RFR: JDK-8153191: UL: Separator in VM.log output is redundant

", LogDecorators::name(decorator)); +out->print("%s%s", first_decorator ? "" : ",", + LogDecorators::name(decorator)); +first_decorator = false; } } out->cr(); --- Thanks, Yasumasa On 2016/03/31 22:11, Marcus Larsson wrote:

Re: RFR: JDK-8153191: UL: Separator in VM.log output is redundant

)) { -out->print("%s,", LogDecorators::name(decorator)); +out->print("%s%s", first_decorator ? "" : ",", + LogDecorators::name(decorator)); +first_decorator = false; } } out->cr();

Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

Hi, On 04/20/2016 01:47 PM, Robbin Ehn wrote: Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to print_on. Since JvmtiBreakpoint extends GrowableElement print_on already exists as a virtual const method, hence the const changes.

Re: RFR: 8154059: JVMTI ObjectTagging to UL

Hi, On 04/14/2016 01:52 PM, Robbin Ehn wrote: Hi all, Please review: This moves jvmti object-tagging output to the tag-set jvmti,objecttagging on debug level. The TraceJVMTIObjectTagging argument is deprecated and aliased with: "-Xlog:jvmti+objecttagging=debug" Did this on top of:

Re: RFR: 8154041: JVMTI to Unified Logging

Hi, On 04/14/2016 01:36 PM, Robbin Ehn wrote: Hi all, Please review: This moves jvmti trace output to the tag jvmti on trace level. The jvmti trace argument e.g. "-XX:TraceJVMTI=ec+ieost,all+ieost" have a lot of functionality, e.g. can filter on func, in/out, etc, so it if left as is.

Re: RFR: 8150894: Unused -Xlog tag sequences are silently ignored.

Ping! On 04/06/2016 08:46 AM, Marcus Larsson wrote: Hi, Please review the following patch to add a warning for when tag selections in -Xlog or VM.log don't match any tag sets used in the VM. Webrev: http://cr.openjdk.java.net/~mlarsson/8150894/webrev.00/ Issue: https

Re: RFR: 8150894: Unused -Xlog tag sequences are silently ignored.

Thanks Robbin! Marcus On 04/08/2016 02:44 PM, Robbin Ehn wrote: Hi Marcus Your change looks good. Thanks! /Robbin On 04/06/2016 08:46 AM, Marcus Larsson wrote: Hi, Please review the following patch to add a warning for when tag selections in -Xlog or VM.log don't match any tag sets used

Re: RFR(xs): 8153845: UL log write method missing essential assert

On 04/08/2016 03:26 PM, Bengt Rutisson wrote: Hi Robbin, On 2016-04-08 14:45, Robbin Ehn wrote: Hi again, I missed LogLevel:Off, it should be: diff -r 35cb720769c5 src/share/vm/logging/logTagSet.cpp --- a/src/share/vm/logging/logTagSet.cppFri Apr 08 08:51:45 2016 +0200 +++

Re: RFR(s): 8153731: Increase max tag combinations for UL expression (config)

Hi Robbin, On 04/08/2016 10:08 AM, Robbin Ehn wrote: Hi all, Please review, Webrev: http://cr.openjdk.java.net/~rehn/8153731/webrev/ I just have one suggestion for a slightly better assert message: "Combination limit (" SIZE_FORMAT ") not sufficient for configuring all available tag sets

Re: RFR(xs): 8153845: UL log write method missing essential assert

Hi Robbin, On 04/08/2016 01:54 PM, Robbin Ehn wrote: Hi all, Please review, Bug: https://bugs.openjdk.java.net/browse/JDK-8153845 Tested with jprt. diff -r 35cb720769c5 src/share/vm/logging/logTagSet.cpp --- a/src/share/vm/logging/logTagSet.cppFri Apr 08 08:51:45 2016 +0200 +++

RFR: 8150894: Unused -Xlog tag sequences are silently ignored.

Hi, Please review the following patch to add a warning for when tag selections in -Xlog or VM.log don't match any tag sets used in the VM. Webrev: http://cr.openjdk.java.net/~mlarsson/8150894/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8150894 Testing: Internal VM tests with

Re: RFR (S): 8153174: Remove trailing comma from log configuration listings

Thanks Robbin! On 04/01/2016 12:54 PM, Robbin Ehn wrote: Hi Marcus, Thanks, looks good! /Robbin On 03/31/2016 12:40 PM, Marcus Larsson wrote: Hi, Please review the following small patch to avoid adding a trailing comma in the tagset and level listings in the configuration string for log

RFR (S): 8153174: Remove trailing comma from log configuration listings

Hi, Please review the following small patch to avoid adding a trailing comma in the tagset and level listings in the configuration string for log outputs. Removing this comma allows the string to be used without modification when configuring logging (with -Xlog or similar). Webrev:

Re: RFR: 8146879: Add option for handling existing log files in UL

Thanks for reviewing! Marcus On 03/30/2016 06:16 PM, Gerard Ziemski wrote: Look good. Thank you for you patience with my review. cheers On Mar 30, 2016, at 9:17 AM, Marcus Larsson <marcus.lars...@oracle.com> wrote: Hi Gerard, On 03/22/2016 07:15 PM, Gerard Ziemski wrote: hi

Re: PING: Re: RFR: 8150823: UL handles disabling logs incorrectly

Need a Reviewer for this. Thanks, Marcus On 03/23/2016 11:41 AM, Marcus Larsson wrote: On 03/18/2016 12:25 PM, Marcus Larsson wrote: Hi, Updated the patch after offline discussion. New patch attempts to normalize the output name before searching for it or adding it. This includes adding

Re: RFR: 8151438: UL instantiates duplicate tag sets

Thanks for reviewing, Stefan! On 03/23/2016 08:34 PM, Stefan Karlsson wrote: Hi Marcus, On 23/03/16 11:59, Marcus Larsson wrote: Hi Stefan, On 03/23/2016 11:00 AM, Stefan Karlsson wrote: Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi, Please review the following patch to fix

Re: RFR: 8151438: UL instantiates duplicate tag sets

Thanks for reviewing, Bengt! Marcus On 03/23/2016 01:36 PM, Bengt Rutisson wrote: Hi Marcus, Looks good to me. Thanks, Bengt On 2016-03-23 11:59, Marcus Larsson wrote: Hi Stefan, On 03/23/2016 11:00 AM, Stefan Karlsson wrote: Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi

Re: RFR: 8151438: UL instantiates duplicate tag sets

Hi Stefan, On 03/23/2016 11:00 AM, Stefan Karlsson wrote: Hi Marcus, On 2016-03-23 10:23, Marcus Larsson wrote: Hi, Please review the following patch to fix the issue where duplicate tagsets are created for the same logical tagset. The code that emulates the variadic template arguments

Re: RFR: 8152538: UL doesn't inline the LogTagSet::is_level check

Hi Stefan, On 03/23/2016 11:28 AM, Stefan Karlsson wrote: Hi all, Please, review this patch to optimize the log_is_enabled check in the Unified Logging framework. http://cr.openjdk.java.net/~stefank/8152538/webrev.01/ Looks good, thanks for fixing this! Marcus

PING: Re: RFR: 8150823: UL handles disabling logs incorrectly

On 03/18/2016 12:25 PM, Marcus Larsson wrote: Hi, Updated the patch after offline discussion. New patch attempts to normalize the output name before searching for it or adding it. This includes adding the implicit file= prefix if missing, and/or removing quotes from a quoted name. Webrev

RFR: 8151438: UL instantiates duplicate tag sets

Hi, Please review the following patch to fix the issue where duplicate tagsets are created for the same logical tagset. The code that emulates the variadic template arguments assumes that _NO_TAG terminates the sequence of tags. If other tags (other than _NO_TAG) follow a terminating tag,

Re: RFR: 8146879: Add option for handling existing log files in UL

Thanks for reviewing, Robbin! Marcus On 03/22/2016 03:24 PM, Robbin Ehn wrote: Hi Marcus, On 03/18/2016 02:04 PM, Marcus Larsson wrote: Updated patch after feedback. New webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.04/ Incremental: http://cr.openjdk.java.net/~mlarsson

Re: RFR: 8150823: UL handles disabling logs incorrectly

Thanks for reviewing, Robbin! Marcus On 03/21/2016 02:36 PM, Robbin Ehn wrote: Hi Marcus On 03/18/2016 12:25 PM, Marcus Larsson wrote: Hi, Updated the patch after offline discussion. New patch attempts to normalize the output name before searching for it or adding it. This includes adding

Re: RFR: 8150823: UL handles disabling logs incorrectly

/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8150823/webrev.00-01/ Tested with serviceability/logging tests through RBT. Thanks, Marcus On 03/11/2016 03:40 PM, Marcus Larsson wrote: Hi, Please review the following patch to fix a problem with disabling log outputs using

Re: RFR: 8146879: Add option for handling existing log files in UL

. Thanks, Marcus On 03/11/2016 03:21 PM, Marcus Larsson wrote: Third time's the charm. Webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.03/ This patch makes log file rotation the default. Default thresholds are 5 rotated files with a target size of 20MiB. Truncating behavior can

Re: RFR: 8146879: Add option for handling existing log files in UL

arcus On Mar 11, 2016, at 8:21 AM, Marcus Larsson <marcus.lars...@oracle.com> wrote: Third time's the charm. Webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.03/ This patch makes log file rotation the default. Default thresholds are 5 rotated files with a target size o

Re: RFR: 8146879: Add option for handling existing log files in UL

want to add a bunch of unused functionality for this so I kept it simple. If we need ctime or atime at a later point I think we should just refactor this or add it separately. On 03/11/2016 03:21 PM, Marcus Larsson wrote: Third time's the charm. Webrev: http://cr.openjdk.java.net/~mlarsson

Re: RFR: 8146879: Add option for handling existing log files in UL

startup and I would expect most people to use around 10 files. Also please check full log file name against MAX_PATH constant. Is it really necessary? Won't fopen() just fail and return the appropriate error for this? Thanks, Marcus -Dmitry On 2016-03-11 17:39, Marcus Larsson wrote

Re: RFR: 8146879: Add option for handling existing log files in UL

Hi, On 2016-03-11 15:35, Bengt Rutisson wrote: Hi Marcus, On 2016-03-11 15:21, Marcus Larsson wrote: Third time's the charm. Webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.03/ I had a quick look at the code changes. It is not really my area of the code, so I'll leave

RFR: 8150823: UL handles disabling logs incorrectly

Hi, Please review the following patch to fix a problem with disabling log outputs using -Xlog:disable or disable_logging() when there are multiple file outputs configured. The patch also resolves an issue with log file lookups that could cause multiple outputs to be created for the same log

Re: RFR: 8146879: Add option for handling existing log files in UL

, Marcus On 2016-03-01 15:05, Marcus Larsson wrote: Hi, After some offline discussions I'm withdrawing this patch. I will instead investigate if I can achieve similar behavior using log rotation as the default. Thanks, Marcus On 03/01/2016 12:11 PM, Marcus Larsson wrote: Hi again, Taking

Re: RFR: 8146879: Add option for handling existing log files in UL

print a reason of fail (os error) -Dmitry On 2016-03-01 14:11, Marcus Larsson wrote: Hi again, Taking a different approach to this. New webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.01/ Existing files will now by default be renamed/archived with a .X suffix where X is the lowest

Re: RFR: 8146879: Add option for handling existing log files in UL

Hi, After some offline discussions I'm withdrawing this patch. I will instead investigate if I can achieve similar behavior using log rotation as the default. Thanks, Marcus On 03/01/2016 12:11 PM, Marcus Larsson wrote: Hi again, Taking a different approach to this. New webrev: http

Re: RFR: 8146879: Add option for handling existing log files in UL (was: Truncate new UL log files)

). A mode option for controlling this behavior has been added as well. It can be set to archive, append, or truncate (i.e. -Xlog::jvm.log::mode=truncate). Tested with included jtreg test through JPRT. Thanks, Marcus On 01/14/2016 04:00 PM, Marcus Larsson wrote: Hi, Please review the following

Re: RFR(s): 8150026: Add the ability to log with variable log level

Hi Robbin, On 02/18/2016 08:37 PM, Robbin Ehn wrote: Hi, please review. This adds a write method to the UL log which takes the level as parameter. JBS: https://bugs.openjdk.java.net/browse/JDK-8150026 Webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8150026/ Looks good, thanks for fixing

[PING] Re: RFR (S): 8149112: configure_stdout test depends on VM arguments

On 02/05/2016 01:07 PM, Marcus Larsson wrote: Hi, Please review the following patch to make the configure_stdout internalvmtest independent on VM arguments for UL. Without this fix the test fails if run while logging to a file (-Xlog::somefile). Webrev: http://cr.openjdk.java.net/~mlarsson

RFR (S): 8149112: configure_stdout test depends on VM arguments

Hi, Please review the following patch to make the configure_stdout internalvmtest independent on VM arguments for UL. Without this fix the test fails if run while logging to a file (-Xlog::somefile). Webrev: http://cr.openjdk.java.net/~mlarsson/8149112/webrev.00/ Issue:

Re: RFR(xs): 8144916: Decrease PerfDataMemorySize back to 32K

Hi Robbin, On 02/03/2016 04:55 PM, Robbin Ehn wrote: Hi, please review. This sets PerfDataMemorySize back to 32k and removes "-XX:PerfDataMemorySize=64k" in PrologSizeSanityCheck test. Bug: https://bugs.openjdk.java.net/browse/JDK-8144916 Webrev: http://cr.openjdk.java.net/~redestad/8144916

Re: RFR: 8147348: LogTagLevelExpression not properly initialized in configure_stdout

Thanks Staffan! Marcus On 01/27/2016 08:56 AM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 21 jan. 2016, at 11:42, Marcus Larsson <marcus.lars...@oracle.com> wrote: Hi, Please review the following patch to fix an initialization error in LogTagLevelExpression. If not

Re: RFR(xs): 8148053: Remove unused log tags

Hi Robbin, On 01/22/2016 04:00 PM, Robbin Ehn wrote: Hi, Please review, this removes unused tags in UL. Testing: Passed RBT build Bug: https://bugs.openjdk.java.net/browse/JDK-8148053 Webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8148053/ Looks good to me! Marcus Thanks and thanks

RFR: 8147348: LogTagLevelExpression not properly initialized in configure_stdout

Hi, Please review the following patch to fix an initialization error in LogTagLevelExpression. If not using the parse() method (as is the case in LogConfiguration::configure_stdout) instances of the class would not be properly initialized. The clear() method has been removed and the

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

Sorry, wrong link to incremental webrev. Look here instead: http://cr.openjdk.java.net/~mlarsson/8146009/webrev.00-01/ On 01/21/2016 01:30 PM, Marcus Larsson wrote: Updated webrev: http://cr.openjdk.java.net/~mlarsson/8146009/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson

Re: RFR: 8147348: LogTagLevelExpression not properly initialized in configure_stdout

Thanks for reviewing Bengt! On 01/21/2016 02:05 PM, Bengt Rutisson wrote: Hi Marcus, On 2016-01-21 11:42, Marcus Larsson wrote: Hi, Please review the following patch to fix an initialization error in LogTagLevelExpression. If not using the parse() method (as is the case

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

to prevent usages from other places. Also removed the previous output instances from LogFileStream.{c,h}pp which I forgot to do in the first patch. Thanks, Marcus On 01/19/2016 02:58 PM, Marcus Larsson wrote: Hi, Please review the following patch to fix an issue in UL causing the VM to crash

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

Hi Kim, On 01/19/2016 08:25 PM, Kim Barrett wrote: On Jan 19, 2016, at 8:58 AM, Marcus Larsson <marcus.lars...@oracle.com> wrote: Hi, Please review the following patch to fix an issue in UL causing the VM to crash during shutdown. The problem is that the static LogStdout

RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

Hi, Please review the following patch to fix an issue in UL causing the VM to crash during shutdown. The problem is that the static LogStdoutOutput is deinitialized before the last use of it (G1 concurrent thread tries to log very late during VM shutdown). The solution is to make sure

Re: RFR: 8146879: Truncate new UL log files

Hi Dmitry, On 01/15/2016 08:52 AM, Marcus Larsson wrote: On 01/14/2016 04:28 PM, Dmitry Samersoff wrote: Marcus, fopen(name, "wa+") truncate file before open it in append mode. Ah, didn't know you could do that. If it works that would be much better, I'll give it a shot. Unf

Re: RFR: 8146879: Truncate new UL log files

12:27, Bengt Rutisson wrote: On 2016-01-14 23:43, Kim Barrett wrote: On Jan 14, 2016, at 10:00 AM, Marcus Larsson <marcus.lars...@oracle.com> wrote: Hi, Please review the following patch to make sure UL truncates existing log files before writing to them. Since files are opened in appen

Re: RFR: 8146879: Truncate new UL log files

Hi, On 01/14/2016 09:36 PM, e...@zusammenkunft.net wrote: Hello, Especially for the GC log it is bad if the file is lost after a restart. It is of course possible to include PID or timestamp into the logfile, and then the truncation is no option, however if you do that you have to do your

Re: RFR: 8146879: Truncate new UL log files

On 01/14/2016 04:28 PM, Dmitry Samersoff wrote: Marcus, fopen(name, "wa+") truncate file before open it in append mode. Ah, didn't know you could do that. If it works that would be much better, I'll give it a shot. Thanks, Marcus -Dmitry On 2016-01-14 18:00, Marcus Larsson

RFR: 8146879: Truncate new UL log files

Hi, Please review the following patch to make sure UL truncates existing log files before writing to them. Since files are opened in append mode, truncation isn't done automatically, so instead the patch adds an attempt to remove the log file before opening it. Webrev:

RFR (XS): 8147079: Add serviceability/logging folder to hotspot_serviceability test group

Hi, Please review the following patch to add the serviceability/logging folder to the hotspot_serviceability test group. This will include the UL tests for JPRT runs. Webrev: http://cr.openjdk.java.net/~mlarsson/8147079/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8147079

Re: PING: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

Hi Markus, Looks good! Thanks, Marcus On 01/12/2016 10:34 AM, Markus Gronlund wrote: Thanks David and Yasumasa, I will then proceed with checking in my suggestion. Thanks again Markus -Original Message- From: Yasumasa Suenaga [mailto:yasue...@gmail.com] Sent: den 11 januari 2016

[PING] Re: RFR: 8145294: TestLogRotation.java triggers a race in the UL framework

On 2015-12-16 09:46, Marcus Larsson wrote: Hi, Please review the following patch to fix a race in file rotations with UL. Summary: freopen and fwrite are not safe to use concurrently and hence the VM might crash if a thread tries to write during a rotation. Writing and rotating needs

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, On 2015-12-17 09:41, Bengt Rutisson wrote: On 2015-12-16 22:43, Coleen Phillimore wrote: On 12/16/15 4:01 PM, John Rose wrote: On Dec 15, 2015, at 12:26 PM, Rachel Protacio wrote: - each incident of ttyLocker that involved separate logging lines for the

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

Thanks for reviewing, Kim! On 2015-12-16 18:07, Kim Barrett wrote: On Dec 15, 2015, at 10:12 AM, Marcus Larsson <marcus.lars...@oracle.com> wrote: I think it's worth another round. :) New webrev: http://cr.openjdk.java.net/~mlarsson/8145083/webrev.04/ Incremental: http://cr.openjdk.ja

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

Thanks for reviewing, David! On 2015-12-17 06:34, David Holmes wrote: Looks good! Thanks, David On 16/12/2015 1:12 AM, Marcus Larsson wrote: Hey Markus, On 2015-12-15 11:58, Markus Gronlund wrote: Hi Marcus, Looks good! One minor thing that you don't need to fix if you don't want to: I

RFR: 8145294: TestLogRotation.java triggers a race in the UL framework

Hi, Please review the following patch to fix a race in file rotations with UL. Summary: freopen and fwrite are not safe to use concurrently and hence the VM might crash if a thread tries to write during a rotation. Writing and rotating needs to be properly synchronized, but using a Mutex is

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

Hi Kim, On 2015-12-15 02:17, Kim Barrett wrote: On Dec 14, 2015, at 9:53 AM, Marcus Larsson <marcus.lars...@oracle.com> wrote: Hi, New webrev: http://cr.openjdk.java.net/~mlarsson/8145083/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8145083/webrev.00-01/ One min

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

or looking at this! Marcus Thanks Markus -Original Message----- From: Marcus Larsson Sent: den 14 december 2015 16:31 To: serviceability-dev@openjdk.java.net Cc: hotspot-runtime-...@openjdk.java.net Subject: Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging con

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

into the ConfigurationLock; added a function to check if current thread has the lock when asserts are enabled. Regards, Marcus On 2015-12-14 16:30, Marcus Larsson wrote: Hi again, Made some changes to the patch after feedback from Markus Grönlund. The ConfigurationLocker and the semaphore have

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

: http://cr.openjdk.java.net/~mlarsson/8145083/webrev.03-04/ Thanks, Marcus Good work! /Markus -Original Message- From: Marcus Larsson Sent: den 15 december 2015 11:25 To: serviceability-dev@openjdk.java.net Cc: hotspot-runtime-...@openjdk.java.net Subject: Re: RFR: 8145083: Use

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

On 2015-12-15 16:13, Markus Gronlund wrote: Looks good, thanks again for doing all of this. Great, thanks for reviewing! Marcus I will be quiet now :-) /Markus -Original Message- From: Marcus Larsson Sent: den 15 december 2015 16:13 To: Markus Gronlund Cc: hotspot-runtime

RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

Hi, Please review the following patch to use a semaphore instead of a mutex for the synchronization of log configuration. Using a mutex requires some parts of the VM to be initialized, whereas the semaphores can be used right from the start. This simplifies the code and allows very early log

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

the LogConfiguration interface and hides the details of the locking under the hood. New webrev: http://cr.openjdk.java.net/~mlarsson/8145083/webrev.02/ Incremental: http://cr.openjdk.java.net/~mlarsson/8145083/webrev.01-02/ Thanks, Marcus On 2015-12-14 15:53, Marcus Larsson wrote: Hi, New webrev

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

Hi David, On 2015-12-14 13:53, David Holmes wrote: Hi Marcus, Looks good! Thanks! On 14/12/2015 8:13 PM, Marcus Larsson wrote: Hi, Please review the following patch to use a semaphore instead of a mutex for the synchronization of log configuration. Using a mutex requires some parts

Re: RFR: 8145083: Use semaphore instead of mutex for synchronization of Unified Logging configuration

sed inside configure_output, which now ensures that the lock is held. Thanks, Marcus On 2015-12-14 11:13, Marcus Larsson wrote: Hi, Please review the following patch to use a semaphore instead of a mutex for the synchronization of log configuration. Using a mutex requires some parts of the VM to be i

Re: [PING] RFR: 8144220: UL does not support full path names for log files on windows

Thanks Staffan! On 2015-12-11 13:58, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 11 dec. 2015, at 13:49, Marcus Larsson <marcus.lars...@oracle.com> wrote: Need another review for this. On 2015-12-03 11:11, Marcus Larsson wrote: Hi, New webrev: http://cr.openjdk.ja

Re: [PING] Re: RFR: 8144220: UL does not support full path names for log files on windows

Thanks Markus! On 2015-12-11 14:32, Markus Gronlund wrote: Hi Marcus, This looks good. Thanks Markus -Original Message- From: Marcus Larsson Sent: den 11 december 2015 13:49 To: serviceability-dev@openjdk.java.net Subject: [PING] Re: RFR: 8144220: UL does not support full path names

[PING] Re: RFR: 8144220: UL does not support full path names for log files on windows

Need another review for this. On 2015-12-03 11:11, Marcus Larsson wrote: Hi, New webrev: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00-01/ Added more test cases to the test, and renamed it to TestQuotedLogOutputs

Re: RFR: 8144146: Unified Logging tags cannot be reserved keywords

Thanks Staffan! Marcus On 2015-12-07 15:43, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 4 dec. 2015, at 15:46, Marcus Larsson <marcus.lars...@oracle.com> wrote: Hi, Please review the following patch to allow C++ reserved keywords to be used as UL tags. This allows

Re: RFR: 8144146: Unified Logging tags cannot be reserved keywords

On 2015-12-07 12:16, David Holmes wrote: On 7/12/2015 5:58 PM, Marcus Larsson wrote: Hi David, On 2015-12-07 07:26, David Holmes wrote: Hi Marcus, On 5/12/2015 12:46 AM, Marcus Larsson wrote: Hi, Please review the following patch to allow C++ reserved keywords to be used as UL tags

Re: RFR: 8144146: Unified Logging tags cannot be reserved keywords

Hi David, On 2015-12-07 07:26, David Holmes wrote: Hi Marcus, On 5/12/2015 12:46 AM, Marcus Larsson wrote: Hi, Please review the following patch to allow C++ reserved keywords to be used as UL tags. This allows usage of a 'class' tag, for example. Tags are now automatically prefixed

RFR: 8144146: Unified Logging tags cannot be reserved keywords

Hi, Please review the following patch to allow C++ reserved keywords to be used as UL tags. This allows usage of a 'class' tag, for example. Tags are now automatically prefixed with underscores by the macros. This means they will still be referred to without underscores when used, but avoid

Re: RFR: 8144220: UL does not support full path names for log files on windows

Hi, On 2015-12-03 13:32, Bengt Rutisson wrote: Hi Marcus, On 2015-12-03 11:11, Marcus Larsson wrote: Hi, New webrev: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00-01/ Looks good. One small detail: I think

Re: PING: RFR: JDK-8140556: Add force rotation option to VM.log jcmd

openjdk.java.net/%7Eysuenaga/JDK-8140556/webrev.04/> >> >> I will send changeset to Marcus if this changeset is reviewed. >> >> >> Thanks. >> >> Yasumasa >> >> >> On 2015/11/05 23:38, Marcus Larsson wrote: >>> >>> Hey,

Re: RFR: 8144220: UL does not support full path names for log files on windows

Hi Bengt, Thanks for looking at this. On 2015-12-02 14:59, Bengt Rutisson wrote: Hi Marcus, On 2015-12-02 14:41, Marcus Larsson wrote: Hi, Please review the following patch to allow full path names for log files on windows. The full path to files will on windows contain a colon (from

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Thanks, David On 27/11/2015 1:17 AM, Marcus Larsson wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00-01/ Changes: * LogLevel::Unchanged was changed t

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

at FormatBuffers for the string handling in LogOutput, but unfortunately they are sized according to template parameters and hence don't play well with the dynamic expansion required here. Thanks Marcus On 2015-11-24 11:46, Marcus Larsson wrote: Hi, Please review the following patch to enable

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Thanks for reviewing, Bengt! Marcus On 2015-11-26 16:25, Bengt Rutisson wrote: Hi Marcus, On 2015-11-26 16:17, Marcus Larsson wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental: http://cr.openjdk.java.net

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

Thanks for reviewing, Staffan! Marcus On 2015-11-26 16:54, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 26 nov. 2015, at 16:17, Marcus Larsson <marcus.lars...@oracle.com> wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~ml

RFR: 8142979: Add programmatic enable/disable methods to Unified Logging

Hi, Please review the following patch adding support for configuration of the stdout unified logging output from within the VM itself. The patch adds the configure_stdout() function, allowing a set of tags to be set to the given level on stdout. To disable logging the level is simply

  1   2   >