Hi Erik,
Looks good.
Thanks
Markus
-Original Message-
From: Erik Gahlin
Sent: den 18 oktober 2017 22:05
To: David Holmes; serviceability-dev@openjdk.java.net
Subject: Re: RFR(S): 8189425: Minor updates in support of closed changes
Hi David,
> Hi Erik,
>
> On 18/10/2017 12:23 PM, Erik
Hi Robin,
Looks good, thanks for adding this information to the event.
Cheers
Markus
-Original Message-
From: Robin Westberg
Sent: den 25 oktober 2017 15:52
To: serviceability-dev@openjdk.java.net
Subject: RFR(S): 8189368: Add information on current bias holder for
BiasedLockRevocation
Hi Erik,
Looks good, thanks for fixing.
Markus
-Original Message-
From: Erik Gahlin
Sent: den 30 november 2017 22:37
To: serviceability-dev@openjdk.java.net
Subject: RFR (XS): 8179083: Uninitialized notifier in Java Monitor Wait tracing
event
Hi,
Could I have fix of this small change
Hi David,
Looks good.
Thanks
Markus
-Original Message-
From: David Buck
Sent: den 19 december 2017 09:17
To: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: [8u] RFR(S) 8031304 : Add dcmd to print all loaded dynamic libraries
Hi!
Please review this s
Hi Leo,
Looks good, thanks for doing this.
Sorry for the delay.
Cheers
Markus
-Original Message-
From: Leo Korinth
Sent: den 13 februari 2018 12:26
To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net
Subject: Re: RFR: 8196337 Add commit methods that take all e
Hi Thomas,
Are you running in two separate Terminal Server Sessions?
You need to be in the same WindowsStation
https://msdn.microsoft.com/en-us/library/windows/desktop/ms687096(v=vs.85).aspx
HTH
Markus
From: Thomas Stüfe [mailto:thomas.stu...@gmail.com]
Sent: den 9 april 2018 1
Hi Poonam,
Looks good, thanks for backporting this.
Cheers
Markus
From: Poonam Bajaj Parhar
Sent: den 2 februari 2015 21:24
To: serviceability-dev@openjdk.java.net
Subject: Re: Review request: Backport of JDK-8046282 to 8u
Hello,
Could I have reviews for these backported changes,
Hi Dan,
I have taken a look with your suggested patch – I think your suggestion looks
very good.
I guess the original hang happened because the PeriodicTask_lock was attempted
to be acquired by a JavaThread, but the PeriodicTask_lock was still held by
someone else. Since the PeriodicTask
.
I will try some experiments, so Dan please go ahead with what you already have.
Cheers
Markus
From: Markus Gronlund
Sent: den 24 februari 2015 16:13
To: Daniel Daugherty
Cc: Alexander Garthwaite; Rickard Bäckman; David Holmes; Coleen Phillimore;
hotspot-runtime-...@
Thanks again Dan,
Added some comments, pls see below.
/Markus
From: Daniel D. Daugherty
Sent: den 24 februari 2015 22:26
To: Markus Gronlund
Cc: Alexander Garthwaite; Rickard Bäckman; David Holmes; Coleen Phillimore;
hotspot-runtime-...@openjdk.java.net; serviceability-dev
Thumbs up!
Thanks
Markus
-Original Message-
From: Daniel D. Daugherty
Sent: den 25 februari 2015 18:00
To: Alexander Garthwaite; Carsten Varming; Rickard Bäckman; David Holmes;
Markus Grönlund; Coleen Phillimore
Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.n
Hi Igor,
In trace.xml:
404
405
406
407
You don't need to write an individual UTF8 string for every class, method and
desc as we have "intrinsics" for taking care of this for you.
This also means you wouldn't need to create a separate struct, as you can just
.
/Markus
-Original Message-
From: Igor Ignatyev
Sent: den 27 februari 2015 11:30
To: Markus Gronlund
Cc: hotspot-compiler-...@openjdk.java.net compiler;
serviceability-dev@openjdk.java.net
Subject: Re: RFR (S) : 8073607 : add trace events for inlining
Hi Markus,
thank you for your review
Greetings,
Kindly asking for reviews for the following changeset:
Bug: https://bugs.openjdk.java.net/browse/JDK-8073042
Webrev: http://cr.openjdk.java.net/~mgronlun/8073042/webrev01/
Description:
The signaling mechanism used to communicate about attaching operations under
Windows c
Hi Dmitry,
Thanks for taking a look.
Also thanks for the hint about using a guarantee instead of an assert - you are
right, I will change it accordingly.
Cheers
Markus
-Original Message-
From: Dmitry Samersoff
Sent: den 2 mars 2015 14:52
To: Markus Gronlund; serviceability-dev
3042: jcmd hangs until another jcmd is executed (which,
in turn, also hangs) (on Windows)
Hi Markus,
On 2.3.2015 13:34, Markus Gronlund wrote:
> Greetings,
>
> Kindly asking for reviews for the following changeset:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK
gleObject() return
immediately decrementing the current count.
Thanks
Markus
-Original Message-
From: Dean Long
Sent: den 3 mars 2015 02:32
To: Markus Gronlund; serviceability-dev@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR(S): 8073042: jcmd hangs unt
Greetings,
Please review this small update to the Visual Studio projectcreator.make in
order to exclude aarch64 files.
Bug: https://bugs.openjdk.java.net/browse/JDK-8074905
Webrev: http://cr.openjdk.java.net/~mgronlun/8074905/webrev01/
Thanks
Markus
HI Igor,
Looks good!
Thanks
Markus
-Original Message-
From: Igor Ignatyev
Sent: den 10 mars 2015 17:41
To: Markus Gronlund; erik.gah...@oracle.com >> Erik Gahlin
Cc: hotspot-compiler-...@openjdk.java.net compiler;
serviceability-dev@openjdk.java.net
Subject: Re: RFR (S) : 8
Looks good!
Thanks
Markus
-Original Message-
From: Staffan Larsen
Sent: den 24 april 2015 11:09
To: Stefan Karlsson
Cc: Serviceability Dev
Subject: Re: RFR: 8078601: print_concurrent_locks should be guarded with
INCLUDE_SERVICES
Looks good!
Thanks,
/Staffan
> On 24 apr 2015, at 16:41
Looks good.
/Markus
-Original Message-
From: Staffan Larsen
Sent: den 27 maj 2015 12:47
To: serviceability-dev
Subject: RFR: 8081292 sun/tools/jmap/BasicJMapTest.java timed out
The test sometimes does not complete in the default timeout so I’m doubling it.
Thanks,
/Staffan
diff --git
Looks good.
/Markus
From: Staffan Larsen
Sent: den 28 maj 2015 12:38
To: serviceability-dev
Subject: RFR: 8080928 Uninitialised variable in
hotspot/src/share/vm/prims/jvmtiEnvBase.cpp
Please review this simple fix for an uninitialized variable.
webrev:
http://cr.openjdk.java.net/
Hi David,
This looks good - thanks for fixing this issue!
/Markus
-Original Message-
From: david buck
Sent: den 17 augusti 2015 13:24
To: serviceability-dev@openjdk.java.net
Subject: RFR 8133666: OperatingSystemMXBean reports abnormally high machine CPU
consumption on Linux
Hi!
Pleas
Hi Bengt,
Looks good - thanks for fixing.
One small thing:
I think we can drop the return (double) cast on line 55, no need for updated
webrevs.
Thanks
Markus
-Original Message-
From: Bengt Rutisson
Sent: den 23 oktober 2015 10:27
To: serviceability-dev@openjdk.java.net serviceabilit
Hi Goetz,
Thanks for suggesting these fixes.
Also thanks for pointing to the issue with _NSIG and MAXSIGNUM - looks like
MAXSIGNUM is defined all over the place (platform specific + platform specific
jsig's)...
I also think it makes perfect sense to bound the signals to the dimensions of
the
Greetings,
Kindly asking for reviews for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8143226
Webrev:
http://cr.openjdk.java.net/~mgronlun/8143226/webrev01/
Summary:
- Remove obsoleted files from make system
- Consolidate to a single Thread abstraction
- Expand
Ping!!
Could I please ask (kindly) for reviews on this?
Thanks in advance
Markus
-Original Message-
From: Markus Gronlund
Sent: den 12 november 2015 13:08
To: hotspot-runtime-...@openjdk.java.net; serviceability-...@openjdk.net
Subject: RE: RFR(L): 8140485: Class load and creation
Greetings,
Kindly asking for reviews for the following:
Bug:
https://bugs.openjdk.java.net/browse/JDK-8143235
Summary:
Remove libjfr mapfile (cleanup) + adds "jdk.management.jfr" to boot modules
Patch is attached and also unrolled here:
# HG changeset patch
# User mg
Greetings,
Looking for review of the following to update module exports for Java Flight
Recorder:
Bug: https://bugs.openjdk.java.net/browse/JDK-8143228
Change:
Patch is attached and also unrolled here:
# HG changeset patch
# User mgronlun
# Date 1447764614 -3600
# Tue N
Thank you Alan.
I agree on coming up with a evolution path here. Thanks for now.
/Markus
-Original Message-
From: Alan Bateman
Sent: den 18 november 2015 20:25
To: Markus Gronlund; jigsaw-...@openjdk.java.net; serviceability-dev
Subject: Re: RFR(XS): 8143228: Update module exports for
these functions static and internal
in CFP.
Coleen
On 11/12/15 7:08 AM, Markus Gronlund wrote:
> Hi again,
>
> I have reworked and simplified this clean up/refactoring suggestion:
>
> Updated high-level description:
> http://cr.openjdk.java.net/~mgronlun/8140485/unified
n summary comment in
klassFactory.hpp - thanks.
Updated webrev:
http://cr.openjdk.java.net/~mgronlun/8140485/unified/unified_review/webrev04/
Thanks again for your help
Markus
From: Serguei Spitsyn
Sent: den 24 november 2015 13:42
To: Markus Gronlund
Cc: serviceability-
Thanks! Harold
On 11/20/2015 1:27 PM, Markus Gronlund wrote:
> Hi Coleen,
>
> Many, many thanks for taking on this large change.
>
> Thanks for the feedback, I have updated like this:
>
> ClassFactory::create(...) -> KlassFactory::create_from_stream(...)
>
> /
Hi Marcus,
This looks good.
Thanks
Markus
-Original Message-
From: Marcus Larsson
Sent: den 11 december 2015 13:49
To: serviceability-dev@openjdk.java.net
Subject: [PING] Re: RFR: 8144220: UL does not support full path names for log
files on windows
Need another review for this.
On 2
Hi Marcus,
Thanks for updating the patch.
I think you could also move the lock representation, i.e the Semaphore to
become a (static) field inside the ConfigurationLocker class - this since you
want all entry/exits to go through instances of this object.
I know that the other MutexLocker's don
Hi Marcus,
Looks good!
One minor thing that you don't need to fix if you don't want to:
I would use:
class ConfigurationLock {
...
debug_only(static bool current_thread_has_lock();)
};
to declare the this function in the class, then I would move the definition
outside of it (since it's si
Looks good, thanks again for doing all of this.
I will be quiet now :-)
/Markus
-Original Message-
From: Marcus Larsson
Sent: den 15 december 2015 16:13
To: Markus Gronlund
Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net
Subject: Re: RFR: 8145083: Use
Hi Marcus,
Looks good, thanks for fixing.
As we spoke out-of-band, post this fix, lets figure a way of how to generalize
this with some kind of SemaphoreAcquireRelease utility.
/Markus
-Original Message-
From: Marcus Larsson
Sent: den 16 december 2015 09:46
To: serviceability-dev@open
Hi Yasumasa,
Apologies for the delay in getting a response to you.
Thanks for reporting and attempting to fix this issue.
I have investigated this a bit as well as trying out your suggested patch.
I must admit it is hard to get this right at this early stage of the VM, and
though I appreciated
). This is
accomplished by checking the availability of both ttyLock as well as
Thread::current_or_null().
Cheers
Markus
-Original Message-
From: David Holmes
Sent: den 11 januari 2016 02:39
To: Markus Gronlund; Yasumasa Suenaga
Cc: serviceability-dev@openjdk.java.net
Subject: Re: PING
Thanks David and Yasumasa,
I will then proceed with checking in my suggestion.
Thanks again
Markus
-Original Message-
From: Yasumasa Suenaga [mailto:yasue...@gmail.com]
Sent: den 11 januari 2016 11:09
To: Markus Gronlund; David Holmes
Cc: serviceability-dev@openjdk.java.net
Subject: Re
Thanks Marcus for taking a look.
/Markus
-Original Message-
From: Marcus Larsson
Sent: den 12 januari 2016 15:29
To: Markus Gronlund; Yasumasa Suenaga; David Holmes
Cc: serviceability-dev@openjdk.java.net
Subject: Re: PING: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing
Hi
Greetings,
Please review this small change in order to allow for the Event-based tracing
framework to trace the creation of Klass'es.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8147442
Webrev:
http://cr.openjdk.java.net/~mgronlun/8147442/webrev01/
Thanks
Markus
Greetings,
I just made a mistake when integrating 8149025, where test code was imported
and applied to the wrong repo.
I would need to back that out:
Webrev: https://bugs.openjdk.java.net/browse/JDK-8149062
Change:
8149062: Remove misplaced integration of test code after 81490
Greetings,
Please review this small change lowering the lock rankings of some locks.
This is done in order to reduce the risk for potential deadlocks and to
increase the surface area for event generation.
Bug: https://bugs.openjdk.java.net/browse/JDK-8149803
Patch of this tiny cha
her states as well.
Thanks for your feedback
Markus
-Original Message-
From: David Holmes
Sent: den 22 februari 2016 02:10
To: Markus Gronlund; serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8149803: Adjust lock rankings for some Event-based
tracing locks
Hi Markus,
Looks good!
/Markus
-Original Message-
From: David Holmes
Sent: den 24 februari 2016 08:03
To: hotspot-dev developers; serviceability-dev
Subject: (S) RFR: 8150506: Remove unused locks
I stumbled across the fact that the following locks are no longer being used in
the VM:
Runtime:
-
Greetings,
Could a please ask for reviews for the following simple fix to resolve a test
issue associated with com/sun/jdi/StepTest.java
Bug: https://bugs.openjdk.java.net/browse/JDK-8151053
Comment:
Need to filter out some classes that has moved to another package
Patch is attach
Thank you Dan!
/Markus
From: Daniel D. Daugherty
Sent: den 2 mars 2016 21:25
To: Markus Gronlund; serviceability-dev
Subject: Re: RFR(XXS): 8151053: com/sun/jdi/StepTest.java fails in 2016-03-01
JDK9-hs-rt nightly
On 3/2/16 12:49 PM, Markus Gronlund wrote:
Greetings,
Could a
Thanks you Erik!
Markus
From: Erik Gahlin
Sent: den 2 mars 2016 21:30
To: serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8151053: com/sun/jdi/StepTest.java fails in 2016-03-01
JDK9-hs-rt nightly
Looks good. Not a reviewer.
Erik
On 2016-03-02 20:49, Markus Gronlund wrote
Hi Erik,
I think this looks good.
Thanks for fixing.
Markus
-Original Message-
From: Erik Gahlin
Sent: den 2 mars 2016 23:08
To: serviceability-dev@openjdk.java.net
Subject: RFR(XS) serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java
failing because expects HPROF JAVA PROFILE 1.0
Greetings,
Could a please ask for reviews for the following simple fix to resolve a test
issue associated with test/java/lang/instrument/NativeMethodPrefixAgent.java
Bug: https://bugs.openjdk.java.net/browse/JDK-8151100
Webrev/diff:
diff --git a/test/java/lang/instrument/NativeMet
Thank you Serguei!
Markus
From: Serguei Spitsyn
Sent: den 3 mars 2016 10:18
To: Markus Gronlund; serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8151100: Test
java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do
CheckIntrinsics
Hi Markus,
The fix
Thanks Dmitry for noticing this - I am running slowdebug so I didn't see that.
Thanks again.
Markus
From: Dmitry Dmitriev
Sent: den 3 mars 2016 12:23
To: Markus Gronlund; serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8151100: Test
java/lang/instr
Thanks Erik!
Markus
From: Erik Gahlin
Sent: den 18 mars 2016 00:39
To: serviceability-dev@openjdk.java.net
Subject: Re: RFR(XS): 8152119: Event-based tracing to allow for tracing Klass
definition
Looks good. Not a reviewer.
Erik
On 2016-03-17 19:43, Markus Gronlund wrote
Greetings,
Kindly asking for reviews for the following change to allow for tracing Klass
definitions.
Bug: https://bugs.openjdk.java.net/browse/JDK-8152119
Webrev: http://cr.openjdk.java.net/~mgronlun/8152119/webrev01/
This change complements the change associated with Klass creat
;classfile/sharedClassUtil.hpp"
#include "classfile/systemDictionaryShared.hpp"
#endif
#if INCLUDE_JVMCI
#include "jvmci/jvmciRuntime.hpp"
#endif
#if INCLUDE_TRACE
#include "trace/tracing.hpp"
#endif
Thanks again
Markus
-Original Message-
From: David Holmes
Greetings,
Please review this small fix:
Bug: https://bugs.openjdk.java.net/browse/JDK-8158033
Webrev: http://cr.openjdk.java.net/~mgronlun/8158033/webrev/
Description:
The intent when putting in the notify_tracing() hook into debug.cpp
(report_java_out_of_memory()) was to interc
Hi David,
Thanks for taking a look, pls see below.
Thanks again
Markus
-Original Message-
From: David Holmes
Sent: den 27 maj 2016 13:52
To: Markus Gronlund; serviceability-dev@openjdk.java.net
Subject: Re: RFR(XS): 8158033: notify_tracing() misplaced for intended purpose
Hi Markus
Greetings,
Please review this small fix to address some new issues seen in testing where
OOM is erroneously being reported:
Bug: https://bugs.openjdk.java.net/browse/JDK-8162945
Changeset:
# HG changeset patch
# User mgronlun
# Date 1470141649 -7200
# Tue Aug 02 14:40:49 2
Thanks Dan,
not too late at all - I agree with your suggestion and will update accordingly.
Thanks again
Markus
From: Daniel D. Daugherty
Sent: den 2 augusti 2016 18:29
To: Markus Gronlund; serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean
Thanks Erik!
Markus
From: Erik Gahlin
Sent: den 2 augusti 2016 15:33
To: serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously
reports OutOfMemory
Looks ok (not a reviewer)
Erik
On 2016-08-02 14:58, Markus Gronlund wrote
Thanks David!
Markus
-Original Message-
From: David Holmes
Sent: den 3 augusti 2016 04:09
To: Markus Gronlund; serviceability-dev@openjdk.java.net
Subject: Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously
reports OutOfMemory
Looks good. Sorry I missed this issue in
Hi Erik,
This looks good, thanks for cleaning this up.
Thanks
Markus
-Original Message-
From: Erik Gahlin
Sent: den 20 augusti 2016 20:49
To: serviceability-dev@openjdk.java.net
Subject: 8164523: Clean up metadata for event based tracing
Hi,
Could I have review of this fix to the even
Greetings,
Kindly asking for reviews for the following change:
Bug: http://bugs.openjdk.java.net/browse/JDK-8166806
Webrev: http://cr.openjdk.java.net/~mgronlun/8166806/webrev/
Thanks in advance
Markus
-
From: Vladimir Kozlov
Sent: den 28 september 2016 20:01
To: Markus Gronlund; serviceability-dev@openjdk.java.net;
hotspot-compiler-...@openjdk.java.net; Nils Eliasson
Subject: Re: RFR(XS): 8166806: Add intrinsic support for writer used in event
based tracing
Hi Markus,
Where _getBufferWriter
Greetings,
I recently integrated intrinsic support for event based tracing which was
tracked in JDK-8166806 (https://bugs.openjdk.java.net/browse/JDK-8166806 ).
Unfortunately, the changes for 8166806 led to issues seen in testing on SPARC
and AARCH64 platforms in that the intrinsic code was
Greetings,
Kindly asking for reviews for the following changeset:
Bug/Enh: https://bugs.openjdk.java.net/browse/JDK-8170672
Webrev: http://cr.openjdk.java.net/~mgronlun/8170672/webrev01/
(this work is covered by an FC exception)
Summary:
Event-based tracing previously had little inf
Thanks Erik!
Markus
From: Erik Gahlin
Sent: den 6 december 2016 21:53
To: serviceability-dev@openjdk.java.net
Subject: Re: RFR(S): 8170672: Event-based tracing to support classloader
instances
Looks good.
Erik
Greetings,
Kindly asking for reviews for the following changeset:
.
Thanks again
Markus
-Original Message-
From: Lois Foltan
Sent: den 6 december 2016 23:02
To: Markus Gronlund
Cc: hotspot-runtime-dev; serviceability-dev@openjdk.java.net
Subject: Re: RFR(S): 8170672: Event-based tracing to support classloader
instances
On 12/5/2016 6:33 PM, Markus
Greetings,
Kindly asking for reviews for the following fix:
Bug: https://bugs.openjdk.java.net/browse/JDK-8171960
Webrev: http://cr.openjdk.java.net/~mgronlun/8171960/webrev01/
Summary:
In order to fix a closed confidential bug, I would need to separate the flag
representation t
Hi Robin,
This looks good, thank you very much for adding this!
Cheers
Markus
From: Robin Westberg
Sent: den 6 oktober 2017 12:22
To: serviceability-dev@openjdk.java.net
Subject: RFR: 8187042: Events to show which objects are associated with biased
object revocations
Hi all,
Looks good Erik,
Thanks for adding this.
Markus
-Original Message-
From: Erik Gahlin
Sent: den 13 oktober 2017 17:11
To: serviceability-dev@openjdk.java.net
Subject: RFR(XS): 8189274: Allow cutoff attribute for event based tracing
Hi,
Could I have a review of this small change that wi
Hi Robin,
Looks good.
Thanks
Markus
From: Robin Westberg
Sent: den 13 oktober 2017 16:56
To: David Holmes
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR: 8187042: Events to show which objects are associated with
biased object revocations
Hi again,
Here’s an updated ve
Hi Robin,
Looks good.
Thanks
Markus
From: Robin Westberg
Sent: den 13 oktober 2017 16:55
To: serviceability-dev@openjdk.java.net
Subject: RFR(XS): 8173917: Safepoint ID is not consistent across event-based
tracing events
Hi all,
Please review the following change that aligns
Changeset: 739c309fd729
Author:mgronlun
Date: 2013-08-23 10:36 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/739c309fd729
8023457: Event based tracing framework needs a mutex for thread groups
Reviewed-by: acorn, sla
! src/share/vm/runtime/mutexLocker.cpp
! src/s
Changeset: 623d923529df
Author:mgronlun
Date: 2013-09-13 17:47 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/623d923529df
8021353: Event based tracing is missing thread exit
Reviewed-by: allwin, acorn, dcubed, dholmes, egahlin
! src/share/vm/runtime/thread.cpp
!
Changeset: 5c599c419c1d
Author:hseigel
Date: 2013-07-11 12:59 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5c599c419c1d
8016256: Make finalization final
Summary: Add private methods to final methods check
Reviewed-by: coleenp, acorn, ahgross
Contributed-by: harol
Changeset: e006d2e25bc7
Author:dholmes
Date: 2013-10-24 20:47 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e006d2e25bc7
8025673: [macosx] Disable X11 AWT toolkit
Summary: Disable but not completely remove the XAWT and headless toolkits on
Mac OS X
Reviewed-by: d
Looks good Staffan!
Thanks for fixing up this (mess).
Thanks
Markus
From: Staffan Larsen
Sent: den 11 november 2013 20:49
To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from
jmap/jinfo/jstac
Greetings,
Kindly asking for reviews for the following changeset:
Webrev: http://cr.openjdk.java.net/~mgronlun/8028128/webrev01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8028128
Description:
Currently, when working with counter based data, the primary data type
representa
en we do revisit the time abstractions, the names
for these types will most likely change - that made me leave the names to
emphasize the "ticks" sources.
Thanks for your input.
Best regards
Markus
From: Vitaly Davidovich [mailto:vita...@gmail.com]
Sent: den 12 november 2013
<=(const Ticks& lhs, const Ticks& rhs) {
98 return !operator>(lhs,rhs);
99 }
Thanks Vitaly!
Cheers
Markus
From: Vitaly Davidovich [mailto:vita...@gmail.com]
Sent: den 13 november 2013 02:19
To: Markus Gronlund
Cc: hotspot-runtime-...@openjdk.java.net
Hi Staffan,
Looks good.
Thanks
Markus
-Original Message-
From: Staffan Larsen
Sent: den 15 november 2013 10:48
To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net
serviceability-dev@openjdk.java.net
Subject: RFR: 8027630 SIGSEGV in const char*Klass::external_n
Changeset: 4288e54fd145
Author:jwilhelm
Date: 2013-10-21 18:51 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4288e54fd145
8026851: Remove unnecessary code in GenRemSet
Summary: Removed the GenRemSet::rem_set_name() since we only have one remset.
Reviewed-by: stefa
Hi Per,
Thanks for taking a look!
Inline.
Cheers
Markus
From: Per Liden
Sent: den 18 november 2013 13:22
To: Markus Gronlund; hotspot-runtime-...@openjdk.java.net;
hotspot-gc-...@openjdk.java.net; serviceability-dev@openjdk.java.net
serviceability-dev@openjdk.java.net
Subject: Re
3 02:58
To: Markus Gronlund
Cc: serviceability-dev; hotspot-gc-...@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR(M): 8028128: Add a type safe alternative for working with
counter based data
Hi Markus,
On 13/11/2013 7:46 PM, Markus Gronlund wrote:
> Hi again!
>
> Tha
Hi again,
I have created an updated webrev02 for the feedback I have gotten so far. In
addition, I have added a few improvements to the original suggestion.
Updated Webrev02: http://cr.openjdk.java.net/~mgronlun/8028128/webrev02/
Original Webrev01: http://cr.openjdk.java.net/~mgronlun/8028128/w
hanks for your help again
Cheers
Markus
-Original Message-
From: David Holmes
Sent: den 20 november 2013 23:11
To: Markus Gronlund
Cc: serviceability-dev; hotspot-gc-...@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR(M): 8028128: Add a type safe alternative for wo
Changeset: 570aaefce624
Author:morris
Date: 2013-11-18 12:26 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/570aaefce624
8028319: ConflictingDefaultsTest.testReabstract spins when running with -mode
invoke and -Xcomp
Summary: Change _abstract_method_handler to ret
Changeset: 86e6d691f2e1
Author:mgronlun
Date: 2013-11-23 12:25 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/86e6d691f2e1
8028128: Add a type safe alternative for working with counter based data
Reviewed-by: dholmes, egahlin
! src/share/vm/classfile/classLoaderDa
Greetings,
Kindly asking for reviews for the following change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8028412
Webrev: http://cr.openjdk.java.net/~mgronlun/8028412/webrev01/
Description:
AsynchGetCallTrace() uses platform specific code for stack frame traversals.
On x86
Hi Sergei,
I have already worked with Nik on this issue and got his confirmation on the
fix.
Thanks
Markus
From: Serguei Spitsyn
Sent: den 27 november 2013 11:31
To: Markus Gronlund; hotspot-compiler-...@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net; serviceability-dev
Cc
e
done in the VM itself and then using RegisterNatives() to hook up a test
case...hmm...)
Thanks again for reviewing
/Markus
-Original Message-
From: Vladimir Kozlov
Sent: den 27 november 2013 19:04
To: Markus Gronlund; hotspot-compiler-...@openjdk.java.net;
hotspot-runtime-...@openjd
Changeset: 9d15b81d5d1b
Author:drchase
Date: 2013-11-26 18:16 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9d15b81d5d1b
8016839: JSR292: AME instead of IAE when calling a method
Summary: Catch missing-because-illegal case for itable entries and use an
exception-
Changeset: c586f8a7322f
Author:mgronlun
Date: 2013-12-05 12:35 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c586f8a7322f
8028412: AsyncGetCallTrace() is broken on x86 in JDK 7u40
Reviewed-by: kvn, sspitsyn
! src/cpu/x86/vm/frame_x86.cpp
Changeset: 55a0da3d420b
Author:sjohanss
Date: 2013-11-26 14:35 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/55a0da3d420b
8027675: Full collections with Serial slower in JDK 8 compared to 7u40
Summary: Reduced the number of calls to follow_class_loader and instead
Staffan,
Looks good (not a Reviewer).
/Markus
-Original Message-
From: Staffan Larsen
Sent: den 16 december 2013 13:38
To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: RFR(XS): 8030184 Remove unneeded "content_type" declarations from
tracetypes.xml
Hi Serguei,
Looks good (not a Reviewer).
Thanks
Markus
-Original Message-
From: Serguei Spitsyn
Sent: den 19 december 2013 09:02
To: hotspot-dev developers; serviceability-dev@openjdk.java.net
Subject: Review Request (XS) 8030027:
nsk/jvmti/scenarios/hotswap/HS101/hs101t006 Crashed the
Looks good Fredrik!
/Markus
From: Fredrik Arvidsson
Sent: den 14 januari 2014 13:52
To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: Re: RFR(S): JDK-8031304 : Add dcmd to print all loaded dynamic
libraries
Hi
Added 'monitor' permission to VM.dynlibs
1 - 100 of 111 matches
Mail list logo
