ve added
the check without documenting it.
Thanks
Kevin
On 28/08/2017 16:01, Mikael Gerdin wrote:
Hi Kevin,
On 2017-08-22 16:38, Kevin Walls wrote:
Hi,
jcmd GC.run to invoke GC fails if -XX:+DisableExplicitGC is set:
this seems like a mistake?
This behaviour is obstructive for a live ap
think
it contradicts anything we document, and we seem to have added the check
without documenting it.
Sounds good.
/Mikael
Thanks
Kevin
On 28/08/2017 16:01, Mikael Gerdin wrote:
Hi Kevin,
On 2017-08-22 16:38, Kevin Walls wrote:
Hi,
jcmd GC.run to invoke GC fails if -XX
Hi Kevin,
On 2017-08-22 16:38, Kevin Walls wrote:
Hi,
jcmd GC.run to invoke GC fails if -XX:+DisableExplicitGC is set: this
seems like a mistake?
This behaviour is obstructive for a live app that _needs_ a GC, and was
started with -XX:+DisableExplicitGC.
DisableExplicitGC to protect from
Hi Robbin,
On 2016-04-20 09:40, Robbin Ehn wrote:
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154728
Thanks !
/Robbin
diff -r 857efca82258 src/share/vm/prims/jvmtiExport.cpp
---
Hi,
this is GC code and the rewview should go to hotspot-gc-dev.
I'm redirecting this mail there.
/Mikael
On 2016-04-06 08:15, Cheleswer Sahu wrote:
Hi,
This fix is waiting for review, can somebody please review this change.
Regards,
Cheleswer
From: Cheleswer Sahu
Sent: Friday,
Hi David,
On 2016-02-24 08:03, David Holmes wrote:
I stumbled across the fact that the following locks are no longer being
used in the VM:
Runtime:
- Interrupt_lock
- ProfileVM_lock
- ObjAllocPost_lock
Serviceability:
-JvmtiPendingEvent_lock
GC:
- CMark_lock
- CMRegionStack_lock
GC
Dmitry,
On 2015-12-18 14:11, Dmitry Samersoff wrote:
Alex,
Unfortunately, webrev.zip attachment is removed from the e-mail.
Could you put it somewhere and send me a link?
http://mail.openjdk.java.net/pipermail/serviceability-dev/2015-December/018519.html
I got the attachment just fine,
Hi Chris,
On 2015-12-16 08:40, Chris Plummer wrote:
Hi Mikael,
On 12/15/15 1:56 AM, Mikael Gerdin wrote:
Hi Chris,
sorry for the late reply.
On 2015-12-10 22:31, Chris Plummer wrote:
Hi Mikael,
See comments inline below:
On 12/9/15 8:48 AM, Mikael Gerdin wrote:
On 2015-12-08 20:14
Hi Chris,
sorry for the late reply.
On 2015-12-10 22:31, Chris Plummer wrote:
Hi Mikael,
See comments inline below:
On 12/9/15 8:48 AM, Mikael Gerdin wrote:
On 2015-12-08 20:14, Chris Plummer wrote:
[Adding serviceability-dev@openjdk.java.net]
Hi Mikael,
Thanks for pointing this out
didn't relize that both the symbols were used for the field, sorry
about that.
I still strongly feel that the method should be on InstanceKlass though.
/Mikael
-Dmitry
On 2015-06-02 15:06, Mikael Gerdin wrote:
Hi Dmitry,
On 2015-06-02 13:12, Dmitry Samersoff wrote:
Staffan,
Instead
Hi Dmitry,
On 2015-06-02 13:12, Dmitry Samersoff wrote:
Staffan,
Instead of hardcoding the field offsets, you can use
InstanceKlass::find_field and fieldDescriptor::offset to find the
offset at runtime.
Done. Please, see
http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.11
I put
Hi Staffan,
On 2015-05-29 10:53, Staffan Larsen wrote:
Can I have a fast review of the following change that is currently blocking
hotspot pushes in jprt. jtreg 4.1b12 adds stricter checking of @library tags.
Some com/sun/jdi tests have @library clauses that are not needed.
I do not intend
places where
updates may be necessary.
We can use GCCause::is_user_requested_gc() if the proposal in above is
accepted.
Thanks
Yasumasa
On 2015/02/13 21:33, Mikael Gerdin wrote:
Hi Yasumasa,
On 2015-02-11 15:02, Yasumasa Suenaga wrote:
Hi all,
I've committed JDK-8068589 to add new GCCause
Kevin,
On 2015-03-03 14:15, Kevin Walls wrote:
Hi,
This is a review request for a way to make the SA tools protect
themselves from infinite loops during initialisation.
Attaching jmap (for example) to a JVM can fail, infinitely writing an
error - and filling a disk if being logged to a file.
if we read a zero for the stride
size, for example. I think it's worth protecting ourselves from that
kind of problem.
That's probably a good idea to fix then.
I'll leave the rest for people who are qualified to review the code :)
/Mikael
Thanks
Kevin
On 03/03/2015 13:51, Mikael Gerdin
Hi Jungwoo,
The DTrace probes are part of the serviceability support, bcc:ing gc-dev
and redirecting to serviceability-dev.
/Mikael
On 2015-02-14 02:21, Jungwoo Ha wrote:
I am not sure if DTraceAllocProbes is a live code, but I think this is a
bug.
dtrace_object_alloc has changed to receive
Hi Yasumasa,
On 2015-02-11 15:02, Yasumasa Suenaga wrote:
Hi all,
I've committed JDK-8068589 to add new GCCause - Diagnostic Command.
However, it has been backouted because test is failed [1] and it is not
considered
about concurrent GC: -XX:+ExplicitGCInvokesConcurrent [2].
I've created
Maynard,
On 2014-12-08 16:05, Maynard Johnson wrote:
On 12/05/2014 05:09 PM, Brendan Gregg wrote:
G'Day Volker,
On Fri, Dec 5, 2014 at 11:22 AM, Volker Simonis
volker.simo...@gmail.com wrote:
Hi Brendan,
I'm still not understanding who is taking the actual stack traces (let
alone the
Hi,
This is the expected behavior for jmap and jinfo. If you call jstack
with the -F flag you will see the same behavior.
The reason for this is that jmap, jinfo and jstack -F all attach to your
target JVM as a debugger and read the memory from the process. That
needs to be done when the
Hi Stefan,
On 2014-08-19 12:25, Stefan Karlsson wrote:
Hi all,
Please review this patch harden two MemoryMXBean tests. These tests
cause intermittent test failures when the allocated objects are put in
the young gen instead of the old gen. The proposed fix/workaround is to
lower the young gen
Hi Jesper,
On Tuesday 04 February 2014 10.17.16 Jesper Wilhelmsson wrote:
Hi,
The patch from jdk9/hs-gc to make MinHeapFreeRatio and MaxHeapFreeRatio
manageable flags and supported in ParallelGC applied cleanly to
jdk8u/hs-dev.
hsx/jdk7u60 required some manual labor to patch since the
Hi Jesper,
On Monday 27 January 2014 21.46.01 Jesper Wilhelmsson wrote:
Staffan, Bengt, Mikael,
Thanks for the reviews!
I have made the changes you have suggested and a new webrev is available at:
http://cr.openjdk.java.net/~jwilhelm/8028391/webrev.5/
I agree with your assessment
Hi Jesper,
On Tuesday 21 January 2014 22.49.19 Jesper Wilhelmsson wrote:
Hi,
Could I have a few reviews of this change?
Summary:
To allow applications a more fine grained control over the GC over time,
we'll make the flags MinHeapFreeRatio and MaxHeapFreeRatio manageable.
The initial
Staffan,
On Monday 02 December 2013 17.30.00 Staffan Larsen wrote:
The problem here happens when SA wants to walk every object in the heap, to
do that it needs to figure out what parts of the heap are in active use
(the live regions). It gets the list of GC spaces as a start. It then
maps out
On Thursday 28 November 2013 13.33.48 Staffan Larsen wrote:
On 28 nov 2013, at 11:16, Leonid Mesnik leonid.mes...@oracle.com wrote:
Eric, Mandy
Sorry that I looping on very late step. It is not a review just
suggestion.
We have whitebox API in Hotspot which includes fullGC() method. It
Piotr,
On Friday 22 November 2013 09.21.56 Piotr Bzdyl wrote:
Is there any other information I could collect to help troubleshoot this
problem? How could I check if VM runs with attach disabled?
The comments in
to
find
out if it is because of the access rights of because how vboxsf file
system
driver works (attached the output).
On Fri, Nov 22, 2013 at 9:51 AM, Mikael Gerdin
mikael.ger...@oracle.comwrote:
Piotr,
On Friday 22 November 2013 09.21.56 Piotr Bzdyl wrote:
Is there any other
Changeset: ea79ab313e98
Author:mgerdin
Date: 2013-10-30 15:35 +0100
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ea79ab313e98
8027252: Crash in interpreter because get_unsigned_2_byte_index_at_bcp reads 4
bytes
Summary: Use 2-byte loads to load indexes from the byte
Erik,
On Monday 21 October 2013 11.26.51 Erik Helin wrote:
Hi all,
this is the second version of a patch for JDK-8025834.
Background:
In JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint, we create a
JvmtiBreakpoint on the stack. This JvmtiBreakpoint contains an
unhandled oop to the
Erik,
(it's not necessary to cross-post between hotspot-dev and
hotspot-gc-dev, so I removed hotspot-gc from the CC list)
On 2013-10-16 18:09, Erik Helin wrote:
Hi all,
this patch fixes an issue where an oop in JvmtiBreakpoint,
JvmtiBreakpoint::_class_loader, was found by the unhandled oop
Thomas,
On Tuesday 15 October 2013 12.53.25 Thomas Schatzl wrote:
Hi all,
can I have reviews for the following change? It updates the SA agent
that got out of date after the changes for JDK-7163191 where the
HeapRegionSeq class has been refactored.
The changes mirror the changes in the
Thomas,
On 15 October 2013 16:08:52 Thomas Schatzl thomas.scha...@oracle.com wrote:
Hi,
On Tue, 2013-10-15 at 15:04 +0200, Mikael Gerdin wrote:
Thomas,
On Tuesday 15 October 2013 12.53.25 Thomas Schatzl wrote:
Hi all,
can I have reviews for the following change? It updates the SA
Fredrik,
On 09/20/2013 04:29 PM, Fredrik Arvidsson wrote:
Please help me review this:
Bug: https://bugs.openjdk.java.net/browse/JDK-8016845
Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8016845/webrev.00/
http://cr.openjdk.java.net/%7Eallwin/farvidss/8016845/webrev.00/
the change looks
Changeset: 899ecf76b570
Author:dsimms
Date: 2013-09-25 13:58 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/899ecf76b570
8023956: Provide a work-around to broken Linux 32 bit Exec Shield using CS
for NX emulation (crashing with SI_KERNEL)
Summary: Execute some
Changeset: 1b03bed31241
Author:allwin
Date: 2013-09-17 17:16 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1b03bed31241
7196151: ParserTest SEGv on solaris
Reviewed-by: sla, coleenp, ctornqvi, dsamersoff
! src/share/vm/services/diagnosticArgument.cpp
Changeset:
On 2013-08-27 10:26, Staffan Larsen wrote:
On 26 aug 2013, at 20:19, Martin Traverso mtrave...@gmail.com
mailto:mtrave...@gmail.com wrote:
Great! Thanks for the explanation.
Just curious, why does running jstack at least once before the code
reaches that method call prevent the problem
Changeset: faf2631b9334
Author:dsimms
Date: 2013-08-26 09:33 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/faf2631b9334
8022683: JNI GetStringUTFChars should return NULL on allocation failure not
abort the VM
Summary: Return NULL on OOM from GetStringChars,
Kevin,
On 07/31/2013 11:45 AM, Kevin Walls wrote:
Hi,
I'd like to get a review on this small change:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020943
https://jbs.oracle.com/bugs/browse/JDK-8020943
webrev
http://cr.openjdk.java.net/~kevinw/8020943/webrev.00/
Looks good to me.
David,
On 2013-07-23 12:31, David Holmes wrote:
Hi Dmitry,
Looks okay.
Minor nit:
! return (int)threadIdField.getJInt(addr);
The cast should not be need as getJInt returns int.
Aside: this looks like a major bug in BasicField to me:
public long getJLong(Address addr) ...
A
Changeset: 39deebbc90b3
Author:mgerdin
Date: 2013-07-16 07:33 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/39deebbc90b3
6671508: JNI GetPrimitiveArrayCritical should not be callable on object arrays
Summary: Checked JNI now reports error for
Peter,
On 2013-07-09 14:25, Peter Allwin wrote:
Hello!
It is reproducible by letting the test create .java_pid* files for all
possible process id’s on the system, setting correct access flags,
launching the target VM and attempting to connect. There are some
caveats though but it should be
the Solaris launcher).
/Mikael
Thanks!
/peter
-Original Message-
From: Mikael Gerdin [mailto:mikael.ger...@oracle.com]
Sent: Tuesday, July 9, 2013 2:49 PM
To: Peter Allwin
Cc: serguei.spit...@oracle.com; daniel.daughe...@oracle.com;
serviceability-dev@openjdk.java.net; hotspot
to do these changes as a separate change. Jon, what do you
about that?
Thanks,
Erik
On 2013-05-31, Mikael Gerdin wrote:
(merging the gc-dev and svc-dev threads)
Hi Erik,
On 2013-05-29 10:44, Erik Helin wrote:
Hi all,
this want sent to hotspot-gc-...@openjdk.java.net, sending to
serviceability-dev
(merging the gc-dev and svc-dev threads)
Hi Erik,
On 2013-05-29 10:44, Erik Helin wrote:
Hi all,
this want sent to hotspot-gc-...@openjdk.java.net, sending to
serviceability-dev@openjdk.java.net as well since the change is about
memory pools.
This change adds two memory pools for metaspace,
Serguei,
On 2013-05-24 11:29, serguei.spit...@oracle.com wrote:
Please, review the fix for:
bug: http://bugs.sun.com/view_bug.do?bug_id=8013945
jbs: https://jbs.oracle.com/bugs/browse/JDK-8013945
Open webrev:
.
本电邮(包括任何附件)可能含有机密资料并受法律保护。如您不是正确的收件人，
请您立即删除本邮件。请不要将本电邮进行复制并用作任何其他用途、或透露本邮
件之内容。谢谢。
--
Mikael Gerdin
Java SE VM SQE Stockholm
not in a rush for the bug fix, it's already marked as a
known failure.
Can someone from the jdk8 project please Review this fix?
Thanks
/Mikael
On 2012-09-05 12:38, Mikael Gerdin wrote:
Bengt,
On 2012-09-05 10:52, Bengt Rutisson wrote:
Hi Mikael,
I think this looks good.
One minor thing. You
2012, at 08:58, Bengt Rutissonbengt.rutis...@oracle.com
wrote:
Thanks, Mikael! I think this fix looks good also when sent out to the
serviceability mailing list :-)
I am not a JDK reviewer...
Bengt
On 2012-09-06 08:54, Mikael Gerdin wrote:
Somehow serviceability-dev was dropped from the CC list
:54, Mikael Gerdin wrote:
Somehow serviceability-dev was dropped from the CC list.
I uploaded a new webrev since I thought Bengt had a point about being
consistent.
We talked about where to integrate the fix during the perm gen removal
meeting and decided that we'd like to push this through jdk8/tl
can get rid of these test
failures in the hotspot testing before we integrate perm removal into jdk8.
With that I'll need someone to sponsor the push since I'm not a Committer.
Thanks
/Mikael
--
Mikael Gerdin
Java SE VM SQE Stockholm
Staffan,
I looked through test makefile changes and the white box test, the
changes seem alright but I'm not convinced that using a white box test
for this is the best approach.
There are some existing tests for the error handler and hs_err creation
in test_error_handler in debug.cpp (look
Hi,
just a small nitpick in parserTests.cpp:
41: const char* lookup_diagnosticArgumentEnum(const char* field_name,
oop object)
and
52: void fill_in_parser(DCmdParser* parser, oop argument)
should probably be static (in the C sense).
Otherwise it looks good.
/Mikael
On 2012-03-15 13:45,
Hi Staffan
On 2012-02-22 09:26, Staffan Larsen wrote:
I'm trying to figure out what the different front ends to SA are and how they
differ. So far I have identified the following:
HSDB - basic UI
CLHSDB - command line version of HSDB
BugSpot - improvement over HSDB ??
JSDB - JavaScript
Hi Staffan,
It looks like you're adding Mac-specific stuff like thread_t and calls
to ::mach_thread_self() inside _ALLBSD_SOURCE #ifdefs, are you sure this
won't break BSD builds?
Does the OSX compiler define _ALLBSD_SOURCE or is that for
(free|net|open)bsd?
It's too bad we don't do regular
Hi Fred,
I ran the repro on a build with your fix applied and it appears that the leak
is fixed. Thanks for finding it so quick :)
/Mikael
On Friday 10 February 2012 10.27.30 Frederic Parain wrote:
Here's a small fix (one line) for CR 7143760 Memory leak in
GarbageCollectionNotifications
55 matches
Mail list logo
