Re: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-06 Thread Chris Plummer
Hi Christoph, Can you explain a bit more about "fix handling of null values in ArgumentIterator::next". When does this turn up? Is there a test case? Everything else looks good. thanks, Chris On 4/6/18 8:01 AM, Langer, Christoph wrote: Hi, can I please get reviews for a set of clean up c

RE: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-09 Thread Langer, Christoph
- > From: Chris Plummer [mailto:chris.plum...@oracle.com] > Sent: Freitag, 6. April 2018 18:37 > To: Langer, Christoph ; serviceability- > d...@openjdk.java.net > Cc: hotspot-...@openjdk.java.net > Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework > >

Re: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-09 Thread Chris Plummer
m...@oracle.com] Sent: Freitag, 6. April 2018 18:37 To: Langer, Christoph ; serviceability- d...@openjdk.java.net Cc: hotspot-...@openjdk.java.net Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework Hi Christoph, Can you explain a bit more about "fix handling of null valu

RE: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-10 Thread Lindenmaier, Goetz
Hi Christoph, thanks for doing this laborious change ... comparing all these files :) Change looks good, just some minor comments: You say you are sorting the includes, but in the VirtualMachineImpl.c files the order is changed, but according to which order? It's not alphabetical as in other f

Re: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-10 Thread Chris Plummer
On 4/10/18 8:34 AM, Lindenmaier, Goetz wrote: Hi Christoph, thanks for doing this laborious change ... comparing all these files :) Change looks good, just some minor comments: You say you are sorting the includes, but in the VirtualMachineImpl.c files the order is changed, but according to wh

RE: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-10 Thread Langer, Christoph
ntag, 9. April 2018 20:05 > To: Langer, Christoph ; serviceability- > d...@openjdk.java.net > Cc: hotspot-...@openjdk.java.net > Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework > > Hi Christoph, > > We have some closed "attach on demand" t

Re: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-10 Thread Chris Plummer
g, 9. April 2018 20:05 To: Langer, Christoph ; serviceability- d...@openjdk.java.net Cc: hotspot-...@openjdk.java.net Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework Hi Christoph, We have some closed "attach on demand" tests that should be run also. I can do this

Re: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-10 Thread Chris Plummer
Christoph -Original Message- From: Chris Plummer [mailto:chris.plum...@oracle.com] Sent: Montag, 9. April 2018 20:05 To: Langer, Christoph ; serviceability- d...@openjdk.java.net Cc: hotspot-...@openjdk.java.net Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework Hi

RE: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-10 Thread Lindenmaier, Goetz
.@openjdk.java.net > Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework > > On 4/10/18 8:34 AM, Lindenmaier, Goetz wrote: > > Hi Christoph, > > > > thanks for doing this laborious change ... comparing all these files :) > > > > Change look

RE: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-11 Thread Langer, Christoph
Hi Goetz, thanks for the review. > You say you are sorting the includes, but in the VirtualMachineImpl.c > files the order is changed, but according to which order? It's > not alphabetical as in other files. It is. However, I have put "subdirs" first. That is, the includes from sys/* come first

RE: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-11 Thread Langer, Christoph
losed testing and let me know the outcome. > >> > >> Thanks a lot in advance > >> Christoph > >> > >>> -----Original Message----- > >>> From: Chris Plummer [mailto:chris.plum...@oracle.com] > >>> Sent: Montag, 9. April 2018 20:05 &g

RE: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-11 Thread Lindenmaier, Goetz
; Sent: Mittwoch, 11. April 2018 09:45 > To: Lindenmaier, Goetz ; serviceability- > d...@openjdk.java.net > Cc: hotspot-...@openjdk.java.net > Subject: RE: RFR (M): 8201247: Various cleanups in the attach framework > > Hi Goetz, > > thanks for the review.

RE: RFR (M): 8201247: Various cleanups in the attach framework

2018-04-11 Thread Langer, Christoph
regards Christoph > -Original Message- > From: Lindenmaier, Goetz > Sent: Mittwoch, 11. April 2018 09:56 > To: Langer, Christoph ; serviceability- > d...@openjdk.java.net > Cc: hotspot-...@openjdk.java.net > Subject: RE: RFR (M): 8201247: Various cleanups in the att