Hi Christoph,
Can you explain a bit more about "fix handling of null values in
ArgumentIterator::next". When does this turn up? Is there a test case?
Everything else looks good.
thanks,
Chris
On 4/6/18 8:01 AM, Langer, Christoph wrote:
Hi,
can I please get reviews for a set of clean up c
-
> From: Chris Plummer [mailto:chris.plum...@oracle.com]
> Sent: Freitag, 6. April 2018 18:37
> To: Langer, Christoph ; serviceability-
> d...@openjdk.java.net
> Cc: hotspot-...@openjdk.java.net
> Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework
>
>
m...@oracle.com]
Sent: Freitag, 6. April 2018 18:37
To: Langer, Christoph ; serviceability-
d...@openjdk.java.net
Cc: hotspot-...@openjdk.java.net
Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework
Hi Christoph,
Can you explain a bit more about "fix handling of null valu
Hi Christoph,
thanks for doing this laborious change ... comparing all these files :)
Change looks good, just some minor comments:
You say you are sorting the includes, but in the VirtualMachineImpl.c
files the order is changed, but according to which order? It's
not alphabetical as in other f
On 4/10/18 8:34 AM, Lindenmaier, Goetz wrote:
Hi Christoph,
thanks for doing this laborious change ... comparing all these files :)
Change looks good, just some minor comments:
You say you are sorting the includes, but in the VirtualMachineImpl.c
files the order is changed, but according to wh
ntag, 9. April 2018 20:05
> To: Langer, Christoph ; serviceability-
> d...@openjdk.java.net
> Cc: hotspot-...@openjdk.java.net
> Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework
>
> Hi Christoph,
>
> We have some closed "attach on demand" t
g, 9. April 2018 20:05
To: Langer, Christoph ; serviceability-
d...@openjdk.java.net
Cc: hotspot-...@openjdk.java.net
Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework
Hi Christoph,
We have some closed "attach on demand" tests that should be run also. I
can do this
Christoph
-Original Message-
From: Chris Plummer [mailto:chris.plum...@oracle.com]
Sent: Montag, 9. April 2018 20:05
To: Langer, Christoph ; serviceability-
d...@openjdk.java.net
Cc: hotspot-...@openjdk.java.net
Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework
Hi
.@openjdk.java.net
> Subject: Re: RFR (M): 8201247: Various cleanups in the attach framework
>
> On 4/10/18 8:34 AM, Lindenmaier, Goetz wrote:
> > Hi Christoph,
> >
> > thanks for doing this laborious change ... comparing all these files :)
> >
> > Change look
Hi Goetz,
thanks for the review.
> You say you are sorting the includes, but in the VirtualMachineImpl.c
> files the order is changed, but according to which order? It's
> not alphabetical as in other files.
It is. However, I have put "subdirs" first. That is, the includes from sys/*
come first
losed testing and let me know the outcome.
> >>
> >> Thanks a lot in advance
> >> Christoph
> >>
> >>> -----Original Message-----
> >>> From: Chris Plummer [mailto:chris.plum...@oracle.com]
> >>> Sent: Montag, 9. April 2018 20:05
&g
; Sent: Mittwoch, 11. April 2018 09:45
> To: Lindenmaier, Goetz ; serviceability-
> d...@openjdk.java.net
> Cc: hotspot-...@openjdk.java.net
> Subject: RE: RFR (M): 8201247: Various cleanups in the attach framework
>
> Hi Goetz,
>
> thanks for the review.
regards
Christoph
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Mittwoch, 11. April 2018 09:56
> To: Langer, Christoph ; serviceability-
> d...@openjdk.java.net
> Cc: hotspot-...@openjdk.java.net
> Subject: RE: RFR (M): 8201247: Various cleanups in the att
13 matches
Mail list logo