Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-27 Thread Staffan Larsen
How about a combination? By default we use -vmoptions/-javaoptions for the debuggee. But if the property jdi.debuggee.VMOptions is specified we will use that instead. This would allow -vmoptions/-javaoptions for simplicity but the property for added control when that is necessary. /Staffan

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-27 Thread Daniel D. Daugherty
Sounds like a wonderful plan. Dan On 8/27/13 4:55 AM, Staffan Larsen wrote: How about a combination? By default we use -vmoptions/-javaoptions for the debuggee. But if the property jdi.debuggee.VMOptions is specified we will use that instead. This would allow -vmoptions/-javaoptions for

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-26 Thread David Holmes
Staffan, javaoptions will only be passed to the java invocation of the VM under test. vmptions will be passed to all VM invocations including javac from the compile-jdk. If your test-jdk and compile-jdk are the same then you will have trouble telling them apart :) That aside I would have

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-26 Thread Staffan Larsen
On 26 aug 2013, at 13:03, David Holmes david.hol...@oracle.com wrote: Staffan, javaoptions will only be passed to the java invocation of the VM under test. vmptions will be passed to all VM invocations including javac from the compile-jdk. Thanks, that was what I thought. So if my VM

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-26 Thread David Holmes
On 26/08/2013 9:27 PM, Staffan Larsen wrote: On 26 aug 2013, at 13:03, David Holmes david.hol...@oracle.com wrote: Staffan, javaoptions will only be passed to the java invocation of the VM under test. vmptions will be passed to all VM invocations including javac from the compile-jdk.

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-26 Thread Staffan Larsen
On 26 aug 2013, at 14:08, David Holmes david.hol...@oracle.com wrote: On 26/08/2013 9:27 PM, Staffan Larsen wrote: On 26 aug 2013, at 13:03, David Holmes david.hol...@oracle.com wrote: Staffan, javaoptions will only be passed to the java invocation of the VM under test. vmptions

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-26 Thread Daniel D. Daugherty
On 8/26/13 5:27 AM, Staffan Larsen wrote: On 26 aug 2013, at 13:03, David Holmes david.hol...@oracle.com wrote: If your test-jdk and compile-jdk are the same then you will have trouble telling them apart :) That aside I would have thought it quite reasonable for the debugger and debuggee

Re: RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-26 Thread Staffan Larsen
So if we really want to be able to use different options for the debugger and the debuggee, then a solution would be a separate property that contains the options to send to the debuggee (as proposed in the original bug report). Something like: jtreg

RFR(S): JDK-6622468 : TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

2013-08-23 Thread Staffan Larsen
The JDI tests have some quite arcane way of sending command line options to the debuggee. Options have to be put into a file called @debuggeeVMOptions before invoking jtreg. This was apparently implemented before there was a way in jtreg to set -vmoptions/-javaoptions. I'd like to remove this