Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-24 Thread David Holmes
On 21/01/2016 10:30 PM, Marcus Larsson wrote: Updated webrev: http://cr.openjdk.java.net/~mlarsson/8146009/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8146009/webrev.01/ Only LogConfiguration::initialize() and LogTagSet constructor now calls the stdout_output()/stderr_output()

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-23 Thread kirk.pepperd...@gmail.com
>>> >>> Or am I missing something obvious? >>> >> >> There is an ideal (which we seem to get further and further from) that the >> JVM should be unloadable within a process. In that model everything we >> initialize we should "de-initialize" before termination. And when logging >> itself can dep

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-23 Thread Thomas Stüfe
David, On Fri, Jan 22, 2016 at 1:21 PM, David Holmes wrote: > On 22/01/2016 3:00 AM, Thomas Stüfe wrote: > >> Hi, >> >> On Wed, Jan 20, 2016 at 2:01 PM, k...@kodewerk.com >> > > wrote: >> >> >> > On Jan 20, 2016, at 5:20 AM, David Holmes >

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-23 Thread Thomas Stüfe
Hi Staffan, On Fri, Jan 22, 2016 at 1:25 PM, Staffan Larsen wrote: > > > > Cleaning up like this is important if the JVM is being run many time > inside the same host process (think applets within a browser), but this is > becoming much less common. I wonder if it works at all at this point. > >

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-22 Thread Staffan Larsen
> On 22 jan. 2016, at 13:21, David Holmes wrote: > > On 22/01/2016 3:00 AM, Thomas Stüfe wrote: >> Hi, >> >> On Wed, Jan 20, 2016 at 2:01 PM, k...@kodewerk.com >> > > wrote: >> >> >>> On Jan 20, 2016, at 5:20 AM, David Holmes >

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-22 Thread David Holmes
On 22/01/2016 3:00 AM, Thomas Stüfe wrote: Hi, On Wed, Jan 20, 2016 at 2:01 PM, k...@kodewerk.com mailto:k...@kodewerk.com>> wrote: > On Jan 20, 2016, at 5:20 AM, David Holmes mailto:david.hol...@oracle.com>> wrote: > > On 19/01/2016 11:58 PM, Marcus Lars

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-21 Thread Thomas Stüfe
Hi, On Wed, Jan 20, 2016 at 2:01 PM, k...@kodewerk.com wrote: > > > On Jan 20, 2016, at 5:20 AM, David Holmes > wrote: > > > > On 19/01/2016 11:58 PM, Marcus Larsson wrote: > >> Hi, > >> > >> Please review the following patch to fix an issue in UL causing the VM > >> to crash during shutdown. >

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-21 Thread Marcus Larsson
Sorry, wrong link to incremental webrev. Look here instead: http://cr.openjdk.java.net/~mlarsson/8146009/webrev.00-01/ On 01/21/2016 01:30 PM, Marcus Larsson wrote: Updated webrev: http://cr.openjdk.java.net/~mlarsson/8146009/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/814600

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-21 Thread Marcus Larsson
Updated webrev: http://cr.openjdk.java.net/~mlarsson/8146009/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8146009/webrev.01/ Only LogConfiguration::initialize() and LogTagSet constructor now calls the stdout_output()/stderr_output() functions. Made the functions private to prev

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-20 Thread Marcus Larsson
Hi Kim, On 01/19/2016 08:25 PM, Kim Barrett wrote: On Jan 19, 2016, at 8:58 AM, Marcus Larsson wrote: Hi, Please review the following patch to fix an issue in UL causing the VM to crash during shutdown. The problem is that the static LogStdoutOutput is deinitialized before the last use of

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-20 Thread k...@kodewerk.com
> On Jan 20, 2016, at 5:20 AM, David Holmes wrote: > > On 19/01/2016 11:58 PM, Marcus Larsson wrote: >> Hi, >> >> Please review the following patch to fix an issue in UL causing the VM >> to crash during shutdown. >> >> The problem is that the static LogStdoutOutput is deinitialized before >>

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-19 Thread David Holmes
On 19/01/2016 11:58 PM, Marcus Larsson wrote: Hi, Please review the following patch to fix an issue in UL causing the VM to crash during shutdown. The problem is that the static LogStdoutOutput is deinitialized before the last use of it (G1 concurrent thread tries to log very late during VM shu

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-19 Thread Kim Barrett
On Jan 19, 2016, at 8:58 AM, Marcus Larsson wrote: > > Hi, > > Please review the following patch to fix an issue in UL causing the VM to > crash during shutdown. > > The problem is that the static LogStdoutOutput is deinitialized before the > last use of it (G1 concurrent thread tries to log

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-19 Thread Tom Benson
Hi Marcus, I think all the copyrights need to be updated. Since I had been able to reproduce the problem on nearly every run, I tried your fix and the crash no longer occurs. However, I now see that in about 1 in 5 runs, the final message that used to trigger the crash now gets printed twice.

RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-19 Thread Marcus Larsson
Hi, Please review the following patch to fix an issue in UL causing the VM to crash during shutdown. The problem is that the static LogStdoutOutput is deinitialized before the last use of it (G1 concurrent thread tries to log very late during VM shutdown). The solution is to make sure neithe