Hi All,
After internal discussions, many of the concerns below were addressed
and final spec is published at,
https://bugs.openjdk.java.net/browse/JDK-8199584
Below is the implementation of the above spec.
http://cr.openjdk.java.net/~hb/8187498/webrev.05/
Please review and provide feedback.
On 4/23/18 1:20 PM, Harsha Wardhana B wrote:
Hi All,
After internal discussions, many of the concerns below were addressed
and final spec is published at,
https://bugs.openjdk.java.net/browse/JDK-8199584
Below is the implementation of the above spec.
http://cr.openjdk.java.net/~hb/8187498
On Thursday 26 April 2018 09:09 PM, mandy chung wrote:
On 4/23/18 1:20 PM, Harsha Wardhana B wrote:
Hi All,
After internal discussions, many of the concerns below were addressed
and final spec is published at,
https://bugs.openjdk.java.net/browse/JDK-8199584
Below is the implementation
On 4/27/18 3:43 PM, Harsha Wardhana B wrote:
On Thursday 26 April 2018 09:09 PM, mandy chung wrote:
src/java.base/share/classes/sun/launcher/resources/launcher.properties
112 \ --start-management-agent option=value[:option=value:]\n\
option and value should be and to represent user-su
On 24/01/2018 11:18, Harsha Wardhana B wrote:
Hi,
Please review the changes for above enhancement having webrev at,
http://cr.openjdk.java.net/~hb/8187498/webrev.00/
One of the guidelines in JEP 293 [1] is to not introduce new options
with -X as a prefix. I think a related discussion point is
Hi Harsha,
Very nice to see progress on this!
Before reviewing, the minimal command line to start up the default
management server now becomes
-Xmanagement:ssl=false,authenticate=false
and if you use a property that doesn't exist, or that is mandatory, you
will get an error message stating
Hi Erik,
The minimal command line would be,
"-Xmanagement", that will start only the local management server.
"-Xmanagement:local=true,port=" will start the remote management
server without SSL or authentication.
On Wednesday 24 January 2018 06:13 PM, Erik Gahlin wrote:
Hi Harsha,
Ver
Hi Harsha,
JEP 293 [1] describes the guidelines for JDK command-line options. As
Alan points out, new options should move away from -X prefix but use
`--` GNU-style long form option. The guideline says:
The use of |-X| as a prefix to indicate "non-standard" options will be
discontinued for
Hi Mandy,Alan,
Thanks for your inputs.
If I keep it as launcher option, it may need to know JMX agent flags
which may need to be extended in future.
I would prefer making it a VM option. I will make the required changes
and send out an updated webrev.
-Harsha
On Thursday 25 January 2018 09:3
On 29/01/2018 05:20, Harsha Wardhana B wrote:
Hi Mandy,Alan,
Thanks for your inputs.
If I keep it as launcher option, it may need to know JMX agent flags
which may need to be extended in future.
I would prefer making it a VM option. I will make the required changes
and send out an updated we
Hi Alan,
I am not fully aware about Java launcher or how it passes options to VM.
Let me check with some other folks and get back to you.
Thanks
Harsha
On Monday 29 January 2018 01:55 PM, Alan Bateman wrote:
On 29/01/2018 05:20, Harsha Wardhana B wrote:
Hi Mandy,Alan,
Thanks for your inp
Hi All,
After internal discussions, below format for management flags was agreed
upon.
1. --start-management-agent port=1234,ssl=on (space seperator)
or
2. --start-management-agent=port=1234,ssl=on ('=' seperator)
If option 1 is specified, it will be converted to option 2 by the
Hi Harsha,
Changes look reasonable to me, couple of things that must be addressed:
1. Since this is a main-stream launcher change with a documented and
supported
option, a CSR is required, you have to add and document the option in
the help page
http://hg.openjdk.java.net/jdk/jdk/file/8cc6
Hi Kumar,
Thanks for your inputs.
On Wednesday 07 February 2018 09:02 PM, Kumar Srinivasan wrote:
Hi Harsha,
Changes look reasonable to me, couple of things that must be addressed:
1. Since this is a main-stream launcher change with a documented and
supported
option, a CSR is required, you
On 07/02/2018 09:19, Harsha Wardhana B wrote:
Hi All,
After internal discussions, below format for management flags was
agreed upon.
1. --start-management-agent port=1234,ssl=on (space seperator)
or
2. --start-management-agent=port=1234,ssl=on ('=' seperator)
If option 1 is spe
On 2/7/18 1:19 AM, Harsha Wardhana B wrote:
--start-management-agent will not be recognized in the current format and
hence will not default to --start-management-agent=local=true.
`--start-local-management-server` is one option as Alan suggests.
Another option is to make `--start-management-a
Hi,
Please find below the revised webrev.
http://cr.openjdk.java.net/~hb/8187498/webrev.02/
On Friday 09 February 2018 05:07 AM, mandy chung wrote:
On 2/7/18 1:19 AM, Harsha Wardhana B wrote:
>
> --start-management-agent will not be recognized in the current format and
> hence will not defa
On 2/13/18 1:30 AM, Harsha Wardhana B wrote:
Hi,
Please find below the revised webrev.
http://cr.openjdk.java.net/~hb/8187498/webrev.02/
On Friday 09 February 2018 05:07 AM, mandy chung wrote:
On 2/7/18 1:19 AM, Harsha Wardhana B wrote:
>
> --start-management-agent will not be recognized
Hi,
Below is the updated webrev.
http://cr.openjdk.java.net/~hb/8187498/webrev.03/
On Wednesday 14 February 2018 01:15 AM, mandy chung wrote:
On 2/13/18 1:30 AM, Harsha Wardhana B wrote:
Hi,
Please find below the revised webrev.
http://cr.openjdk.java.net/~hb/8187498/webrev.02/
On Frid
Ping. Could I please have reviews for below webrev.
Thanks
Harsha
On Wednesday 14 February 2018 09:59 PM, Harsha Wardhana B wrote:
Hi,
Below is the updated webrev.
http://cr.openjdk.java.net/~hb/8187498/webrev.03/
On Wednesday 14 February 2018 01:15 AM, mandy chung wrote:
On 2/13/18 1:30
You are going backwards. You need to have a CSR approved first.
Kumar
Ping. Could I please have reviews for below webrev.
Thanks
Harsha
On Wednesday 14 February 2018 09:59 PM, Harsha Wardhana B wrote:
Hi,
Below is the updated webrev.
http://cr.openjdk.java.net/~hb/8187498/webrev.03/
On
The code review and CSR review can be in parallel. For this case,
I agree with Kumar to have CSR written that would help the code
review. Please specify the behavior and its relationship with
jcmd and other relevant diagnosability tools.
On 2/20/18 6:41 AM, Kumar Srinivasan wrote:
What is the
On Wednesday 21 February 2018 01:51 AM, mandy chung wrote:
The code review and CSR review can be in parallel. For this case,
I agree with Kumar to have CSR written that would help the code
review. Please specify the behavior and its relationship with
jcmd and other relevant diagnosability tool
Hi,
I'm a bit leary of command line arguments being special cased and the
corresponding custom
mappings to system properties. The convenience is fine but we need to
keep the handling
out of native code so it is easier to maintain. We don't have a Java
API for processing
(VM) command line a
On 2/20/18 9:55 PM, Harsha Wardhana B wrote:
We cannot get rid of specifying options via -D. We have plenty of -D
flags but very few have short-hand alternative via
--start-management-agent. If management properties are specified by
--start-management-agent, the options specified by -D are
On Wednesday 21 February 2018 09:51 PM, mandy chung wrote:
On 2/20/18 9:55 PM, Harsha Wardhana B wrote:
We cannot get rid of specifying options via -D. We have plenty of -D
flags but very few have short-hand alternative via
--start-management-agent. If management properties are specified
26 matches
Mail list logo