On Wed, 1 Nov 2023 09:34:01 GMT, Stefan Johansson wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace NULL with nullptr
>
> Sorry for being a bit late to this PR. I think the addition of CPU time
> tracking
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with two additional
commits since the last revision:
- revert gitignore change
- Attempt to fix broken test
-
Changes:
- all:
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 36 additional commits
Segment file is closed from DumpWriter dtor.
On Unix systems `remove` can delete an opened file, on Windows it fails with
"access denied".
The fix destroys DumpWriter objects for segment files after all data are dumped
-
Commit messages:
- jcheck
- fix
- fix
Changes:
The handshakes support for virtual threads is needed to simplify the JVMTI
implementation for virtual threads. There is a significant duplication in the
JVMTI code to differentiate code intended to support platform, virtual threads
or both. The handshakes are unified, so it is enough to define
Discovered while testing changes that made this test fail. The test failure is
hard to diagnose as it logs and retries at full speed, possibly forever, until
timeout. This can hit a log file limit. We can save thousands of lines of
text being printed when the test runs normally and
On Wed, 1 Nov 2023 10:09:40 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools
On Wed, 1 Nov 2023 10:13:03 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/nmt/memMapPrinter.cpp line 105:
>>
>>> 103: _ranges[_count - 1].to = to;
>>> 104: return true;
>>> 105: }
>>
>> I'm pretty sure that the virtual memory tracker already gives you the
>> minimal set of
On Wed, 1 Nov 2023 10:01:43 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/share/nmt/memMapPrinter.cpp line 105:
>
>> 103: _ranges[_count - 1].to = to;
On Wed, 1 Nov 2023 09:52:24 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/nmt/memMapPrinter.cpp line 99:
>>
>>> 97: }
>>> 98:
>>> 99: bool add(const void* from, const void* to, MEMFLAGS f) {
>>
>> Please mention that we're `add`ing in sorted order, that is that `forall R
>> \in _ranges:
On Sat, 28 Oct 2023 13:04:05 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map
On Wed, 1 Nov 2023 09:48:39 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/share/nmt/memMapPrinter.cpp line 99:
>
>> 97: }
>> 98:
>> 99: bool add(const
On Sat, 28 Oct 2023 13:04:05 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools
On Tue, 31 Oct 2023 19:14:13 GMT, Thomas Schatzl wrote:
>> The JEP covers the idea very well, so I'm only covering some implementation
>> details here:
>>
>> * regions get a "pin count" (reference count). As long as it is non-zero, we
>> conservatively never reclaim that region even if there
On Wed, 1 Nov 2023 07:32:23 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/nmt/memMapPrinter.cpp line 79:
>>
>>> 77: const void* const min = MAX2(from1, from2);
>>> 78: const void* const max = MIN2(to1, to2);
>>> 79: return min < max;
>>
>> I had to rewrite it as:
>>
>> `return
On Wed, 1 Nov 2023 09:37:22 GMT, Johan Sjölen wrote:
>> I'll do the former, that is clearer I agree, but leave the latter out (I
>> assume with the macro you mean add it to globalDefenitions.hpp).
>>
>> I fear that a lot of bikeshedding and general discussions would start, and
>> to do it
On Tue, 31 Oct 2023 04:23:13 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Replace NULL with nullptr
Sorry for being a bit
On Tue, 31 Oct 2023 17:08:15 GMT, Gerard Ziemski wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/share/nmt/memMapPrinter.cpp line 79:
>
>> 77: const void* const min =
On Tue, 31 Oct 2023 16:58:19 GMT, Gerard Ziemski wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/os/linux/memMapPrinter_linux.cpp line 59:
>
>> 57: void
On Mon, 30 Oct 2023 17:31:30 GMT, Gerard Ziemski wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/os/linux/memMapPrinter_linux.cpp line 83:
>
>> 81: char line[linesize];
>>
On Mon, 30 Oct 2023 10:29:56 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/os/linux/memMapPrinter_linux.cpp line 80:
>
>> 78: FILE* f =
22 matches
Mail list logo
