On Thu, 2 Nov 2023 18:16:49 GMT, Kevin Walls wrote:
>> test/jdk/javax/management/monitor/ThreadPoolAccTest.java line 167:
>>
>>> 165: String expected = principals[i / 3];
>>> 166:
>>> 167: echo("testPrincipals: monitored: " + monitored[i] + "
>>> principal: " + principa
On Thu, 2 Nov 2023 20:44:14 GMT, Alex Menkov wrote:
>> Segment file is closed from DumpWriter dtor.
>> On Unix systems `remove` can delete an opened file, on Windows it fails with
>> "access denied".
>> The fix destroys DumpWriter objects for segment files after all data are
>> dumped
>
> Alex
> The handshakes support for virtual threads is needed to simplify the JVMTI
> implementation for virtual threads. There is a significant duplication in the
> JVMTI code to differentiate code intended to support platform, virtual
> threads or both. The handshakes are unified, so it is enough to
> The handshakes support for virtual threads is needed to simplify the JVMTI
> implementation for virtual threads. There is a significant duplication in the
> JVMTI code to differentiate code intended to support platform, virtual
> threads or both. The handshakes are unified, so it is enough to
On Thu, 2 Nov 2023 20:44:14 GMT, Alex Menkov wrote:
>> Segment file is closed from DumpWriter dtor.
>> On Unix systems `remove` can delete an opened file, on Windows it fails with
>> "access denied".
>> The fix destroys DumpWriter objects for segment files after all data are
>> dumped
>
> Alex
On Thu, 2 Nov 2023 11:35:29 GMT, Johannes Bechberger
wrote:
>> Fix race condition in debugger port selection, introduced with
>> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>>
>> Tested on my Mac M1, but it doesn't contain platform-dependent code.
>
> Johannes Bechberger has up
On Thu, 2 Nov 2023 06:09:22 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated log text
>
> src/hotspot/share/services/heapDumper.cpp line 1959:
>
>> 1957: // Delete selected segmented he
> Segment file is closed from DumpWriter dtor.
> On Unix systems `remove` can delete an opened file, on Windows it fails with
> "access denied".
> The fix destroys DumpWriter objects for segment files after all data are
> dumped
Alex Menkov has updated the pull request incrementally with one add
On Thu, 2 Nov 2023 06:14:59 GMT, David Holmes wrote:
> Sorry I don't understand the fix here. You changed the AbstractDumpWriter to
> be a C-heap object instead of ResourceObject and then delete it, so invoking
> a destructor, which AFAICS does nothing in terms of removing any files. ???
The f
On Thu, 2 Nov 2023 15:25:14 GMT, Brice Dutheil wrote:
>> This prints protection and offset. The former is interesting for obvious
>> reasons (e.g. lets you tell apart stack guard regions from stack, or
>> uncommitted from committed regions) and the latter interesting for some
>> corner cases (
On Thu, 2 Nov 2023 15:47:00 GMT, Serguei Spitsyn wrote:
>> Discovered while testing changes that made this test fail. The test failure
>> is hard to diagnose as it logs and retries at full speed, possibly forever,
>> until timeout. This can hit a log file limit. We can save thousands of
>>
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Mon, 30 Oct 2023 17:12:19 GMT, Thomas Schatzl wrote:
>> I do not think so. I will do some more testing about this.
>
> I (still) do not think it is possible after some more re-testing. There are
> the following situations I can think of:
>
> * string deduplication is a need-to-be-supported c
> The JEP covers the idea very well, so I'm only covering some implementation
> details here:
>
> * regions get a "pin count" (reference count). As long as it is non-zero, we
> conservatively never reclaim that region even if there is no reference in
> there. JNI code might have references to i
On Wed, 1 Nov 2023 17:10:34 GMT, Kevin Walls wrote:
> Discovered while testing changes that made this test fail. The test failure
> is hard to diagnose as it logs and retries at full speed, possibly forever,
> until timeout. This can hit a log file limit. We can save thousands of
> lines of
On Wed, 1 Nov 2023 06:26:57 GMT, Thomas Stuefe wrote:
>> src/hotspot/os/linux/memMapPrinter_linux.cpp line 59:
>>
>>> 57: void print_OS_specific_details(outputStream* st) const override {
>>> 58: st->print("%s %s ", _info.prot, _info.offset);
>>> 59: }
>>
>> If that's all this is doing,
> Analysts and supporters often use /proc/xx/maps to make sense of the memory
> footprint of a process.
>
> Interpreting the memory map correctly can help when used as a complement to
> other tools (e.g. NMT). There even exist tools out there that attempt to
> annotate the process memory map wi
On Wed, 1 Nov 2023 15:38:46 GMT, Gerard Ziemski wrote:
> LGTM
>
> Thank you for doing this!
Thank you for reviewing, @gerard-ziemski !
-
PR Comment: https://git.openjdk.org/jdk/pull/16301#issuecomment-1790665200
On Wed, 1 Nov 2023 10:04:04 GMT, Johan Sjölen wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix various builds
>
> src/hotspot/share/nmt/memMapPrinter.cpp line 119:
>
>> 117: assert(_capacity > _count, "San
On Wed, 1 Nov 2023 10:46:21 GMT, Johan Sjölen wrote:
>> Yes, it resulted in a significant performance gain for a test run where I
>> interleaved non-committed and committed memory of the same tag. I may have
>> been mistaken, of course.
>
> It being committed or reserved shouldn't matter (I ass
On Tue, 31 Oct 2023 18:54:26 GMT, Thomas Schatzl wrote:
> Had a discussion with @albertnetymk and we came to the following agreement
> about naming:
>
>"allocation failure" - allocation failed in the to-space due to memory
>exhaustion
>"pinned" - the region/object has been pinned
>"evacuation f
> The JEP covers the idea very well, so I'm only covering some implementation
> details here:
>
> * regions get a "pin count" (reference count). As long as it is non-zero, we
> conservatively never reclaim that region even if there is no reference in
> there. JNI code might have references to i
> Fix race condition in debugger port selection, introduced with
> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>
> Tested on my Mac M1, but it doesn't contain platform-dependent code.
Johannes Bechberger has updated the pull request incrementally with one
additional commit since
> Fix race condition in debugger port selection, introduced with
> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>
> Tested on my Mac M1, but it doesn't contain platform-dependent code.
Johannes Bechberger has updated the pull request incrementally with one
additional commit since
On Wed, 1 Nov 2023 23:56:25 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - revert gitignore change
> - Attempt to fix broken t
On Fri, 27 Oct 2023 08:19:13 GMT, Matthias Baesken wrote:
> The allow option of agentlib:jdwp has been introduced a long time ago (see
> JDK-8061228) and is documented here :
> https://docs.oracle.com/en/java/javase/17/docs/specs/jpda/conninv.html#oracle-vm-invocation-options
> However it is sti
On Mon, 30 Oct 2023 08:55:55 GMT, Matthias Baesken wrote:
>> The allow option of agentlib:jdwp has been introduced a long time ago (see
>> JDK-8061228) and is documented here :
>> https://docs.oracle.com/en/java/javase/17/docs/specs/jpda/conninv.html#oracle-vm-invocation-options
>> However it is
> The JEP covers the idea very well, so I'm only covering some implementation
> details here:
>
> * regions get a "pin count" (reference count). As long as it is non-zero, we
> conservatively never reclaim that region even if there is no reference in
> there. JNI code might have references to i
28 matches
Mail list logo
