Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v5]

2024-01-02 Thread Stefan Karlsson
> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename > createJavaProcessBuilder' changed the name of the ProcessTools helper > functions used to create `ProcessBuilder`s used to spawn new java test > processes. > > We now have `createTestJavaProcessBuilder` and >

Re: RFR: 8319948: jcmd man page needs to be updated [v4]

2024-01-02 Thread David Holmes
On Wed, 3 Jan 2024 07:21:36 GMT, Alan Bateman wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed Compiler.directives_add > > Marked as reviewed by alanb (Reviewer). Thanks for the review @AlanBateman !

Re: RFR: 8319948: jcmd man page needs to be updated [v3]

2024-01-02 Thread Alan Bateman
On Wed, 3 Jan 2024 07:15:55 GMT, David Holmes wrote: >> src/jdk.jcmd/share/man/jcmd.1 line 199: >> >>> 197: .TP >>> 198: \f[V]Compiler.directives_add\f[R] \f[I]filename\f[R] >>> \f[I]arguments\f[R] >>> 199: Adds compiler directives from a file. >> >> I might be misreading this one, it looks

Re: RFR: 8319948: jcmd man page needs to be updated [v4]

2024-01-02 Thread Alan Bateman
On Wed, 3 Jan 2024 07:19:03 GMT, David Holmes wrote: >> Please review these missing updates to the `jcmd` manpage - see JBS issue >> for details. >> >> I also fixed the sub-command ordering in a few places and a couple of minor >> formatting fixes. >> >> Thanks to @tstuefe for collating the

Re: RFR: 8319948: jcmd man page needs to be updated [v3]

2024-01-02 Thread David Holmes
On Wed, 3 Jan 2024 07:11:02 GMT, Alan Bateman wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Consistency pass to match manpage text with help text for VM subcommands > > src/jdk.jcmd/share/man/jcmd.1 line 199: >

Re: RFR: 8319948: jcmd man page needs to be updated [v4]

2024-01-02 Thread David Holmes
> Please review these missing updates to the `jcmd` manpage - see JBS issue for > details. > > I also fixed the sub-command ordering in a few places and a couple of minor > formatting fixes. > > Thanks to @tstuefe for collating the initial information on what was missing. > I used to `jcmd

Re: RFR: 8319948: jcmd man page needs to be updated [v3]

2024-01-02 Thread Alan Bateman
On Tue, 2 Jan 2024 22:01:11 GMT, David Holmes wrote: >> Please review these missing updates to the `jcmd` manpage - see JBS issue >> for details. >> >> I also fixed the sub-command ordering in a few places and a couple of minor >> formatting fixes. >> >> Thanks to @tstuefe for collating the

Re: RFR: 8322873: Duplicate -ljava -ljvm options for libinstrument

2024-01-02 Thread David Holmes
On Tue, 2 Jan 2024 21:44:04 GMT, Mikael Vidstedt wrote: > The libinstrument library is linked against libjava and libjvm, twice. This > is mostly harmless but Xcode 15.x generates a warning: > > Creating support/modules_libs/java.instrument/libinstrument.dylib from 12 > file(s) > ld: warning:

Re: RFR: 8319948: jcmd man page needs to be updated [v3]

2024-01-02 Thread David Holmes
On Tue, 2 Jan 2024 13:15:22 GMT, Kevin Walls wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Consistency pass to match manpage text with help text for VM subcommands > > Looks good. > > Trivially can note that

Re: RFR: 8319948: jcmd man page needs to be updated [v3]

2024-01-02 Thread David Holmes
> Please review these missing updates to the `jcmd` manpage - see JBS issue for > details. > > I also fixed the sub-command ordering in a few places and a couple of minor > formatting fixes. > > Thanks to @tstuefe for collating the initial information on what was missing. > I used to `jcmd

Re: RFR: 8319948: jcmd man page needs to be updated [v2]

2024-01-02 Thread David Holmes
> Please review these missing updates to the `jcmd` manpage - see JBS issue for > details. > > I also fixed the sub-command ordering in a few places and a couple of minor > formatting fixes. > > Thanks to @tstuefe for collating the initial information on what was missing. > I used to `jcmd

RFR: 8322873: Duplicate -ljava -ljvm options for libinstrument

2024-01-02 Thread Mikael Vidstedt
The libinstrument library is linked against libjava and libjvm, twice. This is mostly harmless but Xcode 15.x generates a warning: Creating support/modules_libs/java.instrument/libinstrument.dylib from 12 file(s) ld: warning: ignoring duplicate libraries: '-ljava', '-ljvm' In particular, note

Re: RFR: 8318707: Remove the Java Management Extension (JMX) Management Applet (m-let) feature

2024-01-02 Thread Kevin Walls
On Wed, 25 Oct 2023 17:02:03 GMT, Kevin Walls wrote: > Remove the MLet feature and its tests. > > Some tests use MLet classes but are not testing MLets. These are updated, to > use another test MBean or an MBean which is a URLClassLoader, e.g. >

RFR: 8318707: Remove the Java Management Extension (JMX) Management Applet (m-let) feature

2024-01-02 Thread Kevin Walls
Remove the MLet feature and its tests. Some tests use MLet classes but are not testing MLets. These are updated, to use another test MBean or an MBean which is a URLClassLoader, e.g. test/jdk/javax/management/MBeanServer/PostExceptionTest.java

Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v3]

2024-01-02 Thread Stefan Karlsson
On Mon, 11 Dec 2023 14:06:43 GMT, Stefan Karlsson wrote: >> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename >> createJavaProcessBuilder' changed the name of the ProcessTools helper >> functions used to create `ProcessBuilder`s used to spawn new java test >> processes. >>

Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v4]

2024-01-02 Thread Stefan Karlsson
> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename > createJavaProcessBuilder' changed the name of the ProcessTools helper > functions used to create `ProcessBuilder`s used to spawn new java test > processes. > > We now have `createTestJavaProcessBuilder` and >

Re: RFR: 8320707: Virtual thread test updates [v2]

2024-01-02 Thread Alan Bateman
> A lot of test changes have accumulated in the loom repo, this includes both > new tests and updates to existing tests. Some of these updates can be brought > to the main line. This update brings over: > > - The existing tests for pinning use synchronized blocks. In preparation for > changes

Re: RFR: 8319948: jcmd man page needs to be updated

2024-01-02 Thread Kevin Walls
On Tue, 2 Jan 2024 05:51:59 GMT, David Holmes wrote: > Please review these missing updates to the `jcmd` manpage - see JBS issue for > details. > > I also fixed the sub-command ordering in a few places and a couple of minor > formatting fixes. > > Thanks to @tstuefe for collating the initial