On Tue, 2 Jan 2024 13:15:22 GMT, Kevin Walls <[email protected]> wrote:
>> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Consistency pass to match manpage text with help text for VM subcommands > > Looks good. > > Trivially can note that here in jcmd.1 VM.flags says "Prints the VM flag..." > while diagnosticCommand.hpp says: "Print VM flag...". > We could make it consistent, but not important. > "Print" maybe in the minority compared to "Prints", but we have some of each. > 8-) Thanks for the review @kevinjwalls . I did a consistency sweep over the VM subcommands and changed a lot of `Prints` to `Print` so the manpage matches the help text. Which form is better grammatically I'm not sure, but if we want to change things we should do that for the help text and manpage at the same time. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17213#issuecomment-1874615668
