On Tue, 2 Jan 2024 05:51:59 GMT, David Holmes <[email protected]> wrote:
> Please review these missing updates to the `jcmd` manpage - see JBS issue for > details. > > I also fixed the sub-command ordering in a few places and a couple of minor > formatting fixes. > > Thanks to @tstuefe for collating the initial information on what was missing. > I used to `jcmd help <cmd>` option to compare the help text with the manpage > text and adjusted the manpage accordingly (and found a few more omissions - > some of which will be fixed by follow up RFE by the respective owners). Looks good. Trivially can note that here in jcmd.1 VM.flags says "Prints the VM flag..." while diagnosticCommand.hpp says: "Print VM flag...". We could make it consistent, but not important. "Print" maybe in the minority compared to "Prints", but we have some of each. 8-) ------------- Marked as reviewed by kevinw (Committer). PR Review: https://git.openjdk.org/jdk/pull/17213#pullrequestreview-1800411408
