On 04/06/2024 21:52, Iñigo Mediavilla wrote:
Hello,
While there's ongoing work on:
https://github.com/openjdk/jdk/pull/19482
to add the stack trace of mounted virtual threads to the `jcmd
Thread.print` command, I'm starting to think about how I could do to
print the stack trace for virtual
On Wed, 5 Jun 2024 01:21:36 GMT, Nizar Benalla wrote:
>> This is a simple noreg cleanup. The motivation was that I noticed javac
>> doesn't recognise package.html files well.
>>
>> Some of the contents of the `package.html` files (and code in the package)
>> may be outdated, but I think it is
On Wed, 5 Jun 2024 01:17:37 GMT, Jaikiran Pai wrote:
>> I think `timeout`s are not needed for the refactored tests.
>> Per JDK-6528548 the shell action has timed out using a network mounted JDK
>> (MakeJAR2.sh run `javac` 3 times and `jar` 1 time).
>> But I don't see big problem here - up to
On Tue, 4 Jun 2024 17:25:04 GMT, Leonid Mesnik wrote:
> The kill sends async exception that is thrown somewhere during
> log.display(...) method.
> The log shows that it is thrown while PrintStream locking moving it into an
> inconsistent state.
> So the fix is to use some method that could
On Tue, 4 Jun 2024 18:49:03 GMT, Alex Menkov wrote:
>> I have now updated the PR to use the same timeout that was used for the
>> `shell` test before the changes in this PR.
>
> I think `timeout`s are not needed for the refactored tests.
> Per JDK-6528548 the shell action has timed out using a
> This is a simple noreg cleanup. The motivation was that I noticed javac
> doesn't recognise package.html files well.
>
> Some of the contents of the `package.html` files (and code in the package)
> may be outdated, but I think it is out of scope for this PR.
>
> I have also changed three
On Tue, 4 Jun 2024 12:35:33 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/`
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
@altrisi As trivial and low-effort as this seems, this is actually fixing some
technical debt for legacy
On Tue, 4 Jun 2024 19:00:32 GMT, Chris Plummer wrote:
>> I think this is the right place but it is only for return values. There are
>> a few functions where a parameter value can be a null pointer, e.g. in
>> GetThreadState, SuspendThread, GetOwnedMonitorInfo the thread parameter can
>> be a
On Tue, 4 Jun 2024 21:16:08 GMT, Serguei Spitsyn wrote:
>> The empty method is removed. So test failing with '-Xcomp /C2' and exception
>> happens after try block.
>>
>> The log shows:
>> reply[2]: main[1]
>> Sending command: cont
>> reply[0]: >
>> reply[1]: Exception occurred:
On 6/4/24 5:57 AM, Sebastian Lövdahl wrote:
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote:
8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
(Kubernetes debug container)
Sebastian Lövdahl has updated the pull request incrementally with two
additional
I looked through this, and I don’t think the there is anything needed other
than this PR. Eventually jstack creates a VM_PrintThreads command which calls
the threads.cpp code.
> On Jun 4, 2024, at 3:52 PM, Iñigo Mediavilla wrote:
>
> Hello,
>
> While there's ongoing work on:
>
>
On Tue, 4 Jun 2024 17:25:04 GMT, Leonid Mesnik wrote:
> The kill sends async exception that is thrown somewhere during
> log.display(...) method.
> The log shows that it is thrown while PrintStream locking moving it into an
> inconsistent state.
> So the fix is to use some method that could
On Tue, 4 Jun 2024 21:05:40 GMT, Leonid Mesnik wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jdb/kill/kill001/kill001a.java line 153:
>>
>>> 151: }
>>> 152: }
>>> 153:
>>
>> Have you tried an empty method? I don't think it's a matter of how much time
>> you spend in the method, but
On Tue, 4 Jun 2024 19:06:19 GMT, Chris Plummer wrote:
>> The kill sends async exception that is thrown somewhere during
>> log.display(...) method.
>> The log shows that it is thrown while PrintStream locking moving it into an
>> inconsistent state.
>> So the fix is to use some method that
Hello,
While there's ongoing work on:
https://github.com/openjdk/jdk/pull/19482
to add the stack trace of mounted virtual threads to the `jcmd
Thread.print` command, I'm starting to think about how I could do to print
the stack trace for virtual threads from `jstack` but I'm not sure about
On Mon, 27 May 2024 09:01:48 GMT, Nizar Benalla wrote:
>> This is a simple noreg cleanup. The motivation was that I noticed javac
>> doesn't recognise package.html files well.
>>
>> Some of the contents of the `package.html` files (and code in the package)
>> may be outdated, but I think it
On Fri, 31 May 2024 18:22:47 GMT, Leonid Mesnik wrote:
> The fix removes finalization cleanup from vmTestbase.
> The last to classes that use it are: DebugeeBinder and SocketIOPipe.
> The DebugeeBinder is used in jdi and jdwp tests and is always linked with
> debuggee process. So the
On Tue, 4 Jun 2024 18:02:13 GMT, Leonid Mesnik wrote:
>> The fix removes finalization cleanup from vmTestbase.
>> The last to classes that use it are: DebugeeBinder and SocketIOPipe.
>> The DebugeeBinder is used in jdi and jdwp tests and is always linked with
>> debuggee process. So the
On Tue, 4 Jun 2024 17:25:04 GMT, Leonid Mesnik wrote:
> The kill sends async exception that is thrown somewhere during
> log.display(...) method.
> The log shows that it is thrown while PrintStream locking moving it into an
> inconsistent state.
> So the fix is to use some method that could
On Tue, 4 Jun 2024 07:01:54 GMT, Alan Bateman wrote:
>> Thanks, David. I also feel this clarification is still useful.
>
> I think this is the right place but it is only for return values. There are a
> few functions where a parameter value can be a null pointer, e.g. in
> GetThreadState,
On Tue, 4 Jun 2024 12:31:13 GMT, Jaikiran Pai wrote:
>> My guess is these tests were timed out when executed with some specific
>> options like -Xint, -Xcomp or any other that can slow down the execution
>> (e.g. DeoptimizeALot).
>
> I have now updated the PR to use the same timeout that was
On Tue, 4 Jun 2024 12:35:33 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/`
> The fix removes finalization cleanup from vmTestbase.
> The last to classes that use it are: DebugeeBinder and SocketIOPipe.
> The DebugeeBinder is used in jdi and jdwp tests and is always linked with
> debuggee process. So the DebugeeProcess.waitFor() is the good place to close
> binder and
The kill sends async exception that is thrown somewhere during log.display(...)
method.
The log shows that it is thrown while PrintStream locking moving it into an
inconsistent state.
So the fix is to use some method that could be safely interrupted by async
exception.
-
Commit
On Tue, 4 Jun 2024 13:31:50 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Incorporate
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Thanks for the review.
Thanks all for the review.
-
PR Comment:
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Looks good! Somehow the integrate command did not work.
-
Marked as reviewed by chagedorn
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Include virtual thread name in output
-
Changes:
- all:
On Tue, 4 Jun 2024 08:51:40 GMT, Thomas Stuefe wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanup test
>>
>>- Stop virtualthread
>>- Remove unneeded imports
>>- Remove modules that
On Tue, 4 Jun 2024 08:50:53 GMT, Thomas Stuefe wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanup test
>>
>>- Stop virtualthread
>>- Remove unneeded imports
>>- Remove modules that
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Incorporate @tstuefe's remarks
-
Changes:
- all:
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with two
additional commits since the last revision:
- Remove dead code
- Remove extra indentation (leave it for the next PR)
On Tue, 4 Jun 2024 08:50:25 GMT, Thomas Stuefe wrote:
>> Actually I'm not sure what this indentation actually does at this location
>> and its affect on other user's of this API. I would have expected the caller
>> to set up the necessary indentation in the stream that gets passed in. I see
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Marked as reviewed by erikj (Reviewer).
-
PR Review:
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
> /label build
Thanks.
-
PR Comment:
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with two
> additional commits since the last revision:
>
> -
On Tue, 4 Jun 2024 11:47:25 GMT, Serguei Spitsyn wrote:
>> Hello Serguei, that `timeout=240` appears to have been added as part of
>> https://bugs.openjdk.org/browse/JDK-6528548 to several of these tests back
>> in Java 7 days because the `shell` test which was creating the jar file was
>>
> Can I please get a review of this test-only change which addresses
> https://bugs.openjdk.org/browse/JDK-8333130?
>
> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
> under `test/jdk/java/lang/instrument/` which launch the app/test with a
> `-javaagent:` pointing
On Tue, 4 Jun 2024 08:54:40 GMT, Jaikiran Pai wrote:
>> test/jdk/java/lang/instrument/NativeMethodPrefixAgent.java line 34:
>>
>>> 32: * @modules java.management
>>> 33: * java.instrument
>>> 34: * @run shell/timeout=240 MakeJAR2.sh NativeMethodPrefixAgent
>>> NativeMethodPrefixApp
On Tue, 4 Jun 2024 08:50:18 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/`
On Tue, 4 Jun 2024 05:30:36 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/javaThread.cpp line 1832:
>>
>>> 1830: st->print("\t");
>>> 1831: indentation--;
>>> 1832: }
>>
>> Suggestion:
>>
>> while (indentation-- > 0) {
>> st->print("\t");
>> }
>>
>> Though not
On Tue, 4 Jun 2024 07:25:41 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Cleanup
On Tue, 4 Jun 2024 07:12:27 GMT, Serguei Spitsyn wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> unused import
>
> test/jdk/java/lang/instrument/NativeMethodPrefixAgent.java line 34:
>
>> 32: * @modules
On Tue, 4 Jun 2024 07:13:39 GMT, Serguei Spitsyn wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Alex suggestion - remove -XX:-CheckIntrinsics from NativeMethodPrefixApp
>> test too
>> - Alex's suggestion -
> Can I please get a review of this test-only change which addresses
> https://bugs.openjdk.org/browse/JDK-8333130?
>
> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
> under `test/jdk/java/lang/instrument/` which launch the app/test with a
> `-javaagent:` pointing
On Tue, 4 Jun 2024 07:25:41 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Cleanup
Hi all,
This PR several extra empty spaces and extra empty lines in several
Makefiles. It's trivial fix, no risk.
Thanks.
-
Commit messages:
- 8333477: Delete extra empty spaces in Makefiles
Changes: https://git.openjdk.org/jdk/pull/19537/files
Webrev:
On Tue, 4 Jun 2024 07:25:41 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Cleanup
On Mon, 3 Jun 2024 23:02:28 GMT, Leonid Mesnik wrote:
>> The fix removes finalization cleanup from vmTestbase.
>> The last to classes that use it are: DebugeeBinder and SocketIOPipe.
>> The DebugeeBinder is used in jdi and jdwp tests and is always linked with
>> debuggee process. So the
On Tue, 4 Jun 2024 05:33:47 GMT, David Holmes wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Print mounted virtual thread after carrier
>
>
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with two
additional commits since the last revision:
- Cleanup test
- Stop virtualthread
- Remove unneeded imports
- Remove
On Tue, 4 Jun 2024 01:34:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/`
On Tue, 4 Jun 2024 06:38:36 GMT, Serguei Spitsyn wrote:
>> The intent is to provide a definition of what a null pointer is, for both C
>> and C++ programs. Is there a better place to do that so that elsewhere the
>> spec can simply to refer to "a null pointer" or "null"?
>
> Thanks, David. I
On Mon, 3 Jun 2024 22:55:24 GMT, Serguei Spitsyn wrote:
>> Please, review the following `interp-only` issue related to carrier threads.
>> There are 3 problems fixed here:
>> - The `EnterInterpOnlyModeClosure::do_threads` is taking the
>> `JvmtiThreadState` with the `jt->jvmti_thread_state()`
On Tue, 4 Jun 2024 04:48:04 GMT, David Holmes wrote:
>> src/hotspot/share/prims/jvmti.xml line 1007:
>>
>>> 1005: explicitly deallocate. This is indicated in the individual
>>>
>>> 1006: function descriptions. Empty lists, arrays, sequences, etc are
>>> 1007: returned as a null
On Fri, 17 May 2024 03:49:21 GMT, Quan Anh Mai wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: corrected the nullptr clarification
>
> src/hotspot/share/prims/jvmti.xml line 1007:
>
>> 1005:
57 matches
Mail list logo
