Re: [jdk23] RFR: 8325280: Update troff manpages in JDK 23 before RC

2024-07-18 Thread David Holmes
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote: > Before RC we need to update the man pages in the repo from their Markdown > sources. All pages at a minimum have 23-ea replaced with 23, and publication > year set to 2024 if needed. > > This also picks up the unpublished changes to

Re: RFR: 8334145: missing from vm_memory_map_.txt in System.dump_map help text

2024-07-18 Thread David Holmes
On Fri, 19 Jul 2024 01:44:16 GMT, Chris Plummer wrote: > Fix issue with `` argument. Looks good. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20246#pullrequestreview-2187267950

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-18 Thread Jaikiran Pai
On Thu, 18 Jul 2024 11:42:17 GMT, SendaoYan wrote: >> Hi all, >> After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the >> footprint memory usage increased significantly when run the testcase with >> -Xcomp jvm options, then cause the testcase was killed by docker by OOM. >>

RFR: 8334145: missing from vm_memory_map_.txt in System.dump_map help text

2024-07-18 Thread Chris Plummer
Fix issue with `` argument. - Commit messages: - Fix quoting of pid argument Changes: https://git.openjdk.org/jdk/pull/20246/files Webrev: https://webrevs.openjdk.org/?repo=jdk=20246=00 Issue: https://bugs.openjdk.org/browse/JDK-8334145 Stats: 1 line in 1 file changed: 0 ins;

Re: RFR: 8248609: [Graal] vmTestbase/nsk/jdi/VoidValue/toString/tostring001/TestDescription.java failed with Unexpected com.sun.jdi.ObjectCollectedException

2024-07-18 Thread Alex Menkov
On Thu, 18 Jul 2024 18:50:48 GMT, Chris Plummer wrote: > The test is failing with an ObjectCollectedException. The test hits a > SUSPEND_ALL breakpoint. It then uses JDI to allocate an Object on the > debuggee side: > > testedObject = testedClass.newInstance(thread, ctor, params,

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Vladimir Kozlov
On Thu, 18 Jul 2024 21:16:12 GMT, Chris Plummer wrote: > Given that there is no inherent incompatibility with `-Xcomp` and the test is > capable of running with `-Xcomp`, I suggest that you add an `@comment` before > the `@require` stating why it shouldn't be run with `-Xcomp`. Agree.

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Chris Plummer
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Vladimir Kozlov
On Thu, 18 Jul 2024 20:22:47 GMT, Chris Plummer wrote: > Does not running with `-Xcomp` mean not running it with graal? `-Xcomp` is not related to graal at all. It triggers all JIT compilers compilation for each called Java method. And Java thread waits until compilation is finished. It is

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Chris Plummer
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running

Re: RFR: 8336691: Test LongArgTest.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Utils [v2]

2024-07-18 Thread Alex Menkov
On Thu, 18 Jul 2024 07:30:47 GMT, SendaoYan wrote: >> Hi all, >> The testcase `serviceability/attach/LongArgTest.java` intermittent fails >> `java.lang.NoClassDefFoundError: jdk/test/lib/Utils`. Jtreg doesn't >> automatically compile `jdk/test/lib/Utils.class` and >>

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Vladimir Kozlov
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Vladimir Kozlov
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running

RFR: 8248609: [Graal] vmTestbase/nsk/jdi/VoidValue/toString/tostring001/TestDescription.java failed with Unexpected com.sun.jdi.ObjectCollectedException

2024-07-18 Thread Chris Plummer
The test is failing with an ObjectCollectedException. The test hits a SUSPEND_ALL breakpoint. It then uses JDI to allocate an Object on the debuggee side: testedObject = testedClass.newInstance(thread, ctor, params, 0); Since we are under a SUSPEND_ALL, the object is not initially

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Chris Plummer
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running

Re: RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v3]

2024-07-18 Thread Laurence Cable
On 7/17/24 10:03 PM, Thomas Stuefe wrote: On Thu, 18 Jul 2024 00:45:24 GMT, Leonid Mesnik wrote: Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision: Updates based on feedback src/hotspot/share/code/codeCache.cpp line

RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-18 Thread Daniel Lundén
We are seeing quite a few timeouts for `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, possibly related to [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable running `ClhsdbDumpheap.java` with -Xcomp, at least for now. ### Changeset - Add

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-18 Thread Adam Sotona
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote: > Hi all, > After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the > footprint memory usage increased significantly when run the testcase with > -Xcomp jvm options, then cause the testcase was killed by docker by OOM. >

Re: RFR: 8336691: Test LongArgTest.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Utils [v2]

2024-07-18 Thread Jaikiran Pai
On Thu, 18 Jul 2024 07:30:47 GMT, SendaoYan wrote: >> Hi all, >> The testcase `serviceability/attach/LongArgTest.java` intermittent fails >> `java.lang.NoClassDefFoundError: jdk/test/lib/Utils`. Jtreg doesn't >> automatically compile `jdk/test/lib/Utils.class` and >>

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-18 Thread SendaoYan
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote: > Hi all, > After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the > footprint memory usage increased significantly when run the testcase with > -Xcomp jvm options, then cause the testcase was killed by docker by OOM. >

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v9]

2024-07-18 Thread Roman Kennke
On Mon, 15 Jul 2024 00:50:30 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >>

Re: RFR: 8336691: Test LongArgTest.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Utils [v2]

2024-07-18 Thread Chen Liang
On Thu, 18 Jul 2024 07:30:47 GMT, SendaoYan wrote: >> Hi all, >> The testcase `serviceability/attach/LongArgTest.java` intermittent fails >> `java.lang.NoClassDefFoundError: jdk/test/lib/Utils`. Jtreg doesn't >> automatically compile `jdk/test/lib/Utils.class` and >>

Re: RFR: 8336254: Virtual thread implementation + test updates

2024-07-18 Thread Alan Bateman
On Thu, 18 Jul 2024 10:52:43 GMT, Serguei Spitsyn wrote: > Q: There are some new files with a copyright year ranges. I will check but there are a few renames that have to keep the initial year. Also there are some new files that have been checked into the loom repo for a long time so they

Re: RFR: 8336254: Virtual thread implementation + test updates

2024-07-18 Thread Alan Bateman
On Thu, 18 Jul 2024 10:46:16 GMT, Serguei Spitsyn wrote: >> Bringover some of the changes accumulated in the loom repo to the main line, >> most of these changes are test updates and have been baking in the loom repo >> for several months. The motive is partly to reduce the large set of

Re: RFR: 8336254: Virtual thread implementation + test updates

2024-07-18 Thread Serguei Spitsyn
On Thu, 11 Jul 2024 17:30:21 GMT, Alan Bateman wrote: > Bringover some of the changes accumulated in the loom repo to the main line, > most of these changes are test updates and have been baking in the loom repo > for several months. The motive is partly to reduce the large set of changes >

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-18 Thread Adam Sotona
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote: > Hi all, > After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the > footprint memory usage increased significantly when run the testcase with > -Xcomp jvm options, then cause the testcase was killed by docker by OOM. >

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-18 Thread SendaoYan
On Thu, 18 Jul 2024 08:45:43 GMT, Serguei Spitsyn wrote: > Looks okay. I agree this needs to be reviewed by @asotona . Thanks for the review. I will wait reviewed by @asotona before integrate. - PR Comment: https://git.openjdk.org/jdk/pull/19864#issuecomment-2236003849

Re: RFR: 8332551: Test vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001/TestDescription.java timed out [v2]

2024-07-18 Thread Serguei Spitsyn
On Fri, 12 Jul 2024 09:16:05 GMT, Kevin Walls wrote: >> Short version: >> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp" >> >> Make additional typo fixes and tidyups while here, it's just shocking. >> >> TestDescription.java contains the test definition, so the

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-18 Thread Serguei Spitsyn
On Mon, 24 Jun 2024 16:16:29 GMT, SendaoYan wrote: > Hi all, > After [JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960), the > footprint memory usage increased significantly when run the testcase with > -Xcomp jvm options, then cause the testcase was killed by docker by OOM. >

Re: RFR: 8336254: Virtual thread implementation + test updates

2024-07-18 Thread Serguei Spitsyn
On Tue, 16 Jul 2024 05:58:18 GMT, David Holmes wrote: >> Bringover some of the changes accumulated in the loom repo to the main line, >> most of these changes are test updates and have been baking in the loom repo >> for several months. The motive is partly to reduce the large set of changes

Re: RFR: 8336691: Test LongArgTest.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Utils [v2]

2024-07-18 Thread SendaoYan
> Hi all, > The testcase `serviceability/attach/LongArgTest.java` intermittent fails > `java.lang.NoClassDefFoundError: jdk/test/lib/Utils`. Jtreg doesn't > automatically compile `jdk/test/lib/Utils.class` and > `jdk/test/lib/apps/LingeredApp.class` etc.. Maybe it's a jtreg framework bug. > I

Re: RFR: 8336691: Test LongArgTest.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Utils [v2]

2024-07-18 Thread SendaoYan
On Thu, 18 Jul 2024 04:57:27 GMT, Jaikiran Pai wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete @build LongArgTest > > test/hotspot/jtreg/serviceability/attach/LongArgTest.java line 30: > >> 28: * @library

Re: RFR: 8334771: [TESTBUG] Run TestDockerMemoryMetrics.java with -Xcomp fails exitValue = 137

2024-07-18 Thread SendaoYan
On Thu, 18 Jul 2024 05:52:51 GMT, Jaikiran Pai wrote: > So I think we should have this increase in memory reviewed by @asotona or > someone familiar in that area, before deciding whether these tests should be > changed. Okey. - PR Comment: