On Mon, 17 Jun 2024 09:13:57 GMT, Inigo Mediavilla Saiz
wrote:
> Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing
> issues when the PrintMountedVirtualTest.java was
> running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo.
>
> - Fixes issues
On Tue, 18 Jun 2024 11:11:12 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve assert and document conditional print
>
> I looked at the changes in
a potential issue in the test where CountDownLatch.countDown unparks
> the main (virtual) thread and the main thread observes the dummy thread is
> transition .
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
On Tue, 18 Jun 2024 11:41:36 GMT, Inigo Mediavilla Saiz
wrote:
>> Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing
>> issues when the PrintMountedVirtualTest.java was
>> running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo.
>>
On Tue, 18 Jun 2024 09:31:41 GMT, David Holmes wrote:
>> @AlanBateman explained to me why that is possible in
>> https://github.com/openjdk/jdk/pull/19482#issuecomment-2166116062 and
>> https://github.com/openjdk/jdk/pull/19482#issuecomment-2167374446.
>>
>> Alan can correct me if I'm wrong,
On Tue, 18 Jun 2024 09:29:34 GMT, David Holmes wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve assert and document conditional print
>
> src/hotspot/share/runtime/thr
a potential issue in the test where CountDownLatch.countDown unparks
> the main (virtual) thread and the main thread observes the dummy thread is
> transition .
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Mov
On Mon, 17 Jun 2024 13:24:23 GMT, Inigo Mediavilla Saiz
wrote:
>> Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing
>> issues when the PrintMountedVirtualTest.java was
>> running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo.
>>
On Mon, 17 Jun 2024 13:00:11 GMT, Alan Bateman wrote:
>> test/hotspot/jtreg/serviceability/dcmd/thread/PrintMountedVirtualThread.java
>> line 43:
>>
>>> 41: public void run(CommandExecutor executor) throws
>>> InterruptedException {
>>> 42: var shouldFinish = new
On Mon, 17 Jun 2024 13:15:27 GMT, Inigo Mediavilla Saiz
wrote:
>>> We need a comment explaining why we have to check for this as without
>>> knowing the implementation quirks it seems non-sensical for a thread to
>>> have mounted itself!
>>
>> Just to
On Mon, 17 Jun 2024 13:12:00 GMT, Inigo Mediavilla Saiz
wrote:
>> src/hotspot/share/runtime/threads.cpp line 1335:
>>
>>> 1333: const oop vt = p->vthread();
>>> 1334: if (vt != thread_oop) {
>>> 1335: assert(vt !=
a potential issue in the test where CountDownLatch.countDown unparks
> the main (virtual) thread and the main thread observes the dummy thread is
> transition .
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Imp
On Mon, 17 Jun 2024 12:56:03 GMT, Alan Bateman wrote:
>> src/hotspot/share/runtime/threads.cpp line 1334:
>>
>>> 1332: if (p->is_vthread_mounted()) {
>>> 1333: const oop vt = p->vthread();
>>> 1334: if (vt != thread_oop) {
>>
>> We need a comment explaining
On Mon, 17 Jun 2024 12:34:25 GMT, David Holmes wrote:
>> Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing
>> issues when the PrintMountedVirtualTest.java was
>> running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo.
>>
>> - Fixes issues where the test
On Fri, 14 Jun 2024 07:07:39 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unneeded line
>
> It's the countDown by "dummy" thread will un
Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing issues
when the PrintMountedVirtualTest.java was
running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo.
- Fixes issues where the test observes the thread during transitions.
- Fixes a potential issue in the test
On Wed, 12 Jun 2024 08:45:46 GMT, Inigo Mediavilla Saiz
wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last re
On Thu, 13 Jun 2024 10:28:06 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unneeded line
>
> I've created [JDK-8334215](https://bugs.
On Thu, 30 May 2024 14:13:34 GMT, Inigo Mediavilla Saiz
wrote:
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
This pull request has now been integrated.
Changeset: fcedde80
Author: Inigo Mediavilla Saiz
Committer: David Holmes
URL:
On Wed, 12 Jun 2024 08:34:17 GMT, Alan Bateman wrote:
> Thanks for taking feedback, I don't have any other comments.
Thanks a lot for all your comments !
-
PR Comment: https://git.openjdk.org/jdk/pull/19482#issuecomment-2162443508
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Remove unneeded line
-
Changes:
- all: https://git.openjdk.o
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Fix scope of the try block
-
Changes:
- all: https://git.openj
On Wed, 12 Jun 2024 06:17:37 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Require continuations to run the test
>
> test/hotspot/jt
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Test fixes: pass to junit, avoid spinning thread on fail
-
C
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Require continuations to run the test
-
Changes:
- all:
On Tue, 11 Jun 2024 07:57:59 GMT, Alan Bateman wrote:
>> I think the presentation of the carrier the mounted virtual thread in update
>> (b122cc05) looks quite good.
>>
>> I think it would be helpful to include the thread name too. Many virtual
>> threads are unnamed so it will show as "" but
On Tue, 11 Jun 2024 07:54:31 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Incorporate Alan's suggestions
-
Changes:
- all:
On Tue, 11 Jun 2024 07:50:23 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Rename test
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Tue, 11 Jun 2024 07:57:59 GMT, Alan Bateman wrote:
> I assume the follow-up to improve the alignment will be a small change. No
> objection if you do it here or in a follow-up PR.
Indeed, it will be a small change, but since it may be subject to discussion
because it affects other parts of
On Tue, 4 Jun 2024 08:06:28 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanup test
>>
>>- Stop virtualthread
>>- Remo
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request with a new target base due
to a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull r
On Tue, 4 Jun 2024 13:31:50 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revisio
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Include virtual thread name in output
-
Changes:
- all:
On Tue, 4 Jun 2024 08:51:40 GMT, Thomas Stuefe wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanup test
>>
>>- Stop virtualthread
>>- Remo
On Tue, 4 Jun 2024 08:50:53 GMT, Thomas Stuefe wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Cleanup test
>>
>>- Stop virtualthread
>>- Remo
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Incorporate @tstuefe's remarks
-
Changes:
- all:
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with two
additional commits since the last revision:
- Remove dead code
- Remove extra indentation (leave it for the n
On Tue, 4 Jun 2024 08:50:25 GMT, Thomas Stuefe wrote:
>> Actually I'm not sure what this indentation actually does at this location
>> and its affect on other user's of this API. I would have expected the caller
>> to set up the necessary indentation in the stream that gets passed in. I see
On Tue, 4 Jun 2024 05:33:47 GMT, David Holmes wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Print mounted virtual thread after carrier
>
> test/hotspot/jt
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with two
additional commits since the last revision:
- Cleanup test
- Stop virtualthread
- Remove unneeded imports
-
On Mon, 3 Jun 2024 13:13:55 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add indentation for virtual thread stack
>
> I don't think showing the frames
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Print mounted virtual thread after carrier
-
Changes:
- all:
On Mon, 3 Jun 2024 08:34:11 GMT, David Holmes wrote:
>> I also find the duplication of the stack printing code unfortunate. It would
>> be nice to reuse`JavaThread::print_vthread_stack_on`. I don't understand why
>> it cannot be const?
>
>> I also find the duplication of the stack printing
On Mon, 3 Jun 2024 11:22:12 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with two
> additional commits since the last rev
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Add indentation for virtual thread stack
-
Changes:
- all:
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with two
additional commits since the last revision:
- Update
test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTes
On Mon, 3 Jun 2024 09:01:52 GMT, Andrey Turbanov wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add missing header
>
> test/hotspot/jtreg/serviceability/dcmd/thread/PrintVir
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Add missing header
-
Changes:
- all: https://git.openjdk.org/jd
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request with a new target base due
to a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull r
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Remove duplicated Carrying statement and indent vthread stack
-
C
On Thu, 30 May 2024 14:13:34 GMT, Inigo Mediavilla Saiz
wrote:
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
In
https://github.com/openjdk/jdk/pull/19482/commits/ae690b255c9456f3db534be11fbc932648907ead
I've :
- Removed the duplicated &qu
On Thu, 30 May 2024 16:39:03 GMT, Alan Bateman wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Thanks for take this one. Here's the result with the changes in 1a75277e.
>
> "ForkJoinPool-1-worker-1" #25 [33795] daemon prio=5 os_prio=31
Print the stack traces of mounted virtual threads when calling `jcmd
Thread.print`.
-
Commit messages:
- 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump
Changes: https://git.openjdk.org/jdk/pull/19482/files
Webrev:
55 matches
Mail list logo
