On Thu, 7 Sep 2023 02:19:10 GMT, Yi Yang wrote:
>> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap
>> with 96threads and fixes a memory leak of compressor
>>
>> You might argue why this is Linux-only optimization, because sendfile
>> requires at least socket fd in o
On Thu, 21 Sep 2023 02:12:06 GMT, Yi Yang wrote:
> I had not noticed this PR sorry. I do not like the fact we have Linux-only
> functionality being added with no intent to supply similar functionality on
> other platforms. I also do not like the fact we had to ifdef the Linux code
> into the s
On Thu, 21 Sep 2023 01:18:19 GMT, David Holmes wrote:
> I had not noticed this PR sorry. I do not like the fact we have Linux-only
> functionality being added with no intent to supply similar functionality on
> other platforms. I also do not like the fact we had to ifdef the Linux code
> into
On Thu, 7 Sep 2023 02:19:10 GMT, Yi Yang wrote:
>> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap
>> with 96threads and fixes a memory leak of compressor
>>
>> You might argue why this is Linux-only optimization, because sendfile
>> requires at least socket fd in o
On Mon, 18 Sep 2023 11:09:36 GMT, Kevin Walls wrote:
> Apologies for delay, had looked at this previously but not come back for
> final review.
Never mind:) Thanks @alexmenkov and @kevinjwalls for the reviews.
-
PR Comment: https://git.openjdk.org/jdk/pull/15245#issuecomment-17247
On Thu, 7 Sep 2023 02:19:10 GMT, Yi Yang wrote:
>> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap
>> with 96threads and fixes a memory leak of compressor
>>
>> You might argue why this is Linux-only optimization, because sendfile
>> requires at least socket fd in o
On Thu, 7 Sep 2023 02:19:10 GMT, Yi Yang wrote:
>> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap
>> with 96threads and fixes a memory leak of compressor
>>
>> You might argue why this is Linux-only optimization, because sendfile
>> requires at least socket fd in o
On Thu, 7 Sep 2023 02:19:10 GMT, Yi Yang wrote:
>> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap
>> with 96threads and fixes a memory leak of compressor
>>
>> You might argue why this is Linux-only optimization, because sendfile
>> requires at least socket fd in o
> This patch reduce ~16%(24s->20s) pahse 2 merge time during dumping 32g heap
> with 96threads and fixes a memory leak of compressor
>
> You might argue why this is Linux-only optimization, because sendfile
> requires at least socket fd in other platforms([aix
> sendfile](https://www.ibm.com/do
