Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v6]

2024-04-30 Thread Tom Rodriguez
On Wed, 17 Jan 2024 19:52:32 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> di

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v7]

2024-04-30 Thread Tom Rodriguez
> The changes for JDK-8287061 didn't update the SA decoding logic and there are > other places where the decoding has gotten out of sync with HotSpot. Some of > them can't be tested because they are part of JVMCI but I've added a directed > test for the JDK-8287061 code and a more brute force t

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v6]

2024-04-29 Thread Doug Simon
On Wed, 17 Jan 2024 19:52:32 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> di

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v6]

2024-01-17 Thread Cesar Soares Lucas
On Wed, 17 Jan 2024 19:52:32 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> di

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v5]

2024-01-17 Thread Chris Plummer
On Wed, 17 Jan 2024 20:02:44 GMT, Tom Rodriguez wrote: >> It's not -v that is making it do that. It does it without -v also. It can be >> a very slow operation, and I recently was running into cases where even >> after 10 minutes it was not done, so I gave up waiting. I'm about to file a >> CR

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v6]

2024-01-17 Thread Chris Plummer
On Wed, 17 Jan 2024 19:52:32 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> di

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v6]

2024-01-17 Thread Tom Rodriguez
On Wed, 17 Jan 2024 19:52:32 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> di

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v5]

2024-01-17 Thread Tom Rodriguez
On Wed, 17 Jan 2024 19:52:47 GMT, Chris Plummer wrote: >> No. ClhsdbTestAllocationMerge is using `jstack -v` which doesn't work with >> ZGC because the `-v` part needs to iterate the heap looking for >> AbstractQueuedSynchronizers which doesn't work with ZGC and the SA. > > It's not -v that is

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v5]

2024-01-17 Thread Chris Plummer
On Wed, 17 Jan 2024 19:44:38 GMT, Tom Rodriguez wrote: >> test/hotspot/jtreg/ProblemList-generational-zgc.txt line 108: >> >>> 106: serviceability/sa/sadebugd/ClhsdbAttachToDebugServer.java 8307393 >>> generic-all >>> 107: serviceability/sa/sadebugd/ClhsdbTestConnectArgument.java 8307

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v5]

2024-01-17 Thread Tom Rodriguez
On Wed, 17 Jan 2024 19:34:29 GMT, Chris Plummer wrote: >> Tom Rodriguez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove testdebuginfodecode command > > test/hotspot/jtreg/serviceability/sa/TestDebugInfoDecode.java line 109: > >>

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v5]

2024-01-17 Thread Tom Rodriguez
On Wed, 17 Jan 2024 17:35:39 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> di

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v6]

2024-01-17 Thread Tom Rodriguez
> The changes for JDK-8287061 didn't update the SA decoding logic and there are > other places where the decoding has gotten out of sync with HotSpot. Some of > them can't be tested because they are part of JVMCI but I've added a directed > test for the JDK-8287061 code and a more brute force t

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v5]

2024-01-17 Thread Tom Rodriguez
On Wed, 17 Jan 2024 19:40:03 GMT, Chris Plummer wrote: >> Tom Rodriguez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove testdebuginfodecode command > > test/hotspot/jtreg/ProblemList-generational-zgc.txt line 108: > >> 106: servi

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

2024-01-17 Thread Chris Plummer
On Tue, 16 Jan 2024 22:47:04 GMT, Chris Plummer wrote: >> Tom Rodriguez has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java >> >>Co-authored-by: Andre

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v5]

2024-01-17 Thread Chris Plummer
On Wed, 17 Jan 2024 17:35:39 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> di

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v5]

2024-01-17 Thread Tom Rodriguez
> The changes for JDK-8287061 didn't update the SA decoding logic and there are > other places where the decoding has gotten out of sync with HotSpot. Some of > them can't be tested because they are part of JVMCI but I've added a directed > test for the JDK-8287061 code and a more brute force t

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

2024-01-17 Thread Tom Rodriguez
On Tue, 16 Jan 2024 22:36:55 GMT, Chris Plummer wrote: >> Tom Rodriguez has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java >> >>Co-authored-by: Andre

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

2024-01-16 Thread Chris Plummer
On Mon, 15 Jan 2024 16:03:03 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> di

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

2024-01-15 Thread Tom Rodriguez
> The changes for JDK-8287061 didn't update the SA decoding logic and there are > other places where the decoding has gotten out of sync with HotSpot. Some of > them can't be tested because they are part of JVMCI but I've added a directed > test for the JDK-8287061 code and a more brute force t

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v3]

2024-01-14 Thread Andrey Turbanov
On Mon, 15 Jan 2024 05:37:02 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> di

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v3]

2024-01-14 Thread Tom Rodriguez
> The changes for JDK-8287061 didn't update the SA decoding logic and there are > other places where the decoding has gotten out of sync with HotSpot. Some of > them can't be tested because they are part of JVMCI but I've added a directed > test for the JDK-8287061 code and a more brute force t

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v2]

2024-01-14 Thread Tom Rodriguez
On Fri, 12 Jan 2024 21:46:13 GMT, Vladimir Kozlov wrote: >> Tom Rodriguez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix problem list and correct jtreg arguments > > test/hotspot/jtreg/serviceability/sa/ClhsdbTestAllocationMerge.jav

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v2]

2024-01-14 Thread Tom Rodriguez
> The changes for JDK-8287061 didn't update the SA decoding logic and there are > other places where the decoding has gotten out of sync with HotSpot. Some of > them can't be tested because they are part of JVMCI but I've added a directed > test for the JDK-8287061 code and a more brute force t

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken

2024-01-12 Thread Vladimir Kozlov
On Fri, 12 Jan 2024 21:26:36 GMT, Tom Rodriguez wrote: > The changes for JDK-8287061 didn't update the SA decoding logic and there are > other places where the decoding has gotten out of sync with HotSpot. Some of > them can't be tested because they are part of JVMCI but I've added a directed

RFR: 8318682: SA decoding of scalar replaced objects is broken

2024-01-12 Thread Tom Rodriguez
The changes for JDK-8287061 didn't update the SA decoding logic and there are other places where the decoding has gotten out of sync with HotSpot. Some of them can't be tested because they are part of JVMCI but I've added a directed test for the JDK-8287061 code and a more brute force test that