Re: [jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written

2009-11-26 Thread Age Jan Kuperus
Chris Hostetter wrote: Perhaps instead of making API additions/generalizations to XMLWriter, we should approach the problem differnelty and think about what a good reusable general pupose XML generation toolkit that could be used by custom response writers should look like, and then implement

Re: [jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written

2009-11-25 Thread Chris Hostetter
: Sure, but my point was, I am still able to call xmlWriter.writePrim which : lets me write XML tags with unbound names in an arbitrary fashion. In other : words, I can make my field (for XML) instead of spitting out: Oh man ... WTF is writePrim doing marked public ?!?!?!?! ...this is why

Re: [jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written

2009-11-25 Thread Noble Paul നോബിള്‍ नोब्ळ्
Why don't we make the response writers deal w/ SolrDocument instead of lucene Document? That way we can get rid of a lot of ugly code. SOLR-1516 enables responsewriters to do that On Tue, Nov 24, 2009 at 6:44 AM, Yonik Seeley yo...@lucidimagination.com wrote: On Mon, Nov 23, 2009 at 7:04 PM,

Re: [jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written

2009-11-23 Thread Chris Hostetter
: Refactor XMLWriter startTag to allow arbitrary attributes to be written ... : There are certain cases in which a user would like to write arbitrary : attributes as part of the XML output for a field tag. Case in point: I'd ...i think here may be a disconnect here between some of the

Re: [jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written

2009-11-23 Thread Mattmann, Chris A (388J)
Hi Chris, Thanks for the inputs: comments inline below: ...i think here may be a disconnect here between some of the goals you are describing and the purpose of XMLWriter. XMLWriter was originally created to be a wrapper arround a java.io.Writer that had convinent heper methods for

Re: [jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written

2009-11-23 Thread Chris Hostetter
: Potentially -- my problem is, why is XMLWriter a sacred cow? There's not I'm not trying to suggest that it should be ... my point wasn't to suggest that we shouldn't modify XMLWriter because it needs to be preserved as is -- my point was that given XMLWriter's origins, trying to shoehorn

Re: [jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written

2009-11-23 Thread Mattmann, Chris A (388J)
Hi Hoss, Comments inline: : Potentially -- my problem is, why is XMLWriter a sacred cow? There's not I'm not trying to suggest that it should be ... my point wasn't to suggest that we shouldn't modify XMLWriter because it needs to be preserved as is -- my point was that given

Re: [jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written

2009-11-23 Thread Yonik Seeley
On Mon, Nov 23, 2009 at 7:04 PM, Chris Hostetter hossman_luc...@fucit.org wrote: XMLWriter was originally created to be a wrapper arround a java.io.Writer that had convinent heper methods for generating a specific XML response format (ie: wt=xml) back before Solr even supported multiple output

[jira] Created: (SOLR-1592) Refactor XMLWriter startTag to allow arbitrary attributes to be written

2009-11-22 Thread Chris A. Mattmann (JIRA)
Refactor XMLWriter startTag to allow arbitrary attributes to be written --- Key: SOLR-1592 URL: https://issues.apache.org/jira/browse/SOLR-1592 Project: Solr Issue Type: