Re: logging revisited...

2008-12-10 Thread Ryan McKinley
but i don't think changing the api Solr compiles against to commons-logging makes sense -- not since we're already using the least common denominator API (slf4j) sounds good. I agree. We could add a new dependency tomorow that uses log4j, and ship with log4j-over-slf4j.jar; but would we

Re: logging revisited...

2008-12-09 Thread Ryan McKinley
On Dec 9, 2008, at 12:39 AM, Chris Hostetter wrote: : If I knew you had the day off, I would ask about moving to jdk 1.6! Ryan: I may not know where you live, and i may not know what you look like, but if you insist on goading me like this i will dedicate myself to answering those

Re: logging revisited...

2008-12-09 Thread Grant Ingersoll
I'm not sure I follow. We're going to switch to commons-logging, but one that was written by the SLF4J people? On Dec 4, 2008, at 4:43 PM, Ryan McKinley wrote: While I'm on a roll tossing stuff out there Since SOLR-560, solr depends on SLF4j as the logging interface. However since

Re: logging revisited...

2008-12-09 Thread Ryan McKinley
The suggestion is to compile against the commons-loggging *API*, but use an SLF4j implementation in the .war file. The net result is identical behavior and one fewer dependency. However, lets wait to see what happens with: http://www.nabble.com/Java-logging-in-Lucene-td20859711.html (Hoss,

Re: logging revisited...

2008-12-08 Thread Chris Hostetter
: If I knew you had the day off, I would ask about moving to jdk 1.6! Ryan: I may not know where you live, and i may not know what you look like, but if you insist on goading me like this i will dedicate myself to answering those questions so i can come to your house and hurt you. : I feel

Re: logging revisited...

2008-12-04 Thread Erik Hatcher
LOL! On Dec 4, 2008, at 4:43 PM, Ryan McKinley wrote: While I'm on a roll tossing stuff out there Since SOLR-560, solr depends on SLF4j as the logging interface. However since we also depend on HttpClient we *also* depend on commons-logging. This is a strange. Our maven artifacts

Re: logging revisited...

2008-12-04 Thread Chris Hostetter
: Subject: logging revisited... I'm starting to think Ryan woke up today and asked himself what's the best way to screw with Hoss on his day off when he's only casually skimming email? : So, with that in mind I think we should consider using the commons-logging API : and shipping the .war

RE: logging revisited...

2008-12-04 Thread Will Johnson
To a certain extent SLF4j makes this decision a fairly small one, namely what API do you want to code to inside SOLR and what jars do you want to ship as a part of the distribution. It doesn't really matter if you pick commons-logging, log4j or slf4j; all have drop in replacements via SLF4j. They

Re: logging revisited...

2008-12-04 Thread Ryan McKinley
On Dec 4, 2008, at 5:55 PM, Chris Hostetter wrote: : Subject: logging revisited... I'm starting to think Ryan woke up today and asked himself what's the best way to screw with Hoss on his day off when he's only casually skimming email? If I knew you had the day off, I would ask about