[speedtouch] Re: [PATCH] I need feedback from PPPoE users

2002-10-20 Thread Tim Woodall
On Sun, 20 Oct 2002, Edouard Gomez wrote: > swaped in by the VM. Could you explain your point of view a bit more ? > All I meant is that someone in the future could use BUFFER_SIZE in an expression and get a surprise because it isn't surrounded with "(" ")". It's things like this that appear to

[speedtouch] Re: [PATCH] I need feedback from PPPoE users

2002-10-20 Thread Edouard Gomez
Tim Woodall ([EMAIL PROTECTED]) wrote: > On Sat, 19 Oct 2002, Edouard Gomez wrote: > > #ifdef __linux__ > > > if(write_dest(fdout, destination_buf, n + >(bridging)?-BRIDGING1483_HEADER:HDLC_HEADER_SIZE) > 0) > > This is surely wrong? ITYM > if(write_dest(fdout, destina

[speedtouch] Re: [PATCH] I need feedback from PPPoE users

2002-10-20 Thread Edouard Gomez
Tim Woodall ([EMAIL PROTECTED]) wrote: > +#define BRIDGING1483_HEADER 12 Don't try my previous patch it is really bad, per example BRIDGING1483_HEADER is only 10 bytes long but i've confused by the original patch that was just a quick hack to make the patch as small as possibl

[speedtouch] Re: [PATCH] I need feedback from PPPoE users

2002-10-20 Thread Edouard Gomez
Your fixes have been commited too. -- Edouard Gomez Liste de diffusion modem ALCATEL SpeedTouch USB Pour se désinscrire : mailto:speedtouch-request@;ml.free.fr?subject=unsubscribe

[speedtouch] Re: [PATCH] I need feedback from PPPoE users

2002-10-20 Thread Edouard Gomez
I commited the bridged mode patch. It's compiled by default on GNU/Linux systems. I need help to make the patch possible for BSD systems too. What is the equivalent device for making a virtual network device that does ethernet ? I know pppoa3 does not work with BSD systems but if one

[speedtouch] Re: [PATCH] I need feedback from PPPoE users

2002-10-20 Thread Tim Woodall
On Sat, 19 Oct 2002, Edouard Gomez wrote: Hopefully this makes more sense. > > Hello, > > I merged the experimental patch for pppoe support in pppoa3. At the > moment the code is for linux only as i don't have *BSD box. > > I would like people who needs or can use PPPoE to try this patch. >

[speedtouch] Re: [PATCH] I need feedback from PPPoE users

2002-10-20 Thread Tim Woodall
On Sat, 19 Oct 2002, Edouard Gomez wrote: > > Hello, > (I've confused myself :-(. These are comments on the patch from r1.24 to r1.25 of pppoa3.c. I'll reply with my comments on your suggested patch in another email. (I hadn't read your email properly and assumed that the latest change in cvs wa

[speedtouch] Re: [PATCH] I need feedback from PPPoE users

2002-10-20 Thread Edouard Gomez
Edouard Gomez ([EMAIL PROTECTED]) wrote: > I'll try to set up my connection in pppoe mode but i never did that > before so if someone already used the experimental patch could test > this one, it would be great. Ok i tested the code myself and it works just fine, it wil be commited soon.