squid-2.HEAD hanging with 304 not modified responses

2009-06-29 Thread Adrian Chadd
sca-cache/source/detail?r=14103 Those of you toying with Squid-2.HEAD (eg Mark) - would you mind verifying that you can reproduce it on Squid-2.HEAD and comment on the fix? Thanks, adrian

delayed forwarding is in Squid-2.HEAD

2008-10-16 Thread Adrian Chadd
G'day, I've just committed the delayed forwarding stuff into Squid-2.HEAD. Thanks, Adrian

Re: [MERGE] Finish forward-porting HTCP enhancements from squid 2.HEAD.

2008-09-18 Thread Amos Jeffries
Alex Rousskov wrote: On Thu, 2008-09-18 at 13:00 +1000, Benno Rice wrote: This is a forward-port of the HTCP changes I made to squid 2.HEAD. Changes include: - Ability to send HTCP CLR requests when objects are invalidated or purged from the cache. - Config logic to allow the following

Re: [MERGE] Finish forward-porting HTCP enhancements from squid 2.HEAD.

2008-09-18 Thread Alex Rousskov
On Thu, 2008-09-18 at 13:00 +1000, Benno Rice wrote: > This is a forward-port of the HTCP changes I made to squid 2.HEAD. > > Changes include: > > - Ability to send HTCP CLR requests when objects are invalidated or purged > from > the cache. > - Config logi

Re: [MERGE] Finish forward-porting HTCP enhancements from squid 2.HEAD.

2008-09-17 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C200809180300.m8I300dV052893%40harfy.jeamland.net%3E Project: Squid

[MERGE] Finish forward-porting HTCP enhancements from squid 2.HEAD.

2008-09-17 Thread Benno Rice
This is a forward-port of the HTCP changes I made to squid 2.HEAD. Changes include: - Ability to send HTCP CLR requests when objects are invalidated or purged from the cache. - Config logic to allow the following: - HTCP peers who ONLY receive CLR messages from us. - HTCP peers

Re: squid-2.HEAD:

2008-09-12 Thread Adrian Chadd
have you dumped this into bugzilla? Thanks! 2008/9/3 Alexander V. Lukyanov <[EMAIL PROTECTED]>: > Hello! > > I have noticed lots of 'impossible keep-alive' messages in the log. > It appears that httpReplyBodySize incorrectly returns -1 for "304 Not > Modified" replies. Patch to fix it is attached

Re: squid-2.HEAD: fwdComplete/Fail before comm_close

2008-09-12 Thread Adrian Chadd
Hiya, Could you please verify this is still a problem in the latest 2.HEAD and if so lodge a bugzilla bug report with the patch? Thanks! Adrian 2008/8/5 Alexander V. Lukyanov <[EMAIL PROTECTED]>: > Hello! > > Some time ago I had core dumps just after these messages: >Short response fr

Re: squid-2.HEAD: storeCleanup and -F option (foreground rebuild)

2008-09-12 Thread Adrian Chadd
I've committed a slightly modified version of this - store_rebuild.c r1.80 . Take a look and see if it works for you. Thanks! Adrian 2008/8/5 Alexander V. Lukyanov <[EMAIL PROTECTED]>: > Hello! > > I use squid in transparent mode, so I don't want degraded performance > while rebuilding and cle

Squid-2.HEAD URL regression with CONNECT

2008-09-09 Thread Adrian Chadd
G'day, Squid-2.HEAD doesn't seem to handle CONNECT URLs anymore; I get something like: [start] The requested URL could not be retrieved While trying to retrieve the URL: www.gmail.com:443 The following error was encountered: * Invalid URL [end] Benno, could you please double/tr

Re: squid-2.HEAD: some changes to client_side.c for invalid requests.

2008-09-08 Thread Adrian Chadd
G'day, Please make sure you put these patches into bugzilla so they're not lost. adrian 2008/9/8 Alexander V. Lukyanov <[EMAIL PROTECTED]>: > On Mon, Sep 08, 2008 at 02:49:50PM +0400, Alexander V. Lukyanov wrote: >> 3. create method object even for invalid requests (this fixes null pointer >>

Re: squid-2.HEAD: some changes to client_side.c for invalid requests.

2008-09-08 Thread Alexander V. Lukyanov
On Mon, Sep 08, 2008 at 02:49:50PM +0400, Alexander V. Lukyanov wrote: > 3. create method object even for invalid requests (this fixes null pointer > dereferences in many other places). I also suggest this patch to detect attempts to create method-less requests. -- Alexander. Index: HttpReque

squid-2.HEAD: some changes to client_side.c for invalid requests.

2008-09-08 Thread Alexander V. Lukyanov
Hello! I'm using these changes for some time. Maybe they will be useful. 1. Set conn->transparent early after connection establishment and reset connection on transparent connections when there is no valid request. 2. Check http->entry && http->entry->mem_obj && http->entry->mem_obj->reply to av

Re: squid-2.HEAD:

2008-09-03 Thread Adrian Chadd
Hm, I'd have to eyeball the rest of the code to make sure thats the right fix. Can you throw it into a bugzilla ticket for me? I've got a couple other Squid-2.HEAD patches to stare at and commit. Adrian

squid-2.HEAD:

2008-09-03 Thread Alexander V. Lukyanov
Hello! I have noticed lots of 'impossible keep-alive' messages in the log. It appears that httpReplyBodySize incorrectly returns -1 for "304 Not Modified" replies. Patch to fix it is attached. -- Alexander. Index: HttpReply.c ===

Cacheboy / Squid-2.HEAD + IPv6 core

2008-08-12 Thread Adrian Chadd
Just a heads up; I'm part way through migrating the basic cacheboy comm code to support IPv4/IPv6 sockets. The change history is here: http://code.google.com/p/cacheboy/source/list?path=playpen/sockaddr_change This does -not- enable v6 in the Squid codebase proper. Thats for another pass. It al

Re: squid-2.HEAD: fwdComplete/Fail before comm_close

2008-08-10 Thread Alexander V. Lukyanov
On Fri, Aug 08, 2008 at 11:57:03PM +0200, Henrik Nordstrom wrote: > Can you please file a bug report on this? Preferably with a stack trace > of the crash if possible.. Unfortunately, the core dump was corrupted that time. And yes, it was before 22/07. > The second change looks wrong and should

Re: squid-2.HEAD: fwdComplete/Fail before comm_close

2008-08-08 Thread Henrik Nordstrom
Can you please file a bug report on this? Preferably with a stack trace of the crash if possible.. also if this 2.HEAD was from before 22/7 then please test again as there was a number of very related fixes on the 21/7. The second change looks wrong and should be a fwdFail.. The first change loo

Re: squid-2.HEAD: storeCleanup and -F option (foreground rebuild)

2008-08-08 Thread Henrik Nordstrom
tis 2008-08-05 klockan 14:45 +0800 skrev Adrian Chadd: > Ok. Well, the intent of the patch makes sense to me; I'd have to stare > at it a bit to make sure the patch is the right way to do it. > > Henrik? Haven't seriously looked at that part of the code in years, but I guess it should work. Just

Re: Squid 2.HEAD broken when building without --enable-delay-pools

2008-08-06 Thread Adrian Chadd
I thought I had fixed that! Grr. I must've missed a couple of patches. I'll go do that this evening. Thanks for the heads up. Adrian 2008/8/7 Guido Serassio <[EMAIL PROTECTED]>: > Hi Adrian, > > The current Squid 2.HEAD doesn't build without --enable-delay-pools.

Re: squid-2.HEAD: storeCleanup and -F option (foreground rebuild)

2008-08-04 Thread Adrian Chadd
Hm, so whats the behaviour without this patch? I thought -F was meant to rebuild everything before Squid began listening for requests.. Adrian 2008/8/5 Alexander V. Lukyanov <[EMAIL PROTECTED]>: > Hello! > > I use squid in transparent mode, so I don't want degraded performance > while rebuildi

Re: squid-2.HEAD: storeCleanup and -F option (foreground rebuild)

2008-08-04 Thread Adrian Chadd
Ok. Well, the intent of the patch makes sense to me; I'd have to stare at it a bit to make sure the patch is the right way to do it. Henrik? Adrian 2008/8/5 Alexander V. Lukyanov <[EMAIL PROTECTED]>: > On Tue, Aug 05, 2008 at 02:25:34PM +0800, Adrian Chadd wrote: >> Hm, so whats the behaviour

Re: squid-2.HEAD: storeCleanup and -F option (foreground rebuild)

2008-08-04 Thread Alexander V. Lukyanov
On Tue, Aug 05, 2008 at 02:25:34PM +0800, Adrian Chadd wrote: > Hm, so whats the behaviour without this patch? rebuild is done in foreground as expected, but cleanup goes in background in parallel with client requests. The patch fixes the second part - the cleanup. -- Alexander.

squid-2.HEAD: fwdComplete/Fail before comm_close

2008-08-04 Thread Alexander V. Lukyanov
Hello! Some time ago I had core dumps just after these messages: Short response from ... httpReadReply: Excess data from ... I beleave this patch fixes these problems. Index: http.c === RCS file: /squid/squid/src/htt

squid-2.HEAD: storeCleanup and -F option (foreground rebuild)

2008-08-04 Thread Alexander V. Lukyanov
Hello! I use squid in transparent mode, so I don't want degraded performance while rebuilding and cleanup. Here is a patch I use to make storeCleanup do all the work at once before squid starts processing requests, when -F option is specified on command line. Index: store_rebuild.c ==

Re: Merging current Cacheboy changes into Squid-2.HEAD ?

2008-07-10 Thread Henrik Nordstrom
On fre, 2008-07-11 at 01:06 +1200, Amos Jeffries wrote: > As Mark said earlier, its useless making a full formal release if users > can't get a visible improvement out of it. BUT, shuffling that organises > things is usually far better than leaving it a mess. Even if it means > the 2.8 change i

Re: Merging current Cacheboy changes into Squid-2.HEAD ?

2008-07-10 Thread Henrik Nordstrom
On tor, 2008-07-10 at 19:44 +0800, Adrian Chadd wrote: > I wouldn't expect it to be an immediate Squid-2.8 release but I'd > first like some discussion about what would constitute enough. > > The high level goal here is to shuffle code around into > mostly-seperate functional units in preparation

Re: Merging current Cacheboy changes into Squid-2.HEAD ?

2008-07-10 Thread Amos Jeffries
Adrian Chadd wrote: 2008/7/8 Henrik Nordstrom <[EMAIL PROTECTED]>: It's too early to say if that will result in an immediate 2.8 release. Depends on what you have done. So yes, you are more than welcome to split cacheboy up in reviewable changes and submit them for merge. Perhaps beginning wit

Re: Merging current Cacheboy changes into Squid-2.HEAD ?

2008-07-10 Thread Adrian Chadd
2008/7/8 Henrik Nordstrom <[EMAIL PROTECTED]>: > It's too early to say if that will result in an immediate 2.8 release. > Depends on what you have done. > > So yes, you are more than welcome to split cacheboy up in reviewable > changes and submit them for merge. Perhaps beginning with an high leve

Re: Merging current Cacheboy changes into Squid-2.HEAD ?

2008-07-07 Thread Henrik Nordstrom
On mån, 2008-07-07 at 23:12 +0800, Adrian Chadd wrote: > Now that I've finished my first round of restructuring and have begun > moving onto round two, I'd like to see how interested the users and > developers are in me merging what I've done thus far back into > Squid-

Re: Merging current Cacheboy changes into Squid-2.HEAD ?

2008-07-07 Thread Mark Nottingham
I've finished my first round of restructuring and have begun moving onto round two, I'd like to see how interested the users and developers are in me merging what I've done thus far back into Squid-2.HEAD in preparation for a Squid-2.8 release in a few months. The bulk of it is simply r

Re: Merging current Cacheboy changes into Squid-2.HEAD ?

2008-07-07 Thread Kinkie
at I've done thus far back into > Squid-2.HEAD in preparation for a Squid-2.8 release in a few months. > > The bulk of it is simply restructuring. No major differences have > really begun to show up yet. They'll show up after round two of > restructuring and after another cache

Merging current Cacheboy changes into Squid-2.HEAD ?

2008-07-07 Thread Adrian Chadd
Hi everyone, Now that I've finished my first round of restructuring and have begun moving onto round two, I'd like to see how interested the users and developers are in me merging what I've done thus far back into Squid-2.HEAD in preparation for a Squid-2.8 release in a few month

squid-2.HEAD / Cacheboy code reorganisation: almost complete

2008-05-04 Thread Adrian Chadd
This is aimed more as a "how I think things should be done" post as this stuff isn't yet in Squid-2.HEAD. Still, I think its worth pointing out. I've almost finished my first round of code reorganisation along the lines I suggested on squid-dev a few months ago (and some peopl

Re: squid-2.HEAD: proposed patch for max-age + no-cache combination

2008-04-27 Thread Alexander V. Lukyanov
On Sun, Apr 27, 2008 at 07:55:01PM +0800, Adrian Chadd wrote: > On Sun, Apr 27, 2008, Alexander V. Lukyanov wrote: > > Currently it is possible for squid to send out Cache-Control: max-age=XXX, > > no-cache > > combination. But max-age does not make any sense when there is a no-cache > > flag. >

Re: squid-2.HEAD: proposed patch for max-age + no-cache combination

2008-04-27 Thread Adrian Chadd
On Sun, Apr 27, 2008, Alexander V. Lukyanov wrote: > Hello! > > Currently it is possible for squid to send out Cache-Control: max-age=XXX, > no-cache > combination. But max-age does not make any sense when there is a no-cache > flag. > > Here is a patch to fix it. The patch skips setting max-ag

Re: squid-2.HEAD: proposed patch for non-broken keep-alive case

2008-04-27 Thread Adrian Chadd
On Sun, Apr 27, 2008, Alexander V. Lukyanov wrote: > Hello! > > It seems that squid currently considers broken the case of keep-alive when > there is no Content-Length and the transfer encoding is chunked. > I think it is not quite correct, as chunked encoding allows to determine > reply body end.

squid-2.HEAD: proposed patch for max-age + no-cache combination

2008-04-27 Thread Alexander V. Lukyanov
Hello! Currently it is possible for squid to send out Cache-Control: max-age=XXX, no-cache combination. But max-age does not make any sense when there is a no-cache flag. Here is a patch to fix it. The patch skips setting max-age if there is no-cache flag. If the client has sent the combination

squid-2.HEAD: proposed patch for non-broken keep-alive case

2008-04-27 Thread Alexander V. Lukyanov
Hello! It seems that squid currently considers broken the case of keep-alive when there is no Content-Length and the transfer encoding is chunked. I think it is not quite correct, as chunked encoding allows to determine reply body end. Here is an example: 2008/04/27 08:48:51| httpProcessReplyHead

Squid-2.HEAD internal URL rewrite support committed

2008-02-26 Thread Adrian Chadd
I just committed Gonzalo's internal URL rewrite support to Squid-2.HEAD. Adrian -- - Xenion - http://www.xenion.com.au/ - VPS Hosting - Commercial Squid Support - - $25/pm entry-level VPSes w/ capped bandwidth charges available in WA -

Re: 'include' directive in squid-2.HEAD

2008-01-09 Thread Amos Jeffries
Amos Jeffries wrote: Adrian Chadd wrote: On Wed, Jan 09, 2008, Amos Jeffries wrote: Precisely, the goal I'm vectoring in from is a basic squid.conf installed as currently done. And also providing an online community-developed library of relatively self-complete include files to perform certai

Re: 'include' directive in squid-2.HEAD

2008-01-09 Thread Amos Jeffries
Adrian Chadd wrote: On Wed, Jan 09, 2008, Amos Jeffries wrote: Precisely, the goal I'm vectoring in from is a basic squid.conf installed as currently done. And also providing an online community-developed library of relatively self-complete include files to perform certain common or tricky act

Re: 'include' directive in squid-2.HEAD

2008-01-09 Thread Adrian Chadd
On Wed, Jan 09, 2008, Amos Jeffries wrote: > Precisely, the goal I'm vectoring in from is a basic squid.conf > installed as currently done. > And also providing an online community-developed library of relatively > self-complete include files to perform certain common or tricky actions. > > Rat

Re: 'include' directive in squid-2.HEAD

2008-01-08 Thread Amos Jeffries
Henrik Nordström wrote: tis 2008-01-08 klockan 00:47 +0900 skrev Adrian Chadd: My next trick will be breaking up cf.data.pre along the documentation boundary lines and have seperate configuration file chunks for various tasks. cf.data.pre should be split in one file per directive, using the e

Re: 'include' directive in squid-2.HEAD

2008-01-08 Thread Henrik Nordström
tis 2008-01-08 klockan 00:47 +0900 skrev Adrian Chadd: > My next trick will be breaking up cf.data.pre along the documentation > boundary lines and have seperate configuration file chunks for various > tasks. cf.data.pre should be split in one file per directive, using the existing scripts. the

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Adrian Chadd
On Tue, Jan 08, 2008, Robert Collins wrote: > > I looked at this for 3.1, but the config parser there confused me with > > its multiple meanings of 'file'. > > I'd definately like to see how you are doing it in 2 for a side-port. > > I implemented one about 5 years back. Now where did I put it .

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Robert Collins
On Tue, 2008-01-08 at 16:33 +1300, Amos Jeffries wrote: > Adrian Chadd wrote: > > On Tue, Jan 08, 2008, Mark Nottingham wrote: > >> +1, and in 2.7 ASAP; I've already implemented this in my own hacky way > >> (external to squid); would be nice to have 'real' includes. > > > > Well, test it out,

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Adrian Chadd
On Tue, Jan 08, 2008, Amos Jeffries wrote: > I looked at this for 3.1, but the config parser there confused me with > its multiple meanings of 'file'. > I'd definately like to see how you are doing it in 2 for a side-port. Well, its in the tree. :) > FWIW; I believe we should with 3.1 and 2.7 b

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Amos Jeffries
Adrian Chadd wrote: On Tue, Jan 08, 2008, Mark Nottingham wrote: +1, and in 2.7 ASAP; I've already implemented this in my own hacky way (external to squid); would be nice to have 'real' includes. Well, test it out, make sure broken things like ACL lines give the right source file and line num

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Adrian Chadd
On Tue, Jan 08, 2008, Mark Nottingham wrote: > +1, and in 2.7 ASAP; I've already implemented this in my own hacky way > (external to squid); would be nice to have 'real' includes. Well, test it out, make sure broken things like ACL lines give the right source file and line number, and let me kno

Re: 'include' directive in squid-2.HEAD

2008-01-07 Thread Mark Nottingham
ned objections I'll: * be porting the include thing to squid-2.7, as I believe its a non- intrusive change that people who will upgrade to 2.7 will benefit from; * look at breaking out cf.data.pre into something resembling the above for new installs in Squid-2.HEAD at some point

'include' directive in squid-2.HEAD

2008-01-07 Thread Adrian Chadd
t cf.data.pre into something resembling the above for new installs in Squid-2.HEAD at some point in the future (read: when I next need a distraction from my other squid-2 related butchery.) Adrian

Re: proposed refresh_pattern changes to squid-2.HEAD

2007-11-25 Thread Henrik Nordstrom
On mån, 2007-11-26 at 08:55 +0900, Adrian Chadd wrote: > On Mon, Nov 26, 2007, Henrik Nordstrom wrote: > > > As discussed earlier in private max-age should be the normal one.. and > > additionally it doesn't apply to ftp or gopher.. (neither have query > > urls), and a little comments to why thing

Re: proposed refresh_pattern changes to squid-2.HEAD

2007-11-25 Thread Adrian Chadd
On Mon, Nov 26, 2007, Henrik Nordstrom wrote: > As discussed earlier in private max-age should be the normal one.. and > additionally it doesn't apply to ftp or gopher.. (neither have query > urls), and a little comments to why things is the way they are.. Ok, how about this: Suggested default:

Re: proposed refresh_pattern changes to squid-2.HEAD

2007-11-25 Thread Henrik Nordstrom
On sön, 2007-11-25 at 22:13 +0900, Adrian Chadd wrote: > Here's my proposal for refresh pattern changes to squid-2.HEAD; perhaps > Squid-3 too down the track. > > +refresh_pattern cgi-bin 0 0% 0 > +refresh_pattern \? 0 0% 0 >

Re: proposed refresh_pattern changes to squid-2.HEAD

2007-11-25 Thread Amos Jeffries
> Here's my proposal for refresh pattern changes to squid-2.HEAD; perhaps > Squid-3 too down the track. > > Index: cf.data.pre > === > RCS file: /cvsroot/squid/squid/src/cf.data.pre,v > retrieving revision

proposed refresh_pattern changes to squid-2.HEAD

2007-11-25 Thread Adrian Chadd
Here's my proposal for refresh pattern changes to squid-2.HEAD; perhaps Squid-3 too down the track. Index: cf.data.pre === RCS file: /cvsroot/squid/squid/src/cf.data.pre,v retrieving revision 1.440 diff -u -u -r1.440 cf.dat

Re: assorted changes for squid 2 HEAD cvs

2007-10-12 Thread Alexander V. Lukyanov
On Mon, Oct 08, 2007 at 06:07:20PM +0200, Henrik Nordstrom wrote: > Can you please test if the attached patch solves the problem for you? It > makes the maintenance back off if load gets too high. Seems to work. Now I don't get I/O overload during store dir resize. Thank you! -- Alexander.

Re: assorted changes for squid 2 HEAD cvs

2007-10-09 Thread Alexander V. Lukyanov
On Mon, Oct 08, 2007 at 06:07:20PM +0200, Henrik Nordstrom wrote: > > 3. call squidaio_sync in aufs dir maintenance to limit queue growth > >(e.g. when repository size or high/low are decreased). > > Not sure about this one.. this will make Squid block under load and > additionally screws up f

Re: assorted changes for squid 2 HEAD cvs

2007-10-09 Thread Henrik Nordstrom
On tis, 2007-10-09 at 11:35 +0400, Alexander V. Lukyanov wrote: > > Not sure about this one.. this will make Squid block under load and > > additionally screws up fs load metrics. > > I was under impression that only maintenance thread will block. Maybe I was > wrong. Squid is not threaded (othe

Re: assorted changes for squid 2 HEAD cvs

2007-10-08 Thread Henrik Nordstrom
On mån, 2007-10-08 at 13:00 +0400, [EMAIL PROTECTED] wrote: > Hi! > > Here are three changes for squid2 HEAD cvs. > > 1. initialize mem_obj (uninitialized can cause seg. fault). Thanks! Fixed this slightly differently however as entry might be NULL in some corner cases.. > 2. use THREAD_FACTOR

assorted changes for squid 2 HEAD cvs

2007-10-08 Thread lav
Hi! Here are three changes for squid2 HEAD cvs. 1. initialize mem_obj (uninitialized can cause seg. fault). 2. use THREAD_FACTOR instead of hard coded constant 16. 3. call squidaio_sync in aufs dir maintenance to limit queue growth (e.g. when repository size or high/low are decreased). --

non-zero buffering diff for squid-2.head

2007-09-20 Thread Adrian Chadd
Here's a simple patch to remove the need to zero certain mempool buffers in squid-2.HEAD. I've had various versions of this float around and somewhat tested for a while. http://www.creative.net.au/diffs/20070921-squid2.head-nonzero.diff The aim here is to allow selective things to b

Re: logfile daemon stuff in squid-2.HEAD

2007-09-18 Thread Henrik Nordstrom
On tis, 2007-09-18 at 23:34 +0800, Adrian Chadd wrote: > It does need an autoconf/automake pass before the tree will build. Done. Hmm.. should probably automate that to trigger a bootstrap the sources on relevant commits and not only nightly.. Regards Henrik signature.asc Description: This i

logfile daemon stuff in squid-2.HEAD

2007-09-18 Thread Adrian Chadd
G'day, I've committed my logfile daemon stuff to squid-2.HEAD and its passed some cursory load testing. It does need an autoconf/automake pass before the tree will build. (Yes, I'm still not comfortable comitting big Makefile.in changes.) I've got similar code waiting fo

speedup work in squid-2 HEAD

2007-01-21 Thread Adrian Chadd
Hiya, I've committed my first pass of HTTP client-side optimisations and general code tidyup to the Squid-2 HEAD tree. The commit message has the list of changes that were made but in essence they were designed to remove some of the stdio library functions and multiple buffer copies done d