Module: kamailio
Branch: master
Commit: a2209018fb03dda6d4b7df90f933c97bf4ae532b
URL:
https://github.com/kamailio/kamailio/commit/a2209018fb03dda6d4b7df90f933c97bf4ae532b
Author: Victor Seva
Committer: Victor Seva
Date: 2023-05-19T01:40:55+02:00
core: clang-format for coherent indentation and
Module: kamailio
Branch: master
Commit: 339891e7da584abcc378aa2104f536841d615e57
URL:
https://github.com/kamailio/kamailio/commit/339891e7da584abcc378aa2104f536841d615e57
Author: Victor Seva
Committer: Victor Seva
Date: 2023-05-19T01:40:44+02:00
pre-commit: add mixed-line-ending hook [skip
Closed #3461.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3461#event-9284466235
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing
Module: kamailio
Branch: master
Commit: e66a63a230e91461af0a82e3bbc54eabbf5195c7
URL:
https://github.com/kamailio/kamailio/commit/e66a63a230e91461af0a82e3bbc54eabbf5195c7
Author: Victor Seva
Committer: Victor Seva
Date: 2023-05-19T01:08:17+02:00
README: add pre-commit badge
---
Modified:
Module: kamailio
Branch: master
Commit: e15a57e0e027425827509277203341d55ace49fa
URL:
https://github.com/kamailio/kamailio/commit/e15a57e0e027425827509277203341d55ace49fa
Author: Victor Seva
Committer: Victor Seva
Date: 2023-05-19T00:51:27+02:00
pre-commit: update pre-commit-hooks [skip ci]
Module: kamailio
Branch: master
Commit: f781dc9ce914cc619abd9d53f987f117b720
URL:
https://github.com/kamailio/kamailio/commit/f781dc9ce914cc619abd9d53f987f117b720
Author: Victor Seva
Committer: Victor Seva
Date: 2023-05-19T00:25:47+02:00
pre-commit: tool to keep thing tidy [skip ci]
Module: kamailio
Branch: master
Commit: 2cac52c68feeacc1dc90e4ff322b6109c32669e8
URL:
https://github.com/kamailio/kamailio/commit/2cac52c68feeacc1dc90e4ff322b6109c32669e8
Author: Victor Seva
Committer: Victor Seva
Date: 2023-05-19T00:25:47+02:00
README: remove travis-ci info [skip ci]
no
On 18.05.23 16:44, Juha Heinanen wrote:
> I guess I missed the clang-format discussion or did it happen?
> Fr example, I would have voted for
>
> SpaceBeforeParens: ControlStatements
First was quite some time ago, more than 5 years:
-
Pre-Submission Checklist
!-- Go over all points below, and after creating the PR, tick all the
checkboxes that apply --
!-- All points should be verified, otherwise, read the CONTRIBUTING
guidelines from above--
!-- If youre unsure about any of these, dont hesitate to ask on
sr-dev mailing
I guess I missed the clang-format discussion or did it happen?
Fr example, I would have voted for
SpaceBeforeParens: ControlStatements
-- Juha
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
Closed #3460.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3460#event-9280527384
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing
@false-vacuum pushed 0 commits.
--
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3460/files/b816c5a09f22c98bfde3071df3ea1f0c218443cd..08fbc4fa8d44c2c0ee596e1f30b95b5b4fcfc823
You are receiving this because you are subscribed to this thread.
Message ID:
@linuxmaniac pushed 14 commits.
95513201e195147a1363b21b0fd99d35071e0de4 pre-commit: tool to keep thing tidy
9e67b77829c69208a656eecf8805bd21251cb7a3 core: [atomic] clang-format for
coherent indentation and coding style
7aede62f97073b5fb066fdda8d9106fb4d876e6f core: [cfg] clang-format for
Hello Daniel,
just to prevent any misunderstandings - It is perfectly fine with me if Victor
pushes directly to git master/maintenance branches etc.. My initial comment was
not related to that. I am sorry if this was misunderstood. As said, he is also
a core developer.
Best regards,
Henning
Hi,
On 18/5/23 13:43, Henning Westerholt wrote:
Should be fixed now. Just to be 100% safe - executing the clang-format in the
Kamailio root will pick up the correct format, right?
Yes, it's fixed. Yes, executing the clang-format at the root of the repository
will pick the .clang-format
Hello,
I didn't complain about your commit, but about your attitude about what
you expect from others vs what you do. Victor is also core developer, he
could have pushed the commits directly like you did.
So if you want it like that, from now on just do PRs with the commits
that affect
Should be fixed now. Just to be 100% safe - executing the clang-format in the
Kamailio root will pick up the correct format, right?
Cheers,
Henning
-Original Message-
From: Henning Westerholt
Sent: Donnerstag, 18. Mai 2023 13:30
To: Kamailio (SER) - Development Mailing List
Cc:
Module: kamailio
Branch: master
Commit: 08fbc4fa8d44c2c0ee596e1f30b95b5b4fcfc823
URL:
https://github.com/kamailio/kamailio/commit/08fbc4fa8d44c2c0ee596e1f30b95b5b4fcfc823
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2023-05-18T11:37:44Z
dispatcher: fix formatting after
Hi Daniel,
I just said that I found the merge quite fast, and Victor already replied,
thank you for that. I have nothing against the change.
Similar code is used also in other module for the same force send socket
functionality. It was also verified in a test setup and a pre-production setup.
Hi Victor,
I was merging a patch that was finally verified yesterday evening in a test
setup. Thanks also for the other reply for the thread.
But your point is valid. Maybe we can use some git hooks or something, but it
might have some unintended side effects.
Let me have a look to fix the
Hello,
why do you complain in this case when you don't even give a chance for
others to review your commits pushed to modules you haven't authored,
nor you maintain?
-
https://github.com/kamailio/kamailio/commit/6183319381573e42b882d05ae1748539f7547d8c
So others have to do it, only you don't?
Hi,
On 18/5/23 12:54, Henning Westerholt wrote:
Module: kamailio
Branch: master
Commit: 6183319381573e42b882d05ae1748539f7547d8c
URL:
https://github.com/kamailio/kamailio/commit/6183319381573e42b882d05ae1748539f7547d8c
We have to find a way to enforce clang-format. First commit after the huge
for i in $(find src/core -name .git -prune -o -regextype posix-egrep
-regex ^.*\.(c|h)$) ; do clang-format -i $i; done
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3461
-- Commit Summary --
* core: clang-format for coherent
Module: kamailio
Branch: master
Commit: 1f53b159c311715b993ee33d40fb35017626e89c
URL:
https://github.com/kamailio/kamailio/commit/1f53b159c311715b993ee33d40fb35017626e89c
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2023-05-18T13:01:45+02:00
modules: readme files regenerated -
Module: kamailio
Branch: 5.5
Commit: 0125f8818c99d673c22ce8d9448d453124097e87
URL:
https://github.com/kamailio/kamailio/commit/0125f8818c99d673c22ce8d9448d453124097e87
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2023-05-18T10:57:23Z
dispatcher: fix force send socket
Module: kamailio
Branch: 5.6
Commit: d13a0b21d3a2d9c5f453957490c06d924af7e043
URL:
https://github.com/kamailio/kamailio/commit/d13a0b21d3a2d9c5f453957490c06d924af7e043
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2023-05-18T10:56:54Z
dispatcher: fix force send socket
Module: kamailio
Branch: 5.7
Commit: da7944e2f4c7e6f344d125da325c388e1836662f
URL:
https://github.com/kamailio/kamailio/commit/da7944e2f4c7e6f344d125da325c388e1836662f
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2023-05-18T10:56:23Z
dispatcher: fix force send socket
Hi,
On 18/5/23 12:39, Henning Westerholt wrote:
Hello,
the PR related to this proposal was merged quite fast, less then 24h after
creation. Why this was merged already, given that it affects all modules?
Well, that was only me. I discussed enforcing clang-format already in the past
[0] and
Module: kamailio
Branch: master
Commit: 6183319381573e42b882d05ae1748539f7547d8c
URL:
https://github.com/kamailio/kamailio/commit/6183319381573e42b882d05ae1748539f7547d8c
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2023-05-18T10:52:52Z
dispatcher: fix force send socket
Module: kamailio
Branch: master
Commit: 704f589577f51bb85b76070ca5722d54590b2c09
URL:
https://github.com/kamailio/kamailio/commit/704f589577f51bb85b76070ca5722d54590b2c09
Author: Henning Westerholt
Committer: Henning Westerholt
Date: 2023-05-18T10:50:53Z
dispatcher: clarification regarding
Hello,
the PR related to this proposal was merged quite fast, less then 24h after
creation. Why this was merged already, given that it affects all modules?
I have nothing against this change, but it would have been polite to give it a
bit more time for feedback from other module authors,
- URL:
https://github.com/kamailio/kamailio/commit/afdf66528d695994152ec67138643af0deac8741
Author: Victor Seva
Date: 2023-05-18T12:22:30+02:00
auth: clang-format for coherent indentation and coding style
- URL:
Merged #3459 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3459#event-9278192762
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) -
On 17/5/23 18:23, Daniel-Constantin Mierla wrote:
For quite some time, there is a .clang-format file in the root for
kamailio sources folder:
- https://github.com/kamailio/kamailio/blob/master/.clang-format
That's the one used so far for the files formatted in the past,
expecting it is the
34 matches
Mail list logo
