[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread thalman
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories thalman commented: """ there is now one extra commit with default for ad, just to be on the same page """ See the full comment at

[SSSD] [sssd PR#702][+Changes requested] NSS: Avoid changing the memory cache ownership away from the SSSD user

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/702 Title: #702: NSS: Avoid changing the memory cache ownership away from the SSSD user Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories jhrozek commented: """ I also had a follow-up discussion with simo on IRC, let me paste rephrasing: - the AD provider should have an AD specific internal option that generates the homedir.

[SSSD] [sssd PR#703][synchronized] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread thalman
URL: https://github.com/SSSD/sssd/pull/703 Author: thalman Title: #703: nss: sssd returns '/' for emtpy home directories Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/703/head:pr703 git checkout pr703 From

[SSSD] [sssd PR#702][comment] NSS: Avoid changing the memory cache ownership away from the SSSD user

2018-12-04 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/702 Title: #702: NSS: Avoid changing the memory cache ownership away from the SSSD user mzidek-rh commented: """ Could you add comment before this code (the comment can be "Make sure that the memory cache files are chowned to sssd.sssd even if the nss

[SSSD] [sssd PR#707][comment] build: remove hardcoded samba include path

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/707 Title: #707: build: remove hardcoded samba include path jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/707#issuecomment-444129009 ___ sssd-devel mailing list

[SSSD] [sssd PR#707][opened] build: remove hardcoded samba include path

2018-12-04 Thread gmccollister
URL: https://github.com/SSSD/sssd/pull/707 Author: gmccollister Title: #707: build: remove hardcoded samba include path Action: opened PR body: """ SMBCLIENT_FLAGS already provides the samba-4.0 include path. Remove the hardcoded samba include path which causes cross-compilation warnings such

[SSSD] [sssd PR#707][comment] build: remove hardcoded samba include path

2018-12-04 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/707 Title: #707: build: remove hardcoded samba include path centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/707#issuecomment-444125043

[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread simo5
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories simo5 commented: """ On Tue, 2018-12-04 at 05:51 -0800, Jakub Hrozek wrote: > Then why not set a default value for fallback homedir? :-) Because that would override an empty home dir in all

[SSSD] [sssd PR#706][opened] KCM: Fall back to using the first ccache if the default does not exist

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/706 Author: jhrozek Title: #706: KCM: Fall back to using the first ccache if the default does not exist Action: opened PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/3838 KCM stores the default ccache in a separate DB entry. If the DB entry

[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories jhrozek commented: """ I thought that fallback_homedir = "" would work but it doesn't, not even with escaping quotes. An empty attribute is silently ignored. About whether we care about

[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread thalman
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories thalman commented: """ > > Or at least we should IMO add some backwards compatible handling when this > > patch makes it to fedora or RHEL otherwise admins might not be happy. From > >

[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories jhrozek commented: """ > On Tue, 2018-12-04 at 04:51 -0800, Jakub Hrozek wrote: Thanks, this passes > the test. And of course the patch is correct, but after some more testing, I > wonder

[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread simo5
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories simo5 commented: """ On Tue, 2018-12-04 at 04:51 -0800, Jakub Hrozek wrote: > Thanks, this passes the test. And of course the patch is correct, > but after some more testing, I wonder if we

[SSSD] [sssd PR#705][comment] KCM: Add configurable quotas

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Title: #705: KCM: Add configurable quotas jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/705#issuecomment-444096360 ___ sssd-devel mailing list --

[SSSD] [sssd PR#702][comment] NSS: Avoid changing the memory cache ownership away from the SSSD user

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/702 Title: #702: NSS: Avoid changing the memory cache ownership away from the SSSD user jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/702#issuecomment-444096255

[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories jhrozek commented: """ Thanks, this passes the test. And of course the patch is correct, but after some more testing, I wonder if we should at least for one release default to

[SSSD] [sssd PR#703][synchronized] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread thalman
URL: https://github.com/SSSD/sssd/pull/703 Author: thalman Title: #703: nss: sssd returns '/' for emtpy home directories Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/703/head:pr703 git checkout pr703 From

[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories jhrozek commented: """ You also need to amend `test_user_no_dir` in `src/tests/intg/test_files_provider.py` """ See the full comment at

[SSSD] [sssd PR#705][opened] KCM: Add configurable quotas

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/705 Author: jhrozek Title: #705: KCM: Add configurable quotas Action: opened PR body: """ This PR adds several patches that let the user configure quotas to store their ccaches. Please see the commit messages, I hope they are verbose enough. One thing

[SSSD] [sssd PR#703][comment] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread thalman
URL: https://github.com/SSSD/sssd/pull/703 Title: #703: nss: sssd returns '/' for emtpy home directories thalman commented: """ @simo5 I thought about it more and I get to the same conclusion, PR updated """ See the full comment at https://github.com/SSSD/sssd/pull/703#issuecomment-444059683

[SSSD] [sssd PR#703][synchronized] nss: sssd returns '/' for emtpy home directories

2018-12-04 Thread thalman
URL: https://github.com/SSSD/sssd/pull/703 Author: thalman Title: #703: nss: sssd returns '/' for emtpy home directories Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/703/head:pr703 git checkout pr703 From

[SSSD] [sssd PR#695][+Accepted] sss_iface: prevent from using invalid names that start with digits

2018-12-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/695 Title: #695: sss_iface: prevent from using invalid names that start with digits Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to