[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ master: 851d312 709c42f ccd349f d2633d9 a537df2 a2e743c 514b2be 35d6fb7 ba2d5f7 """ See the full comment at https://github.com/SSSD/sssd/pull/128#i

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ I'm sorry about the delay. I had to spend some time to triage the downstream tests, because they were failing and at the same time, our test engine internall

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @jhrozek, I've updated the branch. Your tests are solid now. I've added "Reviewed-by: Fabiano Fidêncio ..." in your patches. Now we're just waiting for the r

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ I pushed the patch that detects the group rename vs. GID duplicate to https://github.com/jhrozek/sssd/tree/group_renaming The rdn_same test now fails when I

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Here's the CI results for the current version of this patch set: http://vm-031.${abc}/logs/job/87/73/summary.html """ See the full comment at https://githu

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ I would suggest sometimes this week because currently I do have the patch in my head :) """ See the full comment at https://github.com/SSSD/sssd/pull/128#is

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ I really failed to understand how to write a test without calling `sss_cache` to invalidate the cache as done in https://github.com/SSSD/sssd/pull/128/files

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ Maybe I don't understand the problem. What is it you're trying to test, the memcache invalidation? """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ > Have you considered changing the ldb expiration timestamps with pyldb or > shelling out to ldbmodify? I don't understand how it would help, Jakub. How doi

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ Have you considered changing the ldb expiration timestamps with pyldb or shelling out to ldbmodify? """ See the full comment at https://github.com/SSSD/sssd

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ I've squashed your patches into mines and updated the PR. My ask for help still stand: https://github.com/SSSD/sssd/pull/128#issuecomment-373748289 and on

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ Hmm, I'm getting permission rejected from pushing to your repository, any chance you can just fetch my branch and push into yours? """ See the full comment a

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ ...viable until I actually sat down and coded the approach myself. """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-379721155 _

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ OK, I'll prettify the patches and force push. About just nacking the patch, I was both not sure if'd you'd appreciate 10th time someone tells you to rework t

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Your version seems okay, please, force-push it to my branch. Just a note: Although I do appreciate you took some time to come up with a better solution, for

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ So I don't like passing the provider from everywhere. But because this PR was going on for so long, I actually prepared alternative version where the data pr

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @jhrozek, @pbrezina, @sumit-bose, @mzidek-rh ... Please, could someone take a look on https://github.com/SSSD/sssd/pull/128#issuecomment-373748289 ? """ See

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ I also would like to ask for help in this one as I didn't find an easy way to test it without having to call "sss_cache" to invalidate the entries. The reas

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Patch set has been updated. It already includes the tests provided on #394. """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-3

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Okay, I'll work on Sumit's suggestion. Please, just mind that while I (theoretically) do have access* to the struct data_provider from the sdap_ad_save_grou

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ I agree with @sumit-bose that sysdb should not be doing this. The return code is much cleaner option. """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set sumit-bose commented: """ @fidencio, you cannot do this on the sysdb level, that's the wrong layer. sysdb_add_incomplete_group() is called in only two places. So I would suggest in

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @jhrozek: ^ """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-366279919 ___ sssd-de

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Okay, I've been playing with the suggestion but I'm kind stuck with one problem here: how to invalidate the negative cache from the sysdb_ops.c? @pbrezina h

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ So, a comment from Oct 2nd says: "Although with the renaming we should not end up with duplicate entries anymore..." and then I've been waiting to know wheth

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ Hmm, which tests in particular would you like to see? Perhaps I could help sometimes during next week to write a test that would help you verify something? (

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Okay, as far as I remember we didn't even have an agreement that we should expire the en tries from the memory cache and since then I've been waiting for th

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ There was a recent confusion about this PR. I thought that this should actually have been marked as changes requested to solve @lslebodn 's comment from Oct 2

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set mc-meta commented: """ Hello, we are heavily hit by this bug. Is there any forecast on when the change will be released? Thanks, -m """ See the full comment at https://github.

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ I'm removing the "Changes Requested" label from this PR as it's waiting from an action from the reviewers. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ ping? """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-336364642 ___ sssd-devel ma

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @lslebodn, what's the result of your check done last Friday? """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-335043746 __

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ On Wed, Oct 4, 2017 at 3:05 PM, lslebodn wrote: > Just for the record, the issues mentioned by @lslebodn > were reported recen

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set lslebodn commented: """ >Just for the record, the issues mentioned by @lslebodn were reported recently >and I really would prefer to treat them as not part of this PR (if necessary)

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Just for the record, the issues mentioned by @lslebodn were reported recently and I really would prefer to treat them as not part of this PR (if necessary).

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ hmm, perhaps we could also forcibly drop the contents of memory cache like we do with the back end to nss back channel when the groups are renamed? Although

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set lslebodn commented: """ BTW I am not sure whether fix is sufficient. base on comment https://github.com/SSSD/sssd/pull/128#issuecomment-325825877 "sss_cache" was called which inval

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ tests added with https://github.com/SSSD/sssd/pull/394 """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-332300491 _

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ So hopefully we can finally close this PR after almost a year because there is also an integration test here: https://github.com/jhrozek/sssd/tree/group_renam

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Squashed your patch into mines and updated the PR. """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-329428257

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ And I'm updating the patches as I've just realized that the link to the pagure issue is wrong. """ See the full comment at https://github.com/SSSD/sssd/pul

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ So, I've just made a simple test after talking to @jhrozek on #sssd. Here's the sssd.conf of my IPA client: ``` [root@clnt x86_64]# cat /etc/sssd/sssd.conf

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @lslebodn: patchset has been updated. Thanks for your suggestions! """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-324004045

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ CI passed: http://vm-058-233.${abc}/logs/job/73/09/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-321674948 ___

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @jhrozek, your suggestion is good. I've updated the patchset and I'm waiting for CI's results. """ See the full comment at https://github.com/SSSD/sssd/pul

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ So I was thinking about this PR a bit more and I'm no longer sure we can rename groups at will. I think we can only support that if we support multiple object

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Just updated the patches adding the loud debug message saying the group has been renamed. """ See the full comment at https://github.com/SSSD/sssd/pull/128

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ So, as far as I remember, the conclusion about this patch is that we should also have a really loud debug message saying that the group has been renamed. Is

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set lslebodn commented: """ On (14/02/17 08:17), Jakub Hrozek wrote: >> Last but not least, @lslebodn suggested (in face to face conversation in >> the office) that maybe we could add an

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ On Tue, Feb 14, 2017 at 05:41:34AM -0800, fidencio wrote: > On Tue, Feb 14, 2017 at 2:07 PM, lslebodn wrote: > > > On (14/02/17 01:57), fidencio wrote: > > >

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ On Tue, Feb 14, 2017 at 2:07 PM, lslebodn wrote: > On (14/02/17 01:57), fidencio wrote: > >@lslebodn: > >Firstly, my answer may be incomplete due to the lac

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set lslebodn commented: """ On (14/02/17 01:57), fidencio wrote: >@lslebodn: >Firstly, my answer may be incomplete due to the lack of knowledge, but let's >try ... >1) As far as I under

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set lslebodn commented: """ On (14/02/17 01:25), Jakub Hrozek wrote: >The tests didn't find any regressions, ACK > I have a tiny question: What would happen if there ate two groups in d

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @lslebodn: Firstly, my answer may be incomplete due to the lack of knowledge, but let's try ... 1) As far as I understand SSSD does not deal properly with mu

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ The tests didn't find any regressions, ACK """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-279653099 _

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ The code looks good and manual tests went fine so far. Also the CI run passed: http://sssd-ci.duckdns.org/logs/job/62/55/summary.html """ See the full commen

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Updating the patch set with a test for this fix ... """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-274545739 ___

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ https://fedorahosted.org/sssd/ticket/3282 """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-274185860 __

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ I haven't read the patches, I just realized we might want to have a ticket and not just a downstream bugzilla. """ See the full comment at https://github.co

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/60/61/summary.html Debian testing failure is unrelated. """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/60/61/summary.html Debian testing failure is unrelated. """ See the full comment at https://github.com/SSSD/sssd/pu