[SSSD] [sssd PR#78][+Accepted] ipa: Nested netgroups do not work

2016-11-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ ack, this version works for me """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ (CI pending) """ See the full comment at https://github.com/SSSD/sssd/pull/39#issuecomment-262709772

[SSSD] [sssd PR#39][+Accepted] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ regardless of what we choose, the patch for PR #80 does not apply atop this patch, can we have a version that applies to the 1.13 branch, p

[SSSD] [sssd PR#75][comment] Add configuirable max payload size limit of a secret

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret jhrozek commented: """ Apart from the nitpick, I don't have any other comments. Unless someone else has, I can even squash the nitpick and just push the patches, -- ju

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes jhrozek commented: """ On Wed, Nov 23, 2016 at 06:05:10AM -0800, lslebodn wrote: > @jhrozek Do you pan to review the patch? Feel free to take over the review, I'm currently busy with other work.

[SSSD] [sssd PR#39][+Changes requested] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][-Accepted] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ For some reason the downstream tests are stuck and time out, even with known-good packages. I will keep trying but for downstream's sake I'm

[SSSD] [sssd PR#75][+Changes requested] Add configuirable max payload size limit of a secret

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#81][comment] Please see the commit message, the fix is hopefully simple

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/81 Title: #81: Please see the commit message, the fix is hopefully simple jhrozek commented: """ Thanks for the review, I pushed a new version. I did test the patch (otherwise the conditional build of the files provider where I added AM_CON

[SSSD] [sssd PR#81][-Changes requested] Please see the commit message, the fix is hopefully simple

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/81 Title: #81: Please see the commit message, the fix is hopefully simple Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#80][comment] SYSDB: Fixing of sudorule without a sudoUser

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Fixing of sudorule without a sudoUser jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/57/23/summary.html the rawhide failure is not related, it's a know bug in the latest python-urllib release. &q

[SSSD] [sssd PR#82][+Accepted] KRB5: Remove spurious warning in logs

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/82 Title: #82: KRB5: Remove spurious warning in logs Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#81][synchronized] Please see the commit message, the fix is hopefully simple

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/81 Author: jhrozek Title: #81: Please see the commit message, the fix is hopefully simple Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/81/head:pr81 git checkout pr81 From

[SSSD] [sssd PR#80][+Accepted] SYSDB: Fixing of sudorule without a sudoUser

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Fixing of sudorule without a sudoUser Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#80][comment] SYSDB: Fixing of sudorule without a sudoUser

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Fixing of sudorule without a sudoUser jhrozek commented: """ ACK, the rule without a sudoUser attribute is properly skipped and the other rules are normally stored. """ See the full comment at https:

[SSSD] [sssd PR#39][+Accepted] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ ACK, this version works for me. I will run also downstream tests to be sure, but my manual testing passed. """ See the full comme

[SSSD] [sssd PR#75][comment] Add configuirable max payload size limit of a secret

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/57/36/summary.html the failure on rawhide is unrelated. """ See the full comment at https:

[SSSD] [sssd PR#39][closed] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Author: celestian Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/39/head:pr39 git checkout pr39

[SSSD] [sssd PR#39][-Accepted] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/57/35/summary.html sssd-1-13: b6d0b0a14c7f09371cbb2afd0347f6a16fcfc8dd """ See the full

[SSSD] [sssd PR#39][+Pushed] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#86][closed] SYSDB: check aliases before using them (sssd-1-13 only)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/86 Author: jhrozek Title: #86: SYSDB: check aliases before using them (sssd-1-13 only) Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/86/head:pr86 git checkout pr86

[SSSD] [sssd PR#86][comment] SYSDB: check aliases before using them (sssd-1-13 only)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/86 Title: #86: SYSDB: check aliases before using them (sssd-1-13 only) jhrozek commented: """ apparently I can't use the hub tool, sorry """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#87][opened] SYSDB: Only process aliases if they are non-NULL

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/87 Author: jhrozek Title: #87: SYSDB: Only process aliases if they are non-NULL Action: opened PR body: """ This bug was found by downstream coverity check. The aliases array is created by sysdb_get_sudo_user_info() which return

[SSSD] [sssd PR#87][edited] SYSDB: Only process aliases if they are non-NULL (sssd-1-13)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/87 Author: jhrozek Title: #87: SYSDB: Only process aliases if they are non-NULL (sssd-1-13) Action: edited Changed field: title Original value: """ SYSDB: Only process aliases if th

[SSSD] [sssd PR#75][comment] Add configuirable max payload size limit of a secret

2016-11-23 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret jhrozek commented: """ ACK, I'll push when CI finishes """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#75][closed] Add configuirable max payload size limit of a secret

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/75 Author: fidencio Title: #75: Add configuirable max payload size limit of a secret Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/75/head:pr75 git checkout pr75

[SSSD] [sssd PR#75][comment] Add configuirable max payload size limit of a secret

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret jhrozek commented: """ master: 9ba53ac52b12e2b9fdd3981d28ae56a8fece0131 7171a7584dda534dde5409f3e7f4657e845ece15 """ See the full comment at https:

[SSSD] [sssd PR#75][+Pushed] Add configuirable max payload size limit of a secret

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#87][+Pushed] SYSDB: Only process aliases if they are non-NULL (sssd-1-13)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/87 Title: #87: SYSDB: Only process aliases if they are non-NULL (sssd-1-13) Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#87][comment] SYSDB: Only process aliases if they are non-NULL (sssd-1-13)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/87 Title: #87: SYSDB: Only process aliases if they are non-NULL (sssd-1-13) jhrozek commented: """ * sssd-1-13: 6ec33f5acfba6fa266c1dd7722c0c7bb88333f7f """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#87][-Accepted] SYSDB: Only process aliases if they are non-NULL (sssd-1-13)

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/87 Title: #87: SYSDB: Only process aliases if they are non-NULL (sssd-1-13) Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#93][opened] SSH: Use default_domain_suffix for users' authorized keys

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/93 Author: jhrozek Title: #93: SSH: Use default_domain_suffix for users' authorized keys Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetc

[SSSD] [sssd PR#93][edited] SSH: Use default_domain_suffix for users' authorized keys

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/93 Author: jhrozek Title: #93: SSH: Use default_domain_suffix for users' authorized keys Action: edited ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd

[SSSD] [sssd PR#93][edited] SSH: Use default_domain_suffix for users' authorized keys

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/93 Author: jhrozek Title: #93: SSH: Use default_domain_suffix for users' authorized keys Action: edited Changed field: body Original value: """ In commit eeecc48 we disabled default_domain_suffix for the SSH responder, but in a wrong way

[SSSD] [sssd PR#93][synchronized] SSH: Use default_domain_suffix for users' authorized keys

2016-11-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/93 Author: jhrozek Title: #93: SSH: Use default_domain_suffix for users' authorized keys Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/93/head:pr93 git checkout pr93 From

[SSSD] [sssd PR#95][opened] STAP: Check the number of transactions in the stap aggregate before dereferencing it.

2016-11-27 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/95 Author: jhrozek Title: #95: STAP: Check the number of transactions in the stap aggregate before dereferencing it. Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-17 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ Apart from fixing ticket #3241, why does sysdb_get_sudo_filter add its own lowercased name and does not add all nameAlias values instead? &q

[SSSD] [sssd PR#80][comment] SYSDB: Sudorule without a sudoUser returns EINVAL

2016-11-17 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Sudorule without a sudoUser returns EINVAL jhrozek commented: """ This would work, but wouldn't it be better to return a custom error code instead of EINVAL so that we are sure we are not skipping some error from ld

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for IPA and AD providers

2016-11-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers jhrozek commented: """ master: 6e27e8572f671de575d9ac2a34a677d9efc24fbc 8caf7ba5005b3be5447311713ad2b58169f9d32f """ See the full comment at https:

[SSSD] [sssd PR#68][closed] MAN: Document different defaults for IPA and AD providers

2016-11-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Author: justin-stephenson Title: #68: MAN: Document different defaults for IPA and AD providers Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/68/head:pr68 git checkout pr68

[SSSD] [sssd PR#68][-Accepted] MAN: Document different defaults for IPA and AD providers

2016-11-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#68][+Pushed] MAN: Document different defaults for IPA and AD providers

2016-11-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for IPA and AD providers Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Hmm, looks like github ate my mail, so let's paste the comment again (and sorry if it arrives twice). Coverity detected some warnings: ``` Error: C

[SSSD] [sssd PR#49][synchronized] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/49

[SSSD] [sssd PR#49][synchronized] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/49

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ Additionally, it looks like the reason CI failed is a valgrind issue in one of the tests: ``` [ RUN ] test_filter_response ==19061== Conditional jump

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ On Tue, Nov 01, 2016 at 01:46:31AM -0700, celestian wrote: > To @pbrezina and @jhrozek > > I introduced new attribute ```su

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ On Tue, Nov 01, 2016 at 05:36:40AM -0700, celestian wrote: > There is another important question from discussion in #39. We would like to

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ btw except from the warnings and the valgrind issue, the code seems to work fine. I tested with sudo -i and then kinit, before the patch: ``` -sh-4.3$ sudo -iu admin

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ Additionally, do you think we should open a ticket to track potentially adding sudo -i to the list by default? """ See the full comment at https:

[SSSD] [sssd PR#49][synchronized] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/49

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-01 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ Thank you for the review, I (hopefully :-)) adressed all the comments and pushed new patches. "&quo

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes jhrozek commented: """ Thank you for the patch. I wonder if you were actually able to reproduce the bug? If so, can you help me reproduce it locally? """ See the full comment at https:

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/56/16/summary.html """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ * master: * ce43f710c9638fbbeae077559cd7514370a10c0c * c8fe1d922b254aa92e74f428135ada3c8bde87a1 """ See the full comment at https://github.com/

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ @sumit-bose the patches do not apply cleanly on top of the sssd-1-13 branch, it looks like there is a conflict in the INI rules code. Could you please push patche

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ * sssd-1-14: * 74711db46029415cc9590bb0e3f9cc662dac1d0c * 0157678081e299660105c753f2d2ac2081960bca """ See the full comment at https://github.com/

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ Thank you, the patches still work and Coverity didn't find anything either. ACK """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#62][+Accepted] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#68][+Changes requested] MAN: Document different defaults for AD provider

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for AD provider Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for AD provider

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for AD provider jhrozek commented: """ Thank you for the patch. I checked it by inspecting the values from ad_opts.c and krb5_opts.c and ldap_opts.c with vimdiff. I only have two questions:

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ master: e5a984093ad7921c83da75272cede2b0e52ba2d6 24d8c85fae253f988165c112af208198cf4

[SSSD] [sssd PR#49][+Pushed] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#60][closed] Document ad_access_filter search for nested groups

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Author: taupehat Title: #60: Document ad_access_filter search for nested groups Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/60/head:pr60 git checkout pr60

[SSSD] [sssd PR#60][-Accepted] Document ad_access_filter search for nested groups

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ master: cf5357ae83cc9fe2240038b8bdccec2cb98991fc sssd-1-14: e1c2aead482cd4bf83a7fe5e68630a981389e82b If any of the maintainers think we should apply th

[SSSD] [sssd PR#49][-Accepted] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#49][closed] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Author: jhrozek Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/49

[SSSD] [sssd PR#60][+Pushed] Document ad_access_filter search for nested groups

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ Setting changes requested to rework the patch to only include the sudoUser and not sudoUserAlias """ See the full comment at

[SSSD] [sssd PR#43][+Changes requested] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) jhrozek commented: """ Setting changes requested to rework the patch to only include the sudoUser and not sudoUserAlias """ See the full comment at htt

[SSSD] [sssd PR#39][+Changes requested] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/56/05/summary.html Coverity also didn't find any errors. For some reason, re-running just the tests that fa

[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups

2016-10-28 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ On Thu, Oct 27, 2016 at 08:48:46AM -0700, taupehat wrote: > @jhrozek I did not intend to remove anything from the last iteration. It's >

[SSSD] [sssd PR#53][comment] Fixes in the config API related to secrets responder

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/53 Title: #53: Fixes in the config API related to secrets responder jhrozek commented: """ Sorry for the delay in reviewing. I tried: ``` [secrets/foo] [secrets/123] ``` as an invalid test and sssd noticed them as invalid. It also didn't

[SSSD] [sssd PR#57][closed] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Author: sumit-bose Title: #57: LDAP/AD: resolve domain local groups for remote users Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/57/head:pr57 git checkout pr57

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ I reviewed the use of `case_preserve` in the code and I think we use it correctly for formatting output or for interacting with external

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ sssd-1-4: ec1829d..c1f3b29 """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ * master: * cbee11e..2569984 """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#46][comment] sss_client: Defer thread cancellation until completion of nss/pam operations

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/46 Title: #46: sss_client: Defer thread cancellation until completion of nss/pam operations jhrozek commented: """ I wonder if @fweimer thinks it's worth merging the patch if the issue in https://bugzilla.redhat.com/show_bug.cgi?id=1

[SSSD] [sssd PR#57][comment] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users jhrozek commented: """ Umm sorry, the ranges are not so nice, let's list the commits * master: * 25699846bd1c9f8bb513b6271eb4366ab682fbd2 * 49d3f0a487d55571b2bdc9d3f

[SSSD] [sssd PR#57][-Accepted] LDAP/AD: resolve domain local groups for remote users

2016-10-31 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/57 Title: #57: LDAP/AD: resolve domain local groups for remote users Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ On Thu, Nov 03, 2016 at 11:19:02PM -0700, celestian wrote: > So, new version is pushed. It uses only ```sudoUser``` attribute. Thank you

[SSSD] [sssd PR#43][comment] RESPONDER: Enable sudoRule in case insen. domains​ (1.15)

2016-11-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: RESPONDER: Enable sudoRule in case insen. domains​ (1.15) jhrozek commented: """ On Fri, Nov 04, 2016 at 12:06:08AM -0700, celestian wrote: > I found function: > ``` > char * > sss_get_cas

[SSSD] [sssd PR#68][comment] MAN: Document different defaults for AD provider

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/68 Title: #68: MAN: Document different defaults for AD provider jhrozek commented: """ On Wed, Nov 02, 2016 at 06:18:57AM -0700, Justin Stephenson wrote: > Thanks for your comments Jakub, please see below: > > 1) Yes, I

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ (Sorry about adding and removing the label, I misread that CI needs to finish) """

[SSSD] [sssd PR#62][comment] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option jhrozek commented: """ thank you, pushed to sssd-1-13: sssd-1-13: * 5cbea81f6019d4c6acc94b8cec0b955d1767430b * 27e38ce07c3f2bb9682e2219ac2ac78e855d43b5 """ See the full

[SSSD] [sssd PR#62][closed] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Author: sumit-bose Title: #62: PAM: add pam_response_filter option Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/62/head:pr62 git checkout pr62

[SSSD] [sssd PR#62][-Accepted] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#49][-Accepted] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#49][+Accepted] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send

[SSSD] [sssd PR#49][comment] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too jhrozek commented: """ https://fedorahosted.org/sssd/ticket/3230 """ See the full comment at https://github.com/

[SSSD] [sssd PR#62][+Pushed] PAM: add pam_response_filter option

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/62 Title: #62: PAM: add pam_response_filter option Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#49][-Changes requested] Try to match multiple results from an AD initgroups request against domain's search bases, too

2016-11-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/49 Title: #49: Try to match multiple results from an AD initgroups request against domain's search bases, too Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To

<    1   2   3   4   5   6   7   8   9   10   >